ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

loplugin:constmethod in forms..fpicker

Browse Source 
Change-Id: I1673e00be0a6c9d34ce02437bf68d929c56952f7
Reviewed-on: https://gerrit.libreoffice.org/79540
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2019-09-26 03:04:34 +02:00
parent d6d0440009
commit 3b13f813da
16 changed files with 28 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files
forms/source/component/FormComponent.cxx
+2 -2
View File
@@ -209,7 +209,7 @@ sal_Bool SAL_CALL OControl::supportsService(const OUString& _rsServiceName)
return cppu::supportsService(this, _rsServiceName);
}
Sequence< OUString > OControl::getAggregateServiceNames()
Sequence< OUString > OControl::getAggregateServiceNames() const
{
Sequence< OUString > aAggServices;
Reference< XServiceInfo > xInfo;
@@ -663,7 +663,7 @@ sal_Bool SAL_CALL OControlModel::supportsService(const OUString& _rServiceName)
return cppu::supportsService(this, _rServiceName);
}
Sequence< OUString > OControlModel::getAggregateServiceNames()
Sequence< OUString > OControlModel::getAggregateServiceNames() const
{
Sequence< OUString > aAggServices;
Reference< XServiceInfo > xInfo;
forms/source/component/GroupManager.cxx
+2 -2
View File
@@ -314,12 +314,12 @@ void SAL_CALL OGroupManager::elementReplaced(const ContainerEvent& Event)
}
// Other functions
Sequence<Reference<XControlModel> > OGroupManager::getControlModels()
Sequence<Reference<XControlModel> > OGroupManager::getControlModels() const
{
return m_pCompGroup->GetControlModels();
}
sal_Int32 OGroupManager::getGroupCount()
sal_Int32 OGroupManager::getGroupCount() const
{
return m_aActiveGroupMap.size();
}
forms/source/component/GroupManager.hxx
+2 -2
View File
@@ -185,10 +185,10 @@ public:
virtual void SAL_CALL elementReplaced(const css::container::ContainerEvent& _rEvent) override;
// Other functions
sal_Int32 getGroupCount();
sal_Int32 getGroupCount() const;
void getGroup(sal_Int32 nGroup, css::uno::Sequence< css::uno::Reference< css::awt::XControlModel> >& _rGroup, OUString& Name);
void getGroupByName(const OUString& Name, css::uno::Sequence< css::uno::Reference< css::awt::XControlModel> >& _rGroup);
css::uno::Sequence< css::uno::Reference< css::awt::XControlModel> > getControlModels();
css::uno::Sequence< css::uno::Reference< css::awt::XControlModel> > getControlModels() const;
static OUString GetGroupName( const css::uno::Reference< css::beans::XPropertySet>& xComponent );
};
forms/source/inc/FormComponent.hxx
+2 -2
View File
@@ -248,7 +248,7 @@ protected:
virtual css::uno::Sequence< css::uno::Type> _getTypes();
// overwrite this and call the base class if you have additional types
css::uno::Sequence< OUString > getAggregateServiceNames();
css::uno::Sequence< OUString > getAggregateServiceNames() const;
private:
void impl_resetStateGuard_nothrow();
@@ -375,7 +375,7 @@ protected:
void doSetDelegator();
void doResetDelegator();
css::uno::Sequence< OUString > getAggregateServiceNames();
css::uno::Sequence< OUString > getAggregateServiceNames() const;
public:
DECLARE_UNO3_AGG_DEFAULTS(OControl, OComponentHelper)
forms/source/xforms/binding.cxx
+4 -4
View File
@@ -214,7 +214,7 @@ void Binding::deferNotifications( bool bDefer )
"deferred modifications not delivered?" );
}
bool Binding::isValid()
bool Binding::isValid() const
{
// TODO: determine whether node is suitable, not just whether it exists
return maBindingExpression.getNode().is() &&
@@ -225,7 +225,7 @@ bool Binding::isValid()
!maBindingExpression.getString().isEmpty() ) );
}
bool Binding::isUseful()
bool Binding::isUseful() const
{
// we are useful, if
// 0) we don't have a model
@@ -744,7 +744,7 @@ MIP Binding::getLocalMIP() const
return aMIP;
}
css::uno::Reference<css::xsd::XDataType> Binding::getDataType()
css::uno::Reference<css::xsd::XDataType> Binding::getDataType() const
{
OSL_ENSURE( getModel().is(), "need model" );
OSL_ENSURE( getModel()->getDataTypeRepository().is(), "need types" );
@@ -758,7 +758,7 @@ css::uno::Reference<css::xsd::XDataType> Binding::getDataType()
: Reference<XDataType>( nullptr );
}
bool Binding::isValid_DataType()
bool Binding::isValid_DataType() const
{
Reference<XDataType> xDataType = getDataType();
return !xDataType.is()
forms/source/xforms/binding.hxx
+4 -4
View File
@@ -246,11 +246,11 @@ public:
void deferNotifications( bool );
/// is this binding valid? (are constraint, type and required MIPs ok?)
bool isValid();
bool isValid() const;
/// determine whether this binding currently performs a useful
/// function, r whether is may be discarded
bool isUseful();
bool isUseful() const;
/// explain why binding is invalid
OUString explainInvalid();
@@ -294,10 +294,10 @@ private:
MIP getLocalMIP() const;
/// get the data type that applies to this binding
css::uno::Reference<css::xsd::XDataType> getDataType();
css::uno::Reference<css::xsd::XDataType> getDataType() const;
/// determine whether binding is valid according to the given data type
bool isValid_DataType();
bool isValid_DataType() const;
/// explain validity of binding with respect to the given data type
OUString explainInvalid_DataType();
forms/source/xforms/convert.cxx
+1 -1
View File
@@ -297,7 +297,7 @@ bool Convert::hasType( const css::uno::Type& rType )
return maMap.find( rType ) != maMap.end();
}
css::uno::Sequence<css::uno::Type> Convert::getTypes()
css::uno::Sequence<css::uno::Type> Convert::getTypes() const
{
return comphelper::mapKeysToSequence( maMap );
}
forms/source/xforms/convert.hxx
+1 -1
View File
@@ -60,7 +60,7 @@ public:
bool hasType( const css::uno::Type& );
/// get list of convertible types
css::uno::Sequence<css::uno::Type> getTypes();
css::uno::Sequence<css::uno::Type> getTypes() const;
/// convert any to XML representation
OUString toXSD( const css::uno::Any& rAny );
forms/source/xforms/xpathlib/extension.hxx
+2 -2
View File
@@ -46,8 +46,8 @@ private:
public:
CLibxml2XFormsExtension() {}
const css::uno::Reference< css::xforms::XModel >& getModel() { return m_aModel;}
const css::uno::Reference< css::xml::dom::XNode >& getContextNode() { return m_aContextNode;}
const css::uno::Reference< css::xforms::XModel >& getModel() const { return m_aModel;}
const css::uno::Reference< css::xml::dom::XNode >& getContextNode() const { return m_aContextNode;}
virtual css::xml::xpath::Libxml2ExtensionHandle SAL_CALL getLibxml2ExtensionHandle() override;
virtual void SAL_CALL initialize(const css::uno::Sequence< css::uno::Any >& aSequence) override;
fpicker/source/office/OfficeControlAccess.cxx
+1 -1
View File
@@ -277,7 +277,7 @@ namespace svt
}
Sequence< OUString > OControlAccess::getSupportedControls( )
Sequence< OUString > OControlAccess::getSupportedControls( ) const
{
Sequence< OUString > aControls( s_nControlCount );
OUString* pControls = aControls.getArray();
fpicker/source/office/OfficeControlAccess.hxx
+1 -1
View File
@@ -73,7 +73,7 @@ namespace svt
css::uno::Any getControlProperty( const OUString& _rControlName, const OUString& _rControlProperty );
// XControlInformation implementation
css::uno::Sequence< OUString > getSupportedControls( );
css::uno::Sequence< OUString > getSupportedControls( ) const;
css::uno::Sequence< OUString > getSupportedControlProperties( const OUString& _rControlName );
static bool isControlSupported( const OUString& _rControlName );
bool isControlPropertySupported( const OUString& _rControlName, const OUString& _rControlProperty );
fpicker/source/office/OfficeFilePicker.cxx
+1 -1
View File
@@ -224,7 +224,7 @@ void SvtFilePicker::DialogClosedHdl(sal_Int32 nResult)
}
// SvtFilePicker
PickerFlags SvtFilePicker::getPickerFlags()
PickerFlags SvtFilePicker::getPickerFlags() const
{
// set the winbits for creating the filedialog
PickerFlags nBits = PickerFlags::NONE;
fpicker/source/office/OfficeFilePicker.hxx
+1 -1
View File
@@ -212,7 +212,7 @@ protected:
) override;
protected:
PickerFlags getPickerFlags();
PickerFlags getPickerFlags() const;
virtual void notify( sal_Int16 _nEventId, sal_Int16 _nControlId ) override;
bool FilterNameExists( const OUString& rTitle );
fpicker/source/office/PlacesListBox.hxx
+2 -2
View File
@@ -56,9 +56,9 @@ class PlacesListBox : public Control
void AppendPlace( const PlacePtr& pPlace );
void RemovePlace( sal_uInt16 nPos );
void RemoveSelectedPlace();
sal_Int32 GetNbEditablePlaces() { return mnNbEditables;}
sal_Int32 GetNbEditablePlaces() const { return mnNbEditables;}
bool IsUpdated();
const std::vector<PlacePtr>& GetPlaces() { return maPlaces;}
const std::vector<PlacePtr>& GetPlaces() const { return maPlaces;}
void SetAddHdl( const Link<Button*,void>& rHdl );
void SetDelHdl( const Link<Button*,void>& rHdl );
fpicker/source/office/iodlg.cxx
+1 -1
View File
@@ -2628,7 +2628,7 @@ void SvtFileDialog::setCurrentFileText( const OUString& _rText, bool _bSelectAll
}
bool SvtFileDialog::isAutoExtensionEnabled()
bool SvtFileDialog::isAutoExtensionEnabled() const
{
return pImpl->_pCbAutoExtension && pImpl->_pCbAutoExtension->IsChecked();
}
fpicker/source/office/iodlg.hxx
+1 -1
View File
@@ -215,7 +215,7 @@ public:
sal_Int32 getAvailableHeight() override;
void setImage( sal_Int16 aImageFormat, const css::uno::Any& rImage ) override;
bool getShowState() override;
bool isAutoExtensionEnabled();
bool isAutoExtensionEnabled() const;
OUString getCurrentFileText( ) const override;
void setCurrentFileText( const OUString& _rText, bool _bSelectAll = false ) override;