ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
517,213 Commits 3 Branches 3 Tags
8e4147e02dfb91c436133f59f4837e35f89fb327
Commit Graph
517213 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Muhammad Naeem 8e4147e02d tdf#45904: Migrate XMasterPagesSupplier test for sd from Java to C++ 
Change-Id: Id9c73452040acb5fa365ce741fd5cf3cf45d842c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205276
Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
Tested-by: Jenkins
 2026-05-25 21:07:12 +02:00
JanayeJackson caf583e1a3 tdf#157664 Drop operator != where respective == is defined 
Change-Id: Ib958689984c20c4f28e078e056c752cb4deb5cf2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205507
Tested-by: Jenkins
Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
 2026-05-25 20:13:05 +02:00
Tomaž Vajngerl 50e2176ab5 sc: Auto-expand and contract dynamic array formulas 
Grow or shrink a matrix formula's declared dimensions to match its
interpreted result size. With this, clearing a blocker lets the
array spill across its full range; shrinking the source data
removes the stale trailing cells. Blocking an already-expanded
array collapses it back to the origin with #SPILL!.

Deferred resize queue: inserting or deleting cells inline from
Interpret (or during grid-repaint iteration) would invalidate the
caller's iterator. Queue resizes in the document and drain them
from safe points, guarded by a MatrixResizeGuard helper around
each cell-iteration scope.

Change-Id: I74376427e707fd84c36034fe6a64105e4a5f74fa
Signed-off-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/1817
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
(cherry picked from commit 76b6825e4d237869cb32889b250277be693a2c5f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205686
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-25 16:30:27 +02:00
Tomaž Vajngerl 47040461df sc: Wire array formula spill detection into the calc pipeline 
Detect a blocked spill at interpretation time. When a 1x1-declared
matrix formula that uses a dynamic-array function produces a result
larger than its declared dimensions, check the expansion area for
blocking cells and set FormulaError::Spill if any are found.

Track spilled formula cells at document level - spilled formulas
only listen to their dependency range, not to cells in their
(blocked) spill area, so they aren't notified when a blocker is
cleared. ScDocShell::ResolveSpilledOutputs (renamed) is called
from the Set*/Delete*/Move* cell operations to re-check spilled
cells after any user edit that might have freed a blocker.

Without auto-expand yet: a formula that loses its blocker
re-interprets to NONE and shows its scalar upper-left. The
matrix does not grow to fill the range in this commit.

Change-Id: Ief252a47e5625f72ef6fe52d3bd0afae2d1ee768
Signed-off-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/1816
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
(cherry picked from commit ea20a2c90a264b34a930a5d4bb1118be7ed4836e)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205685
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-25 16:30:14 +02:00
Tomaž Vajngerl 768a051ec5 sc: Preparation for dynamic-array spill handling 
Add a compile-time flag on FormulaTokenArray for formulas that use
a dynamic array function (UNIQUE, FILTER, SORT, SORTBY, SEQUENCE,
RANDARRAY, DROP, EXPAND, HSTACK, VSTACK, TAKE, CHOOSECOLS,
CHOOSEROWS, TEXTSPLIT, TOCOL, TOROW, WRAPCOLS, WRAPROWS). Set by
the compiler when such an opcode appears. Later commits consume
this flag to decide whether a matrix formula is eligible for spill
or auto-resize.

Also fix GetMatrixFormulaCellToken - it used to hide the matrix
token whenever a result error was set, because GetType() returns
svError. Inspect mpToken directly so the token survives error
state. Later commits need the matrix dimensions of a #SPILL! cell
to be readable.

Change-Id: I63c196553762c77b9a64321a2fe9359ee06f6944
Signed-off-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/1815
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit 1ea485c5df618a7ff10c0b8b135d537ce06d94ed)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205684
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-25 16:29:59 +02:00
Tomaž Vajngerl bf9eaed6da sc: Use #SPILL! error if the pivot table output is blocked 
Replace the error message dialog with the same #SPILL! mechanism
used for array formulas when the pivot table output is blocked.
The pivot table configuration is still applied, but the output
cell shows #SPILL! error until the blocking cells are cleared.

Also includes:
- Auto resolve spilled pivot tables after delete, cut, move, paste
- Add sc::UndoSpillPivotTable, so when undoing we can recover back
to the spill error and delete the pivot table output (if present)
- Skip spill check during import to preserve cached output

Change-Id: Icf7d89c088b9d8a9d255945aa6235c91f602d4a9
Signed-off-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/1750
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
(cherry picked from commit 94299df72efeddb3d5af31396f5008300d66a90d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205683
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-25 16:29:19 +02:00
Tomaž Vajngerl 7ed36f0c6a sc: Guard for BeginDrawUndo() capture windows 
Add sc::DrawUndoGuard - constructor opens the capture window (when
enabled), destructor drains any still-pending states. If an undo
action consumes the window in between, the destructor's drain is
a harmless no-op.

Use it in InsertSheetViewOperation, but could be used in other
places as well. Will be done in a follow-up.

Signed-off-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
Change-Id: I0e829c6b025a1fab91b63a350d2a8034f0041100
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/1431
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit 9c1c6d14aee1285c0bf7be1efbfdb1e5c794c39f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205682
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-25 16:28:48 +02:00
Tomaž Vajngerl 6043b44887 sc: Preserve SheetView GUID in OOXML round-trip, generate if new 
Element namedSheetView attribute @id and nsvFilter attribute
@filterId were regenerated on every save, so each round trip
churned the view's identity. Store both on SheetView and create
fresh ones when a new sheet view is created.

Signed-off-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
Change-Id: I64aeb233e1bed4abd6ec900cb1061dfebe73865c
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/1430
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit bb58d472a9b1d0045c01ff9d344c81def3264978)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205681
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-25 16:28:37 +02:00
Tomaž Vajngerl bd4bb4d100 sc: Change the variable name, don't write XML_tableId 
Rename:
maAutoFilterRangeBefore -> moAutoFilterRangeBefore
maAutoFilterRangeAfter -> moAutoFilterRangeAfter

We write XML_tableId with ID 0 for XML_nsvFilter, which is
probably wrong as auto-filter isn't a table, so remove that
and write a todo to add it when table support is added.

Signed-off-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
Change-Id: I1ac4a4c097add397dabbd2cc1c7acf8634d96f0c
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/1429
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
(cherry picked from commit 34d328a41b0b4651deef435b96f3ac821d3c22d8)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205680
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-25 16:28:26 +02:00
Tomaž Vajngerl 8e1b75f6aa sc: Some fixes for SheetView found during code review 
- guard GetHashCode() return value in getPartInfo / part hash
- remove empty namespace declaration
- allow .uno:SelectSheetView when the document is read only

Signed-off-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
Change-Id: Ie093f25d91e4f8c71d67dfb53e7af3dbef13e513
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/1428
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
(cherry picked from commit 80d41944b9f37c2079d8fbdc03cb68ca61406d70)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205679
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-25 16:28:13 +02:00
Tomaž Vajngerl 6bcfad57f7 sc: Fast path sheet view sync for ApplyAttribute operations 
Add syncMarkPatternToSheetViews() which for each sheet view
rebuilds the mark in that view's coordinate space and re-runs
ApplySelectionPattern there. Patterns don't grow data extent,
so no full-sync fallback is needed.

Signed-off-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
Change-Id: Ibb6217df81684b46c86f4c6a687bd3e62a8ba462
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/1427
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
(cherry picked from commit e34ef663c855af595125f968a47f55ad80dcc5b1)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205678
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-25 16:28:05 +02:00
Julien Nabet 773867d93a Fix license 
Change-Id: I0604e442066403b3aef46c68bdf4d8483732b7a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205667
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-25 16:27:56 +02:00
Tomaž Vajngerl 38e59b51e3 sc: Fast path sheet view sync for ApplyAttributesToCellOperation 
Add syncCellPatternToSheetViews that applies the pattern directly
at the row mapped for each sheet view, and strips overridden
edit-text char attribs on CELLTYPE_EDIT cells.

No auto-filter fallback needed as there is no data extension with
patterns.

Signed-off-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
Change-Id: If8a6ea29dea53e483590f7135ae8cdbf5092321d
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/1426
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit 090d8053b0fae20b0ba1a384f678b3a6b6207b26)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205677
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-25 16:27:33 +02:00
Adolfo Jayme Barrientos 30d16a7b72 Update git submodules 
* Update helpcontent2 from branch 'master'
  to 0dcb761d003026c2e361d10216bad7392abad1ba
  - tdf#171455 “Square” [sic] page mode → CJK manuscript grid in Help
    
    Change-Id: I182dce500dff47350ce660df47fb8c5aceb7f07f
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/205602
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
 2026-05-25 16:08:10 +02:00
Mike Kaganski 79ec708230 Fix --enable-werror gcc build on Linux 
... after changes that introduced and used OPropertyContainerHelper.

In file included from /home/mk/core/include/comphelper/propcontainerimplhelper.hxx:18,
                 from /home/mk/core/sc/inc/chartuno.hxx:34,
                 from /home/mk/core/sc/source/ui/unoobj/cellsuno.cxx:83:
/home/mk/core/include/comphelper/propcontainerimplhelper.hxx: In instantiation of ‘class comphelper::OPropertyContainerImplHelper<comphelper::WeakComponentImplHelper<com::sun::star::table::XTableChart, com::sun::star::document::XEmbeddedObjectSupplier, com::sun::star::container::XNamed, com::sun::star::lang::XServiceInfo>, ScChartObj>’:
/home/mk/core/sc/inc/chartuno.hxx:98:14:   required from here
   98 |       public SfxListener
      |              ^~~~~~~~~~~
/home/mk/core/include/comphelper/propimplhelper.hxx:499:1: error: ‘com::sun::star::uno::Any comphelper::OPropertyImplHelper<BaseClass, Ifc>::getFastPropertyValue(sal_Int32) [with BaseClass = comphelper::WeakComponentImplHelper<com::sun::star::table::XTableChart, com::sun::star::document::XEmbeddedObjectSupplier, com::sun::star::container::XNamed, com::sun::star::lang::XServiceInfo>; Ifc = {}; sal_Int32 = int]’ was hidden [-Werror=overloaded-virtual=]
  499 | OPropertyImplHelper<BaseClass, Ifc...>::getFastPropertyValue(sal_Int32 nHandle)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/mk/core/include/comphelper/propcontainerimplhelper.hxx:66:10: note:   by ‘void comphelper::OPropertyContainerImplHelper<BaseClass, Derived, Ifc>::getFastPropertyValue(std::unique_lock<std::mutex>&, com::sun::star::uno::Any&, sal_Int32) const [with BaseClass = comphelper::WeakComponentImplHelper<com::sun::star::table::XTableChart, com::sun::star::document::XEmbeddedObjectSupplier, com::sun::star::container::XNamed, com::sun::star::lang::XServiceInfo>; Derived = ScChartObj; Ifc = {}; sal_Int32 = int]’
   66 |     void getFastPropertyValue(std::unique_lock<std::mutex>&, css::uno::Any& rValue,
      |          ^~~~~~~~~~~~~~~~~~~~

and

/home/mk/core/chart2/source/tools/CachedDataSequence.cxx: In copy constructor ‘chart::CachedDataSequence::CachedDataSequence(const chart::CachedDataSequence&)’:
/home/mk/core/chart2/source/tools/CachedDataSequence.cxx:70:51: error: expected class-name before ‘(’ token
   70 |         : comphelper::OPropertyContainerImplHelper(),
      |                                                   ^
/home/mk/core/chart2/source/tools/CachedDataSequence.cxx:69:1: error: base class ‘class comphelper::OPropertyContainerImplHelper<comphelper::WeakComponentImplHelper<com::sun::star::chart2::data::XDataSequence, com::sun::star::chart2::data::XNumericalDataSequence, com::sun::star::chart2::data::XTextualDataSequence, com::sun::star::util::XCloneable, com::sun::star::util::XModifyBroadcaster, com::sun::star::lang::XInitialization, com::sun::star::lang::XServiceInfo>, chart::CachedDataSequence>’ should be explicitly initialized in the copy constructor [-Werror=extra]
   69 | CachedDataSequence::CachedDataSequence( const CachedDataSequence & rSource )
      | ^~~~~~~~~~~~~~~~~~

and similar.

Change-Id: I913e139744a452ea992d9f574997353a760f4722
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/642
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit 3917b082b9f4530d305cd947ab47658f6883c4f1)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205669
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-25 14:34:21 +02:00
Mike Kaganski 350c6c5333 Drop OPropertyContainer2 
Unused since I4e54547df46feed01613ebe0766c53be3c06de17 (Move EventListener
to use OPropertyContainerImplHelper).

Change-Id: Iad4efd1df433c77f4a5df20caa7a7b35558ab7e5
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/247
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit 51be9cb71c55b72b61720c38295a62b127c83290)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205668
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-25 14:34:09 +02:00
Mike Kaganski 85e3e0facd Move EventListener to use OPropertyContainerImplHelper 
Simplifies the implementation, removing boilerplate.

Change-Id: I4e54547df46feed01613ebe0766c53be3c06de17
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/246
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit 5368ec1c2b6a1d67f4b23c2ce75482993ca263f0)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205665
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-25 14:33:55 +02:00
Mike Kaganski d59fed102e Move BasicScriptImpl to use OPropertyContainerImplHelper 
Simplifies the implementation, removing boilerplate.

Change-Id: I5ec16fee95fa7180e8551b7eeca3d80b829e044b
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/245
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit 834e3df39cf1abe87957f9a589916fb90783ec37)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205664
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-25 14:33:46 +02:00
Mike Kaganski ca02ecc4f6 Move BasicMethodNodeImpl to use OPropertyContainerImplHelper 
Simplifies the implementation, removing boilerplate.

Change-Id: Idf7ca45d428c09ad18c6af2663f18f306a14bad1
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/244
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit 122cecfefb8302f43d4dc6fa8911b96c4d18be3c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205663
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-25 14:33:29 +02:00
Mike Kaganski 5d046e926f Move OCellListSource to use OPropertyContainerImplHelper 
Simplifies the implementation, removing boilerplate.

Change-Id: Ib46e35f8ab3293b9ea4c081fcc50848390ef7b6e
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/243
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit dd1eeedd23e18a26850e6ad5b331747db7875899)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205640
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-25 14:33:24 +02:00
Mike Kaganski 473fa49632 Move OCellValueBinding to use OPropertyContainerImplHelper 
Simplifies the implementation, removing boilerplate.

Change-Id: I5b27255026c61b5b91ad84befbb094c185dd2ff4
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/242
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit b6a8b72a6bbd0dd98852f07c322be45649a2a285)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205639
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-25 14:33:19 +02:00
Mike Kaganski af25b2836c Move SwarmSolver to use OPropertyContainerImplHelper 
Simplifies the implementation, removing boilerplate.

Change-Id: Icc1b4fa10d963b99c2ca82898ea7555a1d00a147
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/240
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit ef6225edad6b277b112901091e4437c7a9ad8914)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205662
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-25 14:33:14 +02:00
Mike Kaganski 2197da017d Move SolverComponent to use OPropertyContainerImplHelper 
Simplifies the implementation, removing boilerplate.

Change-Id: I0c7e0f81163da04f9186401b22b1b852629f5cce
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/239
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit 86fa394c6ab19dd071d518ea59d2518000a7f693)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205661
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-25 14:33:08 +02:00
Mike Kaganski 084e6e1ac7 Move ODatabaseMetaDataResultSet to use OPropertyContainerImplHelper 
Simplifies the implementation, removing boilerplate.

Change-Id: Ic3b0d27178ba730144afadbab9a15b40719320d8
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/238
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit ed7d521ba17e11d281e1819078423897c349b5f1)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205660
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-25 14:33:03 +02:00
Mike Kaganski f54986e41f Move ScChartObj to use OPropertyContainerImplHelper 
Simplifies the implementation, removing boilerplate.

Change-Id: If9170d5356156e3f23f3ef2ca4e8d8d7ccbd8f47
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/237
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit ab16841ac4ced45d8611866a300f8d6bf38d6d33)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205638
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-25 14:32:58 +02:00
Mike Kaganski f138be4686 Move UncachedDataSequence to use OPropertyContainerImplHelper 
Simplifies the implementation, removing boilerplate.

Change-Id: I6746c75ac6a884db525defeb25557d4e8d6f3d03
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/236
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit a0ff800a69ccb7898043c294ba9a13016f176a58)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205659
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-25 14:32:53 +02:00
Mike Kaganski 31fecb70d0 Introduce OPropertyContainerImplHelper as replacement for OPropertyContainer2 
Combines OPropertyImplHelper with OPropertyContainerHelper and
OPropertyArrayUsageHelper. Derived classes only need to implement
createArrayHelper() and call registerProperty().

Migrate CachedDataSequence to use it.

Change-Id: I7c9077f412303ab3ba4d2541c2b6673813193d5a
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/235
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit 480f2837def56b24b0c3b50dcd559dc785b59631)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205658
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-25 14:32:47 +02:00
Mike Kaganski 38ad50ebf4 Move OXSDDataType to use OPropertyImplHelper 
Simplifies the implementation, removing boilerplate.

Change-Id: I56942a0b847995d680f65387b314c6eb27199198
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/241
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit dbb5e6bcd8e8edb3ed3346fb331cb6d38f1f5252)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205666
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-25 14:32:41 +02:00
Xisco Fauli f6af0683df quickjs: upgrade to 0.15.0 
Downloaded from https://github.com/quickjs-ng/quickjs/releases/download/v0.15.0/quickjs-amalgam.zip

Change-Id: Id3f0d952f26bffe0dd4d870ef01027dd58372248
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205657
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-25 13:53:21 +02:00
Xisco Fauli e69c03a445 fix build with --enable-quickjs and --enable-werror 
/mnt/4d311c06-5193-4f61-a3f6-53ca4d9ea1e1/libreoffice/jsuno/source/jsuno.cxx: In constructor ‘{anonymous}::ModuleData::ModuleData(JSContext*, const rtl::OUString&)’:
/mnt/4d311c06-5193-4f61-a3f6-53ca4d9ea1e1/libreoffice/jsuno/source/jsuno.cxx:238:48: error: declaration of ‘name’ shadows a member of ‘{anonymous}::ModuleData’ [-Werror=shadow]
  238 |     ModuleData(JSContext* ctx, const OUString& name)
      |                                ~~~~~~~~~~~~~~~~^~~~
/mnt/4d311c06-5193-4f61-a3f6-53ca4d9ea1e1/libreoffice/jsuno/source/jsuno.cxx:247:14: note: shadowed declaration is here
  247 |     OUString name;
      |              ^~~~
cc1plus: all warnings being treated as errors

Change-Id: Id4d4a366b455c7497170d00270c5328e00f97f19
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205655
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
 2026-05-25 13:52:46 +02:00
Ujjawal Kumar 1b0c64be44 tdf#172084 Don't detect encoding when pasting markdown 
Explicitly use UCS2 encoding when pasting data because
TransferableDataHelper.GetString already offers endianess
aware utf16 data. Thus removing the need for detecting
encoding.

Pasting as markdown was producing gibberish text because when
pasting ctl content like "שלום" the clipboard data doesn't include
the bom due to which the heuristic detection of the data was producing
inverted endianess for the data stream due to the data being short.
For my system it was LE -> BE.

Signed-off-by: Ujjawal Kumar <ujjawal.kumarchouhan@collabora.com>
Change-Id: I9c41610fe070c794ab0764e320305ad1d56e7440
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/2956
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit a0878c24dbc868c5ffb2d679bfb683f787d86fb6)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205652
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-25 12:20:45 +02:00
Caolán McNamara 6839b94df9 give all comboboxes/spinbuttons in sidebars labels 
For all the ones that can appear in calc:

Put the label above the combobox and move the accessible-name (or reuse
tooltip if not present) to be the label text.

Change-Id: I8a98417c0cff56183759ec2879de33c26ed10ad1
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/1192
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit b11db25cf67ecae68235a3eba2dde32588a07567)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205634
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
 2026-05-25 11:55:55 +02:00
Mike Kaganski 852d2107bc Introduce OPropertyImplHelper as a replacement for OPropertySetHelper 
It is intended to work conveniently with cppu::ImplInheritanceHelper,
without XInterface diamond and without a need to write queryInterface/
getTypes/acquire/release boilerplate.

Migrate PathSettings as first user.

+ try to please gcc13 by calling reserve before insert

Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/234
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit e7d0265cbf6219e8b111dd0f98bf293d66bbba97)
Change-Id: I11e6f2d63dbe751fd3acca4ade34f8511775ee47
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205649
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2026-05-25 11:47:15 +02:00
Caolán McNamara 0e08ca725c ofz#516218705 Bad-cast 
ScExternalSingleRefToken cast to its sibling ScExternalDoubleRefToken
to call GetTableName. The fields line up so the right string came back,
but UBSan flags the vptr mismatch.

Direct call to GetString became a cast to ScExternalDoubleRefToken since:

commit 65da502b7b40bd3bcad0cfd146716e815c72d48d
Date:   Thu Apr 16 12:31:01 2026 +0200

    reduce virtual calling in String*Token

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Id5d690fec60e52529f045779c40484df604b3e36
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/3170
Reviewed-by: Noel Grandin <noel.grandin@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit 988be8de0a6422a97a6beed4bec877b83b5b0682)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205653
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-25 11:36:02 +02:00
Xisco Fauli 4d1fcc9c4c sc: silence warning C6011: Dereferencing NULL pointer 'mpDPObject' 
E: /jenkins/workspace/lo_tb_master_win_analyze/sc/source/ui/operation/ReplacePivotTableOperation.cxx(131): error C2220: the following warning is treated as an error
E: \jenkins\workspace\lo_tb_master_win_analyze\sc\source\ui\operation\ReplacePivotTableOperation.cxx(44) : warning C6011: Dereferencing NULL pointer 'mpDPObject'. : Lines: 38, 40, 41, 44
Change-Id: I6dd023a636837435f066ded4e81592a08eb8ef7e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205654
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
 2026-05-25 11:31:11 +02:00
Tomaž Vajngerl da9e2b6a9e sc: Allow sync of auto-filter in sheet views using the fast-path 
In the previous change we only allowed to change the cells that
were not affected by the sorting to use the fast-path for syncing.
With this change we are doing resorting and unsorting of the cell
address, so we can set the cell content directly for default view
and all sheet views, if they are sorted or not.

Change-Id: I790ea794537b7b5b9ea6d0a786c4ef8913c6c4a0
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/1237
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
(cherry picked from commit b9227fed6820de9fdcd078454898e0f48918d2c7)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205637
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-25 11:18:28 +02:00
Stephan Bergmann fc806ad566 UBSan apparently needs ScDrawView RTTI now 
...in CppunitTest_sc_sheetview_test

Change-Id: I840d4b76dd67683084bd27bd328b3c264c0ae972
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203047
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
(cherry picked from commit 2ee4aea9ccd34011abd6ee04bf01fe8f140e317b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205646
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-25 10:24:04 +02:00
Tomaž Vajngerl 8913ab1f10 sc: Faster sheet view syncing for single-cell Set* operations 
The full sheet view sync (OverwriteContent + Reorder + Sort + Query)
is correct but expensive to perform (time vise). For SetValueOperation,
SetStringOperation, SetNormalStringOperation, SetEditTextOperation,
and SetFormulaOperation this is problematic as they run on every cell
change.

Add syncCellToSheetViews() as a faster alternative that propagates a
single cell change directly to each sheet view at the mapped position,
skipping the full sheet copy and re-sort. Falls back to the full sync
when a sheet view has an active sort or the auto-filter range needs
expanding.

Change-Id: Ia4c762acf034ac51f6f1141456e5dfbd80d7f21d
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/1236
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit d7772876f4eeff12a34237460df8ec77e527c319)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205636
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
 2026-05-25 09:58:11 +02:00
Tomaž Vajngerl 67bc6b3052 sc: Undo/redo sort data for ops. that can extend the auto-filter 
There are other operations that can extend the auto-filter range:
- SetEditTextOperation
- SetFormulaOperation
- SetStringOperation
- SetValueOperation

For those we also need to handle the sync correctly and capture the
sort data, so that we can correctly undo and redo the operation.

This also modifies the test so it performs the same use case for
all operations. There is a difference in the result only because
we get different sorting depending on whether we write a number
as text or as a number (which can be a result of a formula).

Change-Id: Ibbda4407bac38d82d03dfd507cf2743fbccca18f
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/202
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/1235
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
(cherry picked from commit 489d2bb6f932bce70e59e2155f97806960ef0681)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205635
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-25 09:58:05 +02:00
Julien Nabet d57034d11f Revert "Introduce OPropertyImplHelper as a replacement for OPropertySetHelper" 
This reverts commit 6116db6154.

Reason for revert: it makes Tinderbox on Master for Linux fail

Change-Id: I157dcd68c057475a5a677a87efb5d1e347207585
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205648
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2026-05-25 09:18:55 +02:00
Tomaž Vajngerl 6c1cfe00a0 oox: Export document theme - major/minor supplimental font list 
This was imported but export was missing. Previously we had the
grab bag for this, so this was exported "correctly".

Also add a round-trip test for this.

Change-Id: I8ea165425828124bf76cbe6697f6d00c60628655
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/567
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
(cherry picked from commit f5537725982ccf7c2695ca80e51b8c93a56a6bba)
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/605
Reviewed-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.com>
(cherry picked from commit d6f52bd730994d9a7d220e2cbb0592bda202fbeb)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205643
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
 2026-05-25 09:02:54 +02:00
Tomaž Vajngerl 9f1cce14e7 PDF export: Include the Graphic in case we have alpha or not 
If we don't include the Graphic, which contains a PDF stream, then
the writen exported PDF will not include the original stream.

This seems to be a regression since we added support for 32-bit
bitmaps, but we didn't normally hit this code path yet.

Change-Id: I570f23d1cd54cb336e9b3ae3d28b2c3b006f3729
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/577
Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit 95283b661c7321229588eb9694c19b83e238c70d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205641
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-25 09:02:21 +02:00
Mike Kaganski 61e749ba2a Fix ThreadedCommentsFragment::onCharacters to handle multiple calls 
... per characters content, as is usual for SAX parsing.
Thanks Miklos for spotting this in
https://gerrit.collaboraoffice.com/c/core/+/801/comment/9e3a60ba_b69d538f/

Change-Id: Iabfb44dcd56364b708f0c933c7cd32a9a11ebaf4
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/911
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit 4c475432ca1c001d1d041b47595f6ec7c58e87fa)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205633
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
 2026-05-25 09:02:09 +02:00
Caolán McNamara 23e5efed4e add accessible name to advancedfilterdialog.ui 
Change-Id: Idb7361914689e6fd0672ada35dd5e64cef1d947d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/201662
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit af3593af5c541c8526f5d925b033a9cd9f6d2f3d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205632
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
 2026-05-25 09:02:02 +02:00
Caolán McNamara 81d8914159 add accessibility name/descriptions to the color dropdown 
so its the same as the value dropdown, the color one is just a
specialization of the general value case and is shown instead
for colors.

Change-Id: I3f0d538a467f0498446db20120c167e5d5cecbcc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/201660
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
(cherry picked from commit e2a8096f619fbe699734cc4e040f9a625b5c0f6e)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205631
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-25 09:01:55 +02:00
Caolán McNamara 09d96d51fe add an accessible-name to definedatabaserangedialog 
Change-Id: I0994f8e5395b934a974e18b7a5b17178f0c61feb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/201627
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit 3fa965cf7079d553d47791674acf54a6d80c2b67)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205630
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-25 09:01:41 +02:00
Mike Kaganski 6116db6154 Introduce OPropertyImplHelper as a replacement for OPropertySetHelper 
It is intended to work conveniently with cppu::ImplInheritanceHelper,
without XInterface diamond and without a need to write queryInterface/
getTypes/acquire/release boilerplate.

Migrate PathSettings as first user.

Change-Id: Ieee0e3bf8ec8313a19e1475375c4007977fef08f
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/234
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit e7d0265cbf6219e8b111dd0f98bf293d66bbba97)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205218
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2026-05-25 09:01:36 +02:00
shark 789fa61602 tdf#168337 Set draw:escape-direction to auto for 
drawing::EscapeDirection_SMART

Change-Id: I37028da7acabbbb80a71c18efa08f5e37d1eb569
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197456
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-25 08:58:42 +02:00
Aryan Mishra 76d0c3a2fe tdf#162563 Remove remaining Java applet code in stoc 
Remove the TestApplet.html, TestApplet.java and makefile.mk in
stoc/test/javavm/testapplet.

Change-Id: I69c9f25966248b74be3d4cee8b20e2316a6c5776
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203424
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-25 08:49:20 +02:00
Tomaž Vajngerl dfa2cf3b09 sc: fix use-after-free in pivot table tests 
Happens in tests:
testSync_ReplacePivotTable_DefaultAndSheetView
testSync_PivotTable_DefaultAndSheetView

Need to refetch the pivot table object, because sheet view sync
will destroy and recreate the pivot table, so the pointer to the
old one is not valid anymore.

Change-Id: I03d2ca3bfbe0fb585135b2a436b6febe3bb30a2d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202969
Reviewed-by: Stephan Bergmann <stephan.bergmann@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
(cherry picked from commit 30717580b2592ffebcd8f4dc069b262968246727)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205628
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
 2026-05-24 22:39:40 +02:00