Commit Graph
507317 Commits
Author SHA1 Message Date
Michael Stahl 88055a2f43 LOCRDT editeng: adapt to yrs v0.23.4 API change
Change-Id: I957cdaa770f34c48ca1283f6d0f3b89d66064f8c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186902
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Tested-by: Jenkins
2025-06-24 19:06:42 +02:00
Deepanshu Sharma 57352dce99 tdf#56676 disable form properties when they are not available for change
Change-Id: I0f1b8f1a2b4ed93fc59849e0b2b66a1a9af7af8b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183219
Tested-by: Jenkins
Reviewed-by: Sahil Gautam <sahil.gautam@collabora.com>
2025-06-24 18:15:11 +02:00
Caolán McNamara bb90e0ffc3 Resolves: tdf#160415 vcl popups misplaced under x11 gtk3
revert:

commit 698935c220
    tdf#152155 vcl: fix gtk popup listbox positions on sidebar

and implement an alternative fix for the original motivating problem
under gtk3 x11

Change-Id: I12eb41a232ba6588ff9eb933b475755cae68dcb0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186891
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
2025-06-24 17:28:48 +02:00
Mike Kaganski 07fa13b331 tdf#167185: make sure that cell width corrections don't accumulate
The problem was, that several rows may share the same row definition,
and the same RTFSprms in the current state. In commit
d00181e8c1 (tdf#167169: postpone \trleftN
processing until \row, 2025-06-23), RTFDocumentImpl::prepareProperties
started to modify existing values inside table row sprms in place; and
that resulted in accumulating changes, where each next row was getting
more corrections of already corrected widths.

This change copies the RTFSprms for correction, avoiding the problem.

Change-Id: Ia199862c7b8983d93d2fce4898fb60bf8b4a1a4f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186890
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2025-06-24 17:22:08 +02:00
Noel Grandin 7920c94ed8 tdf#166932 UpdateStylesList followup
where I forgot to add an else statement. spotted by caolanm

Change-Id: Ic228f081b1f07d4d7491c2ee5ecf7f46e64d4865
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186885
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-06-24 15:15:04 +02:00
Noel Grandin 380bd856d1 [API CHANGE] remove css::drawing::framework::XView
internal to sd, no need for it to use UNO

Change-Id: I17db2d5185051e551565361d29b9f890eb8d77a9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186886
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-06-24 15:13:06 +02:00
Justin Luth bf326cd729 tdf#166141 writerfilter docx: linkStyles != 0.35cm bottom margin
17.15.1.55 linkStyles
(Automatically Update Styles From Document Template)
This element specifies that styles in the given document
shall be updated to match the styles in the attached
template specified using the attachedTemplate element (§17.15.1.6)
when the document is opened by a hosting application.
This setting enables the styles contained in documents
with attached templates to stay synchronized
with the styles used in the attached template.

<the key part is this>
"If the attached template cannot be located or is not a valid file,
then this setting should be silently ignored."

This was added probably in LO 3.6 for a Novell bug for n751020.rtf.

If there is no attachedTemplate provided,
then yes - we need to update styles using Word's application defaults,
but if an attachedTemplate is referenced,
then we need to update the styles using that template.

Since of course LO don't support updating styles from another file
and almost certainly would not have that template available anyway,
just ignore linkStyles when a template is specified.

make CppunitTest_sw_ooxmlexport25 \
    CPPUNIT_TEST_NAME=testTdf166141_linkedStyles

Change-Id: I5ec2f0abeb8073c3caa9a579ba338f30dea9d5ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186855
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
2025-06-24 14:23:26 +02:00
Justin Luth 0df64acd91 tdf#166092 writerfilter: exception killed critical settings
I also took the opportunity to move one setting
(that was placed directly into the DTOR)
into where these things are normally stored in ApplyProperties
(which is called just a bit earlier in that same DTOR).

I tried setting an assert when this fails,
but already hit
sw/qa/writerfilter/filters-test/data/pass/CVE-2005-2964-1.rtf

An earlier patchset contains the unit test.
However, I did not include it because it takes a VERY long time
to load in a debug environment,
and it seems pointless to try to create a minimal document
that still causes a very strange footnote exception.

Change-Id: Ia2b38232e21149407bccceea4ac859d1f38426e6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186856
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
2025-06-24 14:03:28 +02:00
Heiko Tietze 08a84bef0b Resolves tdf#167103 - Apply VT style to Customize dialog
Change-Id: I321ba7f6e8dd93950a7306fb3f03d105bcefd7dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186829
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Tested-by: Jenkins
2025-06-24 13:20:30 +02:00
Heiko Tietze 47f76e52b6 Resolves tdf#167106 - Apply VT style to Character Formatting dialog
Scope reportdesign

Change-Id: I25503bcfcdd26162e86a18af7481b4c32056e1cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186870
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Tested-by: Jenkins
2025-06-24 13:20:15 +02:00
Heiko Tietze 0e41932753 Resolves tdf#167105 - Apply VT style to PDF Export dialog
Change-Id: I9490e67e1105f72853dbc04f0e866b6bc3779528
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186879
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2025-06-24 13:20:00 +02:00
Miklos Vajna 7aa34659e2 sw: document DocumentRedlineManager
Describe that a redline and a tracked change is the same thing.

Change-Id: Ie726d155dbd94e768963d4fa0d41c4170be2ca74
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186884
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2025-06-24 12:55:14 +02:00
Noel Grandin 3912b30e98 [API CHANGE] remove css::drawing::framework::XPane
internal to sd, no need for it to use UNO

Change-Id: I4cf96de4853fdb4095be4c3d1d534fede41cc07f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186869
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
2025-06-24 12:51:57 +02:00
Michael Weghorn a49ba2d728 tdf#130857 qt weld: Support sw "Caption Options" dialog
This means that native Qt widgets are used for that dialog
now when using the qt5 or qt6 VCL plugin and starting LO with
environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.

To trigger the dialog:

* insert an image in Writer
* select the image, right-click to open context menu
* select "Insert Caption" context menu entry
* press the "Options" button in the dialog

Change-Id: Ia2a7a73b565710da8a419d1d2829857f0ddd6828
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186871
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-06-24 12:35:04 +02:00
Mike Kaganski ca2ef8b3c2 LOK Extract API: Use camelCase for "text before / after" in redline data extraction
This improves consistency.

See https://gerrit.libreoffice.org/c/core/+/186690/comments/eaf49418_87ae6bd2

Change-Id: If80730536e3d387a643d93d2d5c92658ec8a3748
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186705
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
(cherry picked from commit 08260893ad23b4334430e9b14952c93794a22607)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186868
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2025-06-24 10:07:14 +02:00
Heiko Tietze 7c3ddb07e8 Resolves tdf#167104 - Apply VT style to Search Format dialog
Change-Id: I0543e055bd340b40bc5e64274c8ab1b7c17b87cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186867
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2025-06-24 10:04:41 +02:00
Michael Weghorn d83ca520f5 tdf#130857 qt weld: Run QtInstanceBuilder::weld_* in main thread
This fixes

    QObject::installEventFilter(): Cannot filter events for objects in a different thread.

warnings seen for the "Tools" -> "Language" ->
"More Dictionaries Online..." dialog in a WIP branch
where support for that dialog is declared for the
SAL_VCL_QT_USE_WELDED_WIDGETS=1 case where
QtInstanceBuilder::weld_widget etc. get called from
a non-main thread.

Backtrace:

    1  QObject::installEventFilter                                                                                                                                             qobject.cpp           2340 0x7ff07571b5ff
    2  QtInstanceWidget::QtInstanceWidget                                                                                                                                      QtInstanceWidget.cxx  30   0x7ff0766d3851
    3  std::make_unique<QtInstanceWidget, QWidget *&>                                                                                                                          unique_ptr.h          1077 0x7ff076621d7b
    4  QtInstanceBuilder::weld_widget                                                                                                                                          QtInstanceBuilder.cxx 218  0x7ff07661e271
    5  AdditionsItem::AdditionsItem                                                                                                                                            AdditionsDialog.cxx   608  0x7ff01b0f80d3
    6  std::_Construct<AdditionsItem, weld::Grid *, AdditionsDialog *&, AdditionInfo&>                                                                                         stl_construct.h       119  0x7ff01b10c633
    7  std::allocator_traits<std::allocator<void>>::construct<AdditionsItem, weld::Grid *, AdditionsDialog *&, AdditionInfo&>                                                  alloc_traits.h        706  0x7ff01b10c1e1
    8  std::_Sp_counted_ptr_inplace<AdditionsItem, std::allocator<void>, (__gnu_cxx::_Lock_policy)2>::_Sp_counted_ptr_inplace<weld::Grid *, AdditionsDialog *&, AdditionInfo&> shared_ptr_base.h     607  0x7ff01b10c1e1
    9  std::__shared_count<(__gnu_cxx::_Lock_policy)2>::__shared_count<AdditionsItem, std::allocator<void>, weld::Grid *, AdditionsDialog *&, AdditionInfo&>                   shared_ptr_base.h     970  0x7ff01b10bfef
    10 std::__shared_ptr<AdditionsItem, (__gnu_cxx::_Lock_policy)2>::__shared_ptr<std::allocator<void>, weld::Grid *, AdditionsDialog *&, AdditionInfo&>                       shared_ptr_base.h     1713 0x7ff01b10bf1c
    11 std::shared_ptr<AdditionsItem>::shared_ptr<std::allocator<void>, weld::Grid *, AdditionsDialog *&, AdditionInfo&>                                                       shared_ptr.h          463  0x7ff01b10be9a
    12 std::make_shared<AdditionsItem, weld::Grid *, AdditionsDialog *&, AdditionInfo&>                                                                                        shared_ptr.h          1007 0x7ff01b0fc4c9
    13 SearchAndParseThread::Append                                                                                                                                            AdditionsDialog.cxx   303  0x7ff01b0f18b6
    14 SearchAndParseThread::Search                                                                                                                                            AdditionsDialog.cxx   343  0x7ff01b0f2aa8
    15 SearchAndParseThread::execute                                                                                                                                           AdditionsDialog.cxx   415  0x7ff01b0f402a
    16 salhelper::Thread::run                                                                                                                                                  thread.cxx            39   0x7ff0880ee5bc
    17 threadFunc                                                                                                                                                              thread.hxx            189  0x7ff0880eed7e
    18 osl_thread_start_Impl                                                                                                                                                   thread.cxx            237  0x7ff0883ea4ab
    19 start_thread                                                                                                                                                            pthread_create.c      448  0x7ff087c9cb7b
    20 __GI___clone3                                                                                                                                                           clone3.S              78   0x7ff087d1a7b8

Change-Id: I69cc3c321fad3a6597ff318f838bd260b30d15ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186865
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-06-24 08:02:21 +02:00
Michael Weghorn 462cb6d249 tdf#130857 qt weld: Run QtInstanceButton::connect_clicked in main thread
Setting a property on a Qt widget needs to happen in
the main thread.

Without this commit, this was seen triggering an assert
in qtbase for the "Tools" -> "Language" ->
"More Dictionaries Online..." dialog in a WIP branch
where support for that dialog is declared for the
SAL_VCL_QT_USE_WELDED_WIDGETS=1 case.

Change-Id: If9e09bed194d9bd34932d353872754b82a2832f5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186864
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
2025-06-24 08:02:15 +02:00
Michael Weghorn f927491da7 tdf#130857 qt weld: Implement QtInstanceWindow::resize_to_request
This will e.g. required to support the "Tools" -> "Language" ->
"More Dictionaries Online..." dialog.

Change-Id: Ie4a3a275b00fd8e8ee16c291834a47dd96c0fcce
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186863
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-06-24 08:02:09 +02:00
Michael Weghorn d45f2087c7 tdf#130857 cui: Don't use multiple names for same radio menu group
In the .ui file for the dialog that can e.g. be triggered
from Writer using "Tools" -> "Language" ->
"More Dictionaries Online...", use the ID of the first
GtkRadioMenuItem of the radio group and set the "group"
property on the other GtkRadioMenuItems belonging to
the same group. Don't set the "group" property on the
menu item that is the first in the group to the ID
of another item of the same group. That isn't necessary
and not handled in QtBuilder.

Change-Id: I954c5aeb97e1175041e4d8cae84d69fe18d8acf1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186862
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
2025-06-24 08:02:03 +02:00
Michael Weghorn ec371490e4 tdf#130857 qt weld: Implement support for "GtkCheckMenuItem"
Change-Id: Ia438ba6f3c8effa54050fe6dae1b53245720ba37
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186861
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
2025-06-24 08:01:55 +02:00
Michael Weghorn 704bb1e6d6 cui: Resave additionsdialog.ui with glade 3.40
The dialog can e.g. be triggered from Writer using
"Tools" -> "Language" -> "More Dictionaries Online...".

Change-Id: If04e9575971c59d4e0ecdd828b03ad43f6a430e9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186860
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-06-24 08:01:49 +02:00
Michael Weghorn ba2e0b0789 tdf#130857 qt weld: Support sw "Line Numbering" dialog
This means that native Qt widgets are used for that dialog
now when using the qt5 or qt6 VCL plugin and starting LO with
environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.

The dialog can be triggered as from Writer via
"Tools" -> "Line Numbering".

Change-Id: Iea3543e445116283d1d7cee1270044e72ef9b920
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186859
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
2025-06-24 08:01:43 +02:00
Michael Weghorn 608a073fb0 tdf#130857 qt weld: Support "Edit Custom Dictionary" dialog
This means that native Qt widgets are used for that dialog
now when using the qt5 or qt6 VCL plugin and starting LO with
environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.

The dialog can be triggered as follows from Writer:

1) "Tools" -> "Spelling"
2) in the Spelling dialog, press the "Options" button
3) select a dictionary and press the "Edit" button

Change-Id: I6c08b8bdfc090062e322cf39c207569e5d75caa6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186858
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
2025-06-24 08:01:37 +02:00
Michael Weghorn b8dba8c020 sd: Resave definecustomslideshow.ui with glade 3.40
That dialog can be triggered in Impress via
"Slide Show" -> "Custom Slide Show" -> "New".

Change-Id: Icd336a929388921c4ead57ebe88936027d00a2ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186857
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
2025-06-24 08:01:31 +02:00
Michael Weghorn 080210c9b4 [API CHANGE]: a11y: Drop com.sun.star.sheet.AccessibleSpreadsheet
Drop the unpublished service
"com.sun.star.sheet.AccessibleSpreadsheet"
because it's unused (apart from providing some
documentation about internal implementation details of
the a11y class implementing it).

The service name returned in
ScAccessibleSpreadsheet::getSupportedServiceNames
didn't even match because it was missing
".sheet" in the name.

This is one step towards dropping the XServiceInfo
implementation from a11y classes, which will also help
avoid linker issues seen on Windows related to multiple
classes subclassing
cppu::ImplInheritanceHelper<class comphelper::OAccessibleComponentHelper,class com::sun::star::lang::XServiceInfo>
seen with upcoming commit

    Change-Id: Ib56a9ddb1c36356943c2dfd7a5705351ee43e9d9
    Author: Michael Weghorn <m.weghorn@posteo.de>
    Date:   Mon May 26 12:24:52 2025 +0200

        vcl a11y: Let OAccessibleComponentHelper implement XAccessible

(Gerrit change [1], Windows CI log: [2]).

A search in Google and on Ask [3] didn't give
any results that would suggest this unpublisheded service
could be relevant for third party code.
(Instances of the service couldn't be created by external
code anyway.)

[1] https://gerrit.libreoffice.org/c/core/+/185849/6
[2] https://ci.libreoffice.org/job/gerrit_windows/200107/console
[3] https://ask.libreoffice.org/

Change-Id: I9de5834c92d42150614bac21b570b909b7ec6eb1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186851
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-06-24 08:01:20 +02:00
Michael Weghorn a3d90dafcf [API CHANGE]: a11y: Drop com.sun.star.text.AccessibleHeaderFooterView
Drop the unpublished service
"com.sun.star.text.AccessibleHeaderFooterView"
because it's unused (apart from providing some
documentation about internal implementation details of
the a11y class implementing it).

This is one step towards dropping the XServiceInfo
implementation from a11y classes, which will also help
avoid linker issues seen on Windows related to multiple
classes subclassing
cppu::ImplInheritanceHelper<class comphelper::OAccessibleComponentHelper,class com::sun::star::lang::XServiceInfo>
seen with upcoming commit

    Change-Id: Ib56a9ddb1c36356943c2dfd7a5705351ee43e9d9
    Author: Michael Weghorn <m.weghorn@posteo.de>
    Date:   Mon May 26 12:24:52 2025 +0200

        vcl a11y: Let OAccessibleComponentHelper implement XAccessible

(Gerrit change [1], Windows CI log: [2]).

A search in Google and on Ask [3] didn't give
any results that would suggest this unpublisheded service
could be relevant for third party code.
(Instances of the service couldn't be created by external
code anyway.)

[1] https://gerrit.libreoffice.org/c/core/+/185849/6
[2] https://ci.libreoffice.org/job/gerrit_windows/200107/console
[3] https://ask.libreoffice.org/

Change-Id: Ib335de951fbd9e91e9f0c303c2fa40bd8e0408d4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186849
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-06-24 08:01:14 +02:00
Michael Weghorn c71a99019b [API CHANGE]: a11y: Drop com.sun.star.text.AccessibleTextFrameView
Drop the unpublished service
"com.sun.star.text.AccessibleTextFrameView"
because it's unused (apart from providing some
documentation about internal implementation details of
the a11y class implementing it).

This is one step towards dropping the XServiceInfo
implementation from a11y classes, which will also help
avoid linker issues seen on Windows related to multiple
classes subclassing
cppu::ImplInheritanceHelper<class comphelper::OAccessibleComponentHelper,class com::sun::star::lang::XServiceInfo>
seen with upcoming commit

    Change-Id: Ib56a9ddb1c36356943c2dfd7a5705351ee43e9d9
    Author: Michael Weghorn <m.weghorn@posteo.de>
    Date:   Mon May 26 12:24:52 2025 +0200

        vcl a11y: Let OAccessibleComponentHelper implement XAccessible

(Gerrit change [1], Windows CI log: [2]).

A search in Google and on Ask [3] didn't give
any results that would suggest this unpublisheded service
could be relevant for third party code.
(Instances of the service couldn't be created by external
code anyway.)

[1] https://gerrit.libreoffice.org/c/core/+/185849/6
[2] https://ci.libreoffice.org/job/gerrit_windows/200107/console
[3] https://ask.libreoffice.org/

Change-Id: I6359a528fb1956718b2cd79cec5374675e4e4b9c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186848
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-06-24 08:01:07 +02:00
Michael Weghorn cd5ed4b58c [API CHANGE]: a11y: Drop com.sun.star.text.AccessibleEndnoteView
Drop the unpublished service
"com.sun.star.text.AccessibleEndnoteView"
because it's unused (apart from providing some
documentation about internal implementation details of
the a11y class implementing it).

This is one step towards dropping the XServiceInfo
implementation from a11y classes, which will also help
avoid linker issues seen on Windows related to multiple
classes subclassing
cppu::ImplInheritanceHelper<class comphelper::OAccessibleComponentHelper,class com::sun::star::lang::XServiceInfo>
seen with upcoming commit

    Change-Id: Ib56a9ddb1c36356943c2dfd7a5705351ee43e9d9
    Author: Michael Weghorn <m.weghorn@posteo.de>
    Date:   Mon May 26 12:24:52 2025 +0200

        vcl a11y: Let OAccessibleComponentHelper implement XAccessible

(Gerrit change [1], Windows CI log: [2]).

A search in Google and on Ask [3] didn't give
any results that would suggest this unpublisheded service
could be relevant for third party code.
(Instances of the service couldn't be created by external
code anyway.)

[1] https://gerrit.libreoffice.org/c/core/+/185849/6
[2] https://ci.libreoffice.org/job/gerrit_windows/200107/console
[3] https://ask.libreoffice.org/

Change-Id: Ib993cc958ebf87412d8f7d0c1e629856a983c03b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186847
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
2025-06-24 08:01:01 +02:00
Michael Weghorn dd055e38be [API CHANGE]: a11y: Drop com.sun.star.text.AccessibleFootnoteView
Drop the unpublished service
"com.sun.star.text.AccessibleFootnoteView"
because it's unused (apart from providing some
documentation about internal implementation details of
the a11y class implementing it).

This is one step towards dropping the XServiceInfo
implementation from a11y classes, which will also help
avoid linker issues seen on Windows related to multiple
classes subclassing
cppu::ImplInheritanceHelper<class comphelper::OAccessibleComponentHelper,class com::sun::star::lang::XServiceInfo>
seen with upcoming commit

    Change-Id: Ib56a9ddb1c36356943c2dfd7a5705351ee43e9d9
    Author: Michael Weghorn <m.weghorn@posteo.de>
    Date:   Mon May 26 12:24:52 2025 +0200

        vcl a11y: Let OAccessibleComponentHelper implement XAccessible

(Gerrit change [1], Windows CI log: [2]).

A search in Google and on Ask [3] didn't give
any results that would suggest this unpublisheded service
could be relevant for third party code.
(Instances of the service couldn't be created by external
code anyway.)

[1] https://gerrit.libreoffice.org/c/core/+/185849/6
[2] https://ci.libreoffice.org/job/gerrit_windows/200107/console
[3] https://ask.libreoffice.org/

Change-Id: I3455622b26072f3ece5b336f6204d3948b648db8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186846
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
2025-06-24 08:00:54 +02:00
Michael Weghorn 15dc0f1090 [API CHANGE]: a11y: Drop com.sun.star.sheet.AccessiblePageHeaderFooterAreasView
Drop the unpublished service
"com.sun.star.sheet.AccessiblePageHeaderFooterAreasView"
because it's unused (apart from providing some
documentation about internal implementation details of
the a11y class implementing it).

This is one step towards dropping the XServiceInfo
implementation from a11y classes, which will also help
avoid linker issues seen on Windows related to multiple
classes subclassing
cppu::ImplInheritanceHelper<class comphelper::OAccessibleComponentHelper,class com::sun::star::lang::XServiceInfo>
seen with upcoming commit

    Change-Id: Ib56a9ddb1c36356943c2dfd7a5705351ee43e9d9
    Author: Michael Weghorn <m.weghorn@posteo.de>
    Date:   Mon May 26 12:24:52 2025 +0200

        vcl a11y: Let OAccessibleComponentHelper implement XAccessible

(Gerrit change [1], Windows CI log: [2]).

A search in Google and on Ask [3] didn't give
any results that would suggest this unpublisheded service
could be relevant for third party code.
(Instances of the service couldn't be created by external
code anyway.)

[1] https://gerrit.libreoffice.org/c/core/+/185849/6
[2] https://ci.libreoffice.org/job/gerrit_windows/200107/console
[3] https://ask.libreoffice.org/

Change-Id: I18b7c0611cfcd5e507abfd8cbd6eac1ebfbf11ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186845
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
2025-06-24 08:00:47 +02:00
Michael Weghorn 1e8baf35bf [API CHANGE]: a11y: Drop com.sun.star.text.AccessibleTextDocumentView
Drop the unpublished service
"com.sun.star.text.AccessibleTextDocumentView"
because it's unused (apart from providing some
documentation about internal implementation details of
the a11y class implementing it).

This is one step towards dropping the XServiceInfo
implementation from a11y classes, which will also help
avoid linker issues seen on Windows related to multiple
classes subclassing
cppu::ImplInheritanceHelper<class comphelper::OAccessibleComponentHelper,class com::sun::star::lang::XServiceInfo>
seen with upcoming commit

    Change-Id: Ib56a9ddb1c36356943c2dfd7a5705351ee43e9d9
    Author: Michael Weghorn <m.weghorn@posteo.de>
    Date:   Mon May 26 12:24:52 2025 +0200

        vcl a11y: Let OAccessibleComponentHelper implement XAccessible

(Gerrit change [1], Windows CI log: [2]).

A search in Google and on Ask [3] didn't give
any results that would suggest this unpublisheded service
could be relevant for third party code.
(Instances of the service couldn't be created by external
code anyway.)

[1] https://gerrit.libreoffice.org/c/core/+/185849/6
[2] https://ci.libreoffice.org/job/gerrit_windows/200107/console
[3] https://ask.libreoffice.org/

Change-Id: If3fcc03720b5dfb62530c5efdaa954689f8efaf9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186844
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-06-24 08:00:40 +02:00
Michael Weghorn 194ef0598c [API CHANGE]: a11y: Drop com.sun.star.sheet.AccessibleSpreadsheetDocumentView
Drop the unpublished service
"com.sun.star.sheet.AccessibleSpreadsheetDocumentView"
because it's unused (apart from providing some
documentation about internal implementation details of
the a11y class implementing it).

This is one step towards dropping the XServiceInfo
implementation from sc a11y classes, which will also help
avoid linker issues seen on Windows related to multiple
classes subclassing
cppu::ImplInheritanceHelper<class comphelper::OAccessibleComponentHelper,class com::sun::star::lang::XServiceInfo>
seen with upcoming commit

    Change-Id: Ib56a9ddb1c36356943c2dfd7a5705351ee43e9d9
    Author: Michael Weghorn <m.weghorn@posteo.de>
    Date:   Mon May 26 12:24:52 2025 +0200

        vcl a11y: Let OAccessibleComponentHelper implement XAccessible

(Gerrit change [1], Windows CI log: [2]).

A search in Google and on Ask [3] didn't give
any results that would suggest this unpublisheded service
could be relevant for third party code.
(Instances of the service couldn't be created by external
code anyway.)

[1] https://gerrit.libreoffice.org/c/core/+/185849/6
[2] https://ci.libreoffice.org/job/gerrit_windows/200107/console
[3] https://ask.libreoffice.org/

Change-Id: Ia5f1009060c48015da91dee2a27496a8d24a27a2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186843
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-06-24 08:00:34 +02:00
Michael Weghorn 5c1a16cd18 [API CHANGE]: a11y: Drop com.sun.star.sheet.AccessibleSpreadsheetPageView
Drop the unpublished service
"com.sun.star.sheet.AccessibleSpreadsheetPageView"
because it's unused (apart from providing some
documentation about internal implementation details of
the a11y class implementing it, but that's not fully
up to date, e.g. mentions a different accessible
name than the logic in
ScAccessibleDocumentPagePreview::getAccessibleName
actually implements).

This is one step towards dropping the XServiceInfo
implementation from sc a11y classes, which will also help
avoid linker issues seen on Windows related to multiple
classes subclassing
cppu::ImplInheritanceHelper<class comphelper::OAccessibleComponentHelper,class com::sun::star::lang::XServiceInfo>
seen with upcoming commit

    Change-Id: Ib56a9ddb1c36356943c2dfd7a5705351ee43e9d9
    Author: Michael Weghorn <m.weghorn@posteo.de>
    Date:   Mon May 26 12:24:52 2025 +0200

        vcl a11y: Let OAccessibleComponentHelper implement XAccessible

(Gerrit change [1], Windows CI log: [2]).

A search in Google and on Ask [3] didn't give
any results that would suggest this unpublisheded service
could be relevant for third party code.
(Instances of the service couldn't be created by external
code anyway.)

[1] https://gerrit.libreoffice.org/c/core/+/185849/6
[2] https://ci.libreoffice.org/job/gerrit_windows/200107/console
[3] https://ask.libreoffice.org/

Change-Id: I93b64a04a580c3f51b3923181e1538616e14347f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186842
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-06-24 08:00:27 +02:00
Michael Weghorn 11f24f01ce svx a11y: Drop SvxGraphCtrlAccessibleContext::getImplementationId
It does the same as the base class implementation
in ImplInheritanceHelper.

Change-Id: I350a0de61f37a22dfd5b28c36f13afe49c75dc89
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186839
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-06-24 08:00:20 +02:00
Michael Weghorn 667db3ef4a sw a11y: Drop XTypeProvider::getImplementationId overrides
All of these do the same as implementations in
base classes: returning an empty Sequence.

Change-Id: I0e9fdb738f82ae06d1a727a7df70770008e99cbc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186838
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-06-24 08:00:13 +02:00
Michael Weghorn ff1099bad4 sc a11y: Use ImplInheritancehelper for ScAccessibleTableBase
Change-Id: Ie045d59a2265130ff2c62b4fbe9375f697b57b7d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186837
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-06-24 08:00:04 +02:00
Michael Weghorn 9ca78aee92 sc a11y: Use ImplInheritancehelper for ScAccessiblePreviewHeaderCell
Change-Id: Id627d8a57cf708c7daf5353eff153dfd9569291e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186836
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-06-24 07:59:56 +02:00
Michael Weghorn aa25ea3049 sc a11y: Drop ScAccessiblePageHeaderArea::getImplementationId
It does the same as the ImplInheritanceHelper base class
implementation.

Change-Id: I5161fba7901b5b56a292dc27c6459efcdb9673cf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186835
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-06-24 07:59:48 +02:00
Michael Weghorn 48fb1d0813 sc a11y: Use ImplInheritancehelper for ScAccessibleEditObject
Change-Id: I74fa453b81d1e2cb7a0df0f4babfe352618e1e37
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186834
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-06-24 07:59:41 +02:00
Michael Weghorn 05de048353 sc a11y: Use ImplInheritancehelper for ScAccessibleDocument
Change-Id: Id3caa3a0bc21b5cc2e7f3939a5f147d39b3794ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186833
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-06-24 07:59:34 +02:00
Michael Weghorn bb40fdd82f sw a11y: Drop SwAccessibleContext::supportsService overrides
... that all implement the same logic.

Change-Id: I759bf1dcabe7b3efdf6f6685289930ecbbbc99eb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186832
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-06-24 07:59:26 +02:00
Michael Weghorn 836d257415 [API CHANGE]: a11y: Drop AccessiblePageView, AccessibleTextDocumentPageView
Drop the unpublished services
"com.sun.star.text.AccessiblePageView" and
"com.sun.star.text.AccessibleTextDocumentPageView"
because they're unused (apart from providing some
documentation about internal implementation details of
the a11y classes implementing them).

This is one step towards dropping the XServiceInfo
implementation from a11y classes, which will also help avoid
linker issues seen on Windows related to multiple
classes subclassing
cppu::ImplInheritanceHelper<class comphelper::OAccessibleComponentHelper,class com::sun::star::lang::XServiceInfo>
seen with upcoming commit

    Change-Id: Ib56a9ddb1c36356943c2dfd7a5705351ee43e9d9
    Author: Michael Weghorn <m.weghorn@posteo.de>
    Date:   Mon May 26 12:24:52 2025 +0200

        vcl a11y: Let OAccessibleComponentHelper implement XAccessible

(Gerrit change [1], Windows CI log: [2]).

A search in Google and on Ask [3] didn't give
any results that would suggest these unpublisheded services
could be relevant for third party code. (Instances.
couldn't be created by external code anyway.)

[1] https://gerrit.libreoffice.org/c/core/+/185849/6
[2] https://ci.libreoffice.org/job/gerrit_windows/200107/console
[3] https://ask.libreoffice.org/

Change-Id: Ia9688f094ef508a0aae07d81ee2d59386272e1a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186827
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-06-24 07:59:18 +02:00
Michael Weghorn 9b6c61a704 a11y: Drop misleading comments about supported services
Those comments don't match what's actually implemented, e.g.:

    /** Returns a list of all supported services.  In this case that is just
        the AccessibleContext service.
    */
    virtual css::uno::Sequence< OUString> SAL_CALL
        getSupportedServiceNames() override;

is out of line with the actual implementation:

    Sequence<OUString> SwAccessiblePreview::getSupportedServiceNames( )
    {
        return {u"com.sun.star.text.AccessibleTextDocumentPageView"_ustr,
                sAccessibleServiceName};
    }

Change-Id: Ifdc7e3ed8aaeacf06156a425f8a35726a7f06b26
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186826
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-06-24 07:59:11 +02:00
Michael Weghorn 491a8012a6 sw a11y: Drop SwAccessiblePreview::supportsService
It implements the same logic as the base class implementation
in SwAccessibleContext::supportsService.

Change-Id: Icfa88bac4b4b1978d2c5f4aa5918fdb909e88b4a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186825
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
2025-06-24 07:59:04 +02:00
Michael Weghorn d6e11e857c [API CHANGE] a11y: Drop service com.sun.star.sheet.AccessibleCell
Stop overriding the XServiceInfo interface methods
in ScAccessibleCell as the info provided by that interface
isn't needed anywhere, see also

    commit 6af782556d
    Author: Michael Weghorn <m.weghorn@posteo.de>
    Date:   Fri Jun 20 11:14:19 2025 +0200

        svtools ruler a11y: No longer implement XServiceInfo

for more background.

Related to that, drop the unpublished
"com.sun.star.sheet.AccessibleCell" service.

This is one step towards dropping the XServiceInfo
implementation from the ScAccessibleContextBase
base class, which will also help avoid linker
issues seen on Windows related to multiple
classes subclassing
cppu::ImplInheritanceHelper<class comphelper::OAccessibleComponentHelper,class com::sun::star::lang::XServiceInfo>
seen with upcoming commit

    Change-Id: Ib56a9ddb1c36356943c2dfd7a5705351ee43e9d9
    Author: Michael Weghorn <m.weghorn@posteo.de>
    Date:   Mon May 26 12:24:52 2025 +0200

        vcl a11y: Let OAccessibleComponentHelper implement XAccessible

(Gerrit change [1], Windows CI log: [2]).

A search in Google and on Ask [3] didn't give
any results that would suggest this unpublished service
could be relevant for third party code. (Instances.
couldn't be created by external code anyway.)
The thread at [4] mentions it in the initial question,
but then doesn't actually make use of it in the usage
example.

[1] https://gerrit.libreoffice.org/c/core/+/185849/6
[2] https://ci.libreoffice.org/job/gerrit_windows/200107/console
[3] https://ask.libreoffice.org/
[4] https://ask.libreoffice.org/t/how-to-create-and-use-accessiblespreadsheet-and-accessiblecell-interfaces/67497

Change-Id: I6365b51644555025e33d76e99908c16e7b8d224e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186824
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-06-24 07:58:57 +02:00
Heiko Tietze ef272d90c4 Resolves tdf#167111 - Help for the UI Picker
Points to the not yet existing pages
* cui/ui/uitabpage/UITabPage
* cui/ui/toolbartabpage/ToolbarTabPage

Change-Id: I6a5326ccd2e2cb9f536ae68c14eff9af4237ef27
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186852
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2025-06-24 07:43:53 +02:00
Noel Grandin 33560caa34 tdf#167152 PSD-Filews created by Photoshop will not be visible
regression from
    commit 81994cb2b8
    Author: Noel Grandin <noelgrandin@gmail.com>
    Date:   Fri Apr 16 20:33:10 2021 +0200
    Convert internal vcl bitmap formats transparency->alpha (II)

Change-Id: I995e5edef0e16a75b3ea702259753a480d825133
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186854
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-06-23 21:45:57 +02:00
Olivier Hallot 504b61f654 Update git submodules
* Update helpcontent2 from branch 'master'
  to ddcdb85434e6d3e5a212e19046477cdd0fc9feab
  - tdf#167111 Adjust Help page on UI selection to match new dialog
    
    Change-Id: I8c3ac2dbee5cfc60310afc7e9e53cd40f9b4dd00
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/186850
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2025-06-23 19:52:16 +02:00
Noel Grandin 2a6f4a2f4f tdf#167112 MATH: Elements sidebar is empty
regression from
  commit 25f007984f91393dbc34adbd2bf59d8b4bae490a
  Author: Noel Grandin <noelgrandin@gmail.com>
  Date:   Tue Jun 10 18:20:18 2025 +0200
  tdf#166932 use BitmapEx in preview style cache instead of VirtualDevice

Change-Id: I385c3428e97b68e3ce7429ffaf87ddfc81a547b0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186853
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-06-23 19:20:14 +02:00