Avoid deleting fly formats one by one while the document is destroyed
since DeleteAndDestroyAll removes all fly formats at once in
SwDoc::~SwDoc afterwards.
Change-Id: Ie62ead75a3ba1cdfa47d072c329e8d9fec9387ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211864
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Tested-by: Jenkins
Otherwise, all remaining listeners will be checked, leading to
performance issues when closing a document with many objects like formulas.
Change-Id: I99b4b536e40af8a9045c7da6356cca87d3c88b02
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211697
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Tested-by: Jenkins
Exchanging the master page already updates all slides using the same
master, so it is enough to update one selected slide per master.
Change-Id: I1a76d20c33151c30679f5b11d179ffb2052e9438
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211580
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Register BarOfPieDiagram and PieOfPieDiagram and map them to the
existing chart2 BarOfPie/PieOfPie templates used by the chart type
dialog.
Change-Id: Id5ba30d7547d290826bb360b2ccb3713fdb95a42
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211460
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Tested-by: Jenkins
A wildcard AutoCorrect entry like ".*->.*" copied that character into
its replacement text, inserting a second FIELDSTART into the node which
crashes FindFieldSep.
Extend the delimiter check to the entire 0x01 ... 0x08 char range
put in the text (CH_TXTATR_BREAKWORD, CH_TXT_ATR_FIELDSEP,
CH_TXT_ATR_INPUTFIELDSTART/END, CH_TXT_ATR_FORMELEMENT,
CH_TXT_ATR_FIELDSTART/END).
Change-Id: Ib58bb7e3c614977082cd9d23722497f77fe9ca8a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211447
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Tested-by: Jenkins
Since cb884d1bdf matrix cells ignored the document's AutoCalculate
setting. This caused them to recalculate on cell access while normal
formulas waited for a recalc.
Exempting only follow-up cells does not work either. They can read a
stale matrix from the origin and clear their dirty flag.
Drop the exemption entirely. F9 enables AutoCalculate, so ScMatRef
recalculates the origin when needed.
Change-Id: Ie7e9c05d7a74f92672180c64f0b154f03babdfa5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211287
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Tested-by: Jenkins
An odd-length array will be drawn as one dash spanning the entire path.
The specifications under
https://www.w3.org/TR/svg-strokes/#StrokeDashing state: "If the list has
an odd number of values, then it is repeated to yield an even number of
values. Thus, the rendering behaviour of stroke-array: 5,4,2 is
equivalent to stroke-dasharray: 5,4,2,5,4,2."
Change-Id: I8f233c4cec5c85f5ab1096b032cbb8743715f14d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211062
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Tested-by: Jenkins
The button was only constructed to actually test that the mouse cursor
clicked on the popup arrow box. If this was not the case, reset the
auto-filter button to its default state. Otherwise,
RefreshAutoFilterButton() draws a grey box over the entire cell after
the popup will be closed.
Change-Id: I07ea38affed52a6ae5a9ac3d19fcdd2a22941816
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/210978
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
The previously used IGNORE_CASE transliteration folded the German "ß" to
"ss", leading to a single entry in the auto-filter.
In addition, a copy and paste error in LessSortCaseInsensitive was
addressed, which affected the correct display order.
Change-Id: Ib05c6860f1c03986644a7237ee9701ffa16358b4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/210956
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Tested-by: Jenkins
FontSizeMenuController::fillPopupMenu() built a printer and a font list
using it. Neither were used after the change from
pFontList->GetSizeAry() to FontList::GetStdSizeAry().
This construction ran once per context menu activation where it runs
through the printer driver on Windows. Hence, the delay was not present
on Linux.
Change-Id: Ia0d9bd6b789f6b99437e97373421cb13a744a9da
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/210516
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
The GoSub flag (0x8000) was cleared before being tested, so PushGosub
never returned to the following line when returning using a Return
statement.
Change-Id: Ic1e6977d48a34c52ed9c24c5be0d9acfa3eb7552
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/210395
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Tested-by: Jenkins
Pass over an omitted argument as a missing parameter instead of a
numeric zero, so that optional parameters, their default values and the
basic function IsMissing() behave accordingly.
Change-Id: I7c4a65dfb1791f8aa900cc9eddd3007422dc41a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209457
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
For instance, when they were created using Split(), since they may have
been reassigned to a different type.
Change-Id: Ib562dad0156fac267982a224395559713831042c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209107
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Tested-by: Jenkins
Otherwise, the current tab will be cleared and the inserted cell value
will be silently dropped.
Change-Id: I0e27d1944d148afdf06cdac469db74140b5274c0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208535
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Otherwise, cutting/copying the entire sheet operates only on the
selected draw object rather than on the entire sheet.
Change-Id: Ie7b1a1c4fb54743c32bd130a9e308f0b6f68fc43
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/207745
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Avoid visible gaps for metafile and window output by adjusting
nOneX/nOneY as in ScOutputData::DrawGrid.
Change-Id: I3c76b6eb21853e94491997f7a3d38c3de985872e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/207393
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Always paint text even for zero-width glyphs (combining diacritics) by
calling SwTextPortion::Paint() which already handles zero width. Adding
the additional check improves the readability of the change.
Change-Id: Ib4044a31c8f1999b15e0fc71f457243e642ad86d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205713
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Tested-by: Jenkins
Recalculate visible area when hiding whitespace since pages become more
compact and the number of pages change.
Change-Id: Ie6e411a61d57d722eb998e1e2d1a853a43a7d2a8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205833
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Autocomplete displays multi-line strings with \n replaced by space. To
detect an exact match, compare strings without line ends.
Change-Id: Ia645dcb8a49140bb009c8c25c704840e0653eed0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205368
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Ensure GoToStart respects freeze pane split position instead of always
moving to the first cell A1.
Change-Id: I8d7c37528ce7363f6cce31f8b26fb237c8573b5b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205516
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Tested-by: Jenkins
Shrink to data area on either entire document export or expert
configuration (default true). Otherwise, preserve any selection
including leading or trailing empty cells.
Change-Id: I88850dbb194a7ebf9d4e987c5c487b6df3069cdb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205173
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Tested-by: Jenkins
When calling a Basic procedure using a named argument (for example,
foo(y:=10)), optional skipped parameters were not correctly marked as
missing, causing the function IsMissing() to return incorrect results.
Change-Id: I90a9910165ec00a24deba86f7b3397dbc0720c93
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205034
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
In the dimension lines tab page, limit number of decimal places to
prevent numeric overflow in the preview image.
Change-Id: I0205e045d6baa84e7419f7d90e17f44f8290ba7f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203603
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
When performing a fill operation, only visible cells are affected
skipping filtered rows (done in ScTable::FillSeries).
Change-Id: Ie05afa31aebce2397a9aea2837dd0929793570bf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203334
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Otherwise mixed visible/filtered selections lead to inconsitent state,
e.g., bold toggle not reverted because filtered cells have a different
format.
Change-Id: I0aa9caf55ddec8c6e698157634e1417139d673fd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203223
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Tested-by: Jenkins
This helps users distinguish Writer tab stops from the Draw ruler,
otherwise drag-and-drop operations on the Draw ruler would not work.
Change-Id: Ia6b22038f4802b0f93c9ac98eca45f8ddcdd4e9d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/201503
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Tested-by: Jenkins
Otherwise, conversions during the save/insert process will change the
format of the file name field because the constants need to be converted
from SwFileNameFormat to FilenameDisplayFormat and vice versa.
Change-Id: I6ee3ae3adc34a86560381f8e9585a016d4f312ec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198019
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Andreas Heinisch