* Update helpcontent2 from branch 'master'
to edcc3ca5f71bb680059d4713b095246f876837b4
- tdf#149085 Protect section in Writer object properties moved to
Position and Size tab.
I removed the <ahelp> tags as the .ui file already has extended tips defined.
Also update the label Automatic to AutoSize to match current UI.
Change-Id: Iddb9dfa48e983879fba8233a37b64f954b5787fe
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172941
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Jenkins
when we have lots of pages, we trigger a O(n^2) loop.
Do two things to reduce this
(a) be smarter about recalculating page numbers, so we only recalculate
the set of page numbers that need recalculating
(b) duplicate the last page repeatedly, instead of the first page, so we
don't recalculate all the page numbers for each page we duplicate
Change-Id: I40aca812b47a9551039c5855b1c8d26f5f171f41
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172942
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Currently SfxObjectShell::CheckIsReadonly() has a hack for the LOK case
to show the signatures dialog read-only, as only that is async.
The next step to get rid of this hack is to make
SfxMedium::SignContents_Impl() async, now that
SfxObjectShell::SignDocumentContent() is async.
This requires all callers of SfxMedium::SignContents_Impl() to be async,
most notably SfxObjectShell::SignScriptingContent() has to be converted
as well.
Note that no lifecycle problem is expected here for the callback, since
the object shell and its medium is typically around for as long as the
document is loaded.
Change-Id: I57f2c747f8448b9adc0398f874ede36211fed817
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172934
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Fixes an issue causing incorrect textbox positions when the containing
shape is anchored 'as character' inside RTL text, with the
DoNotMirrorRtlDrawObjs compatibility flag set.
Change-Id: I58cade8b91925dda188a1ef8fd078ccfdc3fea56
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172938
Tested-by: Jenkins
Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
Mysteriously this works the first time the section is made visible, but
then hide it again and unhide it and a table has height 0 because only
the table itself is invalidated and none of the text frames inside it.
SwTabFrame::MakeAll() does Prepare(PrepareHint::FramePositionChanged) on
all contained text frames, but that may actually do nothing in common
cases.
So just recursively invalidate everything in the section, that should
fix things.
(regression from commit ff7f1b59e22092d8548459e75fe912db852f056f)
Change-Id: I26e72193947685fde52fb8da78e95592a3866c12
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172920
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Tested-by: Jenkins
Without this, it's hard to see which header node section belongs to the
header of which page desc.
Change-Id: I9994b511c8df7b992350a13ac1cf4fcf875c49ba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172930
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
moNeedsClearRedo is an implementation detail,
so there should not be public functions for it.
Plus, NeedsClearRedo can be called either against
the CurrentLevel stack or the TopLevel stack
(whatever that implies - there is no documentation...)
and since it is a delayed call that means that
multiple NeedsClearRedo attempts could be made,
theoretically against both stacks.
My initial implementation was "last one wins",
(which may very well prove to be the best one)
but whatever happens, it should be clearly intentional.
Based on my limited skill at code reading,
it sounds like CurrentLevel might be more of an implemention detail
or a temporary expansion of a ListUndoAction,
so I am guessing that any request for TopLevel clearing
should be given priority.
For Writer, it is always clearing the TopLevel stack
sw/source/core/undo/docundo.cxx: ClearRedo()
return SdrUndoManager::ImplClearRedo_NoLock(TopLevel);
Change-Id: I195aefb696599f018712135a2e015549d534791f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171984
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Reviewed-by: Justin Luth <jluth@mail.com>
See `QtFrame::UpdateSettings()`, where `StyleSettings::WindowColor` is
set to aBase (QPalette::Base) and `StyleSettings::DialogColor` is set to
WindowColor in a call to `StyleSettings::BatchSetBackgrounds`.
The issue is that without this patch in place, "GetWindowColor()" doesn't
return the color of the window, instead it returns the "base color" from
QPalette.
It had some unintendedd consequences like the "Animation Panel" in the
Impress's Animations sidebar not being painted with the correct color,
as it was expecting the old WindowColor. This patch also fixes that by
changing WindowColor to FieldColor in `SalInstanceWidget::set_stack_background()`
https://gerrit.libreoffice.org/c/core/+/168901/comment/0e5201bd_2cae07b9/
Change-Id: I36f8c5efd8c3e87ded19a1efc00ed9c69a7fccf1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171916
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
changed Korean Font priority for LibreOffice UI
* Change list order, "맑은 고딕;Malgun Gothic;애플 SD 산돌고딕 Neo;Apple SD Gothic Neo"
after Noto Sans CJK & Nanum Gothic.
* Change list order, Make Noto Serif CJK KR font read first for Korean-Serif Familys
Because, Noto Sans CJK KR, Nanum Gothic are mostly used on Windows, Linux, and Mac.
"맑은 고딕;Malgun Gothic;" is used on Windows,
"애플 SD 산돌고딕 Neo;Apple SD Gothic Neo" is used on Mac.
* Modified dotum's Korean name. `돋음` to `돋움`
* default TEXT font use Sans instead of Serif.
In Korean environment, MS products were adopted Sans-family's Malgun Gothic font as a default font since Vista
Also, HWP(South Korea's a proprietary word processing application) is adopted Sans-Family's HCRDotum(함초롱돋움) since HWP 2010.
As a result, I changed Sans-family font as a default Text font instead of Serif-family font on LibreOffice UI.
Change-Id: I3c7803b63a52d5569ca36d788d944a038e6fd8bb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157494
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Jenkins
This reverts my 25.2 commit c8e272734a.
Reason for revert: I found an example where wrapping does apply.
In addition, wrap-through images are not restricted to the paper area, but in this case the shape should still be restricted.
Needs more testing..., so just completely revert for now.
Change-Id: I559942fee98f5693c90f7e16f65fefb7ecb9ab48
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172899
Reviewed-by: Justin Luth <jluth@mail.com>
Tested-by: Jenkins
/<<PKGBUILDDIR>>/sw/source/uibase/config/usrpref.cxx: In member function ‘com::sun::star::uno::Sequence<rtl::OUString> SwContentViewConfig::GetPropertyNames() const’:
/<<PKGBUILDDIR>>/sw/source/uibase/config/usrpref.cxx:120:24: error: ‘strcmp’ is not a member of ‘std’; did you mean ‘strcmp’?
120 | static_assert(std::strcmp("Update/Link", aPropNames[g_UpdateLinkIndex]) == 0);
| ^~~~~~
In file included from /<<PKGBUILDDIR>>/include/rtl/string.hxx:36,
from /<<PKGBUILDDIR>>/include/rtl/ustring.hxx:45,
from /<<PKGBUILDDIR>>/include/com/sun/star/uno/Any.h:30,
from /<<PKGBUILDDIR>>/include/com/sun/star/uno/Any.hxx:35,
from /<<PKGBUILDDIR>>/include/o3tl/any.hxx:21,
from /<<PKGBUILDDIR>>/sw/source/uibase/config/usrpref.cxx:23:
/usr/include/string.h:156:12: note: ‘strcmp’ declared here
156 | extern int strcmp (const char *__s1, const char *__s2)
| ^~~~~~
/<<PKGBUILDDIR>>/sw/source/uibase/config/usrpref.cxx:121:24: error: ‘strcmp’ is not a member of ‘std’; did you mean ‘strcmp’?
121 | static_assert(std::strcmp("Display/DefaultAnchor", aPropNames[g_DefaultAnchor]) == 0);
| ^~~~~~
/usr/include/string.h:156:12: note: ‘strcmp’ declared here
156 | extern int strcmp (const char *__s1, const char *__s2)
| ^~~~~~
make[2]: *** [/<<PKGBUILDDIR>>/solenv/gbuild/LinkTarget.mk:338: /<<PKGBUILDDIR>>/workdir/CxxObject/sw/source/uibase/config/usrpref.o] Error 1
Change-Id: Ie6c89500c554e0027d9b14c082baca519a454c10
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172860
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
(cherry picked from commit f20592f7baf1b07f1b60c1625e69cee6e2e9be88)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172891
Didn't notice that this depends on a global variable "bObjsDirect" so it
only works for some documents; move the HideAndShowObjects() call to the
end so it works in all cases.
(follow-up to commit 8a13277f79)
Change-Id: I26a7cecdb660179f3ac1c3ea1e5d19067806b741
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172915
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Tested-by: Jenkins
Currently SfxObjectShell::CheckIsReadonly() has a hack for the LOK case
to show the signatures dialog read-only, as only that is async.
The first problem for the read-write signatures dialog is that
SfxObjectShell::ExecFile_Impl() has code after invoking
SfxObjectShell::SignDocumentContent(), which will be executed too early
if the dialog is executed async.
Fix the problem by moving the code in question into a new
SfxObjectShell::AfterSignContent(), and only invoke that as a callback
after the async run finished.
The message dialog in the moved code is still non-async, but we can deal
with that later.
Change-Id: I32f0895118ac0da72105ec3a24c0294e18c05545
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172914
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
The problem with a full customer doc is that a table doesn't MoveBwd
because ShouldBwdMoved finds that the rows don't fit as the rows still
have non-0 heights, and the result is an empty page at the end; also the
table later splits.
Turns out that setting bDontSplit prevents both problems; the inner
frames are all set to 0 height by lcl_RecalcTable().
(regression from commit ff7f1b59e22092d8548459e75fe912db852f056f)
Change-Id: I5012142a0019ee2e978d5b8a9eb445ff0949e569
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172910
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Tested-by: Jenkins
* Update helpcontent2 from branch 'master'
to 0e9d2c728aa5f30b4fa97922a85e5f56912869d9
- tdf#162504 tdf#152161 Create help pages for Properties sidebar panels
Created a new page text/shared/01/sidebar_properties.xhp
This page is a WIP but it proved to be easier to created pages for the
individual panels one at a time. I've included it in the patch because
some of the other pages have embedded content from the howtoget section.
Created a new page text/shared/01/sidebar_character_panel.xhp
- to document the Character options in the Properties sidebar
Created a new page text/shared/01/sidebar_paragraph_panel.xhp
- to document the Paragraph options in the Properties sidebar
Created a new page text/shared/01/table_design.xhp
- to document the Table Design options in the Properties sidebar in Draw
and Impress
Created a new page text/swriter/01/paragraph_hyphenation.xhp
- to document the Hyphenation options in the Paragraph panel of the
Properties sidebar in Writer
In text/shared/00/00040502.xhp
- Removed outdated How to get information for the Double Underline
option
- Added section tags so that content can be easily embedded in other
pages
In text/simpress/main0203.xhp
- Added Help instructions for the Character Highlight widget.
- Added icons for the "Increase Font Size" and "Decrease Font Size"
widgets.
In text/shared/01/05020500.xhp
- Added Icon for "Spacing"
In text/swriter/guide/using_hyphen.xhp
- Changed title from "Hyphenation" to "Using Hyphenation" to match H1
and avoid confusion with the two other pages titled "Hyphenation".
Added section and variable tags to allow content to be easily embedded
in other pages in:
source/text/shared/00/00040500.xhp
source/text/shared/01/05010000.xhp
source/text/shared/01/05020100.xhp
source/text/shared/01/05020200.xhp
source/text/shared/01/05020500.xhp
text/shared/01/05030100.xhp
source/text/shared/01/05030700.xhp
source/text/shared/01/05070410.xhp
source/text/shared/01/05070510.xhp
source/text/shared/01/05070610.xhp
source/text/shared/01/05110100.xhp
source/text/shared/01/05110200.xhp
source/text/shared/01/05110300.xhp
source/text/shared/01/05110400.xhp
source/text/shared/01/06050300.xhp
source/text/shared/01/06050500.xhp
source/text/shared/01/StyleNewByExample.xhp
source/text/shared/01/StyleUpdateByExample.xhp
source/text/shared/01/formatting_mark.xhp
source/text/shared/02/02010000.xhp
source/text/shared/02/02020000.xhp
source/text/shared/02/02130000.xhp
source/text/shared/02/02140000.xhp
source/text/shared/02/02160000.xhp
source/text/shared/02/03110000.xhp
source/text/shared/02/03120000.xhp
source/text/shared/02/paintbrush.xhp
source/text/swriter/01/05030200.xhp
source/text/swriter/guide/using_hyphen.xhp
Change-Id: If8071612709aeae514dbd591eba4c1d0d0928a64
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172844
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Python only:
Reset a flag in SF_Database.DMin and DMax methods
to allow dates to be returned.
Review typing hints to accept strings and dates
Integration of remarks from Microsoft/VSCode
about minor syntax issues in scriptforge.pyi
(syntax was accepted by PyCharm).
Now, syntax commonly accepted by both IDE's.
Change-Id: I752d9f1d7a5293222d81748f8fb2e8f46f4317de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172912
Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
Tested-by: Jenkins
There are 2 different ways to hide flys, either destroy the SwFlyFrames
(as is done for delete redlines or fieldmarks) or move them to an
invisible layer (as is done for field-hidden paragraphs).
Previously for hidden sections the FlyFrames would be destroyed, but
it's easier now to move them to invisible layer.
HideAndShowObjects() needs to be recursive so it can hide flys that are
anchored in a table.
(regression from commit ff7f1b59e22092d8548459e75fe912db852f056f)
Change-Id: Ideab0343315e575c066eb9e2e901d2ee0acabe3a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172865
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Tested-by: Jenkins
Ilmari Lauhakangas