ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
401,594 Commits 3 Branches 3 Tags
64d80d22851a38eb3f320f4e2b2bdf875da4d8b4
Commit Graph
817 Commits
Author SHA1 Message Date
Noel Grandin 401d07f31f loplugin:datamembershadow 
Change-Id: I0206905ce95467a560f8ed24db4403df07d3680e
 2016-11-17 11:19:55 +02:00
Noel Grandin 3c4c5aa8cc loplugin:expandablemethods in writerfilter..xmlhelp 
Change-Id: I23ce30e2f15b6fe857a727f1ef84c40d8d0b127d
 2016-10-24 14:29:57 +02:00
Noel Grandin 7477ab1391 loplugin:inlineablemethods in xmloff 
Change-Id: I22202f85c65a862ccdafe1d521e2945e3d99252a
 2016-10-18 08:51:07 +02:00
Stephan Bergmann 81dde672f1 clang-cl loplugin: xmlhelp 
Change-Id: I66956b57b542bd6375ae113ff7cc8856fa6235cd
Reviewed-on: https://gerrit.libreoffice.org/29839
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2016-10-15 07:59:38 +00:00
Stephan Bergmann f255c3e96e [API CHANGE] Remove HAVE_GCC_VISIBILITY_FEATURE, always true 
* GCC documents -fvisibility at least as far back as the GCC 4.0 online
  documentation at
  <https://gcc.gnu.org/onlinedocs/gcc-4.0.4/gcc/Code-Gen-Options.html>.

* For external code, odk/settings/settings.mk unconditionally set
  HAVE_GCC_VISIBILITY_FEATURE for all platforms other than Windows.

Make this a fatal configure error for now.  The check should be removed
completely after LO 5.3 branch-off.

Change-Id: I1de415b6ed1591e0a7b6640ece861b6f0ef74112
Reviewed-on: https://gerrit.libreoffice.org/29073
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2016-09-20 07:34:27 +00:00
Arnaud Versini a46803587d Replace local ASCII function with rtl/character.hxx 
Change-Id: I63568dabbcea4159276b4020af6bc01f9175dfa7
Reviewed-on: https://gerrit.libreoffice.org/28996
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-09-19 07:06:15 +00:00
Noel Grandin 0ea50b5b43 loplugin:countusersofdefaultparams in xmloff 
Change-Id: Ia92a878ac97b3cc668594946e77a718f27a3e3ed
Reviewed-on: https://gerrit.libreoffice.org/28890
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-09-14 08:47:48 +00:00
Stephan Bergmann 91dd2db17b loplugin:override: No more need for the "MSVC dtor override" workaround 
The issue of 362d4f0cd4 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
 2016-09-13 13:19:22 +02:00
Noel Grandin d64395704e loplugin:unusedenumconstants in unotools..xmlhelp 
Change-Id: Id7ddc0fc1f57c5e8e7fb002e31d54fb8e9f8ffab
Reviewed-on: https://gerrit.libreoffice.org/28050
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-08-15 05:51:53 +00:00
Noel Grandin 500a3be0ea loplugin:countusersofdefaultparams in vcl..xmlsecurity 
Change-Id: I538596a99e632178d928ff7e66ad45c71b73c6fd
Reviewed-on: https://gerrit.libreoffice.org/28018
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-08-12 06:54:08 +00:00
Noel Grandin 508c95f1b6 improve passstuffbyref return analysis 
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c
Reviewed-on: https://gerrit.libreoffice.org/27317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-07-27 06:48:25 +00:00
Noel Grandin 9870f02b31 loplugin:countusersofdefaultparams in tools..xmlsecurity 
find methods with default params with only zero or one call site

Change-Id: Ie5b30f60e9fe00ba1acf0dfc79b005ded46f05a0
Reviewed-on: https://gerrit.libreoffice.org/27512
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-07-27 06:44:50 +00:00
Noel Grandin 6e72f0251b new loplugin unnecessary override 
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb
Reviewed-on: https://gerrit.libreoffice.org/27135
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2016-07-15 14:05:41 +00:00
Stephan Bergmann da7259b584 loplugin:passstuffbyref also for {css::uno,rtl}::Reference 
Change-Id: I0d1ee65be8a3e4b01454dba34bbeb4de58744853
 2016-07-07 18:59:55 +02:00
Noel Grandin 6a5e30d52c loplugin:singlevalfields in xmlhelp,xmloff 
Change-Id: Ia40d1c9a153b5237c46d5a2b807dceff30775f4a
Reviewed-on: https://gerrit.libreoffice.org/26589
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-24 06:46:01 +00:00
Noel Grandin 5bd5baff3f remove some more (void) style function definitions/declarations 
found with
    git grep -nP '^\s*void\s*\)'

Change-Id: I1206031cf957cb6f957cae64ec5cae1280bda694
Reviewed-on: https://gerrit.libreoffice.org/26590
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-23 10:57:45 +00:00
Noel Grandin bc1e738708 Convert IteratorState to scoped enum 
Change-Id: I71850584a727261e9e7b2115bdfb488ba76b6d21
Reviewed-on: https://gerrit.libreoffice.org/25919
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-06 07:02:26 +00:00
Noel Grandin e9af29ba83 loplugin:unusedmethods in writerfilter to xmloff 
Change-Id: If95890eff0f785111e8b511ac1d5481c6910f099
Reviewed-on: https://gerrit.libreoffice.org/25148
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-19 10:01:23 +00:00
Noel Grandin 96fab05132 clang-tidy modernize-loop-convert in writerfilter to xmlsecurity 
Change-Id: I334411c6b57c028ffb41b5deb72002f9d54038c3
Reviewed-on: https://gerrit.libreoffice.org/24923
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-13 08:09:03 +00:00
Noel Grandin 58a32075ca use Any constructor instead of temporaries 
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
 2016-05-04 12:39:40 +02:00
Noel Grandin 789055bc2a clang-tidy performance-unnecessary-copy-initialization 
probably not much performance benefit, but it sure is good at
identifying leftover intermediate variables from previous
refactorings.

Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657
Reviewed-on: https://gerrit.libreoffice.org/24026
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-18 07:37:31 +00:00
Noel Grandin 62633dfe02 clang-tidy performance-unnecessary-value-param in various 
Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907
Reviewed-on: https://gerrit.libreoffice.org/24019
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-14 11:37:19 +00:00
Noel Grandin b8eb294651 loplugin:passstuffbyref in various 
Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022
 2016-04-14 10:24:47 +02:00
Noel Grandin a31840be01 reduce unnecessary reallocing 
Change-Id: I01880cfecdab4addb358c74cbcdc02c98c0d6224
Reviewed-on: https://gerrit.libreoffice.org/23764
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-04 09:19:15 +00:00
Noel Grandin b4fda7b3f9 new loplugin:constantparam 
finds parameters that are only ever being called with a single value

Change-Id: Ibd0c9b6e6dbc1d1b5d5a005eaa19959560a6e50f
 2016-03-08 09:04:47 +02:00
Noel Grandin c45d3badc9 new loplugin: commaoperator 
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
 2016-02-23 08:08:56 +02:00
Noel Grandin 778e9a65bf new loplugin: find write-only fields 
Change-Id: I0f83939babacf92485420ee63f290a297d7cb717
Reviewed-on: https://gerrit.libreoffice.org/22498
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-02-19 11:23:57 +00:00
Noel Grandin 2087484c65 use consistent #define checks for the Windows platform 
stage 2 of replacing usage of various checks for the windows platform
with the compiler-defined '_WIN32' macro

In this stage we focus on replacing usage of the WIN macro

Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84
Reviewed-on: https://gerrit.libreoffice.org/22393
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-02-17 11:33:57 +00:00
Chris Sherlock a238b1f8d3 Remove excess newlines 
A ridiculously fast way of doing this is:

for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
  --exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
    perl -0777 -i -pe 's/^
{3,}/

/gm' $i
done

Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-02-09 08:18:05 +00:00
Noel Grandin 752cd07d08 InterfaceContainer2 with vector instead of Sequence 
create an InterfaceContainer2 class to replace InterfaceContainer.
It uses a std::vector instead of a Sequence for the mutable listener
list, which provides far better performance.

Switch all our internal use-sites to the new class.

Change-Id: I6b56cfa511ded2395faa22e68fab3b2f16c3cb88
 2016-01-25 08:52:03 +02:00
Andrea Gelmini 64d624b651 Fix typos 
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
Reviewed-on: https://gerrit.libreoffice.org/21209
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-01-10 14:17:20 +00:00
Stephan Bergmann e9aa3c99d2 Simplify code 
Change-Id: I28cff254d2cc1e2abe6fc893d918bd84bfc8645c
 2016-01-05 12:25:31 +01:00
Stephan Bergmann ce3dd82ca8 Clean up configuration access 
Change-Id: I0662e8ddb24f2c6a7197b8a5f23c219484628b78
 2016-01-05 12:25:31 +01:00
Stephan Bergmann 549e900b4b tdf#96855: Put back assignment of xHierAccess 
...that had inadvertently been removed as part of a larger code removal in
6948c546fd "tdf#75637: Resolve help images via a
vnd.libreoffice.image UCP"

Change-Id: Ic2d5e1a5fa5a10b240bb9e511e6dcb8097e58081
 2016-01-04 15:16:44 +01:00
Noel Grandin 4c7ce41582 loplugin:unusedfields in xmlhelp,xmloff 
Change-Id: I4d2f0ff95da5abaa3d0a0a5223616e09e0c476fc
 2015-12-21 12:45:49 +02:00
Noel Grandin e18b08363a loplugin:unusedmethods 
Change-Id: Ifafdaf6da0225f244853a0042a6458643b570623
 2015-12-21 10:20:31 +02:00
Stephan Bergmann e65233abd4 -Werror,-Wunused-private-field 
Change-Id: I4649381a330bc4e9d4f419137f0393f6f35bea17
 2015-11-26 13:47:36 +01:00
Noel Grandin abc6071b7a loplugin:unusedfields various 
Change-Id: I18f94269a1172cf195ee402384f7144610e1e82d
 2015-11-26 13:26:25 +02:00
Noel Grandin fa452b54a5 com::sun::star->css in xmlhelp 
Change-Id: Iaa57a071f8f0e6945d24f019cb4c06e02d066e0a
Reviewed-on: https://gerrit.libreoffice.org/20147
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-25 04:47:05 +00:00
Noel Grandin 22c5968314 loplugin:unusedfields in xmlhelp/ 
Change-Id: I1db28ad3670c166201050a4e19a50ec13a82fa76
 2015-11-24 10:09:26 +02:00
Noel Grandin 96c26b0d9d use initialiser for Sequence<OUString> 
using variations of:
git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\)\;
\s*OUString\* pArray.*;
.*\[0\]\s*=\s*(\S+)\;/Sequence<OUString> \1 { \2 };/g"

Change-Id: I03c64334ff30ee14dce0d17b67f5122a3893bbe3
Reviewed-on: https://gerrit.libreoffice.org/19971
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-15 12:20:39 +00:00
Noel Grandin 25aec383f9 use initialiser for Sequence<OUString> 
replaced using:
git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)'
| xargs perl -0777 -pi -e
"s/Sequence<\s*OUString\s*> (\w+)\(\s*1\s*\);
.*\[0\] = (\S+);/Sequence<OUString> \1 { \2 };/g"

Change-Id: I20ad0489da887a9712982531c3b127339bb8b3b9
Reviewed-on: https://gerrit.libreoffice.org/19969
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-15 12:18:55 +00:00
Stephan Bergmann 87bae0e188 loplugin:nullptr (automatic rewrite) 
Change-Id: Ibdc68ac3fa6e1424337096c720c8c9605b767480
 2015-11-10 10:32:01 +01:00
Stephan Bergmann fd80fa38db loplugin:stringconstant: elide explicit ctor usage (automatic rewrite) 
Change-Id: I9ee0d12d68cef7bd65d1e119d0272e356e7cf300
 2015-11-06 09:38:40 +01:00
Noel Grandin 9e8ff13eb2 use uno::Reference::set method instead of assignment 
Change-Id: I60e52ef2abc3107ba77e81811dfe1bffbfd77218
 2015-11-05 13:32:17 +02:00
Noel Grandin 59b072e22b yyyyy 
Change-Id: I9a947beefd2dfe21da8239e841ea3fb416bd1548
 2015-11-04 14:10:44 +02:00
Noel Grandin b5db48ada1 no need to use OUString constructor in call to createInstance 
Change-Id: Iaf3d83ba1490cb1d97a5bd4d1f7cd6943d4a7296
Reviewed-on: https://gerrit.libreoffice.org/19704
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-01 15:25:43 +00:00
Noel Grandin 3bc5df7f32 UNO: no need to use OUString constructor when calling createInstance 
Change-Id: I37da28539b94706574116d0fff5f008aabfb5526
Reviewed-on: https://gerrit.libreoffice.org/19682
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-10-30 08:59:59 +00:00
Michael Stahl 03802af730 xmlhelp: apparently "picture.jar" hasn't existed for a long time 
Change-Id: I9ac46ffcf21e8af2cb3b92d4068981cafb271ebc
 2015-10-27 14:39:56 +01:00
Stephan Bergmann 6948c546fd tdf#75637: Resolve help images via a vnd.libreoffice.image UCP 
...which uses the logic already available in VCL's ImplImageTree to locate the
image zip files and find fallbacks for incomplete themes and for localized
images.

Change-Id: Ic1c15fcacb6596a27a2b051093232902202bf472
 2015-10-26 17:55:14 +01:00