ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

loplugin:countusersofdefaultparams in tools..xmlsecurity

Browse Source 
find methods with default params with only zero or one call site

Change-Id: Ie5b30f60e9fe00ba1acf0dfc79b005ded46f05a0
Reviewed-on: https://gerrit.libreoffice.org/27512
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
This commit is contained in:
Noel Grandin
2016-07-27 06:44:50 +00:00
committed by Noel Grandin
parent 1485074d84
commit 9870f02b31
32 changed files with 50 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/source/inet/inetmime.cxx
+1 -2
View File
@@ -446,8 +446,7 @@ public:
void includes(sal_uInt32 nChar);
rtl_TextEncoding getPreferredEncoding(rtl_TextEncoding eDefault
= RTL_TEXTENCODING_DONTKNOW)
rtl_TextEncoding getPreferredEncoding(rtl_TextEncoding eDefault)
const;
void reset();
ucb/source/ucp/file/filglob.hxx
+2 -2
View File
@@ -63,7 +63,7 @@ namespace fileaccess {
extern osl::FileBase::RC osl_File_copy( const OUString& strPath,
const OUString& strDestPath,
bool test = false );
bool test );
/**
* special move:
@@ -84,7 +84,7 @@ namespace fileaccess {
const css::uno::Reference< css::ucb::XCommandEnvironment >& xEnv,
const OUString& aUncPath,
BaseContent* pContent,
bool isHandled = false);
bool isHandled);
// the physical URL of the object
} // end namespace fileaccess
ucb/source/ucp/file/filtask.hxx
+1 -1
View File
@@ -94,7 +94,7 @@ namespace fileaccess
}
void SAL_CALL installError( sal_Int32 nErrorCode,
sal_Int32 nMinorCode = TASKHANDLER_NO_ERROR )
sal_Int32 nMinorCode )
{
m_nErrorCode = nErrorCode;
m_nMinorCode = nMinorCode;
unoidl/source/unoidlprovider.cxx
+1 -1
View File
@@ -551,7 +551,7 @@ std::vector< OUString > readAnnotations(
ConstantValue readConstant(
rtl::Reference< MappedFile > const & file, sal_uInt32 offset,
sal_uInt32 * newOffset = nullptr, bool * annotated = nullptr)
sal_uInt32 * newOffset, bool * annotated)
{
assert(file.is());
int v = file->read8(offset);
vbahelper/source/msforms/vbacontrols.cxx
+1 -1
View File
@@ -50,7 +50,7 @@ class ControlArrayWrapper : public ::cppu::WeakImplHelper< container::XNameAcces
ControlIndexMap mIndices;
private:
void SetArrayElementTo( const uno::Reference< awt::XControl >& xCtrl, sal_Int32 nIndex = -1 )
void SetArrayElementTo( const uno::Reference< awt::XControl >& xCtrl, sal_Int32 nIndex )
{
// initialize the element with specified index to the control
if ( xCtrl.is() )
vbahelper/source/vbahelper/vbacommandbarhelper.hxx
+1 -1
View File
@@ -77,7 +77,7 @@ public:
const OUString& getModuleId() const { return maModuleId; }
OUString findToolbarByName( const css::uno::Reference< css::container::XNameAccess >& xNameAccess, const OUString& sName ) throw (css::uno::RuntimeException);
static sal_Int32 findControlByName( const css::uno::Reference< css::container::XIndexAccess >& xIndexAccess, const OUString& sName, bool bMenu = false ) throw (css::uno::RuntimeException);
static sal_Int32 findControlByName( const css::uno::Reference< css::container::XIndexAccess >& xIndexAccess, const OUString& sName, bool bMenu ) throw (css::uno::RuntimeException);
static OUString generateCustomURL();
};
vcl/inc/fontsubset.hxx
+2 -2
View File
@@ -82,8 +82,8 @@ private:
protected:
bool CreateFontSubsetFromCff( sal_Int32* pOutGlyphWidths = nullptr );
bool CreateFontSubsetFromSfnt( sal_Int32* pOutGlyphWidths = nullptr );
static bool CreateFontSubsetFromType1( sal_Int32* pOutGlyphWidths = nullptr );
bool CreateFontSubsetFromSfnt( sal_Int32* pOutGlyphWidths );
static bool CreateFontSubsetFromType1( sal_Int32* pOutGlyphWidths );
};
#endif // INCLUDED_VCL_INC_FONTSUBSET_HXX
vcl/inc/headless/svpgdi.hxx
+1 -1
View File
@@ -137,7 +137,7 @@ public:
virtual void SetTextColor( SalColor nSalColor ) override;
virtual void SetFont( FontSelectPattern*, int nFallbackLevel ) override;
virtual void GetFontMetric( ImplFontMetricDataPtr&, int nFallbackLevel = 0 ) override;
virtual void GetFontMetric( ImplFontMetricDataPtr&, int nFallbackLevel ) override;
virtual const FontCharMapPtr GetFontCharMap() const override;
virtual bool GetFontCapabilities(vcl::FontCapabilities &rFontCapabilities) const override;
virtual void GetDevFontList( PhysicalFontCollection* ) override;
vcl/inc/headless/svpinst.hxx
+1 -1
View File
@@ -118,7 +118,7 @@ public:
virtual void DestroyFrame( SalFrame* pFrame ) override;
// Object (System Child Window)
virtual SalObject* CreateObject( SalFrame* pParent, SystemWindowData* pWindowData, bool bShow = true ) override;
virtual SalObject* CreateObject( SalFrame* pParent, SystemWindowData* pWindowData, bool bShow ) override;
virtual void DestroyObject( SalObject* pObject ) override;
// VirtualDevice
vcl/inc/impgraph.hxx
+4 -4
View File
@@ -102,10 +102,10 @@ private:
void ImplStartAnimation( OutputDevice* pOutDev,
const Point& rDestPt,
const Size& rDestSize,
long nExtraData = 0,
OutputDevice* pFirstFrameOutDev = nullptr );
void ImplStopAnimation( OutputDevice* pOutputDevice = nullptr,
long nExtraData = 0 );
long nExtraData,
OutputDevice* pFirstFrameOutDev );
void ImplStopAnimation( OutputDevice* pOutputDevice,
long nExtraData );
void ImplSetAnimationNotifyHdl( const Link<Animation*,void>& rLink );
Link<Animation*,void> ImplGetAnimationNotifyHdl() const;
vcl/inc/opengl/program.hxx
+1 -1
View File
@@ -70,7 +70,7 @@ public:
GLuint Id() { return mnId; }
bool Load( const OUString& rVertexShader, const OUString& rFragmentShader,
const rtl::OString& preamble = "", const rtl::OString& rDigest = "" );
const rtl::OString& preamble, const rtl::OString& rDigest );
bool Use();
void Reuse();
bool Clean();
vcl/inc/opengl/texture.hxx
+1 -1
View File
@@ -59,7 +59,7 @@ public:
return mnRefCount == 1;
}
bool InitializeSlotMechanism(int nInitialSlotSize = 0);
bool InitializeSlotMechanism(int nInitialSlotSize);
void SetSlotDeallocateCallback(std::function<void(int)> aCallback)
{
vcl/inc/openglgdiimpl.hxx
+2 -2
View File
@@ -122,7 +122,7 @@ public:
void DrawConvexPolygon( sal_uInt32 nPoints, const SalPoint* pPtAry, bool blockAA = false );
void DrawConvexPolygon( const tools::Polygon& rPolygon, bool blockAA = false );
void DrawTrapezoid( const basegfx::B2DTrapezoid& trapezoid, bool blockAA = false );
void DrawTrapezoid( const basegfx::B2DTrapezoid& trapezoid, bool blockAA );
void DrawRect( long nX, long nY, long nWidth, long nHeight );
void DrawRect( const Rectangle& rRect );
void DrawPolygon( sal_uInt32 nPoints, const SalPoint* pPtAry );
@@ -132,7 +132,7 @@ public:
void DrawTextureRect( OpenGLTexture& rTexture, const SalTwoRect& rPosAry, bool bInverted = false );
void DrawTexture( OpenGLTexture& rTexture, const SalTwoRect& rPosAry, bool bInverted = false );
void DrawTransformedTexture( OpenGLTexture& rTexture, OpenGLTexture& rMask, const basegfx::B2DPoint& rNull, const basegfx::B2DPoint& rX, const basegfx::B2DPoint& rY );
void DrawAlphaTexture( OpenGLTexture& rTexture, const SalTwoRect& rPosAry, bool bInverted = false, bool pPremultiplied = false );
void DrawAlphaTexture( OpenGLTexture& rTexture, const SalTwoRect& rPosAry, bool bInverted, bool pPremultiplied );
void DrawTextureDiff( OpenGLTexture& rTexture, OpenGLTexture& rMask, const SalTwoRect& rPosAry, bool bInverted = false );
void DrawTextureWithMask( OpenGLTexture& rTexture, OpenGLTexture& rMask, const SalTwoRect& rPosAry );
void DrawBlendedTexture( OpenGLTexture& rTexture, OpenGLTexture& rMask, OpenGLTexture& rAlpha, const SalTwoRect& rPosAry );
vcl/inc/salgdi.hxx
+1 -1
View File
@@ -131,7 +131,7 @@ public:
void ReleaseFonts() { SetFont( nullptr, 0 ); }
// get the current font's metrics
virtual void GetFontMetric( ImplFontMetricDataPtr&, int nFallbackLevel = 0 ) = 0;
virtual void GetFontMetric( ImplFontMetricDataPtr&, int nFallbackLevel ) = 0;
// get the repertoire of the current font
virtual const FontCharMapPtr GetFontCharMap() const = 0;
vcl/inc/salinst.hxx
+1 -1
View File
@@ -81,7 +81,7 @@ public:
virtual void DestroyFrame( SalFrame* pFrame ) = 0;
// Object (System Child Window)
virtual SalObject* CreateObject( SalFrame* pParent, SystemWindowData* pWindowData, bool bShow = true ) = 0;
virtual SalObject* CreateObject( SalFrame* pParent, SystemWindowData* pWindowData, bool bShow ) = 0;
virtual void DestroyObject( SalObject* pObject ) = 0;
// VirtualDevice
vcl/inc/textlayout.hxx
+2 -2
View File
@@ -91,8 +91,8 @@ namespace vcl
virtual ~ControlTextRenderer();
Rectangle DrawText( const Rectangle& _rRect,
const OUString& _rText, DrawTextFlags _nStyle = DrawTextFlags::NONE,
MetricVector* _pVector = nullptr, OUString* _pDisplayText = nullptr );
const OUString& _rText, DrawTextFlags _nStyle,
MetricVector* _pVector, OUString* _pDisplayText );
private:
ControlTextRenderer( const ControlTextRenderer& ) = delete;
vcl/inc/unx/genpspgraphics.h
+1 -1
View File
@@ -93,7 +93,7 @@ public:
virtual void SetTextColor( SalColor nSalColor ) override;
virtual void SetFont( FontSelectPattern*, int nFallbackLevel ) override;
virtual void GetFontMetric( ImplFontMetricDataPtr&, int nFallbackLevel = 0 ) override;
virtual void GetFontMetric( ImplFontMetricDataPtr&, int nFallbackLevel ) override;
virtual const FontCharMapPtr GetFontCharMap() const override;
virtual bool GetFontCapabilities(vcl::FontCapabilities &rFontCapabilities) const override;
virtual void GetDevFontList( PhysicalFontCollection* ) override;
vcl/inc/unx/gtk/gtkinst.hxx
+1 -1
View File
@@ -204,7 +204,7 @@ public:
virtual SalFrame* CreateFrame( SalFrame* pParent, SalFrameStyleFlags nStyle ) override;
virtual SalFrame* CreateChildFrame( SystemParentData* pParent, SalFrameStyleFlags nStyle ) override;
virtual SalObject* CreateObject( SalFrame* pParent, SystemWindowData* pWindowData, bool bShow = true ) override;
virtual SalObject* CreateObject( SalFrame* pParent, SystemWindowData* pWindowData, bool bShow ) override;
virtual SalSystem* CreateSalSystem() override;
virtual SalInfoPrinter* CreateInfoPrinter(SalPrinterQueueInfo* pPrinterQueueInfo, ImplJobSetup* pJobSetup) override;
virtual SalPrinter* CreatePrinter( SalInfoPrinter* pInfoPrinter ) override;
vcl/inc/unx/printergfx.hxx
+1 -1
View File
@@ -374,7 +374,7 @@ public:
{ return maVirtualStatus.mbArtBold; }
void DrawText (const Point& rPoint,
const sal_Unicode* pStr, sal_Int16 nLen,
const sal_Int32* pDeltaArray = nullptr);
const sal_Int32* pDeltaArray);
void SetTextColor (PrinterColor& rTextColor)
{ maTextColor = rTextColor; }
sal_Int32 GetCharWidth (sal_uInt16 nFrom, sal_uInt16 nTo,
vcl/inc/unx/printerjob.hxx
+1 -1
View File
@@ -75,7 +75,7 @@ private:
bool writeFeatureList( osl::File* pFile, const JobData&, bool bDocumentSetup );
bool writeSetup( osl::File* pFile, const JobData& );
bool writePageSetup( osl::File* pFile, const JobData&, bool bWriteFeatures = true );
bool writePageSetup( osl::File* pFile, const JobData&, bool bWriteFeatures );
static void writeJobPatch( osl::File* File, const JobData& );
static bool writeProlog (osl::File* pFile, const JobData& );
vcl/inc/unx/salbmp.h
+1 -1
View File
@@ -229,7 +229,7 @@ public:
ImplSalBitmapCache();
~ImplSalBitmapCache();
void ImplAdd( X11SalBitmap* pBmp, sal_uIntPtr nMemSize = 0UL );
void ImplAdd( X11SalBitmap* pBmp, sal_uIntPtr nMemSize );
void ImplRemove( X11SalBitmap* pBmp );
void ImplClear();
};
vcl/inc/unx/salgdi.h
+1 -1
View File
@@ -117,7 +117,7 @@ public:
virtual void SetTextColor( SalColor nSalColor ) override;
virtual void SetFont( FontSelectPattern*, int nFallbackLevel ) override;
virtual void GetFontMetric( ImplFontMetricDataPtr&, int nFallbackLevel = 0 ) override;
virtual void GetFontMetric( ImplFontMetricDataPtr&, int nFallbackLevel ) override;
virtual const FontCharMapPtr GetFontCharMap() const override;
virtual bool GetFontCapabilities(vcl::FontCapabilities &rFontCapabilities) const override;
virtual void GetDevFontList( PhysicalFontCollection* ) override;
vcl/inc/unx/salinst.h
+1 -1
View File
@@ -51,7 +51,7 @@ public:
virtual SalFrame* CreateFrame( SalFrame* pParent, SalFrameStyleFlags nStyle ) override;
virtual void DestroyFrame( SalFrame* pFrame ) override;
virtual SalObject* CreateObject( SalFrame* pParent, SystemWindowData* pWindowData, bool bShow = true ) override;
virtual SalObject* CreateObject( SalFrame* pParent, SystemWindowData* pWindowData, bool bShow ) override;
virtual void DestroyObject( SalObject* pObject ) override;
/// Gtk vclplug needs to pass GtkSalGraphics to X11SalVirtualDevice, so create it, and pass as pNewGraphics.
vcl/source/edit/textdoc.hxx
+1 -1
View File
@@ -54,7 +54,7 @@ public:
bool& HasEmptyAttribs() { return mbHasEmptyAttribs; }
TextCharAttrib* FindAttrib( sal_uInt16 nWhich, sal_Int32 nPos );
const TextCharAttrib* FindNextAttrib( sal_uInt16 nWhich, sal_Int32 nFromPos, sal_Int32 nMaxPos = SAL_MAX_INT32 ) const;
const TextCharAttrib* FindNextAttrib( sal_uInt16 nWhich, sal_Int32 nFromPos, sal_Int32 nMaxPos ) const;
TextCharAttrib* FindEmptyAttrib( sal_uInt16 nWhich, sal_Int32 nPos );
bool HasAttrib( sal_uInt16 nWhich ) const;
bool HasBoundingAttrib( sal_Int32 nBound );
vcl/source/gdi/pdfwriter_impl.hxx
+8 -8
View File
@@ -805,7 +805,7 @@ i12626
/* writes all gradient patterns */
bool emitGradients();
/* writes a builtin font object and returns its objectid (or 0 in case of failure ) */
sal_Int32 emitBuiltinFont( const PdfBuiltinFontFace*, sal_Int32 nObject = -1 );
sal_Int32 emitBuiltinFont( const PdfBuiltinFontFace*, sal_Int32 nObject );
/* writes a type1 embedded font object and returns its mapping from font ids to object ids (or 0 in case of failure ) */
std::map< sal_Int32, sal_Int32 > emitEmbeddedFont( const PhysicalFontFace*, EmbedFont& );
/* writes a type1 system font object and returns its mapping from font ids to object ids (or 0 in case of failure ) */
@@ -1165,7 +1165,7 @@ public:
void emitComment( const char* pComment );
//--->i56629 named destinations
sal_Int32 createNamedDest( const OUString& sDestName, const Rectangle& rRect, sal_Int32 nPageNr = -1, PDFWriter::DestAreaType eType = PDFWriter::XYZ );
sal_Int32 createNamedDest( const OUString& sDestName, const Rectangle& rRect, sal_Int32 nPageNr, PDFWriter::DestAreaType eType );
//--->i59651
//emits output intent
@@ -1175,21 +1175,21 @@ public:
sal_Int32 emitDocumentMetadata();
// links
sal_Int32 createLink( const Rectangle& rRect, sal_Int32 nPageNr = -1 );
sal_Int32 createLink( const Rectangle& rRect, sal_Int32 nPageNr );
sal_Int32 createDest( const Rectangle& rRect, sal_Int32 nPageNr = -1, PDFWriter::DestAreaType eType = PDFWriter::XYZ );
sal_Int32 registerDestReference( sal_Int32 nDestId, const Rectangle& rRect, sal_Int32 nPageNr = -1, PDFWriter::DestAreaType eType = PDFWriter::XYZ );
sal_Int32 registerDestReference( sal_Int32 nDestId, const Rectangle& rRect, sal_Int32 nPageNr, PDFWriter::DestAreaType eType );
void setLinkDest( sal_Int32 nLinkId, sal_Int32 nDestId );
void setLinkURL( sal_Int32 nLinkId, const OUString& rURL );
void setLinkPropertyId( sal_Int32 nLinkId, sal_Int32 nPropertyId );
// outline
sal_Int32 createOutlineItem( sal_Int32 nParent = 0, const OUString& rText = OUString(), sal_Int32 nDestID = -1 );
sal_Int32 createOutlineItem( sal_Int32 nParent, const OUString& rText, sal_Int32 nDestID );
void setOutlineItemParent( sal_Int32 nItem, sal_Int32 nNewParent );
void setOutlineItemText( sal_Int32 nItem, const OUString& rText );
void setOutlineItemDest( sal_Int32 nItem, sal_Int32 nDestID );
// notes
void createNote( const Rectangle& rRect, const PDFNote& rNote, sal_Int32 nPageNr = -1 );
void createNote( const Rectangle& rRect, const PDFNote& rNote, sal_Int32 nPageNr );
// structure elements
sal_Int32 beginStructureElement( PDFWriter::StructElement eType, const OUString& rAlias );
void endStructureElement();
@@ -1201,8 +1201,8 @@ public:
void setAlternateText( const OUString& rText );
// transitional effects
void setAutoAdvanceTime( sal_uInt32 nSeconds, sal_Int32 nPageNr = -1 );
void setPageTransition( PDFWriter::PageTransition eType, sal_uInt32 nMilliSec, sal_Int32 nPageNr = -1 );
void setAutoAdvanceTime( sal_uInt32 nSeconds, sal_Int32 nPageNr );
void setPageTransition( PDFWriter::PageTransition eType, sal_uInt32 nMilliSec, sal_Int32 nPageNr );
// controls
sal_Int32 createControl( const PDFWriter::AnyWidget& rControl, sal_Int32 nPageNr = -1 );
vcl/source/outdev/font.cxx
+1 -1
View File
@@ -1095,7 +1095,7 @@ bool OutputDevice::ImplNewFont() const
pFontInstance->mbInit = true;
pFontInstance->mxFontMetric->SetOrientation( sal::static_int_cast<short>(pFontInstance->maFontSelData.mnOrientation) );
pGraphics->GetFontMetric( pFontInstance->mxFontMetric );
pGraphics->GetFontMetric( pFontInstance->mxFontMetric, 0 );
pFontInstance->mxFontMetric->ImplInitTextLineSize( this );
pFontInstance->mxFontMetric->ImplInitAboveTextLineSize();
vcl/unx/generic/dtrans/X11_selection.hxx
+1 -1
View File
@@ -418,7 +418,7 @@ namespace x11 {
// compound text conversion
OString convertToCompound( const OUString& rText );
OUString convertFromCompound( const char* pText, int nLen = -1 );
OUString convertFromCompound( const char* pText, int nLen );
sal_Int8 getUserDragAction() const;
sal_Int32 getSelectionTimeout();
vcl/unx/generic/printer/ppdparser.cxx
+1 -1
View File
@@ -122,7 +122,7 @@ namespace psp
static css::lang::Locale normalizeInputLocale(
const css::lang::Locale& i_rLocale,
bool bInsertDefault = false
bool bInsertDefault
)
{
css::lang::Locale aLoc( i_rLocale );
xmlhelp/source/cxxhelp/provider/databases.hxx
+1 -1
View File
@@ -430,7 +430,7 @@ namespace chelp {
css::uno::Reference< css::container::XHierarchicalNameAccess >
nextJarFile( css::uno::Reference< css::deployment::XPackage >& o_xParentPackageBundle,
OUString* o_pExtensionPath = nullptr, OUString* o_pExtensionRegistryPath = nullptr );
OUString* o_pExtensionPath, OUString* o_pExtensionRegistryPath );
private:
css::uno::Reference< css::container::XHierarchicalNameAccess >
xmloff/source/style/impastpl.hxx
+2 -2
View File
@@ -82,7 +82,7 @@ public:
~XMLAutoStylePoolParent();
bool Add( XMLAutoStyleFamily& rFamilyData, const ::std::vector< XMLPropertyState >& rProperties, OUString& rName, bool bDontSeek = false );
bool Add( XMLAutoStyleFamily& rFamilyData, const ::std::vector< XMLPropertyState >& rProperties, OUString& rName, bool bDontSeek );
bool AddNamed( XMLAutoStyleFamily& rFamilyData, const ::std::vector< XMLPropertyState >& rProperties, const OUString& rName );
@@ -151,7 +151,7 @@ public:
void AddFamily( sal_Int32 nFamily, const OUString& rStrName,
const rtl::Reference < SvXMLExportPropertyMapper > & rMapper,
const OUString& rStrPrefix, bool bAsFamily = true );
const OUString& rStrPrefix, bool bAsFamily );
void SetFamilyPropSetMapper( sal_Int32 nFamily,
const rtl::Reference < SvXMLExportPropertyMapper > & rMapper );
void RegisterName( sal_Int32 nFamily, const OUString& rName );
xmloff/source/style/xmlexppr.cxx
+1 -1
View File
@@ -192,7 +192,7 @@ public:
vector< XMLPropertyState >& rPropStates,
const Reference< XPropertySet >& xPropSet,
const rtl::Reference< XMLPropertySetMapper >& maPropMapper,
const bool bDefault = false);
const bool bDefault);
sal_uInt32 GetPropertyCount() const { return nCount; }
};
xmlsecurity/qa/unit/signing/signing.cxx
+4 -4
View File
@@ -95,8 +95,8 @@ public:
CPPUNIT_TEST_SUITE_END();
private:
void createDoc(const OUString& rURL = OUString());
void createCalc(const OUString& rURL = OUString());
void createDoc(const OUString& rURL);
void createCalc(const OUString& rURL);
uno::Reference<security::XCertificate> getCertificate(XMLSignatureHelper& rSignatureHelper);
};
@@ -161,7 +161,7 @@ uno::Reference<security::XCertificate> SigningTest::getCertificate(XMLSignatureH
void SigningTest::testDescription()
{
// Create an empty document and store it to a tempfile, finally load it as a storage.
createDoc();
createDoc("");
utl::TempFile aTempFile;
aTempFile.EnableKillingFile();
@@ -194,7 +194,7 @@ void SigningTest::testDescription()
void SigningTest::testOOXMLDescription()
{
// Create an empty document and store it to a tempfile, finally load it as a storage.
createDoc();
createDoc("");
utl::TempFile aTempFile;
aTempFile.EnableKillingFile();