Change styles of objects of first slide to automatic styles.
It preserves styles when affecting Master Page.
Change-Id: I3c54284477d6a4cd84369204a556f123b36b0ba7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179970
Tested-by: Jenkins
Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
Change styles of objects of first slide to automatic styles.
It preserves styles when affecting Master Page.
Change-Id: I43b8d8354c7c7c63f1b6f460e20c6376a76dcc02
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179971
Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
Tested-by: Jenkins
WinLaunchChild takes the same kind of argv as execv, terminated by
a null pointer; so no need to pass argc.
Change-Id: I280c8da0c613a7d0d1a208831a87f0e4648719f8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179952
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Fixes CVE-2024-56378
- remove disable-nss-and-gpgmepp.patch.1 and instead build
CryptoSignBackend.cc which appears to have working ifdefs now
- run the update_pch script
- add clang-std-rotate.patch.1 because jenkins failed
Change-Id: I7fcdd10766287e83dc666041644f129378584d91
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179903
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
This reverts commit 404fbec257.
Reason for revert: It's follow-up fix bbb53997c3
"fix ubsan failure" had to be reverted (because it conflicted with a revert of
cc56bf56e1 "convert RES_OBJECTDYING to SfxHint",
which in turn is known broken and thus needed to be reverted for now), so revert
this known-broken commit for now as well.
Change-Id: I4e65c7113e1e5bfdb9841c98bee3712a1beb12ae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179941
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
This works for standart pages. But notes pages don't have a style property in their master pages.
This commit, when libreofficeKit is active, uses corresponding standart page's master page properties for notes pages.
Used only for background colors.
Change-Id: Ib1115a4fbc87ecd94f9bb44b43268b9578734950
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179929
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
The remaining 2 classes are not used in multiple .cxx files, so just
move them closer to their only user.
Change-Id: I7c7b295e21ea97acf33d7f4a60a61b25788ab5c2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179926
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
Introduce QtInstanceToolbar as the native Qt implementation
for weld::Toolbar that uses a QToolBar widget.
This mostly adds the basic structure and lets Qt{,Instance}Builder
create an instance of the class when encountering a
"GtkToolbar" object in a .ui file.
The actual logic for the QtInstanceToolbar methods
still needs to be implemented. Calling them currently
triggers an assert.
Change-Id: I2734e5b931d5cb9608ec4d01222634a8ffada299
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179883
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
The embedding cannot rely on SVG providing all
values of x/y/w/h, so added fallbacks to real
geometric size. Also removed double-adding
geometry.
Change-Id: I1914ed0c3e1e42ba899db4f3eb9193fd29e9c4be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179831
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
Using an autogen.input somewhat different from what I usually use for ASan/UBSan
builds, that caused
> libtool: link: /home/sberg/llvm/inst/bin/clang -fdiagnostics-color=always -fsanitize=address -fsanitize-address-globals-dead-stripping -fsanitize-address-use-after-return=always -fsanitize=undefined -fsanitize=float-divide-by-zero -fsanitize=local-bounds -fsanitize=nullability -fno-sanitize=function -O0 -Wp,-U_FORTIFY_SOURCE -fstrict-aliasing -fstrict-overflow -ggdb2 -gsplit-dwarf -Xclang -debug-info-kind=constructor -ggnu-pubnames -Wl,-z -Wl,origin -Wl,-rpath -Wl,\$ORIGIN -Wl,-rpath-link -Wl,/home/sberg/lo-asanubsan/core/instdir/program -o .libs/rapper rapper.o ../src/.libs/libraptor2.so -Wl,-rpath -Wl,/usr/local/lib
> /usr/bin/ld: /home/sberg/lo-asanubsan/core/instdir/program/libicuuc.so.75: undefined reference to `__ubsan_vptr_type_cache'
> /usr/bin/ld: /home/sberg/lo-asanubsan/core/instdir/program/libicuuc.so.75: undefined reference to `__ubsan_handle_dynamic_type_cache_miss'
> clang: error: linker command failed with exit code 1 (use -v to see invocation)
> make[3]: *** [Makefile:540: rapper] Error 1
> make[3]: *** Waiting for unfinished jobs....
> libtool: link: /home/sberg/llvm/inst/bin/clang -fdiagnostics-color=always -fsanitize=address -fsanitize-address-globals-dead-stripping -fsanitize-address-use-after-return=always -fsanitize=undefined -fsanitize=float-divide-by-zero -fsanitize=local-bounds -fsanitize=nullability -fno-sanitize=function -O0 -Wp,-U_FORTIFY_SOURCE -fstrict-aliasing -fstrict-overflow -ggdb2 -gsplit-dwarf -Xclang -debug-info-kind=constructor -ggnu-pubnames -Wl,-z -Wl,origin -Wl,-rpath -Wl,\$ORIGIN -Wl,-rpath-link -Wl,/home/sberg/lo-asanubsan/core/instdir/program -o .libs/rdfdiff rdfdiff.o ../src/.libs/libraptor2.so -Wl,-rpath -Wl,/usr/local/lib
> /usr/bin/ld: /home/sberg/lo-asanubsan/core/instdir/program/libicuuc.so.75: undefined reference to `__ubsan_vptr_type_cache'
> /usr/bin/ld: /home/sberg/lo-asanubsan/core/instdir/program/libicuuc.so.75: undefined reference to `__ubsan_handle_dynamic_type_cache_miss'
> clang: error: linker command failed with exit code 1 (use -v to see invocation)
It appears that different configurations cause different libraries to be created
in ExternalProject_raptor, so that's why I never ran into this before, but the
solution is the same as in b3300387f2 "Fix UBSan
build of ExternalProject_redland".
Change-Id: I8bf955632af8c6490d9bd66a1d7dcd19b623c305
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179898
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
...with two hacks, so that at least copying text from LO and pasting it back
into LO works (instead of the copying step either hitting the
> assert(pTrans);
in QtClipboard::getContents in --enable-assert-always-abort builds or doing
nothing in --disable-assert-always-abort builds)
Change-Id: I246986fa1beaf17a8390eccb404408605e121630
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179894
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
Tested-by: Jenkins
Fixes ofz#385256118 Timeout on ImpEditEngine::InitScriptTypes.
Previously, the script assignment algorithm could backtrack in certain
cases where a script run ends with weak characters that should be
included in the following run. Fuzz testing unearthed a case involving
right-to-left override and a CJK combining mark, which caused the
algorithm to make no progress and hang.
The algorithm now always makes progress on each iteration.
Change-Id: I4da138c51d391c152afcee2428c21dc762a2dafc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179888
Tested-by: Jenkins
Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
xmlsecurity/qa/xmlsec/xmlsec.cxx:102:(anonymous namespace)::testInsertPrivateKey::TestBody
equality assertion failed
- Expected: 1
- Actual : 0
Just copying the NSS setup code from the other tests lets the test pass.
Also sync all the copies of the setup code while at it.
Change-Id: Idcaebec4dff29f37e0ed0f05d6d7d62782947325
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179893
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* Update translations from branch 'master'
to c0a323a8e6bf862e47a6f93909ddef6aaaef35dc
- update translations for master
and force-fix errors using pocheck
Change-Id: I5f9bfb155d155c02685c11c39083e5d13d57c9f2
- inlined the controls for color/image with the labels. also inlined
the image stretched/tiled radio buttons.
- There were plans to change the default theme's name from
"Automatic" to "Default", but due to string freeze for 25-2,
moved that to a separate patch which won't be backported to 25-2.
Change-Id: I8470dbf1c42d1b402d17f0feeec12d190e879ca6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179405
Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>
Tested-by: Jenkins
On macOS, due to Retina window scaling, it is very common to
have Skia surfaces that are 2 times the size of their respective
output device sizes so upscaling is often the default state.
But when upscaling bitmaps on macOS with either Skia/Metal or
Skia/Raster, some distortion to color and/or alpha values is
introduced and only BmpScaleFlag::NearestNeighbor will upscale
the bitmap correctly.
Change-Id: I9cf02d3acace82751fa6e114aaecf23cbbb85c65
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179848
Tested-by: Jenkins
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
The problem was the inconsistency between ODF versions for the forms
in the package and the form's content.xml. The check
for consistency was introduced in version 5.4 in commit
0a0f205775 (tdf#105686 - fixed wrongly
imported named expressions:, 2017-03-21). In version 7.0, commit
9fdf8c0a5c (Also consider saved
exceptions when terminating parse, 2019-11-16) made the exception
from that check fatal.
Commit 519d96fd8b (tdf#134582 sfx2:
when storing, set Version on embedded object storage, 2020-07-10)
started to write the embedded object versions to package manifest,
and commit 16de54a5c4 (tdf#138209 ODF
export: work around forms problem in LO < 7.0, 2021-05-10) created
an exception for forms, to workaround the problem in older versions.
But the latter commit created the reverse inconsistency, where the
newer versions started to write older ODF version in manifest.xml,
but newer ODF version in content.xml.
This change restores the correct version written to the manifest.
It is already messy in the already-released versions; it doesn't
look possible to restore sanity retroactively, so just make it
correct from now on, and accept the problem in older versions.
Change-Id: If5d07b6000b9f08b33844db48b815881bed2915b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179867
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
- add functions like IsThemeEnabled(), IsThemeDisabled(), GetThemeState(),
SetThemeState() to check/change registry (theme state) values so that
code outside ThemeColors class remains unaffected from any API changes,
and use enums like ENABLED and DISABLED to represent int values from
registry.
Change-Id: I6067cb5b0fa40d6c038e398229ef8ba93d26ca92
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179404
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
- rename IsThemeLoaded() to IsThemeCached() (similar for setter) because
it's not loading but caching colors in ThemeColors::m_aThemeColors.
ColorConfig_Impl::Load() loads themes.
Change-Id: If65302bc77d50f637176beaac47b43dff949368b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179854
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
At least for a Linux build of mine, `make CppunitTest_vcl_gtk3_a11y` would fail
with something like
> workdir/LinkTarget/Executable/cppunittester X11 error: Can't open display:
> Set DISPLAY environment variable, use -display option
> or check permissions of your X-Server
> (See "man X" resp. "man xhost" for details)
apparently because that test adds an invocation of xvfb-run to ICECREAM_RUN,
which appeared on the command line after gb_CppunitTest_CPPTESTPRECOMMAND
(which, on Linux, sets up LD_LIBRARY_PATH to include instdir/program), so that
the execution of xvfb-run picked up libraries from instdir/program instead of
from the system (at least libpixman-1.so.0, it appears), which then apparently
caused things to not work well.
So move the contents of gb_CppunitTest_CPPTESTPRECOMMAND further down on the
command line (which then requires an invocation of `env`). (This still leaves
me with a `make CppunitTest_vcl_gtk3_a11y` that fails in a different way now,
but that's something for another day...)
Change-Id: Ic53dd8f87e3fa548a998363f5489819a02b2bf8b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179862
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
Tested-by: Jenkins
Open a PDF for signing on the desktop, insert a signature line, click
the "finish signing" button on the infobar, Draw first asks if you want
to save your modified document as ODG, then crashes.
The first problem is that opening a PDF for signing and adding a
signature line / visual signature didn't result in a modified doc model,
but that now happens since commit
aca32a5545 (tdf#146547 sfx2: allow
read-only documents to be modified, 2023-06-16). Probably we want to
keep this feaature that read-only documents can be modified in some
cases, so explicitly mark the PDF document as not-modified before
signing in SfxObjectShell::SignDocumentContentUsingCertificate().
The other problem is that visual signing tried to reload the document:
this is handy, as it shows if our PDF export worked correctly, but
reloading is problematic since the signing code moved to async and it
assumes that the underlying object shell is never deleted, so callbacks
can have a pointer to it without worrying about the lifecycle. Fix this
problem by not reloading, but clearing the marker on the signature shape
and invalidating the signature status, instead of reloading, in
SfxObjectShell::ExecFile_Impl().
With this, visual signing of an existing PDF file works again in desktop
Draw.
Change-Id: I743983947d4607aa06674a1329bc8efb5af8a6d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179856
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
seen on reimport of xlsx export of forum-mso-en4-136321.xlsx as:
XmlFilterBase::importFragment - XML parser failed in fragment 'xl/externalLinks/externalLink1.xml'
com.sun.star.xml.sax.SAXParseException message: "[xl/externalLinks/externalLink1.xml line 2]: xmlParseEntityRef: no name
Change-Id: I71f2d5b01905349bedff7c66fc4b087358569bd0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179845
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
- Use a single `ThemeColors::VclPluginCanUseThemeColors()` check instead of
`ThemeColors::IsThemeLoaded()` and then checking if the current scheme
is Automatic or not
Change-Id: I96294c3b4b75b5f2cee02c72a8b0dd1a85bedec4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179853
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Laurent Balland