Implement new paragraph justification option "Minimum letter spacing"
allowing to shrink text lines more, choosing better paragraph layout
instead of hyphenation or rivers of space.
* Implement visual layout of minimum letter spacing.
* Enable Minimum letter spacing spin box on Alignment pane of the
paragraph formatting dialog window
* Remove also desired letter spacing spin box from the alignment pane.
It will be better to visualize CharKerning with percentage value
instead of adding a new user interface to the same setting.
* Set minimum and maximum spin box ranges to [-100, 0] and [0, 500],
and remove unnecessary handlers.
* offapi: extend API description with ranges of letter spacing
[-100, 500] and word spacing ([0, 1000]).
* Add ODF unit test.
Note: hyphenated lines, lines with multiple portions haven't
been using custom letter spacing, yet.
Note: resolution of the custom letter spacing is only 1/20 point
(1 twip) yet.
Note: adjust testTdf163149 failing on a test machine, maybe
because the DOCX test document contains the not supported Arial
font, resulting small differences based on the font replacement.
Follow-up to commit f83a04c510
"tdf#167648 cui offapi xmloff sw: add DTP-feature maximum letter
spacing".
Change-Id: I0d686ccbdaa5324eaf6c4c7f6da0f37e76f60611
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190533
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
The problem is that the Table Split feature on a floating table results
in 2 tables inside 1 frame, which then cannot be exported to DOCX as a
floating table.
Split the fly frame in this case, and add an anchor node because every
floating table needs its own anchor node.
Change-Id: I7444a75a953fcea60ffc92c2fa7eaca1b044f54b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190009
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
(cherry picked from commit 6f55b9a74f8fdd8609e1aa72388a5f8b97dfcea0)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190075
Tested-by: Jenkins
We don't need the
Create(const SalGraphics& src, vcl::PixelFormat)
variant, because all of the call sites just want a copy
of src with the same format as src, and we already have
a Create() variant for that.
Change-Id: Idb452da2de6baf072be82274435cf765e38c518b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190541
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Open the bugdoc, it contains a format redline that changes the character
style from Strong to Quote and the font size from 24 to 36. Revert the
redline, the char style goes back to Strong, but the font size is 12,
not 24.
The problem is that only the char style was imported in
XMLRedlineImportHelper::InsertIntoDocument(), because direct formatting
is only handled when we have no char style.
Fix the problem by creating an empty item set earlier, similar to how
lcl_SetRedline() does it in the UI code, then both the char style and
direct format can go into that item set.
The format redline's ODT/DOCX filter is now in a reasonable shape with
this.
Change-Id: I28e2a43e218a319045649612e7492821e72649b5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190551
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
...<https://github.com/llvm/llvm-project/commit/88438ba1f37fa4e0c2db203cd5556e52c9c34c08>
"[clang] AST: fix getAs canonicalization of leaf types (#155028)", which started
to cause
> [CPT] compilerplugins/clang/test/redundantfcast.cxx
> error: 'expected-error' diagnostics expected but not seen:
> File compilerplugins/clang/test/redundantfcast.cxx Line 77 (directive at compilerplugins/clang/test/redundantfcast.cxx:78): redundant functional cast from 'const tools::Polygon' to 'tools::Polygon' in construct expression [loplugin:redundantfcast]
> error: 'expected-error' diagnostics seen but not expected:
> File compilerplugins/clang/test/redundantfcast.cxx Line 77: redundant functional cast from 'const tools::Polygon' to 'tools::Polygon' [loplugin:redundantfcast]
> File compilerplugins/clang/test/redundantfcast.cxx Line 221: redundant functional cast from 'const Primitive2DContainer' to 'Primitive2DContainer' [loplugin:redundantfcast]
> error: 'expected-note' diagnostics expected but not seen:
> File compilerplugins/clang/test/redundantfcast.cxx Line 20: in call to method here [loplugin:redundantfcast]
> File compilerplugins/clang/test/redundantfcast.cxx Line 27: in call to method here [loplugin:redundantfcast]
> File compilerplugins/clang/test/redundantfcast.cxx Line 38: in call to method here [loplugin:redundantfcast]
> 6 errors generated.
> make[1]: *** [solenv/gbuild/LinkTarget.mk:338: workdir/CxxObject/compilerplugins/clang/test/redundantfcast.o] Error 1
Change-Id: I2538d419b7921d5617b03de646c83973184ee1ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190527
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@collabora.com>
ODF has the attribute table:embedded-number-behavior to specify a
natural sort (19.628 part3 ODF 1.4). Its values are 'alpha-numeric',
'double' and 'integer'. LO has the attribute bool bNaturalSort in struct
ScSortParam. The ODF method 'integer' is not implemented in LO.
The patch maps the internal bNaturalSort=true attribute to ODF value
'double'. Until value 'integer' is implemented, it is mapped to value
bNaturalSort=true on import, as that makes at least a natural sort.
This is next step after commit 47eb7f4e4d
Change-Id: Ie8c66e6b2eb2bdf035f0b02ada6ef91b1d921fe7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190437
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
Tested-by: Jenkins
Export the bugdoc to markdown, the content of the table is lost.
Common mark has no table support, but there is a spec at
<https://github.github.com/gfm/#tables-extension->, which seems to be
what md4c imports, so export that.
To make sure we export the table content exactly once, don't touch
m_pCurrentPam in OutMarkdown_SwTableNode(), just record the info we need
about the table, then let the iteration loop in SwMDWriter::Out_SwDoc()
process the table content.
This is just minimal support to make sure the table content is in the
output, table alignment is not implemented yet.
Change-Id: I9902fafc1ab5b8b7bc2472b026ab6df490f6407f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190514
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
ODF (and its native applications) can properly handle redline data of
deleted comments. Other formats (or rather, respective applications
like MS Word) don't understand the "comment anchor deletion" markup,
and show the deleted comment as normal.
Commit 419b70b5d4 (tdf#105485 DOCX: import
deleted comments as deleted, 2019-08-26) had implemented correct round-
trip of the redline through DOCX. However, since Word doesn't support
that, it created a situation when users can't correctly collaborate on
documents.
This change introduces a special handling of all non-native file formats
in Writer, where deletion of a comment is handled just as in Word: it is
deleted immediately, instead of marking as deleted. This doesn't affect
deleting ranges of text, which contain comments: they are handled by
both Writer and Word correctly.
The solution works without any compatibility flags. This allows to have
consistent behavior (same types of files will work the same way on all
systems), zero configuration, and maximum functionality using native
formats, unaffected by any settings.
Change-Id: I2f8d3caaecd78af38e11a1ab6900d0afd73ed614
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190376
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Flattens function implementations by returning early when an argument
check fails rather than using if/else blocks.
Change-Id: I5adad466e41ac95ad5bde43d758babf5932ec304
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187606
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
* Update dictionaries from branch 'master'
to f092998f6ea6a39f6b785e96516e21e62b716a00
- tdf#164715 Thai Spell: Address key-based typos and Sara Am encoding
* th_TH/th_TH.aff:
- Add MAP entries to address non-standard Sara Am encoding.
- Add KEY entry to guide suggestions based on keyboard layout.
* th_TH/typos-sara-am.txt, th_TH/typos-key.txt:
- Add test cases for Sara Am and key-based typos.
Miscellaneous improvements:
* th_TH/th_TH.dic:
- Remove "จุงเบย", a slang based on keyboard typo.
- Add words: ขะแมร์, ขะแมร์กอฮอม, โพ้ง.
- Add ph: field to "จริง".
* th_TH/typos-common.txt:
- Updated to cover the changes.
Change-Id: I71a5f40313a706c83d48f2457a5f6e14f9db28f4
Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/187095
Tested-by: Hossein <hossein@libreoffice.org>
Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
they either return true, or they fail in ways that cannot usefully be recovered from.
So just remove the bool return value, and drop the fallback code.
Change-Id: I8a6ac9925defd0a304281f223f11393106b63e28
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190497
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This means that native Qt widgets are used for that dialog
now when using the qt5 or qt6 VCL plugin and starting LO with
environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
The dialog can be triggered via "Sheet" -> "Clear Cells"
in Calc.
Change-Id: Icd529721e15c0690b53d9eee7d680ab257ca8e12
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190493
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
This means that native Qt widgets are used for that dialog
now when using the qt5 or qt6 VCL plugin and starting LO with
environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
The dialog can be triggered via "Sheet" -> "Delete Cells"
in Calc.
Change-Id: Iabb35d9e9b53a0c5a79080e30b66b57e4740641f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190491
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
This reverts 25.2 commit 0c6599ca14,
and commit bcf4b99874.
because rSh.SetCursorInHdFt can move to a different page/footer
and thus rSh.GetVirtPageNum() will change value
on even and odd footers.
Change-Id: I2d29e5c9f7538c47c6e11c8e7432f5f8d880bf72
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190507
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
This partially reverts commit fa3dd1c3a1.
Apparently, the special handling of alpha bitmaps when printing on macOS
is no longer needed and the alpha blending code used on other platforms
now works as expected on macOS.
Change-Id: Ib72e57ec679971c8db06160ae0354c8ba45be91e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190496
Tested-by: Jenkins
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
László Németh