CTFontCopyTable() returns NULL if the table is not in the font, which
is the case we are checking for here, and CFRelease() is documented to
crash on NULL. Similarly CTFontDescriptorCopyAttribute() can return
NULL, in which case the font format was left uninitialized as well.
Change-Id: Idfa570d704244cbe505104934bfca456b2b54451
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208633
Reviewed-by: Khaled Hosny <khaled@libreoffice.org>
Tested-by: Jenkins
SvStream leaves the destination untouched when a read fails, so a font
with no OS/2 table (or a truncated one) filled the coverage bitsets
from an uninitialized variable, and reported them as valid.
Set the bitsets only if the reads succeeded.
Change-Id: I1eb39adc578ef991c29b57ed5d5683fd673e63e4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208631
Reviewed-by: Khaled Hosny <khaled@libreoffice.org>
Tested-by: Jenkins
This means that native Qt widgets are used for this dialog
now when using the qt5 or qt6 VCL plugin and starting LO with
environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
The dialog can be triggered like this:
* start Calc
* "Sheet" -> "Named Ranges and Expressions" -> "Labels..."
Change-Id: I87f009618d8c3514eff6b64d7c67fbc0b9a033d7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208559
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
The dialog can be triggered like this:
* start Calc
* "Sheet" -> "Named Ranges and Expressions" -> "Labels..."
Change-Id: Ifdfdb9843c018433c0daba0312aeaf6c02497d83
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208558
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
This means that native Qt widgets are used for this dialog
now when using the qt5 or qt6 VCL plugin and starting LO with
environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
The dialog can be triggered like this:
* start Calc
* "Sheet" -> "Named Ranges and Expressions" -> "Create..."
Change-Id: I568e4d27cbd1363d43e842b350880096d1ff4417
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208557
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
The dialog can be triggered like this:
* start Calc
* "Sheet" -> "Named Ranges and Expressions" -> "Create..."
Change-Id: Ib8604aa14db7a5add775a2541897980b494e6e0c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208556
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
This means that native Qt widgets are used for this dialog
now when using the qt5 or qt6 VCL plugin and starting LO with
environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
The dialog can be triggered like this:
* start Calc
* select cells A1:A10
* "Sheet" -> "Fill Cells" -> "Fill Random Number..."
Change-Id: Ic56ae0ff509c364d454fae57c7cf83b02982d595
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208555
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
This means that native Qt widgets are used for this dialog
now when using the qt5 or qt6 VCL plugin and starting LO with
environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
The dialog can be triggered like this:
* start Calc
* select cells A1:A10
* "Sheet" -> "Fill Cells" -> "Fill Series..."
Change-Id: I81db46feff9c41d1e90dd817c33e7b3063ee9bcd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208553
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
This means that native Qt widgets are used for this dialog
now when using the qt5 or qt6 VCL plugin and starting LO with
environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
The dialog can be triggered like this:
* start Calc
* "Sheet" -> "External Links..."
Change-Id: I7c6058f2f00d98e88817c8a699566e7fc5e7ab6f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208551
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
The dialog can be triggered like this:
* start Calc
* "Sheet" -> "External Links..."
Change-Id: Id13d69ef241166a1b04b2b85b2eeb6c6abe3c865
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208550
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
This means that native Qt widgets are used for this dialog
now when using the qt5 or qt6 VCL plugin and starting LO with
environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
The dialog can be triggered like this:
* start Calc
* "Insert" -> "Chart..."
* for "Choose a Chart Type", choose "Line"
* for "Line type", select "Stepped"
* press the "Properties..." button
Change-Id: Ica91da7a7ad1f06d09b9f0b6a46d1047c5444429
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208549
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
This commit finalizes the CoordinateMapper refactor by resolving naming
collisions and establishing a strict semantic separation between
physical units and logical distances.
To avoid ambiguity with the word "Pixel" and to clearly distinguish
between pure mathematical scaling and coordinate space translations,
the API has been standardized:
1. Distance Scaling:
Renamed the pure multiplication methods from LogicToViewX/Y to
LogicToViewDistanceX/Y. This frees up the namespace and clarifies
that these methods handle scaling without applying mapping offsets.
2. Physical Pipeline Stages (*Units):
Implemented the definitive space-to-space transformation ladder using
the 'Units' suffix for physical stages and 'LogicUnits' for the
document stage:
- DeviceToWindowUnits / WindowToDeviceUnits
- WindowToViewUnits / ViewToWindowUnits
- ViewToLogicUnits / LogicUnitsToViewUnits
3. Legacy Cleanup:
Purged the orphaned LogicToViewPixelX/Y declarations and
implementations left over from earlier refactoring attempts. Updated
the legacy ImplCalcDevicePixelX/Y helpers to utilize the new
LogicUnitsToViewUnitsX/Y pipeline stage.
4. map.cxx Alignment:
Updated all OutputDevice translation sites in map.cxx that previously
relied on the overloaded LogicToViewX/Y to explicitly call the correct
LogicToViewDistanceX/Y variants, restoring a clean build.
Change-Id: I621ed8741055a29bf65963d75b763ca3e4a7bd0f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203658
Tested-by: Jenkins
Reviewed-by: Dan Williams <dcbw@libreoffice.org>
When detaching the main menu from NSApp via [NSApp setMainMenu:nil],
the NSMenu object can be deallocated immediately if it has no other
strong references, leading to a crash when the subsequent loop attempts
to iterate through its items.
This commit ensures the menu remains valid during the teardown process
by explicitly retaining the menu and scheduling an autorelease before
detaching it from the application.
Change-Id: I78420d42846f11732e23b0a4cf66b41bf6b73c98
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208053
Reviewed-by: Dan Williams <dcbw@libreoffice.org>
Tested-by: Jenkins
It's annoyingly difficult to remove the links from the broadcaster,
drop that approach and do it a more direct and less reentrant way.
Get ~SwFormat and SwContentNode::ImplDestroy to report the death to the
tracker instead.
A flag on SwDoc keeps the common no-links case in those destructors to a
single test.
During ~SwDoc the hosts stay silent: the links administration manager
can already be unreachable through the half-destroyed document, and
~FillBitmapLinkTracker releases whatever is left without touching the
dead hosts.
SwContentNode::ImplDestroy skips disconnected nodes, the stack-built
working copies like SwTextNode::Update's SwContentNodeTmp that have no
nodes-array and no SwDoc. A node deleted for real still reaches its
SwDoc, since SwNodes::RemoveNode deletes nodes while they are still in
the array.
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ibbf15e4e17a7a08aa029c9d5df8f40b7a4a13e04
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/4282
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit 38ac5c0e6c7baf4de27498e5428d6279c753c97e)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208603
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
The write-back of the fetched graphic re-entered onFillBitmapURLChanged
with a now-resolved item and erased the link's LinkManager entry in the
middle of SvBaseLink::Update.
Ignore the write-back with an updating-host guard so resolved links stay
registered and Edit > Links keeps offering them, covered by the new
testBackgroundImageLinkSurvivesUpdate in CppunitTest_sw_tiledrendering2.
This aligns what writer does with what the svx tracker for the calc,
impress and writer draw-layer does since:
commit b08bffeeeba27e0e10664e5f4cbd9c16ca567ae3
Date: Fri May 29 09:03:26 2026 +0100
register calc XATTR_FILLBITMAP URLs as SvBaseLinks via SdrObject ItemChange
Change-Id: I08c7beae66e884d6bbf5c65345526761fcaade96
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/4281
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit aa1cc82b862556fa32cd0edc7f767374d2c90863)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208602
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
The dialog can be triggered like this:
* start Calc
* "Insert" -> "Chart..."
* for "Choose a Chart Type", choose "Line"
* for "Line type", select "Stepped"
* press the "Properties..." button
Change-Id: I0bbef11445f7cf184e46b955dd32fcd8fbb474f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208548
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
This comment just repeats the mapping that the code
underneath it implements.
Drop it, to deduplicate this.
Change-Id: I60497fbd52b057986f76b88cef82d4a991927c7b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208600
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
This vector can be passed by const reference. Also use
an "r" prefix; this is not a pointer.
Change-Id: I5c96a3701a24096a045c58a99d81ad6b49145c4e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208599
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Set the mnemonic widget, which e.g. makes the Orca screen
reader announce what the combo box is about ("Line Type")
when it receives focus with the gtk3 or qt6 vcl plugins on Linux.
For qt6 and the use of native Qt widgets
(SAL_VCL_QT_USE_WELDED_WIDGETS=1) this also fixes
that the labels text was previously shown as a literal
"Line &Type".
Change-Id: I2e699a10bdec27663b38a92d4091e647a6b7c49e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208497
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
This means that native Qt widgets are used for this dialog
now when using the qt5 or qt6 VCL plugin and starting LO with
environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
The dialog can be triggered like this:
* start Calc
* "Insert" -> "Chart..."
* for "Choose a Chart Type", choose "Line"
* for "Line type", select "Smooth"
* press the "Properties..." button
Change-Id: I15685601f9cab81bd15e591b9c7864adae65864d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208496
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
The dialog can be triggered like this:
* start Calc
* "Insert" -> "Chart..."
* for "Choose a Chart Type", choose "Line"
* for "Line type", select "Smooth"
* press the "Properties..." button
Change-Id: I4bad77d57fb6f33dea653ad48f6dd0e32a8085c8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208495
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
This means that native Qt widgets are used for this dialog
now when using the qt5 or qt6 VCL plugin and starting LO with
environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
The dialog can be triggered like this:
* start Calc
* "Insert" -> "Chart"
* confirm with "Finish"
* with chart still selected, press the context menu key
(or click with right mouse button) to open the context menu
* select the "Data Ranges..." context menu entry
This depends on previous commit
Change-Id: Ia368a919c497d51c4560536995e90f60e3b85768
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Wed Jul 22 17:20:59 2026 +0200
tdf#130857 chart2: Don't modify dialog modality while it's shown
for the dialog modality/main window sensitivity to work
as expected. (See the commit message of that commit
for more details.)
Change-Id: I53cbd9061ef473deba2124f17976f24b11c1712a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208494
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
RangeSelectionListenerParent::enableRangeChoosing both sets the
dialog's visibility and modality. So far, it was first setting
the modality and then the visibility.
However, changing the modality while the dialog is shown
doesn't work as expected when using the qt6 vcl plugin
with native Qt widgets with upcoming commit
Change-Id: I53cbd9061ef473deba2124f17976f24b11c1712a
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Wed Jul 22 17:27:01 2026 +0200
tdf#130857 qt weld: Support chart "Data Ranges" dialog
in place and would result in an inability to select the
data area as the main window would remain insensitive/disabled
for the following case:
* start Calc
* "Insert" -> "Chart"
* confirm with "Finish"
* with chart still selected, press the context menu key
(or click with right mouse button) to open the context menu
* select the "Data Ranges..." context menu entry
* in the "Data Range" tab, press the "Select data range" button
* try to click into the document and drag to make a selection
The native Qt implementation wouldn't require changing
modality back and forth, but gtk3 and the gen vcl plugin
would show the same problem as described above when not
setting the dialog to non-modal in the case it gets hidden.
Make all of them work by setting the modality, but always
doing that while the dialog is hidden (not shown), i.e.
either before showing it or after hiding it.
Change-Id: Ia368a919c497d51c4560536995e90f60e3b85768
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208493
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
It's not 100% clear what the
// in order to keep the Strings with the FixedTexts in the resource:
comment was referring to, but it's most likely obsolete,
as nothing here is related to string resources.
(The wording of "FixedTexts" and "resource" also
sounds like terminology specific to the pre-weld era.)
Change-Id: I2e0ae770fdfc039a75ef01b633b7d0506ec9a929
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208491
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
This means that native Qt widgets are used for this dialog
now when using the qt5 or qt6 VCL plugin and starting LO with
environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
The dialog can be triggered like this:
* start Calc
* "Insert" -> "Chart"
* confirm with "Finish"
* with chart still selected, press the context menu key
(or click with right mouse button) to open the context menu
* select the "Data Ranges..." context menu entry
* in the "Data Range" tab, press the "Select data range" button
Change-Id: If6373fb69ae7cb4315c0c4e267dcc7912d5015fe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208489
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
The dialog can be triggered like this:
* start Calc
* "Insert" -> "Chart"
* confirm with "Finish"
* with chart still selected, press the context menu key
(or click with right mouse button) to open the context menu
* select the "Data Ranges..." context menu entry
* in the "Data Range" tab, press the "Select data range" button
Change-Id: I44b0dfd7a4ec9500affbf8fbad9b126dc3fc5c06
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208488
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
This is used for the "Data Series" tab page of the
the dialog that can be triggered like this:
* start Calc
* "Insert" -> "Chart"
* confirm with "Finish"
* with chart still selected, press the context menu key
(or click with right mouse button) to open the context menu
* select the "Data Ranges..." context menu entry
Change-Id: I15ebfe1eac3a83f5e0a2ee03d0548c8bc0e499f0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208487
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
This is used for the "Data Range" tab page of the
the dialog that can be triggered like this:
* start Calc
* "Insert" -> "Chart"
* confirm with "Finish"
* with chart still selected, press the context menu key
(or click with right mouse button) to open the context menu
* select the "Data Ranges..." context menu entry
Change-Id: Ia5f78fdf141eeb0e35cfe5dab990d73e991fe885
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208486
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
The dialog can be triggered like this:
* start Calc
* "Insert" -> "Chart"
* confirm with "Finish"
* with chart still selected, press the context menu key
(or click with right mouse button) to open the context menu
* select the "Data Ranges..." context menu entry
Change-Id: I339bbd6d64344eeb33449fc829f06fe9041e0282
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208485
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
This means that native Qt widgets are used for this dialog
now when using the qt5 or qt6 VCL plugin and starting LO with
environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
The dialog can be triggered like this:
* start Calc
* "Format" -> "Conditional" -> "Condition" -< "Greater than..."
Change-Id: I75435cdd86796b0dc8abaf7510004a2afea0de75
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208478
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Use weld::Frame::set_label directly to set the new text
label for the frame in the Calc "Highlight cells..." dialog
instead of relying on the internal label child.
For the Qt implementation in QtInstanceFrame, there is
no separate label child, but its QGroupBox handles the
title directly.
The dialog can be triggered like this:
* start Calc
* "Format" -> "Conditional" -> "Condition" -< "Greater than..."
Change-Id: I1698902ff88976bd12a4fa9e6116724f36f0dd98
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208477
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Switch the order in which the widgets in the .ui file
are defined so that the order better matches the visual appearance
and logical order, which makes sure that tab focus order with the
Qt-based VCL plugins is correct as well when using native Qt
widgets (SAL_VCL_QT_USE_WELDED_WIDGETS=1), where
focus order is (by default) based on widget creation order.
See
commit 02692566ad
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Thu Oct 24 17:43:35 2024 +0200
tdf#130857 optnewdictionarydialog.ui: Define focusable widgets in order
for more background.
The dialog can be triggered like this:
* start Calc
* "Format" -> "Print Ranges" -> "Edit..."
The Python script mentioned in the commit message of
commit 327679b2fb
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Wed Jul 8 15:50:59 2026 +0200
tdf#130857 Define widgets in Calc "General" options page in order
was used to reorder the GtkGrid children automatically.
Change-Id: I1e0e2d396bec89d93d109f239f76aaceca5c33da
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208476
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
This means that native Qt widgets are used for this dialog
now when using the qt5 or qt6 VCL plugin and starting LO with
environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
The dialog can be triggered like this:
* start Calc
* "Format" -> "Print Ranges" -> "Edit..."
Change-Id: I10fcd9c326a047cf4abd34369f02be1847d77ae1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208475
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
The bool return value of weld::TextWidget::get_selection_bounds
indicates whether a text selection actually exists.
Only use the start and end indices from the out params
if that is the case and otherwise return a default-constructed
Selection object (i.e. one using start and end indices of 0).
Otherwise, this would result in an assertion due to the use of
invalid string indices as seen with the qt6 vcl plugin and native
widgets enabled (SAL_VCL_QT_USE_WELDED_WIDGETS=1) for the following
scenario with upcoming commit
Change-Id: I10fcd9c326a047cf4abd34369f02be1847d77ae1
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Wed Jul 22 14:20:53 2026 +0200
tdf#130857 qt weld: Support Calc "Edit Print Ranges" dialog
in place:
* start Calc
* "Format" -> "Print Ranges" -> "Edit..."
* click on the "Shrink" button in the "Print Range" section
* click anywhere in the sheet
Assertion:
soffice.bin: /home/michi/development/git/libreoffice/sal/rtl/strtmpl.hxx:1059: void rtl::str::newReplaceStrAt(rtl_tString **, rtl_tString *, sal_Int32, sal_Int32, rtl_tString *) [rtl_tString = _rtl_uString]: Assertion `nIndex >= 0 && nIndex <= pStr->length' failed.
This is because QtInstanceEntry::get_selection_bounds
sets the indices to -1 if no selection exists.
Change-Id: Ifc8fd6f6a6d676fe26364da9077cb10acb439a5a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208474
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
This means that native Qt widgets are used for this dialog
now when using the qt5 or qt6 VCL plugin and starting LO with
environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
The dialog can be triggered like this:
* start Calc
* "Insert" -> "Named Range or Expression..."
In order for entries to be listed there, they can
first be added via "Sheet" -> "Named Ranges and Expressions"
-> "Define...".
Change-Id: Ib7fe33450a215256b0752ea9279157b76fb36b8a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208472
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
This means that native Qt widgets are used for this dialog
now when using the qt5 or qt6 VCL plugin and starting LO with
environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
The dialog can be triggered like this:
* start Writer
* open the "Styles" sidebar deck
* press the "Frame Styles" button at the top of the sidebar deck
* right-click on an existing style (e.g. "Frame") to open the context menu
* select "Edit Style..." context menu entry
Change-Id: If148077155edd6f2bc80c81b2cf292f8ed037107
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208464
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Switch the order in which the widgets in the .ui file
are defined so that the order better matches the visual appearance
and logical order, which makes sure that tab focus order with the
Qt-based VCL plugins is correct as well when using native Qt
widgets (SAL_VCL_QT_USE_WELDED_WIDGETS=1), where
focus order is (by default) based on widget creation order.
See
commit 02692566ad
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Thu Oct 24 17:43:35 2024 +0200
tdf#130857 optnewdictionarydialog.ui: Define focusable widgets in order
for more background.
The page can be triggered like this:
* start Writer
* open the "Styles" sidebar deck
* press the "List Styles" button at the top of the sidebar deck
* right-click on an existing bullet style to open the context menu
* select "Edit Style..." context menu entry
* switch to the "Customize" tab
The Python script mentioned in the commit message of
commit 327679b2fb
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Wed Jul 8 15:50:59 2026 +0200
tdf#130857 Define widgets in Calc "General" options page in order
was used to reorder the GtkGrid children automatically.
Change-Id: I0010eb3af1272342f2f40e8f3b0952b676a22618
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208462
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
The dialog can be triggered like this:
* start Calc
* "Insert" -> "Named Range or Expression..."
Change-Id: I8218b642ffa310d038bf0a40bbc49c9c70832bd4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208471
Tested-by: Jenkins
Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
Khaled Hosny