similar to
commit f47fc9a67f16a3da1e5cbcc8b821682298ec90b3
reduce ScRefListToken virtual calls
Push the GetIndex() method down to the only subclasses
that actually use it.
And take the chance to rename them to something more meaningful.
Introduce an inbetween ScExternalToken class to represent
tokens that have an external file id.
Change-Id: If45e87a5bb66aeb1c65d82121b430b886b53f20b
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/955
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Noel Grandin <noel.grandin@collabora.com>
(cherry picked from commit 7705899fa7bca501f331070f7969374fcf5f52e9)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205576
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
similar to
commit f47fc9a67f16a3da1e5cbcc8b821682298ec90b3
reduce ScRefListToken virtual calls
Push the GetString() methods down to the only subclasses
that actually use it.
We change the inheritance hierarchy a little here
-class FORMULA_DLLPUBLIC FormulaStringOpToken final : public FormulaByteToken
+class FORMULA_DLLPUBLIC FormulaStringOpToken final : public FormulaStringToken
because FormulaStringOpToken and FormulaStringToken share
a type svString which makes it hard to decide which subclass we
are handling.
So now we can check for GetType() == svString and then
cast to FormulaStringToken safely.
Change-Id: I3f087d65a2297b2d8fb5213e81987e0001bc1c62
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/1152
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Noel Grandin <noel.grandin@collabora.com>
(cherry picked from commit 8710f98c1565b1d8ecbbbec743b29bcbb38c5ce2)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205569
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Export histogram charts as chart:bar with coext:class="histogram"
and write histogram properties.
Import the histogram class and configuration again recreate the
HistogramChartType, and trigger the histogram template once chart
import is complete so calculated bins, categories, and frequencies
are rebuilt from the preserved raw values-y data.
Change-Id: I202d5666315d4f26da2bf4b3650b4388a9e4fb50
(cherry picked from commit 5fb2f5f2c2676743b823640dbaa02762308d6a54)
Signed-off-by: Devansh Varshney <varshney.devansh614@gmail.com>
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/1880
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.com>
(cherry picked from commit a54fc185d3d73f765bd37cc98df92cac81e01572)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203814
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
This commit introduces the mathematical backend and data interpreter for
the Histogram chart, replacing the temporary raw value rendering.
- Adds HistogramCalculator, utilizing Scott's Rule to calculate optimal
bin widths and frequencies from raw data.
- Introduces HistogramDataSequence that listens to spreadsheet data
changes and automatically regenerates bin categories and frequencies
- Implements HistogramDataInterpreter to intercept raw values-y input,
and output the results into the calculated-y data sequence.
Change-Id: Iaf29ddd0b0824bd3f0808ffc91321cad9d5b877e
(cherry picked from commit 1ef619a998aba626d0ea7a9541109a7c9e145518)
Signed-off-by: Devansh Varshney <varshney.devansh614@gmail.com>
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/1879
Reviewed-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit df68284255ccac4bd86583555986d9f7cbdddf9a)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203747
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
This commit introduces the structural foundation and user interface for
the new Histogram chart type. The rendering engine gracefully falls
back to plotting the raw values-y input data directly. As a result, the
chart currently renders identically to a standard bar/column chart.
- Adds UI entries in the Chart Type dialog.
- Adds HistogramChart to the view layer, inheriting from BarChart and
forcing a 0-gap width.
Change-Id: Ica5b15e9b7428d6c908e1b978259367fe8ff7aab
(cherry picked from commit 14a4a09b62fc283f9b629a2a317156efa6509054)
Signed-off-by: Devansh Varshney <varshney.devansh614@gmail.com>
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/1878
Reviewed-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit 508c3456e85a88771ac5e264cee9460274685a22)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203741
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
After undo or redo, we restore the default view table to a previous (or
future) state, which means we need to synchronize that change to the
sheet views. For that, calling the functionality of SyncSheetViews
should be enough to get them synchronized again. Sync is performed
in EndUndo and EndRedo.
Extracted the sheet view synchronization logic from Operation into
ScDocument::SyncSheetViews method. This allows the same sync logic
to be called from both Operations and undo/redo (ScSimpleUndo).
Change-Id: I67a2580631e547ece67e945883f038b1f9968689
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/201454
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202092
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit f6c8731a6ef27989ce5fc643d3def7f2947c510c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205528
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Move the class out of weld.hxx into its own header, in
order to make it easier to keep an overview and to avoid
having to recompile ~all UI code when the class is
modified.
Change-Id: I0cc1e0f3aa60d3457af0f0f30ec8fe74cb5ce6a9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205489
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Move the class out of weld.hxx into its own header, in
order to make it easier to keep an overview and to avoid
having to recompile ~all UI code when the class is
modified.
Change-Id: Ia7bc570fcd463d9adcbcdad070250cec5bc3b949
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205488
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Move the class out of weld.hxx into its own header, in
order to make it easier to keep an overview and to avoid
having to recompile ~all UI code when the class is
modified.
Change-Id: Ibe76e4c871f364904a2ad65921d37ec0380094ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205487
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Move the class out of weld.hxx into its own header, in
order to make it easier to keep an overview and to avoid
having to recompile ~all UI code when the class is
modified.
Change-Id: I2e42a2992c08311922451bb01062683bd81954fa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205486
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Move the class out of weld.hxx into its own header, in
order to make it easier to keep an overview and to avoid
having to recompile ~all UI code when the class is
modified.
Change-Id: I6d9323c56bca95734a1b60daa60085547f212a66
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205485
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Move the class out of weld.hxx into its own header, in
order to make it easier to keep an overview and to avoid
having to recompile ~all UI code when the class is
modified.
Change-Id: I98a090f31fc8b4111b7e13dfcdf843af8c3113c8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205474
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Move the class out of weld.hxx into its own header, in
order to make it easier to keep an overview and to avoid
having to recompile ~all UI code when the class is
modified.
Change-Id: I8861b5494c22b666ed80ead82ec3a8293dbeee81
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205473
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Move the class out of weld.hxx into its own header, in
order to make it easier to keep an overview and to avoid
having to recompile ~all UI code when the class is
modified.
Change-Id: I2eb564b2483b052f01d4af55fd4feb00b5ed6031
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205472
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Move these to those files actually needing them instead
of relying on transitive includes after multiple weld::Widget
subclasses were moved to their own headers.
Change-Id: If431078dffb85a2788170d4a753978d1983decb6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205471
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Move the class out of weld.hxx into its own header, in
order to make it easier to keep an overview and to avoid
having to recompile ~all UI code when the class is
modified.
Change-Id: Ie5bd9f20c6802301614a9ccbe327797a59e3932b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205465
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Move the class out of weld.hxx into its own header, in
order to make it easier to keep an overview and to avoid
having to recompile ~all UI code when the class is
modified.
Change-Id: Ic0ca052460c3c84ca00bc392c81c1c9fa7bde6b8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205464
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Move the class out of weld.hxx into its own header, in
order to make it easier to keep an overview and to avoid
having to recompile ~all UI code when the class is
modified.
Change-Id: Ib944fa421b9d3bcd82ac6c7ab3faf5f0b8b30b6d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205463
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
similar to
commit f47fc9a67f16a3da1e5cbcc8b821682298ec90b3
reduce ScRefListToken virtual calls
Push the GetDoubleRef() methods down to the only subclasses
that actually use it.
Which means we can return a ref instead of a pointer,
since we now never return nullptr.
Change-Id: I4dfce551e985fe20db00d3a0694ed99f20f87731
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/1050
Reviewed-by: Noel Grandin <noel.grandin@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit 9aab43b4e3a68cd833eddfdd11086f03e55f2c1a)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205508
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
ChgAutoCorrWord checked for any redline crossing the word boundary,
which silently skipped the replacement whenever just-typed text (a
tracked insertion under change tracking) extended past the word
being autocorrected. Narrow the check to tracked deletions, matching
what ReplaceRange already does for the single-character path. The
tdf#130546 guard this is derived from was specifically about text inside
a deletion.
Signed-off-by: Jaume Pujantell <jaume.pujantell@collabora.com>
Change-Id: I7ad7f0319ea74bccf2d7e5acc5d7a991029f632e
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/3039
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit 729809a69558a567afb3333db458220cf5d44814)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205515
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
This is a regression from 0d29394598
(https://gerrit.libreoffice.org/c/core/+/129627).
Word text-boxes are imported as dual-frame (SwFlyFrame inside a
SdrObject), for inline text-boxes the text (SwFlyFrame) is positioned
incorrectly.
While addressing a different problem the commit
0d29394598 changed how inline text-boxes
are positioned. Because of this there is a mismatch b/w the position of
shape (SdrObject) and text (SwFlyFrame) inside the shape.
SwFlyFrame should be positioned based on the SdrObject's position in
the document.
Change-Id: Ia902468f2a17a32aba928af022a1199345f21bcb
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/2494
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
(cherry picked from commit 3d53aa0e171e72274831278234648f11641b55fe)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205510
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
since b8e6595d47 the UCRTSDKDIR was
converted to the native (windows-style) path in the test block already
while previously it was converted as part of the post-AC_CONFIG_FILES
script that mass-converts paths when creating config_host.mk
With the conversion to unix path in wsl < 2.4.5 dropping the trailing
slash from the path, configure then fails with "Could not figure out
what C++ library this is" since it just appends the include path
assuming the trailing slash to be present, resulting in
-IC:/PROGRA~2/WI3CF2~1/10Include/10.0.26100.0/ucrt
^ missing path delimiter here
ultimately failing to include necessary headers and thus failing the
check.
So explicitly check whether the unix-path (that preserves the slash) has
a trailing slash and if so make sure it is also added to the native path
if necessary.
Change-Id: I0ff4e2007af48fc09db4b8a80413dc87f849537a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205440
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
/home/tdf/jenkins/workspace/lo_gerrit/tb/src_wasm/sw/source/uibase/shells/textsh1.cxx:2301:95: error: cannot initialize a parameter of type 'weld::Widget *' with an rvalue of type 'weld::Window *'
2301 | VclPtr<AbstractDropDownFormFieldDialog> pDlg(pFact->CreateDropDownFormFieldDialog(rWrtSh.GetView().GetFrameWeld(), pFieldBM));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/tdf/jenkins/workspace/lo_gerrit/tb/src_wasm/include/sfx2/objsh.hxx:154:24: note: 'weld::Window' is not defined, but forward declared here; conversion would be valid if it was derived from 'weld::Widget'
154 | namespace weld { class Window; }
| ^
/home/tdf/jenkins/workspace/lo_gerrit/tb/src_wasm/sw/inc/swabstdlg.hxx:512:97: note: passing argument to parameter 'pParent' here
512 | virtual VclPtr<AbstractDropDownFormFieldDialog> CreateDropDownFormFieldDialog(weld::Widget* pParent, sw::mark::Fieldmark* pDropDownField) = 0;
| ^
/home/tdf/jenkins/workspace/lo_gerrit/tb/src_wasm/sw/source/uibase/shells/textsh1.cxx:2324:87: error: cannot initialize a parameter of type 'weld::Widget *' with an rvalue of type 'weld::Window *'
2324 | VclPtr<AbstractDateFormFieldDialog> pDlg(pFact->CreateDateFormFieldDialog(rWrtSh.GetView().GetFrameWeld(), pDateField, *GetView().GetDocShell()->GetDoc()));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/tdf/jenkins/workspace/lo_gerrit/tb/src_wasm/include/sfx2/objsh.hxx:154:24: note: 'weld::Window' is not defined, but forward declared here; conversion would be valid if it was derived from 'weld::Widget'
154 | namespace weld { class Window; }
| ^
/home/tdf/jenkins/workspace/lo_gerrit/tb/src_wasm/sw/inc/swabstdlg.hxx:514:89: note: passing argument to parameter 'pParent' here
514 | virtual VclPtr<AbstractDateFormFieldDialog> CreateDateFormFieldDialog(weld::Widget* pParent, sw::mark::DateFieldmark* pDateField, SwDoc& rDoc) = 0;
| ^
2 errors generated.
Change-Id: I602138a9435498393b079072269eeca177e8a557
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205527
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Noel Grandin