Define statements in ChartResourceGroups.hxx have
been replaced with an enum class. Two wrapper functions
were created to simplify code. The .cxx file has been
updated to use this enum. Other formatting changes
made to satisfy clang.
Change-Id: Ib7d095ce4fb3fbf433dcb9693f23958601dc89e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190604
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
before
commit f355ddcbf2
Author: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
Date: Sun Apr 13 11:36:05 2025 +0900
chart2: fold isSupported* functions into ChartType
ChartTypeHelper::isSupportingAxisPositioning,
ChartTypeHelper::isSupportingBaseValue and
ChartTypeHelper::isSupportingBaseValue
checked if xChartType was not nullptr inside them
TODO: add UItest for it.
Change-Id: I908d41ccc88208ab57576bd6369590556aafcce5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189171
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
and
cid#1660225 Variable copied when it could be moved
cid#1660211 Variable copied when it could be moved
cid#1660185 Variable copied when it could be moved
cid#1660173 Variable copied when it could be moved
cid#1660168 Variable copied when it could be moved
cid#1660166 Variable copied when it could be moved
cid#1660165 Variable copied when it could be moved
cid#1660163 Variable copied when it could be moved
cid#1660152 Variable copied when it could be moved
cid#1660149 Variable copied when it could be moved
cid#1660147 Variable copied when it could be moved
cid#1660145 Variable copied when it could be moved
cid#1660142 Variable copied when it could be moved
cid#1660140 Variable copied when it could be moved
cid#1660137 Variable copied when it could be moved
cid#1660136 Variable copied when it could be moved
cid#1660135 Variable copied when it could be moved
cid#1660128 Variable copied when it could be moved
cid#1660124 Variable copied when it could be moved
cid#1660122 Variable copied when it could be moved
cid#1660117 Variable copied when it could be moved
cid#1660114 Variable copied when it could be moved
cid#1660110 Variable copied when it could be moved
cid#1660109 Variable copied when it could be moved
cid#1660105 Variable copied when it could be moved
cid#1660104 Variable copied when it could be moved
cid#1660102 Variable copied when it could be moved
cid#1660100 Variable copied when it could be moved
cid#1660098 Variable copied when it could be moved
cid#1660080 Variable copied when it could be moved
cid#1660079 Variable copied when it could be moved
cid#1660078 Variable copied when it could be moved
cid#1660075 Variable copied when it could be moved
cid#1660071 Variable copied when it could be moved
cid#1660070 Variable copied when it could be moved
cid#1660064 Variable copied when it could be moved
cid#1660063 Variable copied when it could be moved
cid#1660060 Variable copied when it could be moved
cid#1660058 Variable copied when it could be moved
cid#1660053 Variable copied when it could be moved
cid#1660050 Variable copied when it could be moved
cid#1660049 Variable copied when it could be moved
cid#1660046 Variable copied when it could be moved
cid#1660042 Variable copied when it could be moved
cid#1660028 Variable copied when it could be moved
cid#1660023 Variable copied when it could be moved
cid#1660022 Variable copied when it could be moved
cid#1660021 Variable copied when it could be moved
cid#1660020 Variable copied when it could be moved
cid#1660017 Variable copied when it could be moved
cid#1660013 Variable copied when it could be moved
cid#1660005 Variable copied when it could be moved
cid#1660003 Variable copied when it could be moved
cid#1659999 Variable copied when it could be moved
cid#1659998 Variable copied when it could be moved
cid#1659995 Variable copied when it could be moved
cid#1659993 Variable copied when it could be moved
cid#1659989 Variable copied when it could be moved
cid#1659988 Variable copied when it could be moved
Change-Id: I2a30c8a2ac8785050d49b98635b0b406535b185a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189056
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
... instead of the more generic weld::Container for
these widgets defined as "GtkBox" objects in the .ui file
(chart2/uiconfig/ui/chartdatadialog.ui).
This change is done as part of checking that none
of the widgets on which the weld::Container methods
are called is a weld::ScrolledWindow, which will soon
no longer subclass weld::Container.
Change-Id: I97220960531ac61eb2ddeb367c309212c8544d23
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188755
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
The TriStateEnabled struct implements logic to loop
through the three different TriState states for a
weld::Toggleable.
In practice, it is only used for weld::CheckButton
objects, and (while not instantly clear from the API)
TRISTATE_INDET isn't actually supported
by all weld::Toggleable subclasses.
Switch the param to TriStateEnabled::ButtonToggled
from weld::Toggleable& to weld::CheckButton& and
rename to CheckButtonToggled to make clearer this
is only for CheckButton.
As a consequence, adjust callers that were passing
just a weld::Toggleable& to pass a CheckButton&
(to the same underlying object) to adhere to the
new method signature.
This is one step towards making the inconsistent state
specific to weld::CheckButton, i.e. (re)move it from
weld::Toggleable and other subclasses.
Change-Id: I843c1c7075f91c0b81605ecb5d7e54621b9074c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187992
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
... and rename to `m_rParameter` accordingly.
This makes clear this is always non-null and
allows to drop a corresponding null check in
SchAttribTabDlg::PageCreated.
Change-Id: I82f18d7db7b026f31ed6e93b71fecda0f3c7fe89
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187861
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Adjust naming following
Change-Id: Iebc3c1172dfd12dbbe72c3a56eeb6eb333d799c5
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Fri Jun 13 18:45:11 2025 +0200
Move SvColorDialog from svtools to vcl
* Rename SvColorChooserDialog -> ColorChooserDialog,
now that the class is no longer in svtools
* Move ColorPickerMode from svtools namespace to vcl
Change-Id: I27e84d6c6e7f7cde35dea31159b01dd1e0d312cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186482
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Now after
Change-Id: I3b9997b73a9a6bcce4c5b3ae3bd7d57816a4419b
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Fri Jun 13 18:27:09 2025 +0200
Stop using UNO abstraction for color picker
, SvColorDialog no longer depends on anything
above vcl, so move it there, which will
help in implementing support for platform/toolkit-native
alternatives for the color picker instead of using
the LO-internal one.
The "Sv" naming prefix will be dropped in a separate commit,
to keep the diff clearer.
Change-Id: Iebc3c1172dfd12dbbe72c3a56eeb6eb333d799c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186481
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
... instead of as a param to SvColorDialog::Execute or
SvColorDialog::ExecuteAsync.
Passing a dialog or widget parent in the ctor is
typical for UI toolkits.
While SvColorDialog currently only creates the actual color
picker dialog in its Execute{,Async} methods, this will change
in an upcoming commit, for which this one prepares.
Change-Id: Ib1ea41cc986577a3e3f1dddfd93a04c2e69bc15f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186463
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
This moves isSupported* function from ChartTypeHelper to ChartType
where it better belongs to. We can access the concrete classes now
instead of accessing through UNO si this is possible to do.
Change-Id: Icc52a8ba0d8ab6d5907d7942a1834cc6f7093cce
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182712
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Jenkins
This moves functions from ChartModelHelper to ChartModel
where it better belongs to. We can access the concrete classes now
instead of accessing through UNO si this is possible to do.
Change-Id: I21dce8aabe8f8a956863beef7ca5cb4ec6f3b44b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183990
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Convert the `BROWSER_*` defines in include/svtools/brwbox.hxx
to a new enum class BrowserDispatchId.
The specific integer values that were used
don't seem to have any particular meaning, so
just drop them.
Add default case that does nothing in BrowseBox::Dispatch
to address
/home/michi/development/git/libreoffice/svtools/source/brwbox/brwbox2.cxx:1779:13: error: 5 enumeration values not handled in switch: 'NONE', 'CURSORENDOFSCREEN', 'CURSORTOPOFSCREEN'... [-Werror,-Wswitch]
1779 | switch (eId)
| ^~~
1 error generated.
Change-Id: Ibb023ec13ee2c10a0fc0ef7abe1371dbd856e735
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181167
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Rename weld::TreeView member + methods to clarify
that these are about selection changes:
* m_aChangeHdl to m_aSelectionChangedHdl,
* signal_changed to signal_selection_changed
* connect_changed to connect_selection_changed
In GtkInstanceTreeview, also rename the
related methods calling signal_selection_changed
accordingly for consistency.
Change-Id: I299d7930484677395a0bdd0ff105df18688f2e04
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178023
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Add support for input and output of 'split position' parameter (number of entries
in second plot) for of-pie charts. In OOXML this uses the supported split-pos
tag. For ODF I added an extension in loext namespace for this parameter.
This commit also includes simple tests for the I/O functionality in OOXML and
ODF.
Change-Id: I00ff59db721867fa836eb99b6677350040d005dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170666
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
V1037 Two or more case-branches perform the same actions. Check lines: 146, 158. This will still be the case, the code being just at the moment similar.
Change-Id: Iceca3c717ccc6ee3ea865d3a469418ff6e8accd7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175146
Reviewed-by: David Gilbert <freedesktop@treblig.org>
Tested-by: Jenkins
Implemented chart data extraction, and transformation
added insert/delete/modify row/column, and the ability to set
resize data table
setcolumndesc / setrowdesc .. for 1 descriptor,
or with multiple descriptor to set
set 1 cell value, or set the whole table cells values.
it will resize the table, but you can still use partial arrays
like
"data": [ [ 1,2,3,4 ],
[ 2,3,4,5 ],
[ 3 ],
[ 4,5,6,7 ],
[ 2,2,1 ],
[ 5,6,7,8 ] ],
that means the 3. row 2,3,4th cell will not be overwritten.
for insert column, it call codes from DataBrowserModel.
(used by dialog code)
added tests, fixed a contentcontrol date problem
2. commit (made by Caolan) squashed into 1. commit:
WIP hack this to link
move stuff from chartcontroller to chartcore and adjust visibility
until it links at least
Change-Id: I5529f4da33f046eef7e947d755e29486fa966274
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172849
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175121
Tested-by: Jenkins
so nothing happens.
since:
commit 4965b055b5
CommitDate: Fri Feb 16 12:08:55 2024 +0100
Chart: Make Data Range Dialog Async
async conversion missed that there is a DataSourceDialog::run
override so the use of asyncRun means the body of that isn't run.
To keep things simple we can add an explicit 'ok' handler and move
the special dialog ok code into that instead, so all the existing
asyncRun's used with this dialog run the same code originally called
in the previous non-async case.
Change-Id: Ibdb4b764b1a1e48c01ee1528bc260f694e840221
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172336
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Replace up-casting conversion constructor with respective conversion operator,
similar to existing css::uno::Reference conversion operator. Thic change will
not allow code like
rtl::Reference<Foo> foo;
rtl::Reference<Foo> bar(foo, uno::UNO_QUERY_THROW);
which was possible because compiler could use temporary css::uno::Reference.
Change-Id: I54b79af3e2508b26e9cd59f2cc7e2ae92f6efbbf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171166
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
This commit moves bar-of-pie and pie-of-pie chart types into a separate
line in the chart type selection UI from 'plain' pie chart types. This
allows for separate UI controls, including a spin button added in this
commit for of-pie types to specify the number of entries to be included
in the composite wedge and broken out in the right-hand subchart. Per
discussion in this and related bugs, this may not be the long-term best
approach for specifying which entries go into the composite, and it
still only allows for the last entries in the composite. But it is a
step towards allowing greater control.
I've also changed the default number in the composite from 3 to 2, to
better match MSO.
I/O of the 'number in the composite wedge' parameter is not included
in this commit. Implementing that for ODF and OOXML perhaps should be
a separate bug or bugs.
Change-Id: If4afc1417ea94c15e86a9a4dfe967a6f8ecb7ca8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168690
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
- Add the Histogram selection to the UI
- Histogram bars showing with No Gap
- Convert X and Y axis to group data into bins and frequency
- Adjusted failing UI test (tdf138556) as a new chart type was added
Change-Id: Id1f161adac943ead5e17c7fbb7e14c9ab7f1655e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167068
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
gtk_assistant_unmap ...
{
...
priv->current_page = NULL;
...
}
gtk_assistant_map
{
page_num = 0;
...
set_current_page (assistant, page_num)
...
}
It doesn't automatically restore itself to the page it was on
when it was hidden, so do that explicitly.
Change-Id: If23b255193c4a65b286e036c8796d9d8a2ffcb5e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170611
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
Tomaž Vajngerl