ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
476,260 Commits 3 Branches 3 Tags
30e6a4748bb29cc299c41755fbdf108db2c1c005
Commit Graph
3665 Commits
Author SHA1 Message Date
Stephan Bergmann acb65a60be Use more appropriate index variable types 
Change-Id: Ic2cf5512cabcda0ad476c43bcbc544d0d6dd2685
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135231
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2022-06-01 14:15:58 +02:00
Stephan Bergmann af1147f4a6 Use less noisy way to iterate over some (unscoped) enumeration 
Change-Id: I37ed9b3dd607367d2e42fcc163c423dc416cc7c6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135224
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2022-06-01 11:54:32 +02:00
Stephan Bergmann 66500b5041 Use some range-based for loops 
Change-Id: I4935bf51c6c7e9be1e3f069c6c72e618eaa0b4a9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135189
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2022-05-31 19:08:24 +02:00
Noel Grandin 51f46ddacc add GetItemState to SfxItemIter, the same way I did to SfxWhichIter 
to speed up GetItemState while iterating

Change-Id: Ibe092e7581a5be0160eed52472122afe7e0ef377
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135076
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-05-28 17:37:07 +02:00
Noel Grandin bcd27039ee use the new SfxWhichIter::GetItemState feature 
to speed up other places that are iterating over
SfxItemSets

Change-Id: I646bae12420d15e67effdd279e071cdf8a8afffd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135075
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-05-28 17:36:49 +02:00
Stephan Bergmann 5060c50158 Use o3tl::make_unsigned in some places 
...where a signed and an unsigned value are compared, and the signed value has
just been proven to be non-negative here

Change-Id: I20600d61a5d59d739bc1bee838c0038e4611aec2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134875
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2022-05-24 16:50:03 +02:00
Noel Grandin eb6f62496d no need to instantiate these services indirectly 
Change-Id: I5c798d2b0ac3895963cbb907e4a25fc0f14a9a2f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134745
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-05-24 11:57:03 +02:00
Noel Grandin 18715f6a63 remove unnecessary sequenceToContainer 
If we are not going to manipulate the resulting vector, then it is
actually slower, since we have to allocate more storage for the vector

Change-Id: I65677007d105f4783603df74113ebed6db0b551b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133963
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-05-06 21:52:00 +02:00
Noel Grandin 9e57e16484 loplugin:unusedvariableplus 
Change-Id: Id93086be1224b6f6bf0bdaa1d50b4f289099027e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133876
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-05-05 17:35:08 +02:00
Noel Grandin 9f1701d01d use more o3tl::getToken 
found by inspecting call sites of OUString::getToken

Change-Id: I4269c7476c7aa46fac39528227e350568f0eb34a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132644
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-05-05 12:57:00 +02:00
Stephan Bergmann 6ad8a6398d Just use Any ctor instead of makeAny in chart2 
Change-Id: I156cd5597a4b9e683913d9730b8d8bb22e8064f6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133845
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2022-05-05 07:12:47 +02:00
Noel Grandin 5200a73627 use more string_view in various 
found by examining uses of OUString::copy() for likely places

Change-Id: I6ff20e7b273ad6005410b82719183c1122f8c018
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133617
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-05-01 08:30:18 +02:00
Gabor Kelemen dec2c5f3ca Recheck module chart2 with IWYU 
See tdf#42949 for motivation

This time using the new --noexclude switch to recheck validity
of the excludelist; these were the obsolete exclusions

Change-Id: Ifdf79b30ebaf198082c2194611a2ed2b664e6f1f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133309
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
 2022-04-25 16:47:35 +02:00
Gabor Kelemen fef939d8ff Recheck module chart2 with IWYU 
See tdf#42949 for motivation

Change-Id: Id4cdca3eed8618c289f30913d506f8f2bd46f0bb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133112
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
 2022-04-23 16:33:58 +02:00
Mike Kaganski a09cf7e76a Drop a bit more special-casing for Chart's sidebar property deck 
Introduced in commit 2d01ed9e8b
  Author Muhammet Kara <muhammet.kara@collabora.com>
  Date   Mon Nov 25 21:55:31 2019 +0300
    tdf#94288: Show chart props sidebar on activation

The problem was that ChartController::attachFrame, that called
SelectionChangeHandler::selectionChanged notification, did that
*prior* to setting its m_xFrame - and the notification failed
in ContextChangeEventMultiplexer::NotifyContextChange, that
checks the frame first. That prevented the proper context (with
correct application and context names) to arrive to listeners,
and the sidebar didn't update properly.

Changing the order of the calls should fix the original problem.

Change-Id: I9da8465af2ee4ed1f8eabed1c65d1c318f81a3f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133326
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2022-04-22 16:49:51 +02:00
Noel Grandin ab699bfdb3 new loplugin:stringviewvar looks for OUString vars that can be 
... that can be string_view

Change-Id: I0ddf66725e08b58e866a764f57200dd188b9f639
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133066
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-04-19 18:31:10 +02:00
Noel Grandin fd2ca96074 tdf#148635 cache some chart stuff 
cache some intermediate stuff that it does a handful of times when
finishing a chart - halves the time taken

Change-Id: I75c5621844d4309b64e64219a7c9e2bcd344ce36
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133173
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-04-19 18:13:10 +02:00
Noel Grandin 6500106dff tdf#148635 no need to init ChartDataWrapper more than once 
halves the time to finish a chart2

Change-Id: Ib7f066672878f7630c2d1c90b9487a14f2048029
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133172
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-04-19 18:12:55 +02:00
Noel Grandin dbe92dcfa7 use more string_view in chart2 
Change-Id: I9ab6cd3905bfb7c811e7ad14b54ced6c42d2e077
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133003
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-04-14 15:13:34 +02:00
Caolán McNamara c15fceae5e Resolves: tdf#141625 give enough space to see full date+time 
Change-Id: I31193783231f27494ed1507faa143697e8facc30
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132977
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2022-04-14 09:54:37 +02:00
Noel Grandin 3e1e0af376 loplugin:stringviewparam convert methods using match 
which converts to a combination of substr and o3tl::starts_with

Change-Id: I5b01a181b9e6bee3483e4f49f1a9426abcc682d0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132458
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-04-03 10:01:48 +02:00
Stephan Bergmann a29f055491 -Werror,-Wunused-but-set-variable 
...since its uses got commented out with
a9cc010064 "chart2: Weld ChartTypePanel"

Change-Id: I5296ba7ed746df13e8174063f148ff2ce970756c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132224
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2022-03-28 20:07:19 +02:00
Julien Nabet 70cda6eff0 tdf#148157: assertion after set "Between tick marks", click outside the chart 
See bt here:
https://bugs.documentfoundation.org/attachment.cgi?id=179065

Change-Id: Id21f52d5cc33bbe99c27b7a8bdff056249c4d4fb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132027
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2022-03-25 11:33:54 +01:00
Michael Weghorn fe09f12d83 chart a11y: Drop bSendGlobally param from AccessibleBase::BroadcastAccEvent 
Setting it didn't have any effect in practice:
If set to `true`, it resulted in
`vcl::unohelper::NotifyAccessibleStateEventGlobally` getting
called, which calls
`XExtendedToolkit::fireFocusGained` or
`XExtendedToolkit::fireFocusLost`, but the only implementations
in `VCLXToolkit` do nothing.

Interestingly, the documentation for `XExtendedToolkit` in
`offapi/com/sun/star/awt/XExtendedToolkit.idl` says:

>    @deprecated
>        This interface was only implemented in an intermediate developer
>        release anyway.
>
>    @since OOo 1.1.2

but the interface is still used in various places across the
code base...

Change-Id: I4681c28c9d18cf1953be5127765f4aa94563662d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131735
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2022-03-18 13:21:00 +01:00
Dennis Francis 64631ddcf3 lokCalcRTL: chart-edit: no bounding box 
Fix for selections(svx-marks) similar to the fix for chart edit mode
tile painting

```
4fd2a14c6ee68f0574766ec7ec3dca35debe9d20
lokCalcRTL: global RTL: fix chart edit mode rendering
```

Conflicts:
	chart2/source/controller/main/ChartController.cxx

Change-Id: I2b5a2af7023b09254b8471b750122bec10126bde
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131091
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131572
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
 2022-03-15 08:28:46 +01:00
Noel Grandin 69b5f0b657 loplugin:constparams 
Change-Id: I5f184f93dbdb414514855c85c9dc1624e7ec8636
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131337
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-03-11 10:05:39 +01:00
Mike Kaganski dcd5fa0a7b Drop misguided test added in 82a1d32d3d 
The documented precondition is that index must not be greater than
the length of string. Just assert that, and fix the found misuse.

The added test is for in-place replacement, just in case.

Change-Id: I3c545a6f0bf913fe93e2bef83ce733359c193065
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131232
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
 2022-03-09 14:04:03 +01:00
Noel Grandin 6f652725fc make some svx methods const 
Change-Id: If04a160c46b8dbf641ca9d115d1560f17e87ce4d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131043
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-03-05 11:59:04 +01:00
Noel Grandin 3e23161baf use SfxItemSet::GetItemIfSet in chart2 
Change-Id: I1e5eeb8b29d2139a9c3e72c645bae9a8fb5dffff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130664
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-28 11:00:05 +01:00
Noel Grandin 2baf13e903 use more TypedWhichId 
Change-Id: I6ab3ca829bc08e672736dd8dd41ba714d7172090
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130498
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-24 19:31:38 +01:00
Caolán McNamara e63ad6a136 cid#1500434 Dereference after null check 
Change-Id: I10d7c70c40a41301752854b898d8d763ec6d6b72
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130485
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2022-02-24 13:06:58 +01:00
Caolán McNamara ea1600eb54 Resolves: tdf#147292 the area of the tooltip is wrong 
gen happens to make use of the current mouse point so it gets shown
anyway while gtk uses the designated area which isn't in the expected
units or screen relative positions

Change-Id: I11fdb09ad4ce2965d2f2e27fb1427c9d93de7a99
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130442
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2022-02-23 19:02:10 +01:00
Caolán McNamara 1af6ac5448 cid#1500434 Dereference after null check 
Change-Id: I1a9531446fbd5f977d02775f5d25696aba16287d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130431
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2022-02-23 14:56:00 +01:00
Caolán McNamara efa6c3db72 cid#1500643 Dereference before null check 
Change-Id: I1456b9a935c167344e0a56c7339da2c702a43e0b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130419
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2022-02-23 12:16:39 +01:00
Caolán McNamara ff215479a8 cid#1500515 Dereference after null check 
Change-Id: I6483c3a036c5c56c8c6515b5b8f08720c8bd1a6b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130269
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2022-02-21 18:45:12 +01:00
Caolán McNamara a9a4b82c9f cid#1500458 Dereference after null check 
Change-Id: Ic9626b0817ee65fbc6d68592c592c3c2e39d42e8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130267
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2022-02-21 14:45:45 +01:00
Noel Grandin 99b13eed21 loplugin:unusedfields 
Change-Id: I07ec409ea3663e789b6505dbfc999666525ed97f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130062
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-17 13:39:29 +01:00
Noel Grandin 11a3e5707d tdf#147394 delete crash legend 
regression from
    commit 63e8c2ccd3
    Author: Noel Grandin <noelgrandin@gmail.com>
    Date:   Sat Jan 29 21:21:27 2022 +0200
    use more concrete types in chart2, Diagram

Change-Id: I6598bb7c116bd94272a805e77751aa8cf5dc174a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129882
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-13 19:48:14 +01:00
Noel Grandin c1c9071dd5 crashtesting ooo#ooo83229-2 
this reverts part of
  commit b314b5a061
  use more concrete types in chart2, DataSeries
since writer uses it's own implementation of the XLabeledDataSequence
UNO interface

Change-Id: I52154dcee104ca17bfa63a3a8b11ef739cef147f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129772
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-10 11:42:58 +01:00
Noel Grandin 5477193c9c use more concrete types in chart2, SvxShape 
Change-Id: I9ae954f8efaec31d5b848c633e66adb62a13f3f4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129737
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-10 07:49:56 +01:00
Noel Grandin 7c62e59587 use more concrete types in chart2, Axis 
Change-Id: Ia47fd6deedd0a1cf6bedc882cb9817206dfa88b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129690
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-09 07:34:22 +01:00
Noel Grandin 6e800111d6 use more concrete types in chart2, DataSource 
Change-Id: I513491e8d39ee79edf8521d279bd32031cf22a93
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129687
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-09 07:32:09 +01:00
Noel Grandin b314b5a061 use more concrete types in chart2, DataSeries 
Change-Id: I80bc8961832a20c29b31f7618b9d2609f15ab3c2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129642
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-08 08:52:11 +01:00
Noel Grandin d9ff5556e7 use more concrete types in chart2, DataSeries 
Change-Id: If92f6ff6f90d53a9dc6211fd9f071d4d3fce2997
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129535
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-07 18:28:05 +01:00
Noel Grandin 372f590220 crashtesting ooo#20372 
this reverts parts of the "use more concrete types in chart2,
LabeledDataSequence" commits, since writer uses it's own implementation
of the XLabeledDataSequence UNO interface

Change-Id: Icc2c5e9a38f789cddd9fbca63301397ce759fbff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129587
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-07 11:21:24 +01:00
VaibhavMalik4187 8b327cd86d tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro 
Change-Id: I4f5258ca5b37e9b1b4237c5d29e4a9e5362fa855
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129116
Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
 2022-02-06 21:38:32 +01:00
Noel Grandin 333ccb081b use more concrete types in chart2, Axis 
Change-Id: If80b6487ad2b8ac75f98f798b839aff2b8a5c23e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129522
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-05 20:39:03 +01:00
Noel Grandin f7016b59dd use more concrete types in chart2, LabeledDataSequence 
Change-Id: I50b23923c1aa946f2c448534719a6c18003592a1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129521
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-05 17:37:01 +01:00
Caolán McNamara e00032ba6a add toId/fromId to tidy up some ugly casting 
Change-Id: I70f34ac5e9b5d2f2d6c0375e823908eaa2e540b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129487
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2022-02-04 15:02:03 +01:00
Noel Grandin ccbd2b0c66 use more concrete types in chart2, LabeledDataSequence 
Change-Id: Iecc22ad488fff7d0536ffa37f4cde7da460c2c7d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129458
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-04 14:40:10 +01:00