ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

loplugin:constparams

Browse Source 
Change-Id: I5f184f93dbdb414514855c85c9dc1624e7ec8636
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131337
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2022-03-11 10:05:39 +01:00
parent 4015b22dbc
commit 69b5f0b657
59 changed files with 95 additions and 95 deletions
Download Patch File Download Diff File Expand all files Collapse all files
chart2/source/controller/dialogs/TitleDialogData.cxx
+1 -1
View File
@@ -73,7 +73,7 @@ void TitleDialogData::readFromModel( const rtl::Reference<::chart::ChartModel>&
bool TitleDialogData::writeDifferenceToModel(
const rtl::Reference<::chart::ChartModel>& xChartModel
, const uno::Reference< uno::XComponentContext >& xContext
, TitleDialogData* pOldState )
, const TitleDialogData* pOldState )
{
bool bChanged = false;
for( sal_Int32 nN = static_cast< sal_Int32 >( TitleHelper::TITLE_BEGIN );
chart2/source/controller/inc/TitleDialogData.hxx
+1 -1
View File
@@ -45,7 +45,7 @@ struct TitleDialogData
*/
bool writeDifferenceToModel( const rtl::Reference<::chart::ChartModel>& xChartModel
, const css::uno::Reference< css::uno::XComponentContext >& xContext
, TitleDialogData* pOldState=nullptr );
, const TitleDialogData* pOldState=nullptr );
};
} //namespace chart
chart2/source/inc/CommonConverters.hxx
+1 -1
View File
@@ -133,7 +133,7 @@ basegfx::B2DPolyPolygon PolyToB2DPolyPolygon(
*/
OOO_DLLPUBLIC_CHARTTOOLS
void appendPointSequence( css::drawing::PointSequenceSequence& rTarget
, css::drawing::PointSequenceSequence& rAdd );
, const css::drawing::PointSequenceSequence& rAdd );
/** Position3D + Direction3D == Position3D
*/
chart2/source/tools/CommonConverters.cxx
+1 -1
View File
@@ -419,7 +419,7 @@ basegfx::B2DPolyPolygon PolyToB2DPolyPolygon(
}
void appendPointSequence( drawing::PointSequenceSequence& rTarget
, drawing::PointSequenceSequence& rAdd )
, const drawing::PointSequenceSequence& rAdd )
{
sal_Int32 nAddCount = rAdd.getLength();
if(!nAddCount)
chart2/source/view/charttypes/BarChart.cxx
+8 -8
View File
@@ -563,10 +563,10 @@ void BarChart::doZSlot(
bool& bDrawConnectionLines, bool& bDrawConnectionLinesInited,
const std::vector< VDataSeriesGroup >& rZSlot,
const sal_Int32 nZ, const sal_Int32 nPointIndex, const sal_Int32 nStartIndex,
rtl::Reference<SvxShapeGroupAnyD>& xSeriesTarget,
rtl::Reference<SvxShapeGroupAnyD>& xRegressionCurveTarget,
rtl::Reference<SvxShapeGroupAnyD>& xRegressionCurveEquationTarget,
rtl::Reference<SvxShapeGroupAnyD>& xTextTarget,
const rtl::Reference<SvxShapeGroupAnyD>& xSeriesTarget,
const rtl::Reference<SvxShapeGroupAnyD>& xRegressionCurveTarget,
const rtl::Reference<SvxShapeGroupAnyD>& xRegressionCurveEquationTarget,
const rtl::Reference<SvxShapeGroupAnyD>& xTextTarget,
std::unordered_set<rtl::Reference<SvxShape>>& aShapeSet,
std::map< VDataSeries*, FormerBarPoint >& aSeriesFormerPointMap,
std::map< sal_Int32, double >& aLogicYSumMap)
@@ -638,10 +638,10 @@ void BarChart::doXSlot(
const VDataSeriesGroup& rXSlot,
bool& bDrawConnectionLines, bool& bDrawConnectionLinesInited,
const sal_Int32 nZ, const sal_Int32 nPointIndex, const sal_Int32 nStartIndex,
rtl::Reference<SvxShapeGroupAnyD>& xSeriesTarget,
rtl::Reference<SvxShapeGroupAnyD>& xRegressionCurveTarget,
rtl::Reference<SvxShapeGroupAnyD>& xRegressionCurveEquationTarget,
rtl::Reference<SvxShapeGroupAnyD>& xTextTarget,
const rtl::Reference<SvxShapeGroupAnyD>& xSeriesTarget,
const rtl::Reference<SvxShapeGroupAnyD>& xRegressionCurveTarget,
const rtl::Reference<SvxShapeGroupAnyD>& xRegressionCurveEquationTarget,
const rtl::Reference<SvxShapeGroupAnyD>& xTextTarget,
std::unordered_set<rtl::Reference<SvxShape>>& aShapeSet,
std::map< VDataSeries*, FormerBarPoint >& aSeriesFormerPointMap,
std::map< sal_Int32, double >& aLogicYSumMap,
chart2/source/view/charttypes/BarChart.hxx
+8 -8
View File
@@ -84,10 +84,10 @@ private: //methods
void doZSlot(
bool& bDrawConnectionLines, bool& bDrawConnectionLinesInited, const std::vector< VDataSeriesGroup >& rZSlot,
sal_Int32 nZ, sal_Int32 nPointIndex, sal_Int32 nStartIndex,
rtl::Reference<SvxShapeGroupAnyD>& xSeriesTarget,
rtl::Reference<SvxShapeGroupAnyD>& xRegressionCurveTarget,
rtl::Reference<SvxShapeGroupAnyD>& xRegressionCurveEquationTarget,
rtl::Reference<SvxShapeGroupAnyD>& xTextTarget,
const rtl::Reference<SvxShapeGroupAnyD>& xSeriesTarget,
const rtl::Reference<SvxShapeGroupAnyD>& xRegressionCurveTarget,
const rtl::Reference<SvxShapeGroupAnyD>& xRegressionCurveEquationTarget,
const rtl::Reference<SvxShapeGroupAnyD>& xTextTarget,
std::unordered_set<rtl::Reference<SvxShape>>& aShapeSet,
std::map< VDataSeries*, FormerBarPoint >& aSeriesFormerPointMap,
std::map< sal_Int32, double >& aLogicYSumMap);
@@ -96,10 +96,10 @@ private: //methods
const VDataSeriesGroup& rXSlot,
bool& bDrawConnectionLines, bool& bDrawConnectionLinesInited,
sal_Int32 nZ, sal_Int32 nPointIndex, sal_Int32 nStartIndex,
rtl::Reference<SvxShapeGroupAnyD>& xSeriesTarget,
rtl::Reference<SvxShapeGroupAnyD>& xRegressionCurveTarget,
rtl::Reference<SvxShapeGroupAnyD>& xRegressionCurveEquationTarget,
rtl::Reference<SvxShapeGroupAnyD>& xTextTarget,
const rtl::Reference<SvxShapeGroupAnyD>& xSeriesTarget,
const rtl::Reference<SvxShapeGroupAnyD>& xRegressionCurveTarget,
const rtl::Reference<SvxShapeGroupAnyD>& xRegressionCurveEquationTarget,
const rtl::Reference<SvxShapeGroupAnyD>& xTextTarget,
std::unordered_set<rtl::Reference<SvxShape>>& aShapeSet,
std::map< VDataSeries*, FormerBarPoint >& aSeriesFormerPointMap,
std::map< sal_Int32, double >& aLogicYSumMap,
chart2/source/view/charttypes/NetChart.cxx
+2 -2
View File
@@ -112,7 +112,7 @@ drawing::Direction3D NetChart::getPreferredDiagramAspectRatio() const
}
bool NetChart::impl_createLine( VDataSeries* pSeries
, std::vector<std::vector<css::drawing::Position3D>>* pSeriesPoly
, const std::vector<std::vector<css::drawing::Position3D>>* pSeriesPoly
, PlottingPositionHelper const * pPosHelper )
{
//return true if a line was created successfully
@@ -164,7 +164,7 @@ bool NetChart::impl_createLine( VDataSeries* pSeries
}
bool NetChart::impl_createArea( VDataSeries* pSeries
, std::vector<std::vector<css::drawing::Position3D>>* pSeriesPoly
, const std::vector<std::vector<css::drawing::Position3D>>* pSeriesPoly
, std::vector<std::vector<css::drawing::Position3D>> const * pPreviousSeriesPoly
, PlottingPositionHelper const * pPosHelper )
{
chart2/source/view/charttypes/NetChart.hxx
+2 -2
View File
@@ -53,11 +53,11 @@ public:
private: //methods
void impl_createSeriesShapes();
bool impl_createArea( VDataSeries* pSeries
, std::vector<std::vector<css::drawing::Position3D>>* pSeriesPoly
, const std::vector<std::vector<css::drawing::Position3D>>* pSeriesPoly
, std::vector<std::vector<css::drawing::Position3D>> const * pPreviousSeriesPoly
, PlottingPositionHelper const * pPosHelper );
bool impl_createLine( VDataSeries* pSeries
, std::vector<std::vector<css::drawing::Position3D>>* pSeriesPoly
, const std::vector<std::vector<css::drawing::Position3D>>* pSeriesPoly
, PlottingPositionHelper const * pPosHelper );
private: //member
chart2/source/view/inc/ShapeFactory.hxx
+2 -2
View File
@@ -203,7 +203,7 @@ public:
static rtl::Reference<SvxShapeText>
createText(const rtl::Reference<SvxShapeGroupAnyD>& xTarget
, css::uno::Sequence< css::uno::Reference< css::chart2::XFormattedString > >& xFormattedString
, const css::uno::Sequence< css::uno::Reference< css::chart2::XFormattedString > >& xFormattedString
, const tNameSequence& rPropNames
, const tAnySequence& rPropValues
, const css::uno::Any& rATransformation);
@@ -255,7 +255,7 @@ public:
static OUString getStackedString( const OUString& rString, bool bStacked );
static bool hasPolygonAnyLines( const std::vector<std::vector<css::drawing::Position3D>>& rPoly );
static bool isPolygonEmptyOrSinglePoint( css::drawing::PolyPolygonShape3D& rPoly );
static bool isPolygonEmptyOrSinglePoint( const css::drawing::PolyPolygonShape3D& rPoly );
static bool isPolygonEmptyOrSinglePoint( const std::vector<std::vector<css::drawing::Position3D>>& rPoly );
static void closePolygon( css::drawing::PolyPolygonShape3D& rPoly );
static void closePolygon( std::vector<std::vector<css::drawing::Position3D>>& rPoly );
chart2/source/view/main/ChartView.cxx
+1 -1
View File
@@ -2320,7 +2320,7 @@ void formatPage(
}
}
void lcl_removeEmptyGroupShapes( SdrObject& rParent )
void lcl_removeEmptyGroupShapes( const SdrObject& rParent )
{
SdrObjList* pObjList = rParent.getChildrenOfSdrObject();
if (!pObjList || pObjList->GetObjCount() == 0)
chart2/source/view/main/ShapeFactory.cxx
+2 -2
View File
@@ -2074,7 +2074,7 @@ rtl::Reference<SvxShapeText>
rtl::Reference<SvxShapeText>
ShapeFactory::createText( const rtl::Reference<SvxShapeGroupAnyD>& xTarget
, uno::Sequence< uno::Reference< chart2::XFormattedString > >& xFormattedString
, const uno::Sequence< uno::Reference< chart2::XFormattedString > >& xFormattedString
, const tNameSequence& rPropNames
, const tAnySequence& rPropValues
, const uno::Any& rATransformation )
@@ -2418,7 +2418,7 @@ bool ShapeFactory::hasPolygonAnyLines( const std::vector<std::vector<css::drawin
return false;
}
bool ShapeFactory::isPolygonEmptyOrSinglePoint( drawing::PolyPolygonShape3D& rPoly)
bool ShapeFactory::isPolygonEmptyOrSinglePoint( const drawing::PolyPolygonShape3D& rPoly)
{
// true, if empty polypolygon or one polygon with one point
return !rPoly.SequenceX.hasElements() ||
dbaccess/source/ui/browser/unodatbr.cxx
+1 -1
View File
@@ -2120,7 +2120,7 @@ void SbaTableQueryBrowser::populateTree(const Reference<XNameAccess>& _xNameAcce
rTreeView.make_sorted();
}
std::unique_ptr<weld::TreeIter> SbaTableQueryBrowser::implAppendEntry(const weld::TreeIter* pParent, const OUString& rName, DBTreeListUserData* pUserData)
std::unique_ptr<weld::TreeIter> SbaTableQueryBrowser::implAppendEntry(const weld::TreeIter* pParent, const OUString& rName, const DBTreeListUserData* pUserData)
{
EntryType eEntryType = pUserData->eType;
dbaccess/source/ui/inc/unodatbr.hxx
+1 -1
View File
@@ -356,7 +356,7 @@ namespace dbaui
std::unique_ptr<weld::TreeIter> implAppendEntry(
const weld::TreeIter* pParent,
const OUString& rName,
DBTreeListUserData* pUserData);
const DBTreeListUserData* pUserData);
/// loads the grid control with the data object specified (which may be a table, a query or a command)
bool implLoadAnything(const OUString& _rDataSourceName, const OUString& _rCommand,
desktop/source/deployment/gui/dp_gui_updatedialog.cxx
+2 -2
View File
@@ -496,7 +496,7 @@ IMPL_LINK(UpdateDialog, entryToggled, const weld::TreeView::iter_col&, rRowCol,
enableOk();
}
void UpdateDialog::insertItem(UpdateDialog::Index *pEntry, bool bEnabledCheckBox)
void UpdateDialog::insertItem(const UpdateDialog::Index *pEntry, bool bEnabledCheckBox)
{
int nEntry = m_xUpdates->n_children();
m_xUpdates->append();
@@ -505,7 +505,7 @@ void UpdateDialog::insertItem(UpdateDialog::Index *pEntry, bool bEnabledCheckBox
m_xUpdates->set_id(nEntry, weld::toId(pEntry));
}
void UpdateDialog::addAdditional(UpdateDialog::Index * index, bool bEnabledCheckBox)
void UpdateDialog::addAdditional(const UpdateDialog::Index * index, bool bEnabledCheckBox)
{
m_xAll->set_sensitive(true);
if (m_xAll->get_active())
desktop/source/deployment/gui/dp_gui_updatedialog.hxx
+2 -2
View File
@@ -96,8 +96,8 @@ private:
friend class CheckListBox;
void insertItem(UpdateDialog::Index *pIndex, bool bEnableCheckBox);
void addAdditional(UpdateDialog::Index *pIndex, bool bEnableCheckBox);
void insertItem(const UpdateDialog::Index *pIndex, bool bEnableCheckBox);
void addAdditional(const UpdateDialog::Index *pIndex, bool bEnableCheckBox);
bool isIgnoredUpdate( UpdateDialog::Index *pIndex );
void addEnabledUpdate( OUString const & name, dp_gui::UpdateData const & data );
framework/source/uiconfiguration/CommandImageResolver.cxx
+1 -1
View File
@@ -70,7 +70,7 @@ CommandImageResolver::~CommandImageResolver()
{
}
void CommandImageResolver::registerCommands(Sequence<OUString>& aCommandSequence)
void CommandImageResolver::registerCommands(const Sequence<OUString>& aCommandSequence)
{
sal_Int32 nSequenceSize = aCommandSequence.getLength();
framework/source/uiconfiguration/CommandImageResolver.hxx
+1 -1
View File
@@ -40,7 +40,7 @@ public:
CommandImageResolver();
~CommandImageResolver();
void registerCommands(css::uno::Sequence<OUString>& aCommandSequence);
void registerCommands(const css::uno::Sequence<OUString>& aCommandSequence);
Image getImageFromCommandURL(ImageType nImageType, const OUString& rCommandURL);
std::vector<OUString>& getCommandNames() { return m_aImageCommandNameVector; }
include/oox/drawingml/shape.hxx
+1 -1
View File
@@ -253,7 +253,7 @@ public:
void propagateDiagramHelper();
// for Writer it is necessary to migrate an existing helper to a new Shape
void migrateDiagramHelperToNewShape(ShapePtr& pTarget);
void migrateDiagramHelperToNewShape(const ShapePtr& pTarget);
protected:
include/sfx2/dispatch.hxx
+1 -1
View File
@@ -171,7 +171,7 @@ public:
SAL_DLLPRIVATE void DoDeactivate_Impl( bool bMDI, SfxViewFrame const * pNew );
SAL_DLLPRIVATE void InvalidateBindings_Impl(bool);
static boost::property_tree::ptree fillPopupMenu(css::uno::Reference<css::awt::XPopupMenu>& rMenu);
static boost::property_tree::ptree fillPopupMenu(const css::uno::Reference<css::awt::XPopupMenu>& rMenu);
};
#endif
include/svx/ColorSets.hxx
+1 -1
View File
@@ -91,7 +91,7 @@ public:
static std::unique_ptr<Theme> FromAny(const css::uno::Any& rVal);
void UpdateSdrPage(SdrPage* pPage);
void UpdateSdrPage(const SdrPage* pPage);
std::vector<Color> GetColors() const;
};
include/svx/svdoedge.hxx
+1 -1
View File
@@ -290,7 +290,7 @@ public:
// helper method for SdrDragMethod::AddConnectorOverlays. Adds an overlay polygon for
// this connector to rResult.
basegfx::B2DPolygon ImplAddConnectorOverlay(SdrDragMethod& rDragMethod, bool bTail1, bool bTail2, bool bDetail) const;
basegfx::B2DPolygon ImplAddConnectorOverlay(const SdrDragMethod& rDragMethod, bool bTail1, bool bTail2, bool bDetail) const;
};
// The following item parameters of the SdrItemPool are used to
include/svx/svdundo.hxx
+1 -1
View File
@@ -387,7 +387,7 @@ private:
void Do(::std::vector<sal_Int32> & rSortOrder);
public:
SdrUndoSort(SdrPage & rPage,
SdrUndoSort(const SdrPage & rPage,
::std::vector<sal_Int32> const& rSortOrder);
virtual void Undo() override;
oox/source/drawingml/diagram/diagramhelper.cxx
+1 -1
View File
@@ -39,7 +39,7 @@ bool AdvancedDiagramHelper::hasDiagramData() const
AdvancedDiagramHelper::AdvancedDiagramHelper(
const std::shared_ptr< Diagram >& rDiagramPtr,
const std::shared_ptr<::oox::drawingml::Theme>& rTheme,
Shape& rSourceShape)
const Shape& rSourceShape)
: IDiagramHelper()
, mpDiagramPtr(rDiagramPtr)
, mpThemePtr(rTheme)
oox/source/drawingml/diagram/diagramhelper.hxx
+1 -1
View File
@@ -55,7 +55,7 @@ public:
AdvancedDiagramHelper(
const std::shared_ptr< Diagram >& rDiagramPtr,
const std::shared_ptr<::oox::drawingml::Theme>& rTheme,
Shape& rSourceShape);
const Shape& rSourceShape);
virtual ~AdvancedDiagramHelper();
// re-create XShapes
oox/source/drawingml/shape.cxx
+1 -1
View File
@@ -236,7 +236,7 @@ void Shape::propagateDiagramHelper()
}
}
void Shape::migrateDiagramHelperToNewShape(ShapePtr& pTarget)
void Shape::migrateDiagramHelperToNewShape(const ShapePtr& pTarget)
{
if(!mpDiagramHelper)
{
oox/source/drawingml/table/predefined-table-styles.cxx
+1 -1
View File
@@ -202,7 +202,7 @@ static std::map<OUString, sal_Int32> tokens = { { "", XML_dk1 },
{ "Accent5", XML_accent5 },
{ "Accent6", XML_accent6 } };
void setBorderLineType(oox::drawingml::LinePropertiesPtr& pLineProp, sal_Int32 nToken)
void setBorderLineType(const oox::drawingml::LinePropertiesPtr& pLineProp, sal_Int32 nToken)
{
pLineProp->maLineFill.moFillType.set(nToken);
}
oox/source/export/shapes.cxx
+2 -2
View File
@@ -611,7 +611,7 @@ static bool lcl_IsOnAllowlist(OUString const & rShapeType)
return std::find(vAllowlist.begin(), vAllowlist.end(), rShapeType) != vAllowlist.end();
}
static bool lcl_GetHandlePosition( sal_Int32 &nValue, const EnhancedCustomShapeParameter &rParam, Sequence< EnhancedCustomShapeAdjustmentValue > &rSeq)
static bool lcl_GetHandlePosition( sal_Int32 &nValue, const EnhancedCustomShapeParameter &rParam, const Sequence< EnhancedCustomShapeAdjustmentValue > &rSeq)
{
bool bAdj = false;
if ( rParam.Value.getValueTypeClass() == TypeClass_DOUBLE )
@@ -647,7 +647,7 @@ static bool lcl_GetHandlePosition( sal_Int32 &nValue, const EnhancedCustomShapeP
static void lcl_AnalyzeHandles( const uno::Sequence<beans::PropertyValues> & rHandles,
std::vector< std::pair< sal_Int32, sal_Int32> > &rHandlePositionList,
Sequence< EnhancedCustomShapeAdjustmentValue > &rSeq)
const Sequence< EnhancedCustomShapeAdjustmentValue > &rSeq)
{
for ( const Sequence< PropertyValue >& rPropSeq : rHandles )
{
reportdesign/source/ui/dlg/Navigator.cxx
+2 -2
View File
@@ -138,7 +138,7 @@ class NavigatorTree : public ::cppu::BaseMutex
::rtl::Reference< comphelper::OPropertyChangeMultiplexer> m_pReportListener;
::rtl::Reference< comphelper::OSelectionChangeMultiplexer> m_pSelectionListener;
void insertEntry(const OUString& rName, const weld::TreeIter* pParent, const OUString& rImageId, int nPosition, UserData* pData, weld::TreeIter& rRet);
void insertEntry(const OUString& rName, const weld::TreeIter* pParent, const OUString& rImageId, int nPosition, const UserData* pData, weld::TreeIter& rRet);
void traverseSection(const uno::Reference<report::XSection>& xSection, const weld::TreeIter* pParent, const OUString& rImageId, int nPosition = -1);
void traverseFunctions(const uno::Reference< report::XFunctions>& xFunctions, const weld::TreeIter* pParent);
@@ -379,7 +379,7 @@ void NavigatorTree::_selectionChanged( const lang::EventObject& aEvent )
}
void NavigatorTree::insertEntry(const OUString& rName, const weld::TreeIter* pParent, const OUString& rImageId,
int nPosition, UserData* pData, weld::TreeIter& rRet)
int nPosition, const UserData* pData, weld::TreeIter& rRet)
{
OUString sId = pData ? weld::toId(pData) : OUString();
m_xTreeView->insert(pParent, nPosition, &rName, &sId, nullptr, nullptr, false, &rRet);
sc/inc/Sparkline.hxx
+1 -1
View File
@@ -30,7 +30,7 @@ private:
std::shared_ptr<SparklineGroup> m_pSparklineGroup;
public:
Sparkline(std::shared_ptr<SparklineGroup>& pSparklineGroup);
Sparkline(const std::shared_ptr<SparklineGroup>& pSparklineGroup);
Sparkline(const Sparkline&) = delete;
Sparkline& operator=(const Sparkline&) = delete;
sc/inc/document.hxx
+1 -1
View File
@@ -1254,7 +1254,7 @@ public:
/** Spaklines */
SC_DLLPUBLIC sc::Sparkline* GetSparkline(ScAddress const & rPosition);
SC_DLLPUBLIC sc::Sparkline* CreateSparkline(ScAddress const & rPosition, std::shared_ptr<sc::SparklineGroup> & pSparklineGroup);
SC_DLLPUBLIC sc::Sparkline* CreateSparkline(ScAddress const & rPosition, const std::shared_ptr<sc::SparklineGroup> & pSparklineGroup);
/** Notes **/
SC_DLLPUBLIC ScPostIt* GetNote(const ScAddress& rPos);
sc/source/core/data/Sparkline.cxx
+1 -1
View File
@@ -13,7 +13,7 @@
namespace sc
{
Sparkline::Sparkline(std::shared_ptr<SparklineGroup>& pSparklineGroup)
Sparkline::Sparkline(const std::shared_ptr<SparklineGroup>& pSparklineGroup)
: m_pSparklineGroup(pSparklineGroup)
{
}
sc/source/core/data/document.cxx
+2 -2
View File
@@ -5201,7 +5201,7 @@ void ScDocument::GetSelectionFrame( const ScMarkData& rMark,
rLineInner.SetValid( SvxBoxInfoItemValidFlags::VERT, ( aFlags.nVert != SC_LINE_DONTCARE ) );
}
static HasAttrFlags OptimizeHasAttrib( HasAttrFlags nMask, ScDocumentPool* pPool )
static HasAttrFlags OptimizeHasAttrib( HasAttrFlags nMask, const ScDocumentPool* pPool )
{
if ( nMask & HasAttrFlags::Rotate )
{
@@ -6579,7 +6579,7 @@ sc::Sparkline* ScDocument::GetSparkline(ScAddress const& rPosition)
return nullptr;
}
sc::Sparkline* ScDocument::CreateSparkline(ScAddress const & rPosition, std::shared_ptr<sc::SparklineGroup> & pSparklineGroup)
sc::Sparkline* ScDocument::CreateSparkline(ScAddress const & rPosition, const std::shared_ptr<sc::SparklineGroup> & pSparklineGroup)
{
std::unique_ptr<sc::Sparkline> pSparkline(new sc::Sparkline(pSparklineGroup));
sc::Sparkline* pCreated = pSparkline.get();
sc/source/filter/oox/SparklineFragment.cxx
+1 -1
View File
@@ -57,7 +57,7 @@ namespace
}
void addColorsToSparklineGroup(sc::SparklineGroup& rSparklineGroup, sal_Int32 nElement,
const AttributeList& rAttribs, ThemeBuffer& rThemeBuffer)
const AttributeList& rAttribs, const ThemeBuffer& rThemeBuffer)
{
switch (nElement)
{
sc/source/ui/inc/gridwin.hxx
+1 -1
View File
@@ -418,7 +418,7 @@ public:
tools::Long nDimIndex, ScDPObject* pDPObj);
void DrawButtons(SCCOL nX1, SCCOL nX2, const ScTableInfo& rTabInfo, OutputDevice* pContentDev,
ScLokRTLContext* pLokRTLContext);
const ScLokRTLContext* pLokRTLContext);
using Window::Draw;
void Draw( SCCOL nX1, SCROW nY1, SCCOL nX2, SCROW nY2,
sc/source/ui/sidebar/CellLineStyleValueSet.cxx
+1 -1
View File
@@ -71,7 +71,7 @@ void CellLineStyleValueSet::SetSelItem(sal_uInt16 nSel)
}
}
tools::Long CellLineStyleValueSet::GetMaxTextWidth(vcl::RenderContext* pDev)
tools::Long CellLineStyleValueSet::GetMaxTextWidth(const vcl::RenderContext* pDev)
{
if (mnMaxTextWidth > 0)
return mnMaxTextWidth;
sc/source/ui/sidebar/CellLineStyleValueSet.hxx
+1 -1
View File
@@ -38,7 +38,7 @@ public:
void SetUnit(const OUString* str);
void SetSelItem(sal_uInt16 nSel);
tools::Long GetMaxTextWidth(vcl::RenderContext* pDev);
tools::Long GetMaxTextWidth(const vcl::RenderContext* pDev);
virtual void SetDrawingArea(weld::DrawingArea* pDrawingArea) override;
virtual void UserDraw(const UserDrawEvent& rUDEvt) override;
};
sc/source/ui/view/gridwin4.cxx
+1 -1
View File
@@ -2008,7 +2008,7 @@ void ScGridWindow::DrawPagePreview( SCCOL nX1, SCROW nY1, SCCOL nX2, SCROW nY2,
}
}
void ScGridWindow::DrawButtons(SCCOL nX1, SCCOL nX2, const ScTableInfo& rTabInfo, OutputDevice* pContentDev, ScLokRTLContext* pLokRTLContext)
void ScGridWindow::DrawButtons(SCCOL nX1, SCCOL nX2, const ScTableInfo& rTabInfo, OutputDevice* pContentDev, const ScLokRTLContext* pLokRTLContext)
{
aComboButton.SetOutputDevice( pContentDev );
sd/source/ui/dlg/sdtreelb.cxx
+1 -1
View File
@@ -1009,7 +1009,7 @@ bool SdPageObjsTLV::PageBelongsToCurrentShow(const SdPage* pPage) const
void SdPageObjsTLV::AddShapeList (
const SdrObjList& rList,
SdrObject* pShape,
const SdrObject* pShape,
const OUString& rsName,
const bool bIsExcluded,
const weld::TreeIter* pParentEntry)
sd/source/ui/inc/sdtreelb.hxx
+1 -1
View File
@@ -305,7 +305,7 @@ public:
*/
void AddShapeList (
const SdrObjList& rList,
SdrObject* pShape,
const SdrObject* pShape,
const OUString& rsName,
const bool bIsExcluded,
const weld::TreeIter* pParentEntry);
sfx2/source/control/dispatch.cxx
+1 -1
View File
@@ -1801,7 +1801,7 @@ boost::property_tree::ptree fillPopupMenu(Menu* pMenu)
}
boost::property_tree::ptree SfxDispatcher::fillPopupMenu(css::uno::Reference<css::awt::XPopupMenu>& rPopupMenu)
boost::property_tree::ptree SfxDispatcher::fillPopupMenu(const css::uno::Reference<css::awt::XPopupMenu>& rPopupMenu)
{
VCLXMenu* pAwtMenu = comphelper::getFromUnoTunnel<VCLXMenu>(rPopupMenu);
PopupMenu* pVCLMenu = static_cast<PopupMenu*>(pAwtMenu->GetMenu());
slideshow/source/engine/opengl/TransitionerImpl.cxx
+4 -4
View File
@@ -176,7 +176,7 @@ protected:
void createTexture( GLuint* texID,
bool useMipmap,
uno::Sequence<sal_Int8>& data,
const uno::Sequence<sal_Int8>& data,
const OGLFormat* pFormat );
const OGLFormat* chooseFormats();
@@ -188,7 +188,7 @@ private:
void setSlides( const Reference< rendering::XBitmap >& xLeavingSlide , const uno::Reference< rendering::XBitmap >& xEnteringSlide );
void impl_prepareSlides();
void impl_createTexture( bool useMipmap, uno::Sequence<sal_Int8>& data, const OGLFormat* pFormat );
void impl_createTexture( bool useMipmap, const uno::Sequence<sal_Int8>& data, const OGLFormat* pFormat );
bool initWindowFromSlideShowView( const uno::Reference< presentation::XSlideShowView >& xView );
/** After the window has been created, and the slides have been set, we'll initialize the slides with OpenGL.
@@ -448,7 +448,7 @@ bool OGLTransitionerImpl::setTransition( const std::shared_ptr<OGLTransitionImpl
void OGLTransitionerImpl::createTexture( GLuint* texID,
bool useMipmap,
uno::Sequence<sal_Int8>& data,
const uno::Sequence<sal_Int8>& data,
const OGLFormat* pFormat )
{
CHECK_GL_ERROR();
@@ -817,7 +817,7 @@ void buildMipmaps(
void OGLTransitionerImpl::impl_createTexture(
bool useMipmap,
uno::Sequence<sal_Int8>& data,
const uno::Sequence<sal_Int8>& data,
const OGLFormat* pFormat )
{
if( !pFormat )
solenv/lockfile/lockfile.c
+2 -2
View File
@@ -224,7 +224,7 @@ static int lockfilename(const char *lockfile, char *tmplock, size_t tmplocksz)
static int lockfile_create_save_tmplock(const char *lockfile,
char *tmplock, size_t tmplocksz,
volatile char **xtmplock,
int retries, int flags, struct lockargs_s_ *args)
int retries, int flags, const struct lockargs_s_ *args)
{
struct stat st, st1;
char pidbuf[40];
@@ -381,7 +381,7 @@ static int lockfile_create_save_tmplock(const char *lockfile,
#ifdef LIB
static
#endif
int lockfile_create_set_tmplock(const char *lockfile, volatile char **xtmplock, int retries, int flags, struct lockargs_s_ *args)
int lockfile_create_set_tmplock(const char *lockfile, volatile char **xtmplock, int retries, int flags, const struct lockargs_s_ *args)
{
char *tmplock;
int r, e;
solenv/lockfile/lockfile.h
+1 -1
View File
@@ -63,7 +63,7 @@ int check_sleep(int, int);
#endif
int is_maillock(const char *lockfile);
int lockfile_create_set_tmplock(const char *lockfile, volatile char **tmplock,
int retries, int flags, struct lockargs_s_ *);
int retries, int flags, const struct lockargs_s_ *);
#ifdef __cplusplus
}
svx/source/form/filtnav.cxx
+1 -1
View File
@@ -1321,7 +1321,7 @@ std::unique_ptr<weld::TreeIter> FmFilterNavigator::FindEntry(const FmFilterData*
return nullptr;
}
void FmFilterNavigator::Insert(FmFilterData* pItem, int nPos)
void FmFilterNavigator::Insert(const FmFilterData* pItem, int nPos)
{
const FmParentData* pParent = pItem->GetParent() ? pItem->GetParent() : m_pModel.get();
svx/source/form/navigatortree.cxx
+1 -1
View File
@@ -608,7 +608,7 @@ namespace svxform
}
}
std::unique_ptr<weld::TreeIter> NavigatorTree::Insert(FmEntryData* pEntryData, int nRelPos)
std::unique_ptr<weld::TreeIter> NavigatorTree::Insert(const FmEntryData* pEntryData, int nRelPos)
{
// insert current entry
std::unique_ptr<weld::TreeIter> xParentEntry = FindEntry( pEntryData->GetParent() );
svx/source/inc/filtnav.hxx
+1 -1
View File
@@ -273,7 +273,7 @@ private:
void DeleteSelection();
std::unique_ptr<weld::TreeIter> FindEntry(const FmFilterData* pItem) const;
void Insert(FmFilterData* pItem, int nPos);
void Insert(const FmFilterData* pItem, int nPos);
void Remove(FmFilterData const * pItem);
DECL_LINK(OnRemove, void*, void);
svx/source/inc/fmexpl.hxx
+1 -1
View File
@@ -409,7 +409,7 @@ namespace svxform
FmControlData* NewControl(const OUString& rServiceName, const weld::TreeIter& rParentEntry, bool bEditName);
void NewForm(const weld::TreeIter& rParentEntry);
std::unique_ptr<weld::TreeIter> Insert(FmEntryData* pEntryData, int nRelPos);
std::unique_ptr<weld::TreeIter> Insert(const FmEntryData* pEntryData, int nRelPos);
void Remove( FmEntryData* pEntryData );
svx/source/styles/ColorSets.cxx
+3 -3
View File
@@ -33,7 +33,7 @@ namespace
{
/// Updates a text portion to match a new color set, in case it already uses theme colors.
void UpdateTextPortionColorSet(const uno::Reference<beans::XPropertySet>& xPortion,
svx::ColorSet& rColorSet)
const svx::ColorSet& rColorSet)
{
sal_Int16 nCharColorTheme = -1;
xPortion->getPropertyValue(UNO_NAME_EDIT_CHAR_COLOR_THEME) >>= nCharColorTheme;
@@ -63,7 +63,7 @@ void UpdateTextPortionColorSet(const uno::Reference<beans::XPropertySet>& xPorti
uno::makeAny(static_cast<sal_Int32>(aColor)));
}
void UpdateFillColorSet(const uno::Reference<beans::XPropertySet>& xShape, svx::ColorSet& rColorSet)
void UpdateFillColorSet(const uno::Reference<beans::XPropertySet>& xShape, const svx::ColorSet& rColorSet)
{
if (!xShape->getPropertySetInfo()->hasPropertyByName(UNO_NAME_FILLCOLOR_THEME))
{
@@ -318,7 +318,7 @@ std::unique_ptr<Theme> Theme::FromAny(const css::uno::Any& rVal)
return pTheme;
}
void Theme::UpdateSdrPage(SdrPage* pPage)
void Theme::UpdateSdrPage(const SdrPage* pPage)
{
for (size_t nObject = 0; nObject < pPage->GetObjCount(); ++nObject)
{
svx/source/svdraw/svdoedge.cxx
+1 -1
View File
@@ -1991,7 +1991,7 @@ OUString SdrEdgeObj::getSpecialDragComment(const SdrDragStat& rDrag) const
}
basegfx::B2DPolygon SdrEdgeObj::ImplAddConnectorOverlay(SdrDragMethod& rDragMethod, bool bTail1, bool bTail2, bool bDetail) const
basegfx::B2DPolygon SdrEdgeObj::ImplAddConnectorOverlay(const SdrDragMethod& rDragMethod, bool bTail1, bool bTail2, bool bDetail) const
{
basegfx::B2DPolygon aResult;
svx/source/svdraw/svdundo.cxx
+1 -1
View File
@@ -972,7 +972,7 @@ OUString SdrUndoObjOrdNum::GetComment() const
return ImpGetDescriptionStr(STR_UndoObjOrdNum);
}
SdrUndoSort::SdrUndoSort(SdrPage & rPage,
SdrUndoSort::SdrUndoSort(const SdrPage & rPage,
::std::vector<sal_Int32> const& rSortOrder)
: SdrUndoAction(rPage.getSdrModelFromSdrPage())
, m_OldSortOrder(rSortOrder.size())
sw/inc/textboxhelper.hxx
+1 -1
View File
@@ -176,7 +176,7 @@ public:
/// Collect all textboxes of the group given by the pGroupObj Parameter. Returns with a
/// vector filled with the textboxes.
static std::vector<SwFrameFormat*> CollectTextBoxes(SdrObject* pGroupObject,
static std::vector<SwFrameFormat*> CollectTextBoxes(const SdrObject* pGroupObject,
SwFrameFormat* pFormat);
};
sw/source/core/doc/textboxhelper.cxx
+1 -1
View File
@@ -1602,7 +1602,7 @@ void SwTextBoxHelper::synchronizeGroupTextBoxProperty(bool pFunc(SwFrameFormat*,
}
}
std::vector<SwFrameFormat*> SwTextBoxHelper::CollectTextBoxes(SdrObject* pGroupObject,
std::vector<SwFrameFormat*> SwTextBoxHelper::CollectTextBoxes(const SdrObject* pGroupObject,
SwFrameFormat* pFormat)
{
std::vector<SwFrameFormat*> vRet;
sw/source/core/edit/edlingu.cxx
+4 -4
View File
@@ -122,11 +122,11 @@ class SwSpellIter : public SwLinguIter
bool m_bBackToStartOfSentence;
void CreatePortion(uno::Reference< XSpellAlternatives > const & xAlt,
linguistic2::ProofreadingResult* pGrammarResult,
const linguistic2::ProofreadingResult* pGrammarResult,
bool bIsField, bool bIsHidden);
void AddPortion(uno::Reference< XSpellAlternatives > const & xAlt,
linguistic2::ProofreadingResult* pGrammarResult,
const linguistic2::ProofreadingResult* pGrammarResult,
const SpellContentPositions& rDeletedRedlines);
public:
SwSpellIter()
@@ -1533,7 +1533,7 @@ static LanguageType lcl_GetLanguage(SwEditShell& rSh)
/// create a text portion at the given position
void SwSpellIter::CreatePortion(uno::Reference< XSpellAlternatives > const & xAlt,
linguistic2::ProofreadingResult* pGrammarResult,
const linguistic2::ProofreadingResult* pGrammarResult,
bool bIsField, bool bIsHidden)
{
svx::SpellPortion aPortion;
@@ -1574,7 +1574,7 @@ void SwSpellIter::CreatePortion(uno::Reference< XSpellAlternatives > const & xAl
}
void SwSpellIter::AddPortion(uno::Reference< XSpellAlternatives > const & xAlt,
linguistic2::ProofreadingResult* pGrammarResult,
const linguistic2::ProofreadingResult* pGrammarResult,
const SpellContentPositions& rDeletedRedlines)
{
SwEditShell *pMySh = GetSh();
sw/source/filter/ww8/docxattributeoutput.cxx
+3 -3
View File
@@ -622,7 +622,7 @@ void SdtBlockHelper::DeleteAndResetTheLists()
m_bHasId = false;
}
void SdtBlockHelper::WriteSdtBlock(::sax_fastparser::FSHelperPtr& pSerializer, bool bRunTextIsOn, bool bParagraphHasDrawing)
void SdtBlockHelper::WriteSdtBlock(const ::sax_fastparser::FSHelperPtr& pSerializer, bool bRunTextIsOn, bool bParagraphHasDrawing)
{
if (m_nSdtPrToken <= 0 && !m_pDataBindingAttrs.is() && !m_bHasId)
return;
@@ -686,7 +686,7 @@ void SdtBlockHelper::WriteSdtBlock(::sax_fastparser::FSHelperPtr& pSerializer, b
m_bHasId = false;
}
void SdtBlockHelper::WriteExtraParams(::sax_fastparser::FSHelperPtr& pSerializer)
void SdtBlockHelper::WriteExtraParams(const ::sax_fastparser::FSHelperPtr& pSerializer)
{
if (m_nSdtPrToken == FSNS(XML_w, XML_id) || m_bHasId)
//Word won't open a document with an empty id tag, we fill it with a random number
@@ -720,7 +720,7 @@ void SdtBlockHelper::WriteExtraParams(::sax_fastparser::FSHelperPtr& pSerializer
pSerializer->singleElementNS(XML_w, XML_alias, FSNS(XML_w, XML_val), m_aAlias);
}
void SdtBlockHelper::EndSdtBlock(::sax_fastparser::FSHelperPtr& pSerializer)
void SdtBlockHelper::EndSdtBlock(const ::sax_fastparser::FSHelperPtr& pSerializer)
{
pSerializer->endElementNS(XML_w, XML_sdtContent);
pSerializer->endElementNS(XML_w, XML_sdt);
sw/source/filter/ww8/docxattributeoutput.hxx
+3 -3
View File
@@ -145,11 +145,11 @@ public:
void DeleteAndResetTheLists();
void WriteSdtBlock(::sax_fastparser::FSHelperPtr& pSerializer, bool bRunTextIsOn, bool bParagraphHasDrawing);
void WriteExtraParams(::sax_fastparser::FSHelperPtr& pSerializer);
void WriteSdtBlock(const ::sax_fastparser::FSHelperPtr& pSerializer, bool bRunTextIsOn, bool bParagraphHasDrawing);
void WriteExtraParams(const ::sax_fastparser::FSHelperPtr& pSerializer);
/// Closes a currently open SDT block.
void EndSdtBlock(::sax_fastparser::FSHelperPtr& pSerializer);
void EndSdtBlock(const ::sax_fastparser::FSHelperPtr& pSerializer);
void GetSdtParamsFromGrabBag(const uno::Sequence<beans::PropertyValue>& aGrabBagSdt);
};
ucb/source/ucp/webdav-curl/DAVSessionFactory.cxx
+1 -1
View File
@@ -76,7 +76,7 @@ rtl::Reference< DAVSession > DAVSessionFactory::createDAVSession(
}
}
void DAVSessionFactory::releaseElement( DAVSession * pElement )
void DAVSessionFactory::releaseElement( const DAVSession * pElement )
{
assert( pElement );
std::unique_lock aGuard( m_aMutex );
ucb/source/ucp/webdav-curl/DAVSessionFactory.hxx
+1 -1
View File
@@ -64,7 +64,7 @@ private:
std::mutex m_aMutex;
std::unique_ptr<ucbhelper::InternetProxyDecider> m_xProxyDecider;
void releaseElement(DAVSession* pElement);
void releaseElement(const DAVSession* pElement);
friend class DAVSession;
};
writerfilter/source/dmapper/PropertyMap.cxx
+1 -1
View File
@@ -882,7 +882,7 @@ void SectionPropertyMap::CopyHeaderFooterTextProperty( const uno::Reference< bea
}
// Copy headers and footers from the previous page style.
void SectionPropertyMap::CopyHeaderFooter( DomainMapper_Impl& rDM_Impl,
void SectionPropertyMap::CopyHeaderFooter( const DomainMapper_Impl& rDM_Impl,
const uno::Reference< beans::XPropertySet >& xPrevStyle,
const uno::Reference< beans::XPropertySet >& xStyle,
bool bOmitRightHeader,
writerfilter/source/dmapper/PropertyMap.hxx
+1 -1
View File
@@ -299,7 +299,7 @@ private:
void CopyLastHeaderFooter( bool bFirstPage, DomainMapper_Impl& rDM_Impl );
static void CopyHeaderFooter( DomainMapper_Impl& rDM_Impl,
static void CopyHeaderFooter( const DomainMapper_Impl& rDM_Impl,
const css::uno::Reference< css::beans::XPropertySet >& xPrevStyle,
const css::uno::Reference< css::beans::XPropertySet >& xStyle,
bool bOmitRightHeader = false, bool bOmitLeftHeader = false,