ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
474,272 Commits 3 Branches 3 Tags
29578ae1394de2fffae2e34326d03d81b4c4f475
Commit Graph
3645 Commits
Author SHA1 Message Date
Noel Grandin 3e1e0af376 loplugin:stringviewparam convert methods using match 
which converts to a combination of substr and o3tl::starts_with

Change-Id: I5b01a181b9e6bee3483e4f49f1a9426abcc682d0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132458
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-04-03 10:01:48 +02:00
Stephan Bergmann a29f055491 -Werror,-Wunused-but-set-variable 
...since its uses got commented out with
a9cc010064 "chart2: Weld ChartTypePanel"

Change-Id: I5296ba7ed746df13e8174063f148ff2ce970756c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132224
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2022-03-28 20:07:19 +02:00
Julien Nabet 70cda6eff0 tdf#148157: assertion after set "Between tick marks", click outside the chart 
See bt here:
https://bugs.documentfoundation.org/attachment.cgi?id=179065

Change-Id: Id21f52d5cc33bbe99c27b7a8bdff056249c4d4fb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132027
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2022-03-25 11:33:54 +01:00
Michael Weghorn fe09f12d83 chart a11y: Drop bSendGlobally param from AccessibleBase::BroadcastAccEvent 
Setting it didn't have any effect in practice:
If set to `true`, it resulted in
`vcl::unohelper::NotifyAccessibleStateEventGlobally` getting
called, which calls
`XExtendedToolkit::fireFocusGained` or
`XExtendedToolkit::fireFocusLost`, but the only implementations
in `VCLXToolkit` do nothing.

Interestingly, the documentation for `XExtendedToolkit` in
`offapi/com/sun/star/awt/XExtendedToolkit.idl` says:

>    @deprecated
>        This interface was only implemented in an intermediate developer
>        release anyway.
>
>    @since OOo 1.1.2

but the interface is still used in various places across the
code base...

Change-Id: I4681c28c9d18cf1953be5127765f4aa94563662d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131735
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2022-03-18 13:21:00 +01:00
Dennis Francis 64631ddcf3 lokCalcRTL: chart-edit: no bounding box 
Fix for selections(svx-marks) similar to the fix for chart edit mode
tile painting

```
4fd2a14c6ee68f0574766ec7ec3dca35debe9d20
lokCalcRTL: global RTL: fix chart edit mode rendering
```

Conflicts:
	chart2/source/controller/main/ChartController.cxx

Change-Id: I2b5a2af7023b09254b8471b750122bec10126bde
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131091
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131572
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
 2022-03-15 08:28:46 +01:00
Noel Grandin 69b5f0b657 loplugin:constparams 
Change-Id: I5f184f93dbdb414514855c85c9dc1624e7ec8636
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131337
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-03-11 10:05:39 +01:00
Mike Kaganski dcd5fa0a7b Drop misguided test added in 82a1d32d3d 
The documented precondition is that index must not be greater than
the length of string. Just assert that, and fix the found misuse.

The added test is for in-place replacement, just in case.

Change-Id: I3c545a6f0bf913fe93e2bef83ce733359c193065
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131232
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
 2022-03-09 14:04:03 +01:00
Noel Grandin 6f652725fc make some svx methods const 
Change-Id: If04a160c46b8dbf641ca9d115d1560f17e87ce4d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131043
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-03-05 11:59:04 +01:00
Noel Grandin 3e23161baf use SfxItemSet::GetItemIfSet in chart2 
Change-Id: I1e5eeb8b29d2139a9c3e72c645bae9a8fb5dffff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130664
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-28 11:00:05 +01:00
Noel Grandin 2baf13e903 use more TypedWhichId 
Change-Id: I6ab3ca829bc08e672736dd8dd41ba714d7172090
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130498
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-24 19:31:38 +01:00
Caolán McNamara e63ad6a136 cid#1500434 Dereference after null check 
Change-Id: I10d7c70c40a41301752854b898d8d763ec6d6b72
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130485
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2022-02-24 13:06:58 +01:00
Caolán McNamara ea1600eb54 Resolves: tdf#147292 the area of the tooltip is wrong 
gen happens to make use of the current mouse point so it gets shown
anyway while gtk uses the designated area which isn't in the expected
units or screen relative positions

Change-Id: I11fdb09ad4ce2965d2f2e27fb1427c9d93de7a99
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130442
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2022-02-23 19:02:10 +01:00
Caolán McNamara 1af6ac5448 cid#1500434 Dereference after null check 
Change-Id: I1a9531446fbd5f977d02775f5d25696aba16287d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130431
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2022-02-23 14:56:00 +01:00
Caolán McNamara efa6c3db72 cid#1500643 Dereference before null check 
Change-Id: I1456b9a935c167344e0a56c7339da2c702a43e0b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130419
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2022-02-23 12:16:39 +01:00
Caolán McNamara ff215479a8 cid#1500515 Dereference after null check 
Change-Id: I6483c3a036c5c56c8c6515b5b8f08720c8bd1a6b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130269
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2022-02-21 18:45:12 +01:00
Caolán McNamara a9a4b82c9f cid#1500458 Dereference after null check 
Change-Id: Ic9626b0817ee65fbc6d68592c592c3c2e39d42e8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130267
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2022-02-21 14:45:45 +01:00
Noel Grandin 99b13eed21 loplugin:unusedfields 
Change-Id: I07ec409ea3663e789b6505dbfc999666525ed97f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130062
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-17 13:39:29 +01:00
Noel Grandin 11a3e5707d tdf#147394 delete crash legend 
regression from
    commit 63e8c2ccd3
    Author: Noel Grandin <noelgrandin@gmail.com>
    Date:   Sat Jan 29 21:21:27 2022 +0200
    use more concrete types in chart2, Diagram

Change-Id: I6598bb7c116bd94272a805e77751aa8cf5dc174a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129882
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-13 19:48:14 +01:00
Noel Grandin c1c9071dd5 crashtesting ooo#ooo83229-2 
this reverts part of
  commit b314b5a061
  use more concrete types in chart2, DataSeries
since writer uses it's own implementation of the XLabeledDataSequence
UNO interface

Change-Id: I52154dcee104ca17bfa63a3a8b11ef739cef147f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129772
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-10 11:42:58 +01:00
Noel Grandin 5477193c9c use more concrete types in chart2, SvxShape 
Change-Id: I9ae954f8efaec31d5b848c633e66adb62a13f3f4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129737
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-10 07:49:56 +01:00
Noel Grandin 7c62e59587 use more concrete types in chart2, Axis 
Change-Id: Ia47fd6deedd0a1cf6bedc882cb9817206dfa88b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129690
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-09 07:34:22 +01:00
Noel Grandin 6e800111d6 use more concrete types in chart2, DataSource 
Change-Id: I513491e8d39ee79edf8521d279bd32031cf22a93
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129687
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-09 07:32:09 +01:00
Noel Grandin b314b5a061 use more concrete types in chart2, DataSeries 
Change-Id: I80bc8961832a20c29b31f7618b9d2609f15ab3c2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129642
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-08 08:52:11 +01:00
Noel Grandin d9ff5556e7 use more concrete types in chart2, DataSeries 
Change-Id: If92f6ff6f90d53a9dc6211fd9f071d4d3fce2997
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129535
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-07 18:28:05 +01:00
Noel Grandin 372f590220 crashtesting ooo#20372 
this reverts parts of the "use more concrete types in chart2,
LabeledDataSequence" commits, since writer uses it's own implementation
of the XLabeledDataSequence UNO interface

Change-Id: Icc2c5e9a38f789cddd9fbca63301397ce759fbff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129587
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-07 11:21:24 +01:00
VaibhavMalik4187 8b327cd86d tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro 
Change-Id: I4f5258ca5b37e9b1b4237c5d29e4a9e5362fa855
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129116
Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
 2022-02-06 21:38:32 +01:00
Noel Grandin 333ccb081b use more concrete types in chart2, Axis 
Change-Id: If80b6487ad2b8ac75f98f798b839aff2b8a5c23e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129522
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-05 20:39:03 +01:00
Noel Grandin f7016b59dd use more concrete types in chart2, LabeledDataSequence 
Change-Id: I50b23923c1aa946f2c448534719a6c18003592a1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129521
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-05 17:37:01 +01:00
Caolán McNamara e00032ba6a add toId/fromId to tidy up some ugly casting 
Change-Id: I70f34ac5e9b5d2f2d6c0375e823908eaa2e540b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129487
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2022-02-04 15:02:03 +01:00
Noel Grandin ccbd2b0c66 use more concrete types in chart2, LabeledDataSequence 
Change-Id: Iecc22ad488fff7d0536ffa37f4cde7da460c2c7d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129458
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-04 14:40:10 +01:00
Noel Grandin fc03ef1e02 use more concrete types in chart2, LabeledDataSequence 
Change-Id: I88d5b7e045814cbd40750ebe927e6a76d5a463d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129456
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-04 12:20:00 +01:00
Noel Grandin 3c2192c840 use more concrete types in chart2, DataSeries 
Change-Id: I51a30d2a6a3c424dcdc29b6647aa2b67fa35884a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129455
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-04 08:40:49 +01:00
Noel Grandin 8f67e2633a tools::Long -> sal_Int32 
Change-Id: Ife7fc63f4ad0f3dcd34c9079d74044bae7924988
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129403
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-03 17:12:27 +01:00
Noel Grandin 6b14014342 make css::chart2::InterpretedData a normal struct 
this is internal-only, no need for it to use UNO IDL

Change-Id: I5f9844f48640618ac5bd348721bdee43e5f0a57f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129303
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-03 14:26:22 +01:00
Noel Grandin 9903e1f495 use more concrete types in chart2, RegressionCurveModel 
Change-Id: I0efecc48c63dc0fc62372eff7e9d5471666346b1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129302
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-02 09:59:18 +01:00
Noel Grandin 9706ddb47c use more concrete types in chart2, RegressionCurveModel 
Change-Id: I844238da0ce0ce4aea308c652c341efa540149a2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129234
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-01 08:28:02 +01:00
Noel Grandin 9f36eba170 use more concrete types in chart2, DataSeries 
Change-Id: I561d3d04cd534a30e774b0ed3fe1fb927a40c8df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129184
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-01-31 14:50:19 +01:00
Noel Grandin 47bbacb2b1 use more concrete types in chart2, DataSeries 
Change-Id: Ib07ed6ec3321dc617cfec872d16683cf5de60907
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129181
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-01-31 10:39:29 +01:00
Noel Grandin 63e8c2ccd3 use more concrete types in chart2, Diagram 
Change-Id: Ieaee7c8381c19e3bfd3560d2f674bebf49afac56
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129156
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-01-30 10:13:30 +01:00
Noel Grandin 56c3cc776a use more getChartModel in ChartController 
avoids some unnecessary dynamic_cast

Change-Id: I7389fd793c295d52cb6eb1b946199a2887544512
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129154
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-01-30 07:10:06 +01:00
Noel Grandin c3d5c9a08d used TypedWhichId in the constructor of various svx *Item classes 
to act as an extra check that we have the association of Item and
TypedWhichId annotations correct.

(*) requires that I add an upcasting constructor to TypedWhichId

(*) Make the field dialog stuff in writer use a new item id
FN_FIELD_DIALOG_DOC_PROPS instead of abusing the
existing SID_DOCINFO

Change-Id: Ica4aea930c80124609a063768c9af5a189df1c27
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129098
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-01-29 18:59:53 +01:00
Noel Grandin 2781c7a50f use more concrete types in chart2, Legend 
Change-Id: Ifbf8ddd92eacd4caaf6fdaa061821222e543a1a6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129133
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-01-29 15:51:30 +01:00
Noel Grandin 1be7f03c8f use more concrete types in chart2, ChartType 
Change-Id: I78fe27e14993b7a6e5d27662282241b3007ac03e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129113
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-01-29 12:52:43 +01:00
Noel Grandin 00e28abcd3 use more concrete types in chart2, BaseCoordinateSystem 
Change-Id: Ieb815775e069dd0d2cc36a2ab97b318e3b9f7a1b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129056
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-01-28 09:04:55 +01:00
Noel Grandin 4abb554b16 no need to call GetWhich on these SID_ values 
none of them are remapped (via the SfxItemEntryInfo stuff in the pool)

Change-Id: Ic4f1b13e1f35f7e67195a12c727ea2f088f8ddc7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129060
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-01-28 08:28:31 +01:00
Noel Grandin 59b6ffb381 use more concrete types in chart2, BaseCoordinateSystem 
Change-Id: I28b2af18ebd073701b4f8d3e9161d242396ce44a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129055
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-01-28 08:20:14 +01:00
Noel Grandin 883ae88f29 use more concrete types in chart2, BaseCoordinateSystem 
Change-Id: Iacbca66dbb5cfe617c5e8ca25796a7261f1ce10d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129053
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-01-27 19:45:32 +01:00
Caolán McNamara a951590bfb let SfxDispatcher::fillPopupMenu operate on css::awt::XPopupMenu 
rather than need to be passed its internal PopupMenu

Change-Id: Iff1106b80b71602cf8b77361086517f0e8f11c6c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129052
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2022-01-27 18:26:32 +01:00
Noel Grandin 93933e5f4e use more concrete types in chart2, BaseCoordinateSystem 
Change-Id: I98890707708f2b6161e52ef5c1563cceb6e3e56a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129000
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-01-27 07:40:50 +01:00
Noel Grandin a12b65360b use more concrete types in chart2, Diagram 
Change-Id: I768983241bf277d3b7688dca12a1ab441ac2373d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128999
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-01-27 07:40:37 +01:00