Not necessary, Word doesn't export it, and OOXML
validator complains about the test doc if val attribute
is present with true value:
{"Description":"The attribute
'http://schemas.openxmlformats.org/wordprocessingml/2006/main:val'
has invalid value 'true'. The Enumeration constraint failed.",
"Path":{"Namespaces":{},"XPath":
"/w:document[1]/w:body[1]/w:tbl[2]/w:tr[1]/w:trPr[1]/w:cantSplit[1]",
"PartUri":"/word/document.xml"},
"Id":"Sch_AttributeValueDataTypeDetailed","ErrorType":"Schema"}
Change-Id: I964320ea2ef6b48795224ac14545a2eaf4a3b5bc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202396
Tested-by: Jenkins
Reviewed-by: Aron Budea <aron.budea@collabora.com>
The previous implementation used integer math with a factor of 25,
leading to significant rounding errors. For example, a standard
96 DPI image was incorrectly calculated as 94 DPI.
This patch improves precision by:
- Using a double-precision factor of 25.4 (2540.0 to account for
coordinate scaling).
- Using std::round() instead of truncation to find the nearest
integer DPI.
- Adding a safety check to prevent division by zero if
rMtfSizeLog dimensions are missing.
This ensures that EMF+ files exported from LibreOffice have
the correct physical scale metadata.
Change-Id: I82c8b8f7e2137f6713b1081ec3e0e596453c741a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202537
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
Fixed a missing trhing in DiagramDataState used by
SdrUndoDiagramModelData. The BGShapeID was not restored,
so after copy/paste and change and Undo the BGShape could
not be associated and loose it's FillState ModelData.
Simplified Point/Connection Im/Export for own format.
No need to read/write NumOfPt/Cn at all. No need to
read/write Pt#/Cn# at all. Simplified AFAP before this
will be used when feature is activated.
Change-Id: I6fca23964df708a5da13fdb620376b7a5684e1a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202582
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
Tested-by: Jenkins
This is safe to ignore both, when one of them empty, as opposed to a
case when both are non-empty, but have different number of elements.
Allows to read some broken real-life documents.
A possible TODO: maybe consider to warn about a broken package, and
only open in repair mode?
Change-Id: I0697dcc73933aa1761ba59a766a519965872a0ed
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202552
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Commit 92e7f28f9a (Related: tdf#104718
Use package repair request and behavior, 2023-11-29) made repaired
documents behave like templates, requiring user to explicitly choose
a name on save.
Since switching to template mode happens in this case rather late in
the loading procedure, at this point, lock file is already created
for the original file. Switching to template mode clears media URL;
and after that, media can't remove the lockfile.
This change releases the lock (and removes the lockfile) prior to
clearing URL.
Change-Id: Ibd4794e2b82dc8e1b1c96e22fa2089b9dd597744
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202521
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
To mimic plain text paste behaviour for markdown as it is just
plain text with some additional formatting elements.
Changed the type of DataFlavor from cppu::UnoType<Sequence<sal_Int8>>::get() to
cppu::UnoType<OUString>::get() and the corresponding handling in sw/source/uibase/dochdl/swdtflvr.cxx
which allows us to use the same conditions for markdown as text/plaintext with utf16 encoding as
the mimetype for markdown is not detected on most of the system.
1. https://gerrit.libreoffice.org/c/core/+/187792: Initial commit which added markdown
into the clipboard registry with DataFlavor type as cppu::UnoType<Sequence<sal_Int8>>::get()
2. https://gerrit.libreoffice.org/c/core/+/188067: This patch introduced a new dialog
which added the feature to select between plain text and markdown when using paste special -> unformatted text.
After the previous patch the design team suggested to remove the dialog.
3. https://gerrit.libreoffice.org/c/core/+/191225: Removed the dialog and added heuristic
detection of markdown when pasting as plain text.
Backtracking to point 2: Mike Kaganski suggested to add markdown under paste special explicitly
removing the need of heuristic detection.
This is a followup patch for the previous suggestion.
----cherry pick note----
master and distro/collabora/co-25.04, distro/collabora/co-26.04
branches diverged while cherry-picking I423bfa356c337e7a6365beda0dcf1fff233f3edd
on 25.04 branch due to code review suggestions which introduced
an additional patch I44ffb00e240425701c4677bb58667141658845a5(this change)
being merged on distro/collabora branches.
This patch is to sync the changes between master and disto/collabora
branches.
Change-Id: I44ffb00e240425701c4677bb58667141658845a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199975
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/201493
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202306
Tested-by: Jenkins
... instead of by pointer.
This also allows to drop one superfluous null check
in SvLBoxButton::InitViewData.
Change-Id: Iefbfc4c701effefbc618f2eaa0b101edbd6ee176
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202346
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Add framework for import/export of chartex layout properties (cx:layoutPr).
Also support the child cx:binning property, used for clusteredColumn charts
(and perhaps others). This allows the binning property to round-trip
successfully MSO -> LO -> MSO.
Change-Id: I54bd1692ce4fb59dd70c9d4ac68f108c33cbca8a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199553
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Rename 25 tests in sw/qa/extras/autocorrect/autocorrect/cxx
The old test name was based on the original bug number only.
Rename it to actually reflect the tested behavior
No functional change
Change-Id: I6ffcac08d56c9e60f36bd05cef3d353cecc91d6e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202292
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Regression from online.git commit
3cf8a2f1f161270fb0a85863bea1d5277e92eed3 (cool#10630 doc electronic
sign: fix outgoing mouse messages on 2nd page, 2025-01-27), click
somewhere on the 2nd page of a PDF file in LOK mode, the view jumps to
page 1, while nothing should happen.
This "worked" previously because the JS client had a bug and we sent an
out-of-page coordinate for the mouse click, so nothing happened, while
now it started text edit on the only graphic object on the page. One big
image for each page is the expected model for pdfium-based import
result, but adding text to images in a read-only view is not wanted.
Fix the problem by improving sd::FuDraw::DoubleClick() to check for
LokReadOnlyView next to the existing ReadOnly, which should improve
things in general for multiple LOK views where some of them are
read-only and others are read-write.
Change-Id: Id862c0e143366f7f6fec07576ef5bad8729a0a72
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202506
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
Changes the values of skew coefficients in PDFWriterImpl::drawVerticalGlyphs,
specifically fSkewA to 0 and fSkewB to fSkew. This fixes the text being
slanted differently in PDF export compared to Writer.
Change-Id: I04d193351089e0dc87a8e978ded771e135dbde7a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202319
Reviewed-by: Khaled Hosny <khaled@libreoffice.org>
Tested-by: Jenkins
Mike Kaganski