ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
520,958 Commits 3 Branches 3 Tags
main
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Takeshi Abe 017c6150e9 tdf#128892 Give menu "Rename Sheet" an alternative mnemonic H 
... to avoid the duplicate R for "Insert Rows".

Change-Id: Ie2e0faf566ba5f85e4b2a72c289a4320e580f7f9
Reviewed-on: https://gerrit.libreoffice.org/83368
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
 2019-11-22 16:04:45 +01:00
Takeshi Abe 86876ff86e sc: the type is not Data, but Date 
Change-Id: I32105e1f40ddb0c206d62f30f66054b7dbe803d0
Reviewed-on: https://gerrit.libreoffice.org/74594
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
 2019-07-08 10:03:25 +02:00
Takeshi Abe 93eeaf0ad9 tdf#120047 Support attribute harpoon/wideharpoon in Math 
... for an alternative style of vectors.

They are vec/widevec analogs but with COMBINING RIGHT HARPOON ABOVE
(U+20D1).  The new attribute names are deliberately long in order to
make fewer accidental collisions with variable names in formulae of
exising documents.

This also adds a glyph uni20D1 to OpenSymbol.

Change-Id: I31666e57808aa0e0327500916d3b862549891886
Reviewed-on: https://gerrit.libreoffice.org/72987
Tested-by: Jenkins
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
 2019-06-13 05:11:25 +02:00
Takeshi Abe 932c1bd99f tdf#124936 Show "(x86)" in About dialog on the 32-bit version 
... installed on Windows.

Change-Id: I2a4d846265b69f0e46e4c711430689ce39d60fcd
Reviewed-on: https://gerrit.libreoffice.org/73211
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Tested-by: Michael Stahl <Michael.Stahl@cib.de>
 2019-05-31 11:29:35 +02:00
Takeshi Abe 5fbd5c9ba9 tdf#116431 Make the string "LibreOffice (Safe Mode)" translatable 
Change-Id: I29f68f16c228c46841a7a3a50bb6dfe4f703403f
Reviewed-on: https://gerrit.libreoffice.org/72212
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2019-05-15 12:38:30 +02:00
Takeshi Abe 88d46ba32e tdf#119890 followup: Forbid HOME to be the default dir 
... of user templates

This is kludgy yet better than making innocent users waiting for
the template dialog ~forever as pointed out in the comments in
<https://gerrit.libreoffice.org/#/c/67741/>.

Change-Id: I6dfdc0408effb06cc9175cd976ea6687e52a7136
Reviewed-on: https://gerrit.libreoffice.org/69883
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-04-13 14:59:48 +02:00
Takeshi Abe 03b3562a91 filter: inline PptFontCollection to avoid inheritance of std::vector 
Change-Id: Ib431f6f69dc3da958629f54d6d2a1ce76b9d63a5
Reviewed-on: https://gerrit.libreoffice.org/69108
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-04-12 10:49:10 +02:00
Takeshi Abe 597c5d75b8 Introduce next Japanese gengou era 'Reiwa' 
starting from 2019-05-01, which has been announced officially.

This fills the provisional slot acknowledged at
cacbb0faef.

Change-Id: Ifb12e6afaad4c66d455f664b46ec946e80324e87
Reviewed-on: https://gerrit.libreoffice.org/70028
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
 2019-04-02 22:54:49 +02:00
Takeshi Abe 9c607b61f4 tdf#114311 Translate "LibreOffice Extension" file type in Windows 
Change-Id: I5e2f222449424d4a6498d8566f13aca7f07c0c51
Reviewed-on: https://gerrit.libreoffice.org/68303
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>
 2019-03-29 13:18:03 +01:00
Takeshi Abe 97b78d77eb filter: Replace needless std::deque with simpler std::vector 
Change-Id: I95ffde095909b925531a9bb1a3f0d394ba8d5c80
Reviewed-on: https://gerrit.libreoffice.org/69267
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-03-16 07:17:45 +01:00
Takeshi Abe 96af93e5df Fix typo: KATAGANA -> KATAKANA 
No functional change offered, but this reduces some amount of confusion.
Japanese word "Katakana" ("kata" + "kana") does not undergo Rendaku [1]
while "Hiragana" ("hira" + "kana") does.

[1] https://en.wikipedia.org/wiki/Rendaku

Change-Id: I07824147d72397c312a0774eca1fdcc7549abc59
Reviewed-on: https://gerrit.libreoffice.org/68661
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2019-03-04 12:16:53 +01:00
Takeshi Abe 41e56742d0 Link https://www.libreoffice.org in LICENSE 
... instead of the http one.

Change-Id: Id66c3212bd56f7cb33501d834c26d70cafafc0d7
Reviewed-on: https://gerrit.libreoffice.org/68189
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
 2019-02-25 02:10:56 +01:00
Takeshi Abe 3a6d425818 tdf#120361 Store Berend_Ilko_Tom_Stella_Volker.stc as temporary 
... at invoking uno:ChooseDesign, instead of saving it into user's
working directory.

Change-Id: I899b259faca7fbc6ba2f5cc4ac8638f34e5febc6
Reviewed-on: https://gerrit.libreoffice.org/66672
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
 2019-02-19 17:50:02 +01:00
Takeshi Abe 91731a8674 tdf#119890 Lookup XDG_(DOCUMENTS|TEMPLATES)_DIR correctly 
... for My Documents and My Templates.

It seems customary to name XDG_*_DIR in all uppercase.  This also
fixes buffer overrun IIUC, as osl_readLine() does not return the
newline delimiter.

Change-Id: If85ca7e6abe663e29d36b65a08d358d3d7d27c4b
Reviewed-on: https://gerrit.libreoffice.org/67741
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-02-13 10:02:02 +01:00
Takeshi Abe 0ca822c95a sc: Fix CJK Unified Ideographs range in comments 
i.e. 4E00-9FAF -> 4E00-9FFF.

According to <https://www.unicode.org/mail-arch/unicode-ml/y2003-m02/0351.html>,
the confusion was partly due to older Unicode specification.
As of Unicode 4.1 the trailing end (9FB0-9FFF) is in fact in use
by "CJK Additions": <https://www.unicode.org/versions/Unicode4.1.0/>

Change-Id: Ibd3704a81341743b3fa80686d3fcfc0bd11104ef
Reviewed-on: https://gerrit.libreoffice.org/67087
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
 2019-01-29 18:19:22 +01:00
Takeshi Abe 86501f5776 tdf#106678 Implement CSV filter option's 8th token 
... which decides whether number cells are stored as numbers
or quoted like strings, as documented in
<https://wiki.openoffice.org/wiki/Documentation/DevGuide/Spreadsheets/Filter_Options#Token_8.2C_csv_export>
but long unimplemented.

Note that in this implementation the false value of the above token
is superseded and ignored if either "Fixed column width" (1st token)
or "Save cell content as shown" (9th token) option is on.

Change-Id: Ib4ff02a2be81a8590e1fc249725f02cd83e91118
Reviewed-on: https://gerrit.libreoffice.org/65604
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
 2019-01-16 17:44:44 +01:00
Takeshi Abe 5669026f58 basegfx: Kill empty .cxx 
Change-Id: I5bf94400d787bd57396870878d3ae7bd1e36e22d
Reviewed-on: https://gerrit.libreoffice.org/66263
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-01-13 20:46:01 +01:00
Takeshi Abe 4bec85e561 sc: Drop empty reordermap.cxx 
Change-Id: I6d3183cf281363538c603d126660064a205cda5b
Reviewed-on: https://gerrit.libreoffice.org/66058
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2019-01-10 07:11:50 +01:00
Takeshi Abe 538ed5f348 basic: Spare temporary variable 
Change-Id: I6c39061e04537c01c87f6cb2f40a35dd0a551a08
Reviewed-on: https://gerrit.libreoffice.org/65597
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-12-26 08:13:42 +01:00
Takeshi Abe 58966e16d8 sc: Simplify RemoveSubTotalsHandler using std::set 
instead of std::vector.

Change-Id: I5927e061b5d2944cad68b96e313934738c63c321
Reviewed-on: https://gerrit.libreoffice.org/65400
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
 2018-12-20 17:02:52 +01:00
Takeshi Abe 320a77a314 sc: Use std::find() to simplify code 
Change-Id: I903a59591cd204556e873429280aac9cf8d5325a
Reviewed-on: https://gerrit.libreoffice.org/65067
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-12-13 07:32:21 +01:00
Takeshi Abe 791bb16967 sc: Peel off a pimpl 
Change-Id: I8797ccc165fb0a6060c6232babc299114411130a
Reviewed-on: https://gerrit.libreoffice.org/64707
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-12-07 14:14:07 +01:00
Takeshi Abe 1e6cc2c856 sc: Drop ineffective SetError() 
as GetNewMat() already sets error FormulaError::MatrixSize
when returning null.  In fact IllegalArgument is irrelevant
here.

Change-Id: Ib7354c2e861b666deef1353b2c26d876668d77e3
Reviewed-on: https://gerrit.libreoffice.org/64420
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-12-07 10:35:33 +01:00
Takeshi Abe e4c2d0bb57 i#32345 Support a matrix of rank argument for LARGE()/SMALL() 
This is a followup of e22ab5e6f6.

Change-Id: I7052e113173204f7cfcd40622f52c5d4e14b3aa9
Reviewed-on: https://gerrit.libreoffice.org/64139
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
 2018-11-30 22:14:17 +01:00
Takeshi Abe f5011d7226 sc: Calculate the value only once for micro-optimization 
Change-Id: I394bca979d4b914d6b6997837fab636b9bc4e479
Reviewed-on: https://gerrit.libreoffice.org/61879
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-17 07:33:50 +01:00
Takeshi Abe e22ab5e6f6 Resolves: i#32345 Make LARGE()/SMALL() return an array 
... if the second parameter is an array.

This change follows their specification in ODF 1.2.

Change-Id: I45c8923f462e9477e1234b47e39dcdd8d2198784
Reviewed-on: https://gerrit.libreoffice.org/62541
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
 2018-11-15 22:12:01 +01:00
Takeshi Abe eef0f6cd6b Mythes -> MyThes 
as seen in its README.

Change-Id: I0fef39484967e9de8dc7076fb3b7a2d0e55c801f
Reviewed-on: https://gerrit.libreoffice.org/63147
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>
 2018-11-12 21:08:48 +01:00
Takeshi Abe 2e184378da sc: Fix a wrong reference in a SMALL()'s test case 
Change-Id: I6eb5491cb437745a787304bde9f5673e63892773
Reviewed-on: https://gerrit.libreoffice.org/62380
Tested-by: Jenkins
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
 2018-10-30 02:43:56 +01:00
Takeshi Abe 10fff25227 sc: Let SKEW/SKEWP raise #!DIV/0 when < 3 numbers are given 
as ODF 1.2 mentions such constaints of these functions, and
Excel's documentation also admits it with more specific remark:
<https://support.office.com/en-us/article/skew-function-bdf49d86-b1ef-4804-a046-28eaea69c9fa>
<https://support.office.com/en-us/article/skew-p-function-76530a5c-99b9-48a1-8392-26632d542fcb>

Change-Id: If19350997ddcb6f0fb36e29e090e260c3ae3d262
Reviewed-on: https://gerrit.libreoffice.org/61130
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
 2018-10-15 13:39:30 +02:00
Takeshi Abe e785c027af sc: Make KURT() return #DIV/0! when <4 arguments are given 
as Excel does:
<https://support.office.com/en-us/article/kurt-function-bc3a265c-5da4-4dcb-b7fd-c237789095ab>

Change-Id: I1059e6e5dd9f01688219492e76af6dbbe97be41a
Reviewed-on: https://gerrit.libreoffice.org/61286
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
 2018-10-15 13:37:42 +02:00
Takeshi Abe 7f7e890a10 sd: micro-optimize SdPage::GetPresObj() by sorting less 
No need to sort all matched elements.

Change-Id: I4133b28a9c84ab322e55f9987859690e426f600c
Reviewed-on: https://gerrit.libreoffice.org/59691
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-09-28 13:33:46 +02:00
Takeshi Abe de65bb0f0d Let's calm down and end message with a period 
Change-Id: I14bbb49e7d7200785b0fb812b9719d030987cbc5
Reviewed-on: https://gerrit.libreoffice.org/60845
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
 2018-09-21 04:38:00 +02:00
Takeshi Abe dc139f0010 sc: Begin with upper case for labels of Number Transformation 
Change-Id: I28b9af112d48fb6a39b7d61af3b49ee43db957fb
Reviewed-on: https://gerrit.libreoffice.org/58953
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
 2018-09-18 17:42:02 +02:00
Takeshi Abe 9b0d2c5c3b sd: Drop unused ImplProcessObjectList() 
which could be gone at commit 174bbee548.

Change-Id: I2baa67123279f0da6f2443af6bfd351aaa9dfcd8
Reviewed-on: https://gerrit.libreoffice.org/60298
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-09-11 09:48:35 +02:00
Takeshi Abe 40e2c08856 svl: Avoid unnecessary indirection in SfxItemPropertySetInfo 
Change-Id: I56db3db23361590b5d2c09bc8f6f23a02ccd7f60
Reviewed-on: https://gerrit.libreoffice.org/59570
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-08-27 08:48:53 +02:00
Takeshi Abe 3d13da021a sw: Prefer std::vector to undemanded std::list 
Change-Id: I2003538f3a7cff2163cbb85f948c0bab9187dfeb
Reviewed-on: https://gerrit.libreoffice.org/59379
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-08-23 20:41:52 +02:00
Takeshi Abe e020cc8816 toolkit: a micro-optimization taking min and max simulnateously 
Change-Id: I161dd318b1e5729ef0b8c55a41c0eddc681b153f
Reviewed-on: https://gerrit.libreoffice.org/57612
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-08-19 14:48:27 +02:00
Takeshi Abe abb780094d sw: Replace std::list with std::vector for simplicity 
Change-Id: I239df7b0009711eeaf025221bec9c95887681c8d
Reviewed-on: https://gerrit.libreoffice.org/58918
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-08-17 22:13:17 +02:00
Takeshi Abe 992242a15c sc: Report #DIV/0! when MOD()'s divisor is 0 
as Excel does [1], while ODF 1.2 does not specify which kind of
error should be assigned for that case.

[1] https://support.office.com/en-us/article/mod-function-9b6cd169-b6ee-406a-a97b-edf2a9dc24f3

Change-Id: Id6ebf790ac407f2a8b8769fc0518f136a1271a3d
Reviewed-on: https://gerrit.libreoffice.org/58351
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
 2018-08-15 13:11:17 +02:00
Takeshi Abe d063bea958 sw: Reduce redundant copy 
Change-Id: Iee865bbbc5cbb98ba64305c6e90273ce3c719e6e
Reviewed-on: https://gerrit.libreoffice.org/58804
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-08-10 08:19:21 +02:00
Takeshi Abe fed411f4b6 sw: Replace std::list with std::vector for simplicity 
Change-Id: I91c4c1d53f1cea0aebbdc2cc1548cad86d5226a4
Reviewed-on: https://gerrit.libreoffice.org/58675
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-08-07 16:07:20 +02:00
Takeshi Abe 61a54ea68e sw: Prefer std::vector for SwLineOffsetArray to std::list 
as its instance adds an element only at the end, and no erase.

Change-Id: I41dc7c4d0f7d070b7ce0cef2e36ee73c05f342ae
Reviewed-on: https://gerrit.libreoffice.org/58635
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-08-06 08:53:03 +02:00
Takeshi Abe f30afe009e sc: Make CONFIDENCE.T() raise #DIV/0! when size is 1 
... for interoperability with Excel, as remarked in
<https://support.office.com/en-us/article/CONFIDENCE-T-function-E8ECA395-6C3A-4BA9-9003-79CCC61D3C53>.

Change-Id: I2d24573055455fa014c38f6e5985e3501ed6ba6e
Reviewed-on: https://gerrit.libreoffice.org/57322
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
 2018-07-26 02:00:14 +02:00
Takeshi Abe 07c934e3f1 sw: Change TextPortions to std::vector 
as its usage does not require std::deque.

Change-Id: I047e31972325a28f5ff92153e34893821e80fe57
Reviewed-on: https://gerrit.libreoffice.org/57898
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-07-24 08:40:14 +02:00
Takeshi Abe ba0e705b53 sw: Turn SwScriptInfo's m_HiddenChg into a std::vector 
as it is added only at its end.

Change-Id: I46731565ddf833b055ddd5dc9175638daef1e298
Reviewed-on: https://gerrit.libreoffice.org/57837
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-07-23 08:46:28 +02:00
Takeshi Abe e469ab0d9e sc: Compare vectors by simpler code 
Change-Id: I5efac4a449b388c2d8a6e47beb4a6a8fbfed909a
Reviewed-on: https://gerrit.libreoffice.org/57797
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-07-21 14:49:18 +02:00
Takeshi Abe f3df554636 sw: Change m_KashidaInvalid to std::unordered_set 
... for clarifying what is supposed to do, and doing it more
efficiently.
Actually this assumes that m_KashidaInvalid has no duplicate
entries, which I think is humble and sane.

Change-Id: I010d3d9788378b369b5b52a37a3824c8e415c2aa
Reviewed-on: https://gerrit.libreoffice.org/57611
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-07-18 10:46:37 +02:00
Takeshi Abe 972ff044ed sc: Drop #undef leftover 
Change-Id: I48bb3d8717319f8ac34a575037e15a1c41730448
Reviewed-on: https://gerrit.libreoffice.org/57542
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
 2018-07-17 12:31:22 +02:00
Takeshi Abe 65b1990687 sc: Add a test case for ZTEST() raising #DIV/0! 
... when the sample stddev is 0.

This follows up d17e8faa13.

Change-Id: I4ce718f60f1dbcf58fdcbbb553c345c9c8907a2b
Reviewed-on: https://gerrit.libreoffice.org/55741
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2018-07-13 21:59:19 +02:00
Takeshi Abe bd71dccb26 sc: Prefer std::vector to std::deque or std::stack 
as the queue is modified only by either appending or clear().

Change-Id: I6866c047eaf7149221c77ff4f1f3759dbf10492e
Reviewed-on: https://gerrit.libreoffice.org/57182
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-07-11 09:36:53 +02:00
Takeshi Abe 7e971b500f sc: Prefer std::vector to std::deque 
There seems no need for choosing deque in the first place
5099046dcc.

Change-Id: I194e6bee37d8f6f177aee96681b3014119aa11c1
Reviewed-on: https://gerrit.libreoffice.org/56997
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
 2018-07-05 19:00:13 +02:00
Takeshi Abe de7e83969b sc: Eliminate the case of MAXROWCOUNT_DEFINE <= 65536 
It is 1024*1024 since b3579d71c6.

Change-Id: I7f523f21229de8f4fa378aa85f124863a67b21c8
Reviewed-on: https://gerrit.libreoffice.org/56843
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2018-07-03 11:51:30 +02:00
Takeshi Abe e46df81b67 sc: A micro optimization of PERCENTILE() for interpolation cases 
As the leading std::nth_element() already partitions the vector,
all we have to do is to pick the minimum in its latter part.

Change-Id: I7767edc538819251c8fe9d26441ae57b06b2f865
Reviewed-on: https://gerrit.libreoffice.org/55575
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
 2018-07-03 11:50:08 +02:00
Takeshi Abe 123a4808dc scaddins: Drop unused stuff 
Change-Id: Icdbb297df55ed5984b4008e304a41df89a996334
Reviewed-on: https://gerrit.libreoffice.org/56523
Tested-by: Jenkins
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
 2018-07-02 07:43:19 +02:00
Takeshi Abe d6aa070267 sc: Replace DblMin() with std::min() 
Change-Id: Ic9ca0e9c1a63519026152f9aa1a038f183de1e4d
Reviewed-on: https://gerrit.libreoffice.org/56581
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2018-07-02 03:28:45 +02:00
Takeshi Abe 658ff424b8 sc: Spare an OUStringBuffer by replacing removeChars() 
... with OUString::replace().

Change-Id: I8d6ae6ff1674dafaafb276cb0efc72e01579f9bb
Reviewed-on: https://gerrit.libreoffice.org/56759
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-06-30 19:28:34 +02:00
Takeshi Abe b42c316fcf sd: Reduce the number of possible intermediate allocations 
... by reserving enough space at once.

As the length of these vectors depends/grows on user's input,
this change can be a micro optimization.

Change-Id: I1baa7d1433875491e86403d727f11f676d29a833
Reviewed-on: https://gerrit.libreoffice.org/56346
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-06-24 08:08:07 +02:00
Takeshi Abe 578e4eca82 sccomp: Reserve enough space at once for micro-optimization 
Change-Id: Ib4e178d2a0f09cb44854f1d1aad026d8394a8917
Reviewed-on: https://gerrit.libreoffice.org/56312
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2018-06-23 10:53:21 +02:00
Takeshi Abe 39180f706f sw: Allocate enough space at once for micro optimization 
Change-Id: Ibcf95f2ddeb7b0a9f08944d760beb40f2d8ae688
Reviewed-on: https://gerrit.libreoffice.org/56237
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-06-21 17:11:26 +02:00
Takeshi Abe c37b27af91 sw: Avoid unnecessary copy in SwAutoCompleteWord::GetWordsMatching() 
Its sole client code in sw/source/uibase/docvw/edtwin.cxx allows the
precondition that its 2nd argument rWords is empty.

This also corrects the @param description of the argument.

Change-Id: Icc12bc36d0d4157ed05ef10fb3c3db325c6bfaf2
Reviewed-on: https://gerrit.libreoffice.org/55943
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-06-17 14:27:18 +02:00
Takeshi Abe 615c269325 sc: These booleans are constant 
Change-Id: Ib5098cc38ca9fecfcf2d57e59573253b714f2df4
Reviewed-on: https://gerrit.libreoffice.org/55785
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-06-15 09:11:27 +02:00
Takeshi Abe d17e8faa13 sc: Make ZTEST() raise #DIV/0! when the sample stddev is 0 
because it is an actual division-by-zero error and Excel does.

Call for suggestion: I would like to add a test case to
sc/qa/unit/data/functions/statistical/fods/ztest.fods, but
do not know the right manner of adding it cleanly without
messing up other parts such as styles.

Change-Id: I79b99a6b7385177e94d75bb4e00d724332b9b8bf
Reviewed-on: https://gerrit.libreoffice.org/55152
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
 2018-06-11 13:00:42 +02:00
Takeshi Abe 9804cc4eff sc: ScHeaderFieldData always stores a datetime 
It does not change only the date part nor the time part
separately, thus holding single DateTime is sufficient.

Change-Id: Ic619608ce7a961287c299698b9a004cbf7038702
Reviewed-on: https://gerrit.libreoffice.org/54058
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
 2018-06-11 12:35:49 +02:00
Takeshi Abe d155f7af03 sc: A putative micro optimization of MEDIAN() for even-length arrays 
As the previous run of std::nth_element() already collects all of
smaller elements than the upper median into the first half of the
vector (which may also contain an equal one to the upper median,
that's OK), we can safely ignore the later half for finding the lower
median.

Change-Id: I64c97ee03b02ea363399077244dd99d0d10defcb
Reviewed-on: https://gerrit.libreoffice.org/55370
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
 2018-06-07 12:03:25 +02:00
Takeshi Abe db042b2a59 sc: Stop pushing an extra error 
as MustHaveParamCount() already does it when returning false.

Change-Id: Ia4f8998a2f65eea5e6be3fd21b5ca724d13770d0
Reviewed-on: https://gerrit.libreoffice.org/55265
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2018-06-05 17:21:54 +02:00
Takeshi Abe 4534da9dab sc: Insert a space for consistency 
Change-Id: Ifb1429eb3ad6d1093a7b5126ea3d15c4509cf8cc
Reviewed-on: https://gerrit.libreoffice.org/54981
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
 2018-05-30 14:44:35 +02:00
Takeshi Abe f122faeede basic: Avoid looking up system clock twice to get current datetime 
Change-Id: I3de322a420bdbbd7906160b97dca531dfe3092a4
Reviewed-on: https://gerrit.libreoffice.org/53929
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
 2018-05-28 11:32:14 +02:00
Takeshi Abe b4960947db xmlsecurity: Ask current datetime only once 
... and pass it as the sole argument to XMLSignatureHelper::SetDateTime().

Change-Id: I7f3e8dc90bb34ca347a1ad5a79717a338af3bed9
Reviewed-on: https://gerrit.libreoffice.org/54706
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-05-24 13:28:12 +02:00
Takeshi Abe 1091e786b4 vbahelper, xmloff: Ask current datetime only once 
Change-Id: I930983fab11d30f0887965fe30b07c5ac6eef8ef
Reviewed-on: https://gerrit.libreoffice.org/54651
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-05-22 08:45:04 +02:00
Takeshi Abe 338d5f14ba sw: Ask current datetime only once 
Change-Id: I99bed9a09ed1701ce441ddb0a19b5259ab37f135
Reviewed-on: https://gerrit.libreoffice.org/54621
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-05-21 20:42:55 +02:00
Takeshi Abe 622691b895 sc: Avoid looking up system clock twice to get current datetime 
Change-Id: I904067260c15263f8169f095809e642d0738f6bb
Reviewed-on: https://gerrit.libreoffice.org/53957
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-05-21 09:11:29 +02:00
Takeshi Abe 027b5a1483 svx: Avoid looking up system clock twice for current datetime 
Change-Id: I636ddfdaeac211ddc9de6b5dfe36cbdc32c7f7f2
Reviewed-on: https://gerrit.libreoffice.org/54509
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
 2018-05-20 04:53:26 +02:00
Takeshi Abe 84efa4087b sfx2: Avoid looking up system clock twice for current datetime 
Change-Id: If5d7bbd611321e6eee1c4bd9143af415c8a1671d
Reviewed-on: https://gerrit.libreoffice.org/54472
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
 2018-05-20 04:47:40 +02:00
Takeshi Abe 1de2b14b3f sd: Avoid looking up system clock twice for current datetime 
Change-Id: I777210723f4c41ee27e2d6497aa466640924d8b5
Reviewed-on: https://gerrit.libreoffice.org/54348
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
 2018-05-20 04:43:03 +02:00
Takeshi Abe 5103c6a405 tools: Avoid looking up system clock twice to get DateTime 
DateTime::DateTime(DateTimeInitSystem) had initialized Date and
Time separately, which causes a slight possibility that it could
get a wrong datetime with almost 24 hours delay when it went beyond
midnight. E.g., the date part was of the previous day while the
time part was 00:00:00.xxx of the next day.

This also reduces duplicate code by sharing GetSystemDateTime().

Change-Id: I352d90f468f5cbc70e7936a337bed97365baa06c
Reviewed-on: https://gerrit.libreoffice.org/53612
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
 2018-05-04 21:30:43 +02:00
Takeshi Abe d69a043b54 svx: These arrays are constant 
Change-Id: Icda32ea104888afa3e4e1064e25dad6825b83b99
Reviewed-on: https://gerrit.libreoffice.org/53383
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-04-26 11:41:53 +02:00
Takeshi Abe 5823ecd54b toolkit: Recover missing service names for ControlModelContainerBase 
namely:
com.sun.star.awt.UnoControlProgressBarModel
com.sun.star.awt.UnoControlScrollBarModel
com.sun.star.awt.UnoControlFixedLineModel
com.sun.star.awt.UnoControlRoadmapModel

They seems accidentally dropped at 45fe77164c.

Change-Id: Iebd72cadc9eb9bdcb80f9b8c11f6e5e40bdb50a2
Reviewed-on: https://gerrit.libreoffice.org/52673
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2018-04-11 09:31:32 +02:00
Takeshi Abe 2c63fcb0cf ucb: Fix overwriting at index 7 
It seems a typo at ee2ecbf89b.
This recovers command "insert".

Change-Id: Id335799ab615c09e025badd9408aeb363200c430
Reviewed-on: https://gerrit.libreoffice.org/52552
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-04-08 08:38:56 +02:00
Takeshi Abe ad8961511a osl: Remember the last error before returning osl_Socket_Error 
This prevents from e.g. com.sun.star.bridge.UnoUrlResolver's
emitting confusing messages, when trying to connect to a port
on which no LibreOffice process is listening, like:
> Traceback (most recent call last):
>  File "<stdin>", line 1, in <module>
>  __main__.NoConnectException: Connector : couldn't connect to socket (Success)
                                                                        ^^^^^^^
After applying this patch:
> Traceback (most recent call last):
>  File "<stdin>", line 1, in <module>
>  __main__.NoConnectException: Connector : couldn't connect to socket (Connection refused)

You can see the above behavior with the following python code:

import uno
x = uno.getComponentContext()
y = x.ServiceManager
z = y.createInstanceWithContext("com.sun.star.bridge.UnoUrlResolver", x)
url = "uno:socket,host=localhost,port=2002;urp;StarOffice.ComponentContext"
a = z.resolve(url)

... provided that no process is waiting on port 2002.

Change-Id: Id094cf9271fe77d84f2284d91a0e452448de2bc2
Reviewed-on: https://gerrit.libreoffice.org/52018
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-04-06 08:52:14 +02:00
Takeshi Abe 786a1c8ef1 fflush() followed by fclose() is redundant 
Change-Id: Iacb9332635cb6afa90ec1a72e96388b3b5b7b56c
Reviewed-on: https://gerrit.libreoffice.org/52420
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-04-06 06:35:02 +02:00
Takeshi Abe 8d6e498a11 ucb: Shift property "IsRowCountFinal"'s index from 0 to 1 
The original 0 seems a typo.
Cf. ucb/source/sorter/sortresult.cxx and
    ucb/source/ucp/ftp/ftpresultsetbase.cxx.

Change-Id: I5c2331483aa8186a031bba9fb2fc906ee4a1e535
Reviewed-on: https://gerrit.libreoffice.org/52484
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-04-06 06:34:31 +02:00
Takeshi Abe 4e13bfaf68 svx: Fix the sequence's length 
Change-Id: I8b1798659efb798ca4f4883469118a297f40b83b
Reviewed-on: https://gerrit.libreoffice.org/52466
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-04-06 06:33:55 +02:00
Takeshi Abe eb77037ea1 osl: Fix possible memleak 
Change-Id: I162993df6b802bd51e4e079b3dc530476b220e4e
Reviewed-on: https://gerrit.libreoffice.org/52325
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-04-03 18:40:54 +02:00
Takeshi Abe 52829d9a7a ucb: The sequence's length is 3, not 2. 
This completes 1a9261124e.

Change-Id: I03e6167bca67f8852250d8464b6fde5e4e690f32
Reviewed-on: https://gerrit.libreoffice.org/52261
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-04-02 17:03:25 +02:00
Takeshi Abe bba299d814 tdf#114751 Update the default UI fonts for Japanese locale 
- give priority to IPA P Gothic and Noto Sans CJK JP
- for Windows, try Yu Gothic UI first, then Meiryo UI
- look for Hiragino Kaku Gothic ProN/Pro on macOS

Thanks to Jun Nogata and AWASHIRO Ikuya for their suggestions.
This addresses only part of the issue; another incoming change
will take care of the rest.

Change-Id: I1491ba63e1447d3b9086dfcfdf3981bee6282661
Reviewed-on: https://gerrit.libreoffice.org/50515
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
 2018-03-14 09:37:44 +01:00
Takeshi Abe e1771058eb starmath: Adjusting by 0 is the same as doing nothing 
Change-Id: I417c67ca8be458befff4ff3151404fe3833e7582
Reviewed-on: https://gerrit.libreoffice.org/50227
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
 2018-02-24 23:40:01 +01:00
Takeshi Abe 32a5ea9d0b starmath: no need to use std::deque here 
Change-Id: I735d751bc9a5c3392075b6155d63e10b0da0d33b
Reviewed-on: https://gerrit.libreoffice.org/49968
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
 2018-02-20 13:26:31 +01:00
Takeshi Abe 6893d8b193 starmath: Spare unnecessary assignments 
Change-Id: I8ddc1c04a76475d63a39dc21d36cda7a7aa26b9e
Reviewed-on: https://gerrit.libreoffice.org/49921
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
 2018-02-19 00:55:54 +01:00
Takeshi Abe abcd782510 starmath: Prefer moving subnodes to copying them 
Change-Id: Id92dd0715daf43a63d09529f01a6583c23de7c7d
Reviewed-on: https://gerrit.libreoffice.org/49725
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
 2018-02-15 11:13:52 +01:00
Takeshi Abe 3c913c3844 starmath: Omit SmParser::GetError()'s argument 
as it was always 0.

Change-Id: I59570967deb139f258e7aeaab17619f714bc7bb5
Reviewed-on: https://gerrit.libreoffice.org/49640
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
 2018-02-14 01:13:51 +01:00
Takeshi Abe 609888f3c8 starmath: Make SmParser::DoAttribut() etc. return std::unique_ptr 
Change-Id: I9693cf15abf202657f5be478bfebd1272dc261dd
Reviewed-on: https://gerrit.libreoffice.org/49339
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
 2018-02-08 01:27:52 +01:00
Takeshi Abe f0c171a1dd starmath: Make SmParser::DoLine() etc. return std::unique_ptr 
Change-Id: Ia85f66d3490471d7e0c2ce8a1947051be129acf9
Reviewed-on: https://gerrit.libreoffice.org/49276
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
 2018-02-07 01:36:57 +01:00
Takeshi Abe 715114595e starmath: Make DoAlign() return std::unique_ptr 
to take advantage of copy elision and simplify client code.

Change-Id: I9e08bc2b9743563f483657c7348abca05dd34c85
Reviewed-on: https://gerrit.libreoffice.org/49222
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
 2018-02-06 00:30:25 +01:00
Takeshi Abe b52275dd26 sd: Remove unused keywords 
Change-Id: I1a180aaca32cabc56a6d5a6a3f0b23680d60aaf3
Reviewed-on: https://gerrit.libreoffice.org/47760
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2018-02-01 14:50:50 +01:00
Takeshi Abe 1056f14525 starmath: Put GetDefaultFontName() in an unnamed namespace 
Change-Id: I877e1c9b33ae240a2e8ac9972a6bc45e0848ee28
Reviewed-on: https://gerrit.libreoffice.org/49027
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
 2018-02-01 01:37:15 +01:00
Takeshi Abe f16fdfa559 Add unit tests for rtl::math's inverse hyperbolic functions 
based on i#97605's test cases.

Change-Id: Id7e57914553ba8801a624f667979badc191108e5
Reviewed-on: https://gerrit.libreoffice.org/46152
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
 2018-01-23 14:39:28 +01:00
Takeshi Abe f3d1b2e58c starmath: Make SmParser::Parse() return std::unique_ptr 
Change-Id: I6c8811f71ab40398043cdcfa3334eee4381b4c7e
Reviewed-on: https://gerrit.libreoffice.org/48098
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
 2018-01-22 06:26:00 +01:00
Takeshi Abe 5306ae7ecd starmath: Make SmParser::ParseExpression() return std::unique_ptr 
Change-Id: Ib8b65dced2af3ac7dca3fe9dd02e70f02c865f79
Reviewed-on: https://gerrit.libreoffice.org/47974
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-01-17 07:45:05 +01:00
Takeshi Abe 0f2104cd74 starmath: getLength() > 0 -> !isEmpty() 
Change-Id: I72e56e8e8cad77084bf771df8d85cb7d85712437
Reviewed-on: https://gerrit.libreoffice.org/47640
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
 2018-01-11 12:54:11 +01:00
Takeshi Abe 08de4faa00 starmath: Replace confusing sal_uIntPtr with sal_Int32 
Change-Id: If823398b75217f4a5a5bb5c83106d4d9d2e5f6be
Reviewed-on: https://gerrit.libreoffice.org/47527
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2018-01-08 14:13:40 +01:00