This patch partially reverts f69793083e
Reason described by Stephan:
"I think for test code (in vcl/qa) we always want to print information
about how and why a test failed, regardless of the configuration of
--enable-sal-log and the SAL_LOG environment variable. (Otherwise, it
just gets harder to decipher why some buildbot build, for which all we
have is its stdout/-err output, failed.)"
https://gerrit.libreoffice.org/c/core/+/197490/comments/3d04e8a0_9793bd57
Change-Id: I51a36350bd361eb48222513fc39a2b80416c6b8e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199017
Reviewed-by: Hossein <hossein@libreoffice.org>
Tested-by: Jenkins
Replaced legacy osl::profile with manual parser using osl::file. The
code now reads .ini file line by line to find section and keys. Added
SAL_WARN to alert if a profile file fails to open. Also, section headers
are matched by looking at the content between brackets.
Change-Id: I67ede84cde5911cd35d3944de1cebeef03f82ee0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196192
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@collabora.com>
Currently, the .uno:InsertPageBreak command (FN_INSERT_PAGEBREAK)
ignores all arguments and simply inserts a default page break.
This limits the ability of macros and UI elements to specify a
target page style when breaking the page.
This patch:
1. Updates the SDI definition in swriter.sdi to change the return type
from SfxVoidItem to SfxStringItem, and adds a string parameter
PageStyle (mapped to FN_PARAM_1).
2. Updates the execution logic in textsh.cxx to check for this parameter.
If a style name is provided, it passes it to SwWrtShell::InsertPageBreak,
allowing the page break and style switch to happen immediately.
This enables users (via macros) to insert a break and switch to
"Landscape" or other styles in a single command.
Change-Id: I8de15cd7ddd037420e3b3f4f482f11e1efb02c4a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195326
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Remove the obsolete test code related to Java Applets in the bean module.
Since the Applet feature is being removed, these tests are no longer needed.
Change-Id: Iaee7aad618e6addff5f14c08ec4a07d920c01a90
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195592
Reviewed-by: Stephan Bergmann <stephan.bergmann@collabora.com>
Tested-by: Jenkins
Removes the "NetAccess" and "Security" configuration properties
from the Office.Java schema.
Also removes the corresponding logic in stoc/source/javavm/javavm.cxx
that read these properties to configure the JVM appletviewer mode.
Since Applet support is being removed (deprecated in Java 9, removed
in Java 17), the JVM no longer needs these specific security flags.
Change-Id: Ifb2a2be4d103750d918d938d569c7dc8e196f19d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195591
Reviewed-by: Stephan Bergmann <stephan.bergmann@collabora.com>
Tested-by: Jenkins
Replaces the legacy std::bind usage with a modern C++ lambda in
SetNotifyUndoActionHdl. This improves readability and ensures
std::unique_ptr arguments are moved correctly using std::move.
Change-Id: I96d1fe48563a80057fdac64007f729552c5411bb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195172
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
The GetPageNum function logically retrieves information without
modifying the document, so it should be marked as const.
This patch:
1. Marks GetPageNum as const in the header and source.
2. Removes the unnecessary const_cast at the call site in viscrs.cxx.
3. Handle the non-const requirement of CurrShell internally using
const_cast to preserve logical constness of the API.
Change-Id: Id4ff5245d4160166bbddee7dce0b0999bb3fc5c8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195084
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Replaces the legacy std::bind usages with modern C++ lambdas in
EffectRewinder. This improves readability and avoids the need for
std::bind and std::placeholders.
Change-Id: If0f0f52d02a3b89327feaf01cd0f7f0f3d290501
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195174
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Replaces sal_uIntPtr with sal_uInt64 in ImpCalcEdgeTrack and
related variables.
This ensures safety on 64-bit systems and avoids usage of
pointer-sized integers for arithmetic logic, consistent with
modern codebase standards.
Change-Id: I9120d4e15fc63ea75dc04ae67969b6108e0499f4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194938
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Replaces the old explicit template instantiation with the
modern SfxItemSet::makeFixedSfxItemSet helper function.
This simplifies the syntax and enables auto type deduction.
Change-Id: I23102ca679756f6e2b1caca182469fdaacd501a1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194927
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
shlok3640