30 Commits
Author SHA1 Message Date
Isamu Mogi d2c469cc16 related fdo#63230: Fix unit test for fdo#44286 to run in all locales
fdo#44286 test fails depending on system language. To fix it, this commit sets
output language to LANGUAGE_ENGLISH_US.

Erorr message:
| $ LANG=fr_LU.UTF-8 make -rs CppunitTest_svl_qa_cppunit
| [build CUT] svl_qa_cppunit
| /home/master/src/libreoffice/workdirs/master/svl/qa/unit/svl.cxx:403:(anonymous
| namespace)::Test::testFdo44286
| equality assertion failed
| - Expected: 1902-04-22
| - Actual  : YYYY-04-DD
|
| svl.cxx:403:Assertion
| Test name: (anonymous namespace)::Test::testFdo44286
| equality assertion failed
| - Expected: 1902-04-22
| - Actual  : YYYY-04-DD
|
| Failures !!!
| Run: 7   Failure total: 1   Failures: 1   Errors: 0

Change-Id: I58756c7508c7f02bec9c3b7b693032265d18c6ae
Reviewed-on: https://gerrit.libreoffice.org/9826
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2014-06-19 06:23:46 +00:00
Isamu Mogi 65b5d1a3f0 related fdo#63230: Add unit test for fdo#44286
It fails if 6013fe19a4 is reverted.

Change-Id: Iabf13b15e3c26d7ebafdc9284642183f27723d8c
Reviewed-on: https://gerrit.libreoffice.org/9781
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-18 09:48:36 +00:00
Isamu Mogi a5f62d96b1 Fix to be able to edit seconds in Japanese date/datetime cells
Currently seconds in Japanese date/datetime cells can't be edited.
But i18npool/source/localedata/data/locale.dtd and
offapi/com/sun/star/i18n/NumberFormatIndex.idl say that seconds in
time/datetime cells should be editable. And Japanese users
reported that current behavior is inconvenient.

Also to retain relativity against @formatindex='40', each
[@usage='TIME']/@type are shorten.

For better backward compatibility, @formatindex='55' should be
default format. But since there is implementation limit of
SvNumberFormatter::ImpGenerateFormats, @formatindex>=50 can't
be default one.

These changes are discussed in Japanese ML:
http://listarchives.libreoffice.org/ja/discuss/msg03044.html

Change-Id: I074b8d6d5c9d69b8ba1eb14c29b661d753c003ad
Reviewed-on: https://gerrit.libreoffice.org/9703
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-06-11 14:59:12 +00:00
Isamu Mogi e4abc1cb06 Fix comments
Change-Id: I7957db170ec7020c9aba915e43779e01c7b98a8c
2014-06-04 15:18:22 +01:00
Isamu Mogi 4452ac2322 Fix hungarian prefix for calendars
Change-Id: I78b3c0a8d32610e86e09ab5ad6da6cc4e0395926
Reviewed-on: https://gerrit.libreoffice.org/9566
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-06-01 16:22:12 +00:00
Isamu Mogi 42877b3478 fdo#68546 Make menubar's text color of persona the same as Firefox
Change-Id: Ib9370f4b369f2baf29d118a1bbcd565bca005c30
Reviewed-on: https://gerrit.libreoffice.org/8712
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-28 11:38:55 +00:00
Isamu Mogi 26355306ff fdo#68546 Update style settings before changing layout
Currently, ImplInitStyleSettings()'s effect isn't be reflect to UI.
Because it is called after refreshing UI by ImplLayoutChanged().
This fixes these order.

Change-Id: I4cfe0115bc32551cecc70cf4b33921fb8ee7ea5a
Reviewed-on: https://gerrit.libreoffice.org/8714
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-28 11:37:50 +00:00
Isamu Mogi 46142545de fdo#68546 Add menubar's text color of persona to StyleSettings
Change-Id: I376e0b71b71fdbc2eaf2b10adb7792a841cf9098
Reviewed-on: https://gerrit.libreoffice.org/8711
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-28 11:36:43 +00:00
Isamu Mogi 48d09a74dd fdo#68546 Update settings for MenuBarWindow in InitStyleSettings
It updates menubar's text color settings in StyleSettings when user
changes persona.

Change-Id: Ic9c3e8073b9188a792823a84bf78b9b5976af50d
Reviewed-on: https://gerrit.libreoffice.org/8713
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-28 11:29:38 +00:00
Isamu Mogi 38cf887abd Replace UTF-8 no-break space to ASCII space
UTF-8 no-break space causes C4819 warning in MSVC with CP932.

Change-Id: I83a6ea6d060d132d21d8ea3141051f850d0e6bd2
Reviewed-on: https://gerrit.libreoffice.org/8628
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-19 10:25:27 +00:00
Isamu Mogi 2cea4c98c2 Add sal_textenc dependency to cppumaker
In Japanese localized Windows, cppumaker requires sal_textenclo.dll
but that rule isn't written in .mk. It causes build failure.

Change-Id: Icab74493a4a3b445144bb9d969b79636dbd17162
Reviewed-on: https://gerrit.libreoffice.org/7134
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2013-12-30 21:57:01 +00:00
Isamu Mogi 1542a655ea --disable-atl disables winaccessibility
Change-Id: I548ea294e6c632b8ae95e6745a51d9b12c7e5297
Reviewed-on: https://gerrit.libreoffice.org/7130
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-12-19 13:03:16 +00:00
Isamu Mogi 70b3cae54b Support to compile firebird on cygwin-64
C Compiler (cl.exe, gcc-wrapper.exe) for firebird generates 32bit
object file but windres on cygwin-64 generates 64bit one. It causes
link error. This patch unifies these objects in 32bit.

Change-Id: Ie631bdcc22eedd694c880f55101db77b9ac5f669
Reviewed-on: https://gerrit.libreoffice.org/5273
Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>
2013-08-09 07:54:48 +00:00
Isamu Mogi ded871e9c1 fdo#66246 fdo#66395 BOM for MSVC with UTF-8 unfriendly codepage
MSVC misinterprets UTF-8 source code without BOM as ANSI/OEM codepage.
For that reason if local codepage is unfriendly to UTF-8, it sometimes
causes compilation error.

Change-Id: I8acd5500e581e020fd60b5a2ec20629f92fdf87c
2013-07-31 09:29:07 +01:00
Isamu Mogi 92e484c4b5 Ignore empty line in autogen.input
Change-Id: I5a640c996779ba548c1b4772820eaa799537c1af
Reviewed-on: https://gerrit.libreoffice.org/4991
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-07-26 16:12:25 +00:00
Isamu Mogi 9722cd44be Remove debug output
From 8e784b59f1

Change-Id: Iab0ac8ef53cf0d3d1f1f1ec23ee9a26a3d89f38a
Reviewed-on: https://gerrit.libreoffice.org/4435
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-06-28 11:54:12 +00:00
Isamu Mogi 2947430455 fdo#65450 Not to call MenuBar's selection logic for rollover effect
Currently when we rollovers on MenuBar, MenuBar's selection logic
(ChangeHighlightItem et al) is called. But calling these logic on background
window seems to illegal and causes fdo#65450.
2013-06-11 11:30:59 +01:00
Isamu Mogi 6d2e3bdac2 fdo#41226 Add error handling of recursed GetCaseCorrectPathNameEx()
GetCaseCorrectPathNameEx() with bCheckExistence = true doesn't support windows
share path but occasionally it doesn't return failure and returns broken result.
For example, when we call with "\\USER-PC\Users\foo" then it converts the path
to "\Users\foo". And when "\Users\foo" exists, it returns "\Users\foo". It is
caused by missing error handling of searching for file "\\USER-PC". Also similar
bug possibly occurs even for local file path. This commit fixes these bugs.

Change-Id: Idf1dd1282510d8a6810ed239a83051bb0f8e2f87
Reviewed-on: https://gerrit.libreoffice.org/4151
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-06-06 13:09:49 +00:00
Isamu Mogi 2f912c2937 gbuild: Use gb_RCFLAGS
gb_RCFLAGS is defined. But it wasn't used anywhere.

Change-Id: Ib9c5ba85a7c72560a94829fde4eee8c73fad3c5a
Reviewed-on: https://gerrit.libreoffice.org/4125
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-06-04 14:31:56 +00:00
Isamu Mogi 16ca542834 gbuild: Add -nologo option for rc.exe in VC2012
rc.exe in Windows SDK version higher than 6.0A accepts -nologo.
And according to configure.ac:3131 VC2012 can't use 7.x, 6.0A or older.
So it's a safe bet.

Change-Id: I833e96adad322bb0f5eed36c9a09ece88111b5f7
Reviewed-on: https://gerrit.libreoffice.org/4127
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-06-04 14:27:27 +00:00
Isamu Mogi be4bf1016e gbuild: Fix indent
Change-Id: I9dafd3dd75f00a8447b78d4765ec1087c84f61c2
Reviewed-on: https://gerrit.libreoffice.org/4126
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-06-03 11:20:00 +00:00
Isamu Mogi 8645239c91 vcl: Check SH_MenuBar_MouseTracking when menubar is drawn on KDE
If QStyle::SH_MenuBar_MouseTracking is 0, it makes a mouse rollover
effect minimize. By this, a menubar item of CDE and Motif styles becomes
closer to standard behavior.

Change-Id: I87dccbd30bf7b9f0d82d1a6e67355c1b25d22dc8
Reviewed-on: https://gerrit.libreoffice.org/4018
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-05-27 06:37:09 +00:00
Isamu Mogi 97852d41dd vcl: Implement drawing CTRL_MENUBAR and PART_MENU_ITEM on KDE
Currently, menubar's background is drawn in window's background color
and no menubar's specific background color. To fix this, The patch
calls QStyle::drawControl() with QStyle::CE_MenuBarEmptyArea.

Change-Id: I89b9decc016a926a0f00b9663ec1a5bce81daac1
Reviewed-on: https://gerrit.libreoffice.org/4025
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-05-27 06:01:17 +00:00
Isamu Mogi 762151c359 vcl: Add sink effect (QStyle::State_Sunken) to menubar on KDE
A selected menubar item of cleanlooks, gtk+ and plastique styles
becomes closer to standard looks by passing QStyle::State_Sunken
with QStyle::CE_MenuBarItem to QStyle::drawControl(). It is
currently not documented on QT developmet resources. But these
styles interpret that.

Change-Id: Ic7835bf0bf7af374ebdf8330d15b462d056de8a5
Reviewed-on: https://gerrit.libreoffice.org/4017
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-05-27 06:00:45 +00:00
Isamu Mogi 8eb1fb9eff Add mouse rollover effect to menubar on KDE and Windows
- Add mouse rollover handling code to vcl::MenuBarWindow and vcl::Menu
- Add member variable of rollover color to StyleSettings and ImplStyleData
- Add rollover color definitions for each platforms

Change-Id: I9ececd8a7089918ac63c5f2027c0c2f361a9d227
Reviewed-on: https://gerrit.libreoffice.org/3856
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-05-22 21:02:46 +00:00
Isamu Mogi 2147d08c78 Re-add PNG file that used to have a pathological (LF) filename
This is a cherry-pick of 4aa27cc3b98d455379f7c97a215d557d646fa08e .
Author: Andrea Pescetti <pescetti@apache.org>
Date:   Sat May 11 11:42:03 2013 +0000

Change-Id: Id91c9d5cd462e73a243d9c5670572a9c2293798e
Reviewed-on: https://gerrit.libreoffice.org/3985
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-05-21 09:44:33 +00:00
Isamu Mogi 19ab0e5fc5 Avoid pathological filename, breaking checkout on some systems.
This is a cherry-pick of 8cb45ee0b8d744c282b76be8b26b1196b9d91b44 .
Author: Andrea Pescetti <pescetti@apache.org>
Date:   Sat May 11 11:39:07 2013 +0000

Conflicts:
    icon-themes/galaxy/svx/res/symphony/

Change-Id: I125e506531248c167cda20714228777e102a24e9
Reviewed-on: https://gerrit.libreoffice.org/3984
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-05-21 09:44:01 +00:00
Isamu Mogi d68243cd66 Fix warnings by shadowing variables in boost/logic/tribool.hpp
Change-Id: I7d85cdb5e32802ddfd83a350f3daa49348bc18a6
Reviewed-on: https://gerrit.libreoffice.org/3935
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-05-17 15:32:46 +00:00
Isamu Mogi 80cf1c22b6 gbuild: Replace SHOWINCLUDES_PREFIX without regexp.
With MSVC Japanese, SHOWINCLUDES_PREFIX includes regexp special
charactor \x5b (left square bracket). In this case replacing
SHOWINCLUDES_PREFIX with regexp fails. To fix it, this commit
changes the script not to use regexp.

Example value of $SHOWINCLUDES_PREFIX from MSVC Japanese:
$ echo $SHOWINCLUDES_PREFIX | hexdump -C
83 81 83 82 3a 20 83 43 83 93 83 4e 83 8b 81 5b |....:.C...N...[|
83 68 20 83 74 83 40 83 43 83 8b 3a 20 20 43 3a |.h.t.@.C..:  C:|
5c 54 65 6d 70 5c 73 74 64 69 6f 2e 68 0d 0a    |\Temp\stdio.h..|

Change-Id: Ic7d85fc3a93807de11155488e9d0368427375c78
Reviewed-on: https://gerrit.libreoffice.org/3579
Reviewed-by: Kohei Yoshida <kohei.yoshida@suse.de>
Tested-by: Kohei Yoshida <kohei.yoshida@suse.de>
2013-05-13 13:26:37 +00:00
Isamu Mogi 263ab3f14b fdo#59850: Resolves invalid date changing by ICU's timezone detection bug.
Patch was also submitted with https://ssl.icu-project.org/trac/ticket/10129
of which the outcome should be monitored.

Change-Id: I3ebd4aaef281214062a5b2a858eff8e57a34c9b1
Reviewed-on: https://gerrit.libreoffice.org/3637
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-05-02 15:11:29 +00:00