There appears to be special logic for replacing words that end
with a dot in the spellcheck dialog. Where the dot at the end is
ignored during replacement.
This special handling is only there for the spelldialog, i.e. it
is not there if you try to do the replacement via the context
menu or via IDocumentRedlineAccess.
e.g. If the text with the error text is only "." and the
replacement is "REPLACEMENT", clicking Correct button on the
dialog ends up with "REPLACEMENT."
Make it so that if the error text is just a dot, do not enforce
having a dot at the end of the replacement. Since it is obvious
the suggested replacement is for the dot.
It feels to me like the whole special handling for dot was
originally dictionary/suggestion error and was worked around in
the wrong place.
Change-Id: I65675ad18e5386f65ee978c0e92952bba29ae3cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184495
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
support slots FN_NUM_BULLET_ON & FN_NUM_NUMBERING_ON to properly
report back whether or not numbering functionality is available in
notes pane.
Change-Id: I94fd395a328a45db3bc7c394b7473a22edf0c957
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183943
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
start handling the paste special slot: supporting at least RICHTEXT,
HTML, HTML_SIMPLE, EDITENGINE_ODF_TEXT_FLAT which should be trivial to
handle for the notes area.
Change-Id: If508e81f81b213d829efef59220196b18252dec4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183917
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
fix HTML paste-special option creating a new text object even if
paste-special was used in a text-edit context. insert the text into the
current text edit context instead of creating a seperate object.
this is the current behavior for RTF & Flat XML Format paste options- so
it is was a bug for html paste option.
Change-Id: Ief9a19997a619b9f0b9c7855561de3f00de2df68
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183913
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
make scrollbars update when the current slide is switched via
hotkeys.
which eliminates now not needed UpdateScrollBars call at
CurrentSlideManager.
Change-Id: I89db8c45edd14a871e6d9901a156609ad569984c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183854
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
notes pane uses pgup & pgdown for scrolling the text inside
the pane. which blocks regular slide switching hotkeys for
impress.
add a new impress shortcut ctrl+pgup / ctrl+pgdown for going
to the next or previous slide. for consistency sake this
shortcut is not specific to notes pane but works everywhere on
impress.
make notes pane do not consume these keys so the default keys
from accelerator config takes effect.
Change-Id: I2221f90556683d1c00747ea855a7fe3a11d1a2a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183849
Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
Tested-by: Jenkins
Set p as the mnemonic for Notes Pane menu item. AFAICS no
clash-free mnemonic was possible. As a result the mnemonics
for Slide Pane and Notes Pane clash now.
I think it is logical to make these two items clash, since
they are both for toggling panes.
Change-Id: I00ac6f815e0109a3e276eeee7e03beffba7b0946
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183777
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
Now with the /org.openoffice.Office.Common/Misc/FreehandThresholdPixels config
option, when using low threshold pixels like 1px it is more apparent that
XPolygon::PointsToBezier will sometimes make the curve shoot off.
Try to counteract by ignoring control points offsetted more then the segment
length.
Better fix would be changing the PointsToBezier algorithm, but this seems to
hold OK for now.
Change-Id: I7ab0a67a33e25874ff55af932b3e087bbaad98fb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181841
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
Pane shells (BottomImpressPane, LeftImpressPane etc.) do not implement any slot
handling, so make sure they are not activated on the top of the shellstack.
Another solution for this could have been getting ChildWindowPanes properly
dispose instead of Hide() at BasicPaneFactory::releaseResource, and adapting the
rest of the code which assumes these Panes are recycled.
This is since ConfigurationUpdater::UpdateCore attempts at releasing via
ConfigurationUpdater::CheckPureAnchors and
ConfigurationControllerResourceManager::DeactivateResources calls.
But in the end the ChildWindowPane is hidden on the DeactivateResource call
instead of being diposed, so the "PureAnchor"'s Shell stays at the shellstack.
Change-Id: I52788d350b66ae22875683f57d87326f4a9a77de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177686
Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
Tested-by: Jenkins
previously Save as dialog's "Sign with default certificate"
checkbox's senstivity was decided depending on if there was a
matching key.
Doing that forces a dialog pop-up for password protected NSS
databases.
Now if there's a value in
"/org.openoffice.UserProfile/Data/signingkey", the checkbox
is sensitive.
Matching key is checked during save, and reported if it isn't
found & signing failed.
Change-Id: Ia714b70ce6456752200088cc5382ab6374af9587
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173129
Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
Tested-by: Jenkins
fix GPG CertificateImpl::getSHA1Thumbprint not returning a
sequence of bytes as the thumbprint. (that is what the
documented API states, and what all of the code assumed.)
now /org.openoffice.UserProfile/Data/signingkey and
encryptionkey stores the key's SHA1Thumbprint for better
identification of keys. Previously on the key name was being
used.
fix annoying NSS Certificate Database password prompt
appearing on Tools->Options if the certificate database is
password protected.
improve Tools->Options->UserData user key selection and
display of information.
add a ui test for "Sign with default certificate"
interaction in the save dialog.
Change-Id: I1036856003f58f494838e0f81ca0fe18e821f528
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171395
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
Include X.509 certificates under Tools->Options->UserData
among the keys for signing.
Add a new checkbox to Save file dialog, to sign with that
selected key easily.
The checkbox is disabled if there's no matching key found.
Change-Id: I9fc16790c479819cd1f35bcad040d0ebc7c4bdef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170619
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
Not setting any parent window for XDocumentDigitalSignatures
causes the key selection window to be non-modal, letting the
user keep editing the document without completing the
encryption interaction.
Change-Id: Ic7e66cb43606355beaffc720b7c23cdf4f81d934
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170630
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
Flattens DocumentIteratorImpl, getting rid of the
intermediary ViewIteratorImpl.
Now the DocumentIteratorImpl, iterates in the following
pattern:
1-) For all slides, visit the NormalView and
the NotesView before advancing to next slide.
2-) Master Pages
3-) Handouts
Now when a search result is found in the NotesView that is
displayed on the NotesPane instead of the NotesView.
Change-Id: I8133c6a74861e783ab1a23f51ac5faf362a0f512
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169659
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
Introduces OverridingShells that when set, makes the view
act like the MainViewShell.
The main use case is having more then one ViewShell in a
single window, where context (toolbars, sidebars etc.) can
jump in between different ViewShells.
Uses OverridingShells to enable NotesPane to react
ToolBarShells. Accessing the functionality of ToolBarShells
without the previous hacks with slot forwarding.
Change-Id: Icc9721d7f54097025bc9dc7ef7069aed856e6d96
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169658
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
use non-scoped interaction handler instead of the scoped
SimpleFileAccessInteraction so that errors will be handled
with correct pop-up dialogs.
Also throw the correct type of DAVException for
USC_CONNECT_FAILED in Content::Open
Change-Id: If2031dfa2796f91fad6866bc9608194c92658b96
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169519
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Giving the user the option to determine if they should trust an
invalid signature in HIGH macro security doesn't make sense.
CommonName of the signature is the most prominent feature presented
and the CommonName of a certificate can be easily forged for an
invalid signature, tricking the user into accepting an invalid
signature.
in the HIGH macro security setting only show the pop-up to
enable/disable signed macro if the certificate signature can be
validated.
Additionally present a ViewSignatures button in the Macro Disabled
infobar, so that the user can inspect what are the invalid signatures
and why (wihtout the ability of enabling macros).
Change-Id: Ia766fb701660160ee5dc9f6e077f4012a44ce721
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168667
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
Make SlideSorterView update the current page properly when it is the
MainViewShell.
Also fixes Notes Pane not properly updating on SlideSorter
view mode.
Change-Id: If4fed4e84951cb4a1707874b288ac46e6d5c26da
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168022
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
The "early rejection test" removed here is a historical
artifact when UpdateForKeyPress was created.
in the current state it checked if
pOutlineViewShell->GetActualPage() was different from
itself.
In the OutlineViewShell::UpdatePreview, there's an
additional check if we have actually moved to a new page, so
we can just safely remove this.
Also fixes Notes Pane not properly updating on Outline View Mode
Change-Id: Ic9de2e7302e76260809f90360533f0bfe6e05d2e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168017
Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
Tested-by: Jenkins
Makes it so that notes pane handles some previously
incorrectly handled keys itself. e.g. PageUp & PageDown
Change-Id: I19f73fa2782900a752889544dcc79fc180ee52d4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168008
Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
Tested-by: Jenkins
After clearing the notes pane outliner and filling with then
new content, if the new content didn't overfill the
previous' area there was a residue from the last content
visible.
Make sure it is flushed by triggering onResize() on page
change.
Which also fixes the notespane sometimes keeping the
scrollbar & scrollarea from the previous content.
Change-Id: Ibbcb0f4f316bd283e5e65bb2ebd9cf17a3b38c0e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167489
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
Introduces new NotesPaneModule which manages the visibility
of NotesPane across modes and different runs.
Also introduces new three config values under
Office/Impress/MuliPaneGUI/NotesPane/Visible ImpressView,
OutlineView and NotesView.
Similar to what was there for SlideSorterBar.
Change-Id: Id540c508e81878e5a8e1aebd6544839e70b813c8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167348
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
Guessing this has regressed with
9fc28d7ef5
Read the values from std::optional<bool> properly.
The default values are taken from the configuration
officecfg/registry/data/org/openoffice/Office/Impress.xcu
Change-Id: I93d5537a9e06dc6985a2ec375353d9869b92e08c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167353
Reviewed-by: Sarper Akdemir <sarper@libreoffice.org>
Tested-by: Jenkins
Sarper Akdemir