Makes hyperlink ordering in Navigator and Navigate By follow the
order of document occurrence including hyperlinks in footnotes and
endnotes.
Previous to this patch hyperlinks in footnotes and endnotes
were always listed first in the Navigator hyperlinks catagory.
Navigate By hyperlinks follow the same order as hyperlinks listed in the
Navigator.
Change-Id: Id28c98d4fa8dc5b7174a3ad2cd803dffb7f5ae93
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/207376
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
* Makes the title show as "Slide Properties" instead of "Page
Properties".
* Makes the label for the resize all slides checkbox show as "Resize all
slides" instead of "Resize all pages"
Change-Id: Idda0bdf6ef6215696ae4189549f62c05ef0076c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209996
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Jenkins
Moves m_pWrtShell->GetCursor()->Normalize to before SwSearchOptions
aOpts is constructed to fix search key not found when a forward search
results in a unique find selection to the end of the document followed
by a backward search or when a backward search results in a unique find
selection to the start of the document followed by a forward search
search. Unique find selection meaning the document contains only one
match of the search key.
Why this works:
SwSearchOptions checks if the cursor is at the start of the document.
After a forward search, the point is at the end of the document, and the
mark is at the start of the word 'bug'.
So when we create SwSearchOptions for the next (backwards) search,
bDontWrap is set because the cursor is at the end of the document.
Next, the cursor is normalised, effectively starting it before 'bug'.
Because bDontWrap was set, the search doesn't go past the start of the
document - and thus reports 'not found'.
So by normalising BEFORE SwSearchOptions, the cursor is not considered
to be at the end of the document, and so wrapping is allowed.
Change-Id: I4dd9e70a19d8a50395fcc21f4661756336399c06
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208268
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
* Makes the "All Styles" entry checkbox indeterminate when filter
entries are checked other than "Hidden Styles" entry.
* Makes all filter entry checkboxes checked when the "All Styles"
entry checkbox is changed from unchecked or indeterminate to checked.
* Makes all filter entry checkboxes unchecked when the "All
Styles" entry checkbox is changed from checked to unchecked.
Change-Id: Ib4c9a3dd28ad92d2cb72b98027eeee837b1cb9fa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/206236
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Tested-by: Jenkins
Adds configuration option "NavigateByCategoryBinding" to control whether
the Navigate By control relates to the Navigator content list category
in terms of automatic selection.
Change-Id: I505e1ce73050ab8a382fa850a044908c9125cf4c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/206606
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Removes setting table style in the insert table dialog OK handler. The
table style is set by the caller.
Change-Id: I05e368c9b0421cbe6bf8cc02b40d802f60ffdb17
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/206184
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Tested-by: Jenkins
This patch provides user customization of styles shown in the
SvxStyleToolBoxControl through the Expert Configuration dialog by adding
a StyleToolBoxControl group having four boolean property settings
(ShowDefaultStyles, ShowUsedStyles, ShowFavouriteStyles,
ShowUserDefinedStyles) under org.openoffice.Office.Common.
Change-Id: Ie9ae1f6ecbf0af77cf32be34850bc04854307a2b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205925
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Currently styles spotlight numbers are reverse for GTK compared to the
other VCL backends. This patch makes inserting items into the style list
happen in the same order for all VCL plugins.
Change-Id: Id14b385b24bc03ca5a794d0279990d3a411fd762
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205573
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Fixes a crash caused by commit commit
64a7d5179b where I added a
TreeView::set_children_on_demand at the end of the
SwContentTree::RequestingChildren function. I thought I had removed the
set_children_on_demand function from the places in the code where it
follows a call to RequestingChildren. In this patch I have removed the
the added set_children_on_demand in the RequestingChildren function.
Change-Id: I1bcca7dcd72d7196afba4c1acd674df6318f7a33
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203794
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Tested-by: Jenkins
Enhancement for Writer Navigator to make grouped drawing object entries
expandable to show drawing objects in the group.
Change-Id: Iae6a20c50379e2f5473848bea649f4c0db593d72
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200914
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Tested-by: Jenkins
* Makes clicking on a page separator entry select the next entry in the
finds list.
* Makes up/down arrow key movements skip over page separator entries.
* Makes movements that result in selecting a page separator entry
select the next entry in the finds list. Movements that can do this are
the page up/down and home keys.
Change-Id: Ibde0807ecea85ab7bd8497b3759642d18234c8dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202503
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Currently the result of the Writer "Go to Page" dialog splits the
viewport between pages. This patch makes the result match the behavior
of the Navigator "by Page". It aligns the viewport to the top of the
target page.
Change-Id: Ie44b95f1ff1cbec9bd79c026edc70f016f728da6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/201724
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Makes the position of the attention overlay rectangle correct for
drawing objects having rotation angle and/or shear set.
Change-Id: Ic82c83d0ad71d77d9ace1666a153b2cc57e98a8b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200693
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Makes 'Slide' or 'Page' be shown in the Navigator navigation toolbox
button tooltips depending whether the Navigator is being used for
Impress or Draw.
Change-Id: I4301e2661130b9ef2e4312e0b7b395fc3b3edb45
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199462
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Tested-by: Jenkins
When reopening Print Preview with outline folding enabled and a heading
in the first paragraph and display formatting hidden characters option
is enabled.
Effort to understand why this crash happens revealed a similar
occurrence in SwDocShell::LoadStyles_. While moving the call to
InvalidateOutlineContentVisibility in SwView ctor to before the line
having 'g_NoInterrupt = bOld' seems to avoid the crash, or my first
approach of conditionally including StartAction/EndAction through use of
a function argument, this patch uses the
comphelper::FlagRestorationGuard used in rhbz#818557, fdo#58893 fix in
SwDocShell::LoadStyles_:
"rhbz#818557, fdo#58893: EndAllAction will call SelectShell(),
which pushes a bunch of SfxShells that are not cleared
(for unknown reasons) when closing the document, causing crash;
setting g_bNoInterrupt appears to avoid the problem."
Attempts to make this crash occur in a unit test have not been
successful; therefore one is not included with this patch.
Change-Id: I993f0faef68bcb1ac6a9f38a241de48fa755a475
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198821
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Here is effort to avoid a crash that occurs when a fly frame is
unfloated that has a drawing object or fly frame anchored to its frame.
To avoid the crash, this approach uses FN_TOOL_ANCHOR_PARAGRAPH to
change the anchor of frame anchored drawing and fly frame objects to be
paragraph anchored in the fly frame content. MoveObjToVisibleLayer is
added in SwDrawContact::SwClientNotify
sw::DrawFrameFormatHintId::POST_RESTORE_FLY_ANCHOR case handling to make
undo restored fly anchored objects visible. SwFEShell::SelectFlyFrame is
made SW_DLLPUBLIC to make the clang linker not complain about 'linker
cannot find symbol(s) for architecture x86_64' when used in the included
unit test.
Change-Id: Ie6791cb45e7dce31132d3b6a8dac79d63bc27eb2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195650
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Changes the name of the Indexes context menu checkbox item "Read-only"
to "Protected against manual changes" to match the name in the "Table
of Contents, Index, or Bibliography" dialog.
Change-Id: I8b80a8fc8a6da62ba0370be75a1a65fdf57fbe68
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194806
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Examining DocxAttributeOutput::WriteFlyFrame case ww8::Frame::eOle,
it seems that OLE objects need to have their frames visible in
the document for them to be saved. This patch makes all folded
outline content visible during execution of the
DocxExportFilter:exportDocument function. SW_DLLPUBLIC's are added to
make linking succeed with clang.
Change-Id: I8fcaa98402ebd9a7a6135f65467a82bbca8731f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196516
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Enhancement patch to do this from the Writer Navigator Headings
(Outline) context menu. Currently experimental mode must be on to see
the 'Sort Alphabetically in Document' menu item which is only shown for
headings with sub headings.
Change-Id: Iec0006d1309b3c96bc7019d009b9dc4f9146df62
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197230
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
The UNO command for this feature .uno:SortChapters is set experimental.
I found a couple undo redo crashes exposed by this patch. Fixes for
these are done in related patches.
Change-Id: I75e67b137668be200dce192cfd5cd9a4e1ffdf8e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196240
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
...again
Follow up patch to always ask for the password when unprotecting
sections that have protection set with a password. The previous patch
askes for the password only the first time.
Change-Id: I54818151b8c5f43026d656065f85f2d736f98fc6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196049
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Tested-by: Jenkins
Makes unprotecting password protected sections from the Navigator
Sections entries popup menu show the password dialog for password entry
match before unprotect can be done.
Change-Id: I1178a2254616a32ad33f6974071885e3021d1dcf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196040
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Specifically, split frames holding floating tables aren't highlighted
fully. This patch uses SwIterator<SwFrame, SwFormat> as observed in
SwFrameFormat::DelFrames. Here it is used to visit all frames to
highlight.
Change-Id: I7d713cd9bca14acddcd5049b5cf81a34e403af72
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195961
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Ideally content entries in the Navigator tree are shown as 'grayed out'
when the content they refer to in the the document view is not visible
due to being in a hidden section or in outline content that is folded.
Currently this doesn't happen for content in hidden sections. This patch
makes content entries in the Navigator tree 'grayed out' when the
content they refer to in the document view is in a hidden section.
Change-Id: I1a0f39ee4a1c336a12f814a813b764a12a030c42
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195214
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Tested-by: Jenkins
Currently when content is unfolded that has drawing objects anchored 'To
Frame', excluding fly frame type drawing objects, the drawing object is
not made visible. This patch is dependent on its parent commit
dfc0ec48f8 made for tdf#90993 - Fix
anchored objects disappear.
Change-Id: Ie3d413cb3c0302fcc785d0fb459e6ed474b11dc9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195859
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Tested-by: Jenkins
A stab at fixing when an anchor of a frame is changed all draw objects
anchored to the frame or anchored in the frame content disappear.
Change-Id: Icce446b759def60460a2b72bd9eb57b5749cd26f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195689
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Currently Indexes Update is done through UNO methods. This causes the
tree entry in the Indexes list to become grayed out. This patch fixes
the graying out by replacing the UNO method with the
SwWrt::UpdateContentOf function.
Change-Id: Ia1a9b28fd1934901c87a048b14a3613ef311ad8a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194808
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
...entry selection
* 'Custom', 'Theme colors', and 'Document colors' palettes are included
in the search.
* When no palette is found having the chart colors list entry selection
color, the palette combobox text is set empty and the color valueset is
cleared. This can happen when a chart colors list entry selection color
was made from the 'Theme colors' palette and the SvxDefaultColorOptPage
is opened from the start center backing window.
Change-Id: I8ad9956c0bb9ee7de5fdcff77a250e81d7a58a9b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195335
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Tested-by: Jenkins
commit 676892af95 was my first stab.
This second effort aims to provide the expected behavior of not
changing the last used palette when it does not have a color match of
the 'Active' color. Additionally this patch handles when the
'Custom', 'Theme colors', or 'Document colors' palette is the last
used palette.
Change-Id: Ibce078778d8cad483448837dbb6364acbf668a40
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195265
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Tested-by: Jenkins
Currently a name comparison approach is used to bring index content
to attention in the document when the mouse pointer is over an Indexes
entry in the Navigator content tree. This doesn't work very well for
user defined indexes which initially get "_Head" appended to the
section name, e.g. "my user defined index1" is shown in the Navigator
content tree for the index but "my user defined index1_Head" is the
initial name of the section. This changes to "my user defined index1" if
the index is deleted and then the delete is undone. Bring-to-attention
then works as expected for the index. I haven't yet investigated why
this happens. A seemingly better approach is to compare SwTOXBase
pointers, which is the change made by this patch.
Change-Id: I9ae7fc0c72d70f7f5b3445d02b562f2d344ce34f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194826
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Rework of commit ae94c420e6 where I made
the visibility of menu items dependent on the state of the index
'Read-only' setting. I also removed the 'Remove Index' menu entry. I've
since realized that index 'Read-only' is 'Protected against
manual changes' and 'Remove Index' removes the index section but keeps
the index text. Both of these changes are reverted by this patch.
Change-Id: Icded7a0b2ed0a09619a34b518c1aeb08839b870c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195108
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Tested-by: Jenkins
"Protect against manual changes" seems not the same as read-only when
it comes to removing table of contents. For example, .uno:RemoveTableOf
removes a table of content regardless of the "Protect against manual
changes" setting. This patch changes the current behavior of displaying
the read-only content write-protected info message to not displaying
the message and allowing table of content deletion/cutting
when the entire table of content is included in a selection.
Change-Id: I4a14f0b1a17afbaacf211d7ddbe14f613761ebc5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194753
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Tested-by: Jenkins
When the current cursor is positioned in a fly frame, call
ExtendedSelectAll so content not visible in the frame is also
selected.
Change-Id: I27f77b43eec692331d70016abe35cbeb1650846e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194377
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Tested-by: Jenkins
Enhancement request for special handling for situations when a user
has scrolled/moved the view so that the cursor is no longer visible.
To handle this, recency navigation should check if the cursor is in
the view and if not, then scroll/move the view to make the cursor
visible without any manipulation of the back/forward stack.
Change-Id: Iaaa2b09108649ed12183dcc75b9bb03a7915458c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194147
Tested-by: Jenkins
Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org>
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Makes the query text in the Find&Replace dialog find entry become that
of the sidebar Find deck find entry when keyboard focus is in the Find
deck find entry and Ctrl+H (or any accelerator assigned to
.uno:SearchDialog) is pressed or the F&R button in the Find deck is
pressed. Normally these actions make the F&R dialog open or close. Here
the F&R dialog is never closed. It either opens the F&R dialog and
copies the find text to it or copies the find text to the already open
F&R dialog. Reasoning for this behavior: F&R dialog is open. Find deck
search finds nothing. Ctrl+H or F&R toolbar button in the Find deck is
pressed to upgrade the search using options in the F&R dialog. Without
this patch the open F&R dialog closes when Ctrl+H or the F&R button is
pressed. Likely what is expected is the F&R dialog remains open and the
text in the F&R dialog find entry becomes that of the sidebar Find deck
find entry, which is what this patch does.
Change-Id: Ic01cbbe6881469349a0756f3837428324f27d5b4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193945
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
This patch copies the query text to the Find&Replace dialog when Ctrl+H
is pressed in the Find toolbar find text field control. Normally Ctrl+H
toggles the Find&Replace dialog on and off. This patch makes the dialog
not toggle off when pressed in the Find toolbar find text field control,
it either opens the Find&Replace dialog and copies the query text or
copies the query text to the already open Find&Replace dialog.
Change-Id: I6aa28f9e47431bdc75d63c7f68469203bc3b59df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193837
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Currently when a search is made using the sidebar Find in Writer that
results in more than one find, only the first find in the document
view is shown as selected. This patch makes all finds in the document
view show as selected.
Change-Id: Ib68f79be4710725b639bcba83326f84d2214bc39
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194008
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
This patch makes the color table selected color in the Area and
Background Color tab pages sync with the active color when the tab page
is activated.
Change-Id: Iedd913a7a3480dbaf7226b2833958b8c0f14db0f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193438
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
This patch makes the selected data series entry color in the chart
colors list be selected in the color table for SvxDefaultColorOptPage.
The color selection made in the color table could be from a different
palette than the original. The first palette in the list of palettes
that has a matching color is choosen.
I noticed when a color selected from the Material palette was set for a
data series color, the Tonal palette was shown when reselecting it. An
off by 1 index bug that causes the last palette in the list of
palettes to not be searched for the color was found.
Another thing I noticed is when a data series chart color was set to a
color in the Freecolour HCL palette that needed to be scrolled to see
it, it didn't do it. Commenting out mbScroll in the condition in the
SelectItem function that checks its value solved the problem. I don't
get the need for the ValueSet mbScroll variable. The only place its
value can change is in the Format function. That doesn't get called in
the SelectItem function unless mnCols is 0. The SelectItem function is
the only place its value is checked. I don't see a problem with always
checking if the visible area needs to be scrolled. This patch removes
the ValueSet mbScroll variable.
Change-Id: I1f05a3ad8a0b64b2a28d3001cace391379cc00c6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193437
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
This patch adds a 'Text Alternative...' menu item to the Writer
Navigator context menu for content type entries that can have this
(Frames, Images, OLE objects, and Drawing objects). It also
adds an action button to the functions toolbar in the Writer Navigator
tool box for these content types.
Seems gtk isn't able to use the 'action-name' property in the .ui
file. <property name="action-name">.uno:ObjectTitleDescription</
property> works for qt and gen, which allows to not need the alias
"TargetURL" UNO commands added to GenericCommands.xcu and the icon
declarations added to the icon-theme link text files. I think it would
be nice if gtk supported this .ui property as well.
Change-Id: I519590fc56f39e9c6c2b2fccea568271e5fd3e77
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193376
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
For x11 a no drop icon was shown for single page documents when nav-
ordering objects by dnd in the Navigator objects tree.
Change-Id: If84b34a764527db57d9645ec7d23c8b1d4c10942
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192657
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Navigator and dropping it in the Pages pane
The patch prevents dropping of unnamed objects by checking
SdTransferable::IsPageTransferable()
Comment in SdPageObjsTLV::DoDrag():
"For shapes without a user supplied name (the automatically created name
does not count), a different drag and drop technique is used."
std::shared_ptr<SdTransferable::UserData>
Clipboard::CreateTransferableUserData (SdTransferable* pTransferable)
if (nPageIndex == SDRPAGE_NOTFOUND) break;
This is why SdTransferable::SetPageBookmarks does not get called and
therefore mbPageTransferable is not set true.
Change-Id: Ia4eddb6c384e6e73047a0cddd4cd59c20562aa5d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192675
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
This patch uses a trick from commit
f3c68cdf8f
"An additional trick is to make sure that the current shell is the draw
shell (and not the slide sorter) after navigation, so follow-up
operations work with the selected object and not with the whole slide."
Change-Id: I0d9a7ef0b532abc8cbec286f4b9b401e8acb699c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192007
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
In this case one that happens on folding outline content when the
document view is set to 'Web' and the Navigator is open.
SwDocShell::Broadcast(SfxHint(SfxHintId::DocChanged)) in
SwRootFrame::CheckViewLayout causes an update of the Navigator content
tracking which when SwWrtShell::GetContentAtPos is called in
SwContentTree::Update eventually fails an assert in
objectpositioning::SwEnvironmentOfAnchoredObject::GetVertEnvironmentLayoutFrame
with the assert message:
"SwEnvironmentOfAnchoredObject::GetVertEnvironmentLayoutFrame(..) -
found frame isn't a layout frame"
stack at crash:
objectpositioning::SwEnvironmentOfAnchoredObject::GetVertEnvironmentLayoutFrame
environmentofanchoredobject.cxx 91
objectpositioning::SwToContentAnchoredObjectPosition::CalcPosition
tocntntanchoredobjectposition.cxx 287
SwFlyAtContentFrame::MakeObjPosfly cnt.cxx 1522
SwFlyFreeFrame::MakeAll flylay.cxx 222
SwFlyAtContentFrame::MakeAll flycnt.cxx 413
SwFrame::PrepareMake calcmove.cxx 396
SwFrame::Calc trvlfrm.cxx 1858
SwFlyFrame::Calc fly.cxx 3438
SwFlyFrame::GetModelPositionForViewPoint trvlfrm.cxx 567
(anonymous namespace)::lcl_GetModelPositionForViewPoint_Objects
trvlfrm.cxx 87
SwPageFrame::GetModelPositionForViewPoint trvlfrm.cxx 208
SwRootFrame::GetModelPositionForViewPoint trvlfrm.cxx 477
SwCursorShell::GetContentAtPos crstrvl.cxx 1519
SwContentTree::UpdateTracking content.cxx 4779
SwContentTree::TimerUpdate content.cxx 4668
SwContentTree::Notify content.cxx 4046
SfxBroadcaster::Broadcast SfxBroadcaster.cxx 43
SwRootFrame::CheckViewLayout pagechg.cxx 2515
SwFrame::AdjustNeighbourhood wsfrm.cxx 1816
SwLayoutFrame::ShrinkFrame wsfrm.cxx 3020
SwFrame::Shrink wsfrm.cxx 1635
SwContentFrame::Cut wsfrm.cxx 1390
SwContentNode::DelFrames node.cxx 1552
SwWrtShell::MakeOutlineContentVisible wrtsh1.cxx 2649
SwWrtShell::InvalidateOutlineContentVisibility wrtsh1.cxx 2703
SwEditWin::ToggleOutlineContentVisibility edtwin.cxx 7135
Fixed by waiting to paint until after removal of content frames during
InvalidateOutlineContentVisibility.
Change-Id: I69fdf173763211f42c5079069e79253ccdc19d79
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191576
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Tested-by: Jenkins
level direct formatting is cleared
Without this patch the fold button remains and a crash occurs if the
button is pressed. The patch also assures folded outline content is
shown for outlines set by a style after the RES_PARATR_GRABBAG
"OutlineContentVisibleAttr" is reset.
Change-Id: I5ee19ec972c3084f3ba64c11bda32932141c81f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191526
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
by handling the case of a paragraph outline level set by direct
formatting.
Change-Id: Ida0c8f91f0fb0584b39c16b3ddf2201429c6943f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191471
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Determining the outline end position from the Navigator content tree to
calculate outline word count, character count, and page(s) shown in the
heading entries tooltip gives incorrect results when headings are
ordered alphabetically. This patch uses the outline level of outline
nodes to determine the outline end position.
Change-Id: Ibeb9ea0206450d8d9c7d605f981890d41a56e8cb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191419
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Tested-by: Jenkins
ends in-place editing (x11 only)
Fixing this revealed that ESC ends in-place editing when the popup
menu is active. Esc a second time ends the popup menu. This patch
fixes this issue as well.
Change-Id: Ia617d27fcdf7221263bc9b2ae96d8a8ebf934fc4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184400
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
This patch allows the sidebar FocusManager to handle the ESC key when
the keyboard focus is in the Navigator sidebar panel. I could not make
program execution enter the Navigator window KeyInputHdl when dragging
an object and pressing escape. The test for in-drag is dropped by this
patch. Possibly pre-welded it was needed. Also, I am unsure of the use
of catching ESCAPE in the Navigator to end a slide show. The patch adds
a test to determine if a slide show is running before ending it and
consuming the escape key so no furthing key-input processing is done.
Change-Id: Ib8cc465dd11988ac95877782e7a54b1e3fdfb2a4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184344
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Recent review of the patch done to provide in-place renaming in the
Writer Navigator (commit 492c94abe0)
inspired me to review what had been done for this for the Draw
Navigator. This patch revamps the original work and makes the context
menu item Rename consistent with the behavior of the Writer Navigator
context menu item Rename. It starts in-place editing instead of opening
the Name dialog.
Known issues:
* Gtk3 in-place editing doesn't notify when editing is canceled by
Escape. This leaves the SdPageObjsTLV editing flag true which causes the
Enter key to start entry editing instead of going to the object in the
document.
* For the Navigator in the sidebar, sal in-place editing doesn't revert
to the original text when Escape is pressed. The sidebar FocusManager
handling of Escape for focus in a panel content location is the culprit.
Change-Id: If51f962daf8f9f10a738fa8483fc4626a037bc6a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184321
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
* Makes turning on spotlight not switch to the Styles deck unless the
sidebar is not currently open.
* Makes turning off spotlight not switch to the Styles deck.
* Fixes incorrect spotlight checkbutton state in the Styles deck when
the state is changed in the Styles Inspector deck.
* Fixes spotlight not turning on using the Styles Inspector deck
spotlight buttons before visiting the Styles deck once.
Change-Id: I6d2dea05c0ba47fbe3bf63d3caed8d87960df7ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183694
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Tested-by: Jenkins
styles spotlight feature
The feature was initially referred to as styles highlighter. Shortly
before merging it was relabeled styles spotlight.
Change-Id: Ie65c6dd9c759c6ff1ea0ca23642a4041a932881c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183693
Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org>
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
The surface attribute for the cell renderer pixbuf in column 1 of the
chart colors tree view needs to be set to 0 for gtk3 to show the color
column. It got bonked when resaving with a newer version of glade in
commit
7eb0e13c65
Change-Id: I1ab322b9f54bd6dd07de5a484ca77917e5be2d33
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182551
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Tested-by: Jenkins
Headings entries the outline word and character count that includes
all sub outline words and characters.
Examples:
FIRST_LEVEL_HEADING --> tooltip shows 30 words
two three four five six seven eight nine ten
SECOND_LEVEL_HEADING --> tooltip shows 20 words
two three four five six seven eight nine ten
THIRD_LEVEL_HEADING --> tooltip shows 10 words
two three four five six seven eight nine ten
FIRST_LEVEL_HEADING --> tooltip shows 17 words
two three four five
SECOND_LEVEL_HEADING --> tooltip shows 4 words
two three four
SECOND_LEVEL_HEADING --> tooltip shows 8 words
two three
THIRD_LEVEL_HEADING --> tooltip shows 5 words
two three four five
Change-Id: If2a40c14633889d6a38df77f017b73a0f038584d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175895
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Windows scaling, the widget extends off display
Applies to gen(x11)/win/qt5 VCL plugins.
Change-Id: Ic5df291ba68ab8a19dd950dacd8a7dd61224c913
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171966
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
This is a follow up to commit
55e86edcb3 to fix a crash that occurs
when importing a Basic library.
The change made to functions arguments passed to ImportLib in PS28
requires they be checked for nullptr before use. For further
understanding please see change to moduldl2.cxx at https://
gerrit.libreoffice.org/c/core/+/176254/27..28
Change-Id: I3f7ccc46134ddd2429c499d6e728e30331b51d7d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177924
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
dialog contains percent symbols instead Cyrillic
Additionally use the same approach to make the expected symbols
appear in the description text view.
Change-Id: I89adafde4305dbe9a6e56481ed246376bc1d94a1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177925
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
(make from 5 existing only one)
Much of what makes up this patch is adapted from existing code that is
used to organize and select macros and to assign macros to shortcut
keys. Comments in the patch say where code is borrowed from.
Known issues:
+ Scripting framework library rename for BeanShell, Java, and JavaScript
always returns fail when there are no macro entries in the library even
though it actually succeeds. The same thing happens using
SvxScriptOrgDialog::renameEntry.
+ Deleting Basic macros from the Macro Manager dialog is not implemented
yet.
Change-Id: If4da04549f8b39675910cbbd1f94dd9a6b73c31a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176254
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
This allows the layer objects overlay to not be done when the value set
for DisableLayerHighlighting is less than the number of objects in the
layer of the tab which the mouse is hovered over in the layer bar.
Change-Id: Ie49ecb11bfb029ada57824c0acbbd133e1fe83b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176809
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
The intent of this patch is to address an issue with the Writer
Navigator page change control reported at https://
ask.libreoffice.org/t/writer-display-single-page/111050
"I have selected View > Normal and View > Whitespace and View> Zoom>
Entire Page. On the bottom right, I’ve chosen the single page icon."
... "It is odd that the page number displayed as you click the
[Navigator Page control spin button] up and down arrows does not
change.."
The patch changes the function used by the page control to determine
the page number of the page in the view to that used by the status
bar page control. It also disables page tracking by the control when
the view is set to Multiple-page view or Book view.
Change-Id: I439bb4493061528f87eaeca3c08a33095adb8192
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173888
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
name in Function list box in the Customize dialog Keyboard tab
In SfxAcceleratorConfigPage Reset, RadioHdl is called just before
m_xGroupLBox->SelectMacro. In RadioHdl an idle timer is started whos
handler gets fired after m_xGroupLBox->SelectMacro is called in
Reset. This makes the selection made in the functions list box by
m_xGroupLBox->SelectMacro in Reset get bonked by the call to
m_xGroupLBox->GroupSelected in SelectHdl called from the idle timer
handler. m_xGroupLBox->GroupSelected always selects the first
function in the function list box. This patch fixes this selection
bonk by calling SelectHdl directly from RadioHdl instead of calling
SelectHdl from an idle timer handler.
Change-Id: I15d26d4611948d61e0a258e9a350d8c952b2b211
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176038
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
by keeping track of the selected entry positions in SwOutlineNodes
instead of iterators in the content tree.
Change-Id: Iad0a477d6e3b25a1d602e3f827f2590c441eb236
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174912
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Tested-by: Jenkins
This enhancement patch for the quick find panel makes the document
order index of the match entry selected in the finds list be shown in
the found times label at the bottom of the panel. For example,
selecting the 6th entry in the finds list for a search that has 25
matches will display "Match 6 of 25 matches."
Change-Id: Iea39e754b0cd75d3ca446781a4b8d2e8651e7d08
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173835
Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org>
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Tested-by: Jenkins
Jim Raykowski