Checking the selection type while pasting does not work and
returns either frame or text. When pasting OLE objects
the selection type must be preset.
Change-Id: I11229d45ba71c148e93c06093f12902cb69f2452
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/206235
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
Tested-by: Jenkins
Editing fields with conditional/hidden text and (previous/next) page number
resets required sub type which invalidates the fields.
Came in with
commit 9257e94e5d
Author: Noel Grandin <noelgrandin@gmail.com>
Date: Sat Jul 5 16:35:17 2025 +0200
Change-Id: Ie07186be2fecad713dceb92f45e29621c99fe41e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/204899
Tested-by: Jenkins
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
Document statistics should be considered as initialized only
if the call to IncrementalDocStatCalculate() came to an end.
Change-Id: I3d83e99fb8b1cfa6c63ca0ee120275fe80c00e47
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202041
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
Tested-by: Jenkins
As a result of e45f187870362ed4448f4a9fb96883b8431887fb the StyleRef
field needs to use the modified style name with (suffix " (user)")
The related JUnit test requires a German locale to detect the
related issue. Otherwise there is no suffix that needs to be
applied to the field.
Change-Id: Iad4257568ad05900df63a6098ba81e926df701e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186150
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Tested-by: Jenkins
Reset character properties that are not repated at run level also if
- the text run is in a table
- there is no style with the index 0 ('Normal')
Change-Id: I840178d727a157b628cb359e5c2798c1455cd555
Change-Id: Id04a501e156e33804e6b99b13688eef1cb899e6e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184277
Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Tested-by: Jenkins
In read only documents a double click on a field executes the
copy field dialog if the field contains text to be copied.
Change-Id: I83042a95c4320f7fa94b04e53f880d0bc5af92a1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183323
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Keeps reference to range in front of the current range to
apply page style to an already available page break in cases
where the section starts with a table.
Page number restart is also applied in the old and the new code.
Remove of dummy section paragraphs introduced with
b696600821 is now only performed
if it is no RTF import.
This causes:
Test name: testHiddenParaBreaks::TestBody
equality assertion failed
- Expected: 3
- Actual : 4
- In <>, XPath '/root/page[2]/body/txt' number of nodes is incorrect
But the file is not imported correctly anyway and this is actually
fixing a bug, so adapt the test file.
rtfimport.cxx:910:Assertion
Test name: (anonymous namespace)::testContSectionPageBreak::TestBody
equality assertion failed
- Expected: THIRD
- Actual :
The problem here is that the extra paragraph that is inserted for \sect
if m_bIgnoreNextContSectBreak is now wrong as it was previously removed
but no longer is, so don't insert the extra paragraph any more.
But leave the extra paragraph in case it's a frame, otherwise we get:
rtfexport8.cxx:91:(anonymous namespace)::testTdf158586_0::TestBody
equality assertion failed
- Expected: 1
- Actual : 2
testTd112202 fails, but Oliver says that extra page 6 is an improvement.
Change-Id: Ie9a22f00e75c797762f52e6b865e32002051988c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182830
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Applying a paragraph style with an attached list style does now
overwrites a list style at a paragraph that had a list(style) applied
Change-Id: I0dc124dc2db167370dab8416a6cc97d563bcc03c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177842
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Tested-by: Jenkins
Labels get their number format usually from source. When copy/pasted
the chart has no connection to a source format anymore.
The related LinkNumberFormatToSource flag is therefore reset.
The label (data series) number format used is now also saved.
Change-Id: I640083ec0036f116dec94cc982317e1e7992328b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180600
Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Tested-by: Jenkins
Table objects in Draw/Impress now have Open/Edit/Copy/Remove hyperlink
entries in context menu of text in table objects.
Change-Id: Id3a5346eb3227871a06d2ea7fdb3ed38c07654c6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177849
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
Some optimization in commit 52abeff6d5836b29dbefe69f284bbd89f6672ae2
ignores paragph attributes if the paragraph is empty.
But it is not empty if it has an active list.
Change-Id: I8885d0f201fc48279263a3d41ec6d660b534ded2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178311
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Store (vml) textbox elements to determine whether to load shape text or
Writer frame. Replay elements in second step and process depending
on the outcome.
- result flag not yet available while processing
- The text shape in docx bugdoc of tdf#152878 can now be loaded as Writer frame
but with wrong size/position.
- should also be applied to drawing ml shapes currently always loaded as Writer
frame
Change-Id: I0778057f9985f5523d91a9d757e00f2968aba350
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174902
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Controls/shapes and images/objects have a display option in tools/options/
Writer/View and in print dialog there is "Form controls" and
"Images and other graphic objects". With this change the options
will actually be applied again.
Change-Id: I52389a8519d863792a7cd126a95a389c90c05a5e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171905
Tested-by: Jenkins
Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Invisible cells in Word are added to Writer tables to get regular
tables. Borders of such cells are allready switched off. Now also
paragraph spacing is removed to not determine the row height.
Change-Id: I27d3d033de54f051527cf29e2655e7a564d1a5ec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176219
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Tested-by: Jenkins
Pasting paragraph with a list into an empty or completely selected
paragraph with lists has been changed:
If the pasted paragraph(s) are all formatted with a list from the
paragraph style then this list will be preferred.
If some the pasted paragraphs including the first one are formatted
with a hard list then these attributes will be preferred.
If all paragraphs have a hard list or no list at all the list at
the target position will be preferred.
Change-Id: I5aa6834d32f7c69b2eb9f8330b282c0ae6fca559
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176478
Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Tested-by: Jenkins
Lines containing EN_SPACES only ignore character height
while calculating line height. In FORMTEXT fieldmarks the character
height of the default EN_SPACES is not ignored.
Change-Id: I8a89f13875f61ed287ce1697a91b42f20bd17192
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176147
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Tested-by: Jenkins
Since 6c04b8356c SVG was added
to the supported clipboard formats but it did not work.
SVG support is now fixed and PNG format is added in the gallery.
Change-Id: Ic9cb2eebfc37bd38605dfaa3a1c353a7532af357
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165908
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
In Word 'invisible' cells at the end of the row are usually marked
with \trwWidthAN. If that information is missing the table needs to
get addtional cells to smaller rows. This prevents extension of
exisition cell to the full width of the table.
Change-Id: I064f3da55665302d8198ed44d9f640a7707c34e8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174385
Tested-by: Jenkins
Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Applying the zoom value works now as expected. The prior
fix mixed up zoom value and 100% and didn't always apply
special zoom values.
Change-Id: I7cf1f34fca5724eea14339535e7614cfecffdd79
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174688
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Tested-by: Jenkins
Pictures/shapes with contour wrap are clipped in Writer.
Word paints the pictures completely while the text flows above
around the contour. This is implemented here for imported documents.
Change-Id: I2a5fd89c18cbb3e88b65bc63e8105cc07b95af82
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173869
Tested-by: Jenkins
Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
In RTF vertical position of paragraphs in frames is handled differenty
than in docx. y position is incremented in docx. To get the same result
in RTF import the y position needs to be incremented, too.
Additionally the state of '\hyphcaps' needs to be imported to fix
the formatting of the wrapped paragraph of the bugdoc tdf#152865.
Change-Id: Ibb9851eb11a0e57ec7b9b1114264456d941cec24
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173525
Tested-by: Jenkins
Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Zoom value is sometimes stored at documents. But users
might prefer local zoom settings over stored values.
Users are now able to set preferred values in Writer's
option dialog.
Change-Id: Ia1c3926aac3dd236f15f84d8dc535d8aa3758238
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171482
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
If a paragraph ends with a line break Word applies the paragraph
properties to the last line. Writer extends the properties of the
las run.
The new line could be smaller or bigger as it would be in Word.
To prevent that a zero width space is added at the end of the
paragraph if the character properties of the run differ to
the properties of the paragraph.
Additionally attributes are not applied to the current font if the
portion is hidden.
Change-Id: I128d67bb621fb99d9db008cccbb93733f255294e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170629
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Word includes the width of horizontal borders when calculating
row height in case the row height is set as "atLeast"
This is now handled via a compat flag for doc/rtf/docx formats.
The default for ODF is unspecified,
which (sanely) continues to treat the row size
of "atLeast" and "fixed" as measuring the same thing.
Change-Id: I37778e5cdc6e083e94a17f50bd0b75a291ededcd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169611
Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
With tdf#160069 the format paintbrush was disabled outside of text
selection and with tdf#160069 target selection was reduced to
text only. The change of tdf#160069 is mostly undone with this
patch.
Change-Id: I8e23ef56206c6749913e2c95870537c3e378f946
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170672
Tested-by: Jenkins
Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
TabStops and spaces are not included in height calculation of paragraphs in Word.
With a compatibility option this is now also set in RTF import.
But if spaces or/or tabstops are the only parts of a line their font size
is taken into account.
The fix 89e7341025b607491c90efdb74708e63d875c1e5%5E%21 from tdf#142404
has been removed because it broke formatting of follow lines.
Change-Id: Id28488438462114bd54c4f8bd15e2ada606c4192
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168788
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Adds SYMBOL field to the list of content that cannot be nested into
an IF field. Prevents importing of SYMBOLs before the IF field.
Change-Id: I0c2f92d7893c189a42e835ffd4b9fd6e0e23a17b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169900
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Tested-by: Jenkins
With this, both edit and add fields dialog should look near-identical
at this spot (seems extra rows are needed for native dialogs like gtk,
while Windows wants the extra height-request).
Change-Id: Iafee3d60d33c9eee6020e9ef49aaac900222a0e6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170835
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
In documents containing tables with rows having different right margins
an additional cell is added to fill the gap.
These cells should be 'invisible' and therefore need to have no border.
Change-Id: I802310251f36fb6b2c00f3cb38786f438e4565a6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170179
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Applying AutoFormat to large selections may take really long.
A warning has been added to warn users.
Additionally a progress is shown while AutoFormat is working.
Change-Id: I74909a6243748ebfe0089406ebe947bb48eb93d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167950
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Tested-by: Jenkins
The SfxPoolItem has a new member SfxItemType m_eItemType to
compare types based on enums instead of typeinfo() which
consumes a lot of time e.g. while AutoFormat is running
Change-Id: I033ce67bc9a28ee4790f162380314de85fb4154e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166452
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
Oliver Specht