100 Commits
Author SHA1 Message Date
Pranam Lashkari 208f2d6a7b sw: restore the deleted word on undo when tracked changes are hidden
Deleting a word that sits inside an existing tracked formatting change,
with change tracking on but tracked changes hidden, then undoing the
deletion, left the word invisible until Show Changes was switched on again.

Such a deletion produces a redline that is a delete with a format change
stacked on top of it. SwRangeRedline::InvalidateRange only sent the
SwRedlineDelText and SwRedlineUnDelText hints when GetType() was Delete,
but GetType() returns the top of the stack, which is Format here, so the
hints were never sent. Without SwRedlineUnDelText the paragraph frame kept
the stale extents in its merged paragraph and went on hiding the word until
the next full reformat, which toggling Show Changes happens to trigger.

Look through a stacked format change with GetTypeIgnoringAdditonalFormat(),
the same way Show() and Hide() already do, so the hints are sent for these
redlines too and the merged paragraph updates itself on undo.

Change-Id: I8070b89de4d7fb4485a4609d90cdfb93f1db4b29
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/5924
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
(cherry picked from commit 60dbffe37033d6ec947e4f386dffe2e6ef7ce0f6)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/207735
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
2026-07-08 11:21:37 +02:00
Pranam Lashkari 417ebad37a Autocorrect: undo of a typographic quote left a straight quote behind
When an apostrophe or quotation mark is typed, autocorrect replaces it
with the matching typographic quote. This was done in two edits: the
typed straight character was inserted first, then replaced with the
typographic one. Since each edit is its own undo step, undoing the
autocorrect first turned the quote back into a straight quote and only a
second undo removed it. In languages that never use straight quotes, for
example French, typing 'un and undoing left a stray straight quote in the
text.

Build the typographic quote with a single edit, so one undo removes the
whole quote.

The change is limited to the quote handling. Autocorrections that insert
a character and then act on something else, such as turning a web or mail
address into a link after a space, keep their existing per-step undo

Change-Id: Ibf47fb8f37d29d5ba180ed692f730d20e9f3e431
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/5897
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit e2ba52e1996f81ff3b93fa70ecf625b7709d07fb)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/207621
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
2026-07-06 10:51:31 +02:00
Pranam Lashkari 1bb7291f2f starmath OOXML import: keep math operators bare inside multi-character runs
When a DOCX math formula put an operator and its operand in one run, for
example "-4", the OOXML import quoted the operator as literal text. The
minus then rendered as a short text hyphen (U+002D) in the text font
instead of a full-length minus sign (U+2212) in the math font, so the
two minus signs in a formula like the quadratic formula came out at
different lengths.

The earlier fix that stopped quoting single-character operator runs only
covered runs that held the operator on its own. A run that combined the
operator with its operand still went through the per-character loop in
encloseOrEscapeLiteral, which quoted every operator character.

Keep the standard math operators (+, -, *, /, =, <, >) bare in that loop
too, using the existing isSingleCharMathOperator helper, and drop them
from the delimiter table that does the quoting. A run like "-4" now
imports as the minus operator followed by 4, so StarMath renders it with
the math-font glyph and both minus signs match.

Change-Id: I38ed1a9fb344cc1a44f391e3ce3f097d8f16d09c
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/4681
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit 1be656242e4c3cf42ad246bb2a6e30b3df8ce2d1)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/207201
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2026-06-23 16:35:19 +02:00
Pranam Lashkari 38f8e5a53b sw: reset stale OOXML ParaId/ParentId when copying comment fields
When copying annotations from a DOCX-imported document, the copied
SwPostItField retained the original m_nParaId and m_nParentId values.
These OOXML paragraph IDs became stale duplicates, causing
UpdatePostItsParentInfo (sidebar rebuild) and the OOXML export to
match replies to the wrong parent via ParaId, breaking comment threads
after paste or save/reload.

Reset both IDs to 0 during copy so that parent-child resolution falls
through to PostItId and ParentName based matching, which are correctly
updated by EstablishParentChildRelationsOfComments.

Change-Id: Ia910edbdafebc9acff6dc91f9052a6a98d09f1ed
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/3222
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit 9c721d2f0f14f48b4f2255bf7717b3b3652620fe)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/206653
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2026-06-16 01:21:02 +02:00
Pranam Lashkari 07b1781475 starmath OOXML import: stop quoting single-char math operators as literal text
When importing OOXML math formulas, encloseOrEscapeLiteral() quoted
every delimiter character, including standard math operators like =, -,
and +. StarMath then rendered them as text-font glyphs instead of
math-font operators. This caused the equals sign to misalign with the
fraction bar and the minus sign to render as a shorter text hyphen.

Skip quoting for single-character standard math operators (+, -, *, /,
=, <, >) so StarMath treats them as proper operators with correct glyph
selection and alignment.

A bare operator alone inside braces (e.g. rsup {+}) is a StarMath parse
error because the parser expects an operand. Add a safety re-quote in
readOMathArgInElement() for that case, since all its callers wrap the
result in {...}

Change-Id: I22f01a25212d3c030e8104a00418ab1f6bdb2d07
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/3329
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit f2ccbc5a30dbac56b600747af655076d6f7058c2)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205823
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2026-05-29 13:59:37 +02:00
Pranam Lashkari f5d7760f18 impress: mark document modified on slide section changes
Section operations (add, remove, rename, move) were missing
SetModified() calls, so the document was never flagged as edited.
This prevented auto-save in Online

Change-Id: I4af1a57d0670aa605ca87b8cbb0c01f3f80f6a24
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/1475
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/1621
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
(cherry picked from commit e16db4c44aca838c01d297aaa78b91636f801c87)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205184
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2026-05-14 21:16:29 +02:00
Pranam Lashkari cddbd57195 sd: fix MoveSection downward overshoot
MoveSection's downward branch computed nTargetPage with an extra
-nSrcCount adjustment, assuming MoveSelectedPages pre-removes the
selected pages. It doesn't — MovePages() moves pages in place and
interprets nTargetPage in the current ordering. The adjustment
caused the source block to land in the middle of the target
section instead of after it, while section metadata still claimed
the split contents as one section.

Use nTargetEnd - 1 directly. Extend the Move{Up,Down}{PPTX,ODP}
tests to capture each section's SdPage* set before the move and
assert the same set lands under the expected section afterwards —
count-only assertions missed this class of failure.

Change-Id: I73bdd8e5b1c3a0c0687385fd6f16a3b151f0d481
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/1271
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/1620
Tested-by: Pranam Lashkari <lpranam@collabora.com>
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
(cherry picked from commit 71fbe7ad6c1af884b8a998ca754977e75027d747)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205183
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2026-05-14 15:41:35 +02:00
Pranam Lashkari 5142c825f3 slide sections: implemented undo/redo
UndoSlideSection captures the sections vector before the mutation
and, on first Undo(), captures the post-mutation state for Redo —
matching the UndoAnimation lazy-snapshot pattern. Wired into
Add/Remove/Rename/MoveSection in both SlotManager and DrawViewShell;
Move uses BegUndo/EndUndo to group with MovePages()'s own undos so
the whole operation reverts atomically.

Change-Id: I755b2118511eb5e629980b3b644fe24c8edac9cf
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/1251
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/1619
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
Tested-by: Pranam Lashkari <lpranam@collabora.com>
(cherry picked from commit b9fafb69b1259dcb8e63e8f8e5877a58291a2317)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205182
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2026-05-14 15:41:24 +02:00
Pranam Lashkari 05c61b0b2a sd: expose slide sections to Kit for Collabora Online
Add Kit support for Impress slide sections so that Online
can display section headers in the slide panel and allow
users to add, remove, rename, and move sections.

- Include sections array in getPresentationInfo() output with
  name, id, startIndex, and slideCount for each section.
- Register section SIDs (Add, Remove, Rename, Move Up/Down) on
  the DrawViewShell so they are reachable via Kit .uno dispatch.
- Add DrawViewShell handlers using GetActualPage() for reliable
  page resolution in Kit mode.
- Add SectionIndex and Name parameters to SID_RENAME_SLIDE_SECTION
  so the rename can accept arguments from the online client.

Change-Id: I54c2827af2a5735a1d8f62131ce52a3f8778428d
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/1097
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/1616
Tested-by: Pranam Lashkari <lpranam@collabora.com>
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
(cherry picked from commit 7c1d5cad871811ac0e511b84ffff3d5df46b0cfa)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205181
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2026-05-14 14:32:06 +02:00
Pranam Lashkari c3ccc3109b sd: SlideSectionManager cleanup - remove redundant SaveToDocument
The "SlideSections" UNO property is just a view onto our own
in-memory maSections (the getter calls GetSectionsAsPropertyValues,
the setter calls SetSectionsFromPropertyValues). Calling
setPropertyValue from SaveToDocument was therefore a roundtrip:
maSections -> PropertyValue -> maSections, with no actual
persistence. The data was already in its final place after each
mutation.

Remove SaveToDocument() and all its callers; mutations to
maSections are the final state. Also drop the includes that
were only needed by it: DrawDocShell.hxx, XPropertySet.hpp,
XPropertySetInfo.hpp, XModel.hpp, sal/log.hxx.

Change-Id: I2fda95a52ba067b69f4492b8abaec7e1eb145f7b
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/1232
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/1618
Tested-by: Pranam Lashkari <lpranam@collabora.com>
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
(cherry picked from commit b43943b73d5b98b180eac2093bc0fe9c1f58192c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205171
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2026-05-14 00:27:49 +02:00
Pranam Lashkari c98ee00760 slide section: updated tests
1. added new tests for adding sections
2. moved section tests into new file (kept export related test untouched)

Change-Id: Ia1e42bce12ff269cdd2e259afd4fe1b48ffba34e
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/1100
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/1617
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
Tested-by: Pranam Lashkari <lpranam@collabora.com>
(cherry picked from commit 0f27632687c9bb8218bb5d4abae3a0ea2f4ad7d1)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205170
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
2026-05-14 00:27:39 +02:00
Pranam Lashkari a226c37e40 Impress: replace InteropGrabBag with native SlideSections UNO property
Add "SlideSections" document property on SdXImpressDocument and
migrate all section import/export paths from InteropGrabBag to
use it directly. SlideSectionManager is now the authoritative
model, accessible from any module via standard UNO property access.

Change-Id: I276cc968e3be9a5d3599e2d7e1c581e5b1d84c1c
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/1030
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/1615
Tested-by: Pranam Lashkari <lpranam@collabora.com>
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
(cherry picked from commit 03ce4ec8b3d3752cbf5377a7f21f24affd73b9c4)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205169
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2026-05-14 00:27:18 +02:00
Pranam Lashkari 746bdfb0b8 Impress: add section context menu commands
Add UI commands for managing slide sections in the slide panel:
- Add Section, Remove Section, Rename Section
- Move Section Up, Move Section Down

Change-Id: I27ad92667230ad5eab9a686505f475dd29ab02fd
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/896
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit 78ae446cdfaa5496be2478b37b4e2047dab487fd)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205168
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2026-05-14 00:27:09 +02:00
Pranam Lashkari 7df9cd36dd Updated slide section tests
1. open the pptx file with sections
2. export the PPTX with sections to ODP file
3. Open ODP file with sections
4. Export ODP file with sections to PPTX
5. Rename the Section in pptx
6. Move section up in pptx
7. Move section down in pptx
8. Rename the Section in ODP
9. Move section up in ODP
10. Move section down in ODP

Change-Id: Ia8e429177f62ed6ac719d05f67a8f74497eac0db
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/966
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit a94e1527137aba244a72f4499f7a8f06e5768a04)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205055
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
2026-05-12 08:33:46 +02:00
Pranam Lashkari dc84af7885 PPTX/ODP export: fix section round-trip issues
PPTX export (pptx-epptooxml.cxx):
- Add xmlns:p14 namespace declaration on <p14:sectionLst>,
  required by Office 365 to parse the extension block
- Add position-based fallback when slide name lookup fails
  (e.g. after ODP round-trip where "Slide 1" becomes "page1")
- Make section extension URI a constexpr string

ODP export (sdxmlexp.cxx):
- Resolve grab bag slide names to current draw:page names by
  position, preventing stale name mismatch between
  <loext:section-slide loext:name="..."> and <draw:page draw:name="...">

Change-Id: Id816072838da1a8be4c638310ec252b2eaeaf041
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/895
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit 78766729df864a2d46ed02e95fba7ab4ebf3f689)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205054
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2026-05-12 08:33:39 +02:00
Pranam Lashkari fcd5bf2fca Impress: display section headers in slide sorter panel
Add visual section name headers above each section's first slide
row in the slide panel

Change-Id: I7e42b6659ccc2e68bd22ce91df8b850b6d250815
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/894
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit d36f9ebbcf7ce426bf7ed6365a60f1f0c434e8d2)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205053
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
2026-05-12 08:33:31 +02:00
Pranam Lashkari d7cc529bd6 Impress: add SlideSectionManager for slide section model
Add SlideSectionManager as an in-memory model that bridges the
InteropGrabBag (used for PPTX/ODP round-trip) and the Impress UI.

Sections are stored as a sorted vector of SlideSection structs,
each holding a name, GUID, and the 0-based start index of the
first slide.

Change-Id: I23c109fd2c7e00e288c1e8793fa7a1d53290169b
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/893
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit 9e585554af9824ef076ed5e41808d622863f96e9)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205052
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2026-05-12 08:33:25 +02:00
Pranam Lashkari 85820592b3 Add tests for slide section round-trip preservation
- testSlideSections: PPTX -> PPTX export verifies section names,
  counts, and slide assignments in the exported presentation.xml.

- testSlideSectionsODP: PPTX -> ODP export verifies the
  loext:section-list structure in content.xml with correct section
  names and slide counts.

- testSlideSectionsODPRoundTrip: PPTX -> ODP -> reload -> PPTX
  full round-trip verifies sections survive the ODP intermediate
  format with correct names and slide assignments.

Change-Id: Ib21c5b430c573ee24f163e66c3374269bcd564e4
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/714
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit b248afb794f0c43a063754e3fc1ebd812076a9af)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205051
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2026-05-11 22:16:02 +02:00
Pranam Lashkari a95c2dfee5 ODP: export and import slide sections via loext:section-list
Store slide sections in ODP files using a new loext: extension
element, written only in ODFSVER_EXTENDED mode:

  <loext:section-list>
    <loext:section loext:name="Section Name"
                   loext:identifier="{GUID}">
      <loext:section-slide loext:name="Slide1"/>
    </loext:section>
  </loext:section-list>

Export (sdxmlexp.cxx):
  Add exportSections() method that reads OOXSectionList from
  InteropGrabBag and writes the loext elements. Section names,
  GUIDs, and slide page names are written directly since the
  grab bag already stores names.

Import (ximpbody.cxx):
  Add SdXMLSectionListContext and SdXMLSectionContext classes
  that parse the loext:section-list structure and store sections
  back into InteropGrabBag with slide names and optional GUIDs.
  Hook into SdXMLBodyContext::createFastChildContext.

This enables full PPTX -> ODP -> PPTX round-trip preservation
of slide sections including their GUIDs.

Change-Id: Ic1c040d06c8c890699b7dfa4974694a2ea204f90
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/713
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit b0c9f8bd70a96b2e3d432993260920d3739a2eda)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205050
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
2026-05-11 20:54:57 +02:00
Pranam Lashkari e1c41f9736 PPTX export: write slide sections to presentation.xml
Write the p14:sectionLst element inside p:extLst when exporting
to PPTX, reading section data from the document's InteropGrabBag.

Resolve slide page names back to PPTX slide IDs at export time by
building a name-to-index map from the current draw pages, then
mapping indices to the slide IDs assigned during export. This
approach naturally handles slide deletion (deleted slide names
simply don't match) and reordering (names are position-independent).

Generate a new GUID via comphelper::xml::generateGUIDString() for
sections that lack an Id (e.g. after ODP round-trip from older
files), ensuring PowerPoint always sees valid section identifiers.

Track slide IDs in maSlideIdsInOrder during ImplWriteSlide() so
WriteSections() can map slide indices to the correct PPTX IDs.

Change-Id: I28909a45d684d35416368d3fdcd5c78fc3fbff5f
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/712
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit eb36cc655b791322ead8117e17201fd6749a87fc)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205049
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2026-05-11 20:54:39 +02:00
Pranam Lashkari 2320d291e8 PPTX import: parse slide sections from presentation.xml
PowerPoint stores slide sections in presentation.xml as
<p14:sectionLst> inside <p:extLst>. Each section has a name,
a GUID identifier, and a list of slide IDs referencing slides
in that section.

Store sections in the document's InteropGrabBag under the key
"OOXSectionList". Each section stores its name, GUID, and a list
of slide page names (not indices) so that sections remain valid
when slides are deleted or reordered after import.

Change-Id: I2e56746e7d5f79dd071695507ff030522d26c8ec
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/711
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit 5596879527f6b317eb4692ae8c9032e72898bf06)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205048
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
2026-05-11 20:54:33 +02:00
Pranam Lashkari b3bdd9e1a0 Add XML tokens for slide sections interop
Added 'section-list' and 'section-slide' tokens for storing
slide sections in ODP files

Change-Id: I24fb220c434c1a972fb50712d3285834698c0f68
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/710
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit 839dd1b514cd2f8bdad036ef2b920d6fff261afd)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205047
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
2026-05-11 20:54:28 +02:00
Pranam Lashkari 27dd3aab2f LOK: send notification when autofilter is changed
Change-Id: I4b1e45461099404cffc0fe9cbbc5d45c09736bad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197302
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit 3ad33e68f76aac47546920825c8081f166e37ae3)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197349
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
2026-01-16 10:54:27 +01:00
Pranam Lashkari 966cbcaeea tdf#170171 math: allow equestions to end without opening brackets
problem:
some user complained equation not rendering correctly
if it ended with opening brackets while it worked fine in MSO

i.e: [0;+∞[

Change-Id: Iccfbfd0782379985736cdc181479f167ca0beb95
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196197
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
(cherry picked from commit 7a4ea5e1e197798ec0c39c442bfc51397e00d1c4)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196303
Tested-by: Jenkins
2026-01-08 18:57:31 +01:00
Pranam Lashkari 3998e5ca53 tdf#162972 math: special treatment for apostrophe(') in MSO
problem:
in MSO is only apostrophe is in superscript, MSO treats it as normal text

i.e: in question 2' ^' both apostrophe will be displayed on same level

Change-Id: Idc1eb144115ed0cb51c18a76b6d8b9423eb5e910
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196198
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit 3c20957c43c3a8bb86b21a22acdbc762efc82566)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196304
Tested-by: Jenkins
2026-01-07 22:19:17 +01:00
Pranam Lashkari 000591bdd5 Revert "svx: fixed textbox text always black on dark theme"
This reverts commit c52f139b4f.

these changes are not needed after b1a6bc7a

Change-Id: Id71c57d383703c182dec790b66e96563ed8fbac2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196404
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196605
Tested-by: Jenkins
2026-01-06 15:07:29 +01:00
Pranam Lashkari c1e5d16513 editeng: for automatic font color also check char background
problem:
in automatic color we only check doc color and background color(i.e: cell color)
text can also have highlight color which also should be taken
in cosideration when chosing automatic color

Change-Id: I3689baa5cc95bc8d3b855251ae92c91a82102db3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196403
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196604
2026-01-06 15:07:22 +01:00
Pranam Lashkari bca4888319 svx: update background color of editing outliner view
problem:
when textbox is in edit mode and user changed the theme
automatic font color was not updated until textbox editing ended
this resulted in automatic color staying accoring to previous theme

Change-Id: I522e9244621345853d6ede45403e12a1ac4ed94d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196402
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196600
2026-01-06 13:19:18 +01:00
Pranam Lashkari d2dc364ca3 tdf#169843 math: OOXML set letter not interpreted correctly
problem:
OOXML has special property to define set names
m:scr with value "double-struck" means text should be
interpreted as set names and double-struck letters should be used

Change-Id: I8acefb369694ae901fc4df2505a85d0691a2cb16
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196199
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
(cherry picked from commit f325e0de3447c0403656ebb2a2fe4789aa59e78e)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196305
Tested-by: Jenkins
2026-01-05 10:05:28 +01:00
Pranam Lashkari f97b7742d7 jsdialog: allow treelist lazy loading
mark entries visible and update jsdialogs when
treelists are scrolled and new entries are visible

Change-Id: I0c54cd2ae5473b6148f7d20c0b083066e28450e0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195318
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit 777fff6a8088061e3d87bff84e2cd3015ebd2112)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196306
Tested-by: Jenkins
2026-01-05 10:01:49 +01:00
Pranam Lashkari 65ca233db9 tdf#168261: resume ScInputHandler even if error not displayed
problem:
regression from 72bbb0dd4a
when data validity dialog was not displayed, error function returned early
this caused issue with cell invalid data cleaning and it was not possible
to enter new data in any new cell

to reproduce:
select data validity as list and also disable error message showing
enter the invalid data in the validity cell
subsequently its not possible to type in any cells

Change-Id: Ia2157ae57ca90dd9365daae7881640a00c3f1216
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193141
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
Tested-by: Jenkins
2025-11-03 15:38:03 +01:00
Pranam Lashkari 0b9b82f41a tdf#167126: resume ScInputHandler even if error not displayed
problem:
regression from 72bbb0dd4a
when data validity dialog was not displayed, error function returned early
this caused issue with cell invalid data cleaning and it was not possible
to enter new data in any new cell

Change-Id: I612ea8b9c651afba1095fc14726e5398484207f5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193186
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
Tested-by: Jenkins
2025-11-03 15:36:58 +01:00
Pranam Lashkari 258618e4e2 LOK: send slide unique id in presentationInfo
Change-Id: I56df8ec5fb75a958defddd254a28ee4d187b27b6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192181
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
(cherry picked from commit a2a7e98c2f8d6462897b6dd97ad90b284da09c77)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192285
Tested-by: Jenkins
2025-10-14 15:13:19 +02:00
Pranam Lashkari ef7151c271 tdf#156263: fixes freeze after opening data validity dialog
after making dialog async ScValidationRegisteredDlg was destroyed while
dialog is still running causing undefined behaviour

regression caused by 63b26e8e20

Change-Id: Idef30f12b88c46cb30a01ffb12588bb11e279750
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191105
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191116
Tested-by: Jenkins
2025-09-18 14:09:30 +02:00
Pranam Lashkari 79c2accf1e lok: use locale units for all dialogs
problem:
in lok table dialog used inches when language was de
but sidebar was set correctly to cm

continues work from e2708fecb3

Change-Id: I59b2aa28ec219c7298de6d0abd712617e9ddf7a6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190580
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit ca185af0838243290ee204f049923ef3bd39d236)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190706
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
Tested-by: Jenkins
2025-09-09 17:53:27 +02:00
Pranam Lashkari bd246eb473 svx: added parameters for writer page margin uno commands
Change-Id: Ic395e94b1fd3560f20403bc27dd520d0d1f68956
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189889
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit 8a9eea0d01b9a8ad0eaf476788ca0a200a7712dd)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190502
Tested-by: Jenkins
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2025-09-04 12:40:22 +02:00
Pranam Lashkari 2bca699285 uno: handle parameters to LineStyle in writer(SID_FRAME_LINESTYLE)
new parameters introduced in 0357d749487ad540a3779d2c3af23357c942620b

Change-Id: I7b20090901a88110710937f6aae249c23f48f9a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190472
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
(cherry picked from commit f65cceb2c43ffe9bed845a31aaf3ceb6f80e342d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190501
Tested-by: Jenkins
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2025-09-02 11:25:05 +02:00
Pranam Lashkari e32f6f7e4f sw: handle uno:Orientation for writer
Change-Id: I771a6db9cda410912b323918d04f561ab2b3ac7b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189926
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
(cherry picked from commit 1b235ee7d1190b5cb020fd40aae9ec5c8d2b383d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190504
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
Tested-by: Jenkins
2025-09-02 11:24:52 +02:00
Pranam Lashkari 65639e909f svx: added parameter for writer page size uno command
parameter for SID_ATTR_PAGE_SIZE

Change-Id: I3f44dc8bc9397893f9214ee8915eb592d32c6894
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189890
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
(cherry picked from commit fb4f5e6a68fb74b37356bb9ca11f89df1c106184)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190503
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
Tested-by: Jenkins
2025-09-02 11:24:40 +02:00
Pranam Lashkari b50cc9c40e sc: disable line style button if border is not set
problem:
sidebar would disable this button as and when needed but
toolbar was not doing the same

Change-Id: I08ba037f630b64ee9048112282c4fa83835eaf50
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189557
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
(cherry picked from commit a4339162a6ca17f3fffe599086e7db5c9e101c78)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189650
Tested-by: Jenkins
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2025-08-15 11:55:42 +02:00
Pranam Lashkari 49956b7a30 uno: added parameters to LineStyle (SID_FRAME_LINESTYLE)
Change-Id: I0993bd10da42bfc29dedce3d50524889bc7a3447
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189518
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
(cherry picked from commit 0357d749487ad540a3779d2c3af23357c942620b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189649
Tested-by: Jenkins
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2025-08-15 11:55:30 +02:00
Pranam Lashkari 26e22145fe kit: always send text change update for font combobox
problem:
in online some font widgets are duplicated at multiple places,
if the text update messages are not sent then text is only
reflected in the combobox where actions were performed and rest
are not updated

Change-Id: I147e16150c6acb646cc1578fb093a246e4f3a1ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188303
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
(cherry picked from commit b7b38179f1297bba60348d5b4be646003f3212e3)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189462
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
Tested-by: Jenkins
2025-08-13 14:32:29 +02:00
Pranam Lashkari 2568245da5 lok: use locale units in dialogs and table sidebar
this patch updates fix for the dialog which were not fixed by e2708fecb3
part 3

Change-Id: Icae1254a6a6825ee7b4c78a28c9b8d328b7de4a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185694
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit 1cdff82bfcbf9192ad6e477763e49d7fe3b7de3a)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185799
Tested-by: Jenkins
2025-07-02 12:18:08 +02:00
Pranam Lashkari 3b379b6dfd sw: avoid front expansion of field with NeverExpand flag
improvment on d6b8e20c9cdca69d684390c264e775a708777846

Change-Id: I572090466f4df7c93099244d7f07e62c1468176e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185316
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185351
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185555
Tested-by: Jenkins
2025-05-23 10:13:42 +02:00
Pranam Lashkari 6c3c9d3d94 sw: introduce field parameter to avoid expanding field
problem:
in online when a reference mark field is inserted and you start
typing after it, field always expanded.

problem was detected when using zotero citations

patch reverts some part of 58e5e3208a

Change-Id: Ia664b82dae7a2385d9d0a3cf16276bb3ef39e61c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184711
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185554
Tested-by: Jenkins
2025-05-23 10:13:34 +02:00
Pranam Lashkari e7e48682cc sd: use slide(SdPage/Part) selection for current view only
problem:
in LOK when multipe users select the different slides some operations may fail
i.e:
- user A and B opens the document,
- User B selects slide 4
- User A selects slide 1
(without this patch SdPage will only concider slide 1 selected)
- Then user B tries to drag and drop slide 4 above the slide 1
- now core will think slide 1 is selected and need to put
it above slide 1 that means nothing happens

Change-Id: Ia9ebe531ddb1c21ffaa1435d9cc777750b4ca24c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184629
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
(cherry picked from commit aee332547295c78b3bcda38b67ba3f1ec2b0fc06)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184842
Tested-by: Jenkins
2025-04-30 20:32:58 +02:00
Pranam Lashkari 7dddd44906 sd: copy slides from instance to another
in core this works between multiple instances (ie: multi users)
in online now its will be possible to copy slides from one
presentation to another

in core to test with multiple instance:
./instdir/program/soffice -env:UserInstallation=file:///tmp/test1 &
./instdir/program/soffice -env:UserInstallation=file:///tmp/test2 &

Co-authored-by: Pranam Lashkari <lpranam@collabora.com>
Co-authored-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I95b4d332968fd8895b1d950ea620ea37a85524c8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184232
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit cdaf9a06f5467f0f0167885a3e44ecc3cdd87b76)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184262
Tested-by: Jenkins
2025-04-17 10:04:58 +02:00
Pranam Lashkari f2ed4a8493 uno: introduced command to copy slides
problem:
in online though kit process it was difficult to
trigger the slidesorter clipboard to copy slides.
Difficulty was caused by slidesorter using its
own viewshell to copy and online triggering copy
command on drawviewshell.
It's more convenient to use a different command
rather than jumping between viewshells in this case

Change-Id: I347ad0044efa64a3e5dcd26aeb16fe5b8103bb12
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183924
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2025-04-09 15:27:52 +02:00
Pranam Lashkari e8c44d23c7 jsdialog: enabled writer setboarder style popup
Change-Id: I6ac3f81de49d91ef46ada4b5f881404155cab3c9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182366
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
(cherry picked from commit 032659457188fe5a96fea3945754ad944ffade38)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182368
Tested-by: Jenkins
2025-02-28 22:49:16 +01:00
Pranam Lashkari dc80175639 sc comment kit: use iso format dates
problem:
Online expects iso format dates, different date type confuses online as there is no way to identify in online which format date is sent

Change-Id: I84d83005287869cea44f27c1d5a337bd67975bab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182243
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
(cherry picked from commit 432e75c8997dafca72ab816ac5decee7bfed21c7)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182312
Tested-by: Jenkins
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2025-02-27 20:31:52 +01:00
Pranam Lashkari 19df53668c tdf#162070: enclose delimiters in in formula inside quotes
problem:
1. some characters were not correctly interpreted inside formulas
casuing them to appear as inverted question mark.
2. when some special symbols like 'abs' were inserted as normal string
were replaced with symbols and sometimes also causing to invalidate formula
and add inverted question mark

Note:
So in MSO if you use operator with spaces on either size it will be treated as
literal and when you use them without space in either side it will be operator.
This same thing goes for all operators.

In libre office you will be able to see visual difference
in operator and literal one is slightly bold than other.

Change-Id: Id1b0cda36727c1749619adc858b27212057b37e3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176421
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177797
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2025-02-27 10:45:28 +01:00
Pranam Lashkari f6944d251f sc comment: use standerd ISO date format for comment
problem:
in online when comments are stored in one language (i.e: en-us)
and opened in another language(i.e: de) it caused months and
day to be swapped which caused incorrect date stamp for comment

Change-Id: Ibaf3a5cc30389f261c14381356dbc8bdcf794639
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182093
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182119
Tested-by: Jenkins
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2025-02-25 00:18:48 +01:00
Pranam Lashkari 63b26e8e20 sc: convert data validity dialog async
Change-Id: Ifef985c15a58c1c081f9a011e174e3b2547f3ea2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179402
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180704
Tested-by: Jenkins
2025-01-29 10:24:10 +01:00
Pranam Lashkari 1ee33246ae lok: send username of the person who removed comments
This can be userful to know when a user is editing comment
and another user deletes it.
It will help to identify and inform about
the conflict to relevent users only

Change-Id: I81f5edc8f6cbb85ad00e03b5bf668b68eeae1ad8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179298
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
(cherry picked from commit 0b3e73526496875735eeb657929d94897a840b02)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180289
Tested-by: Jenkins
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2025-01-17 14:41:51 +01:00
Pranam Lashkari 72bbb0dd4a sc: make data validy error dialog async (invalid value error)
Change-Id: Icd077776b26e21b226b4dee5beb1a5ff6dcf301a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179509
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit 495be2dcb34d22af59a2028d3a686a0d48774166)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180286
Tested-by: Jenkins
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2025-01-17 14:41:36 +01:00
Pranam Lashkari 1de4b9ae2b math: store main viewshell id in math view shell
problem:
when we enter to edit a formula a new view shell is created.
In LOK all the JSwidgets would be mapped to this window id.
But when LOK requests widgets we get the requests from the main viewshell
and we can't find any widgets mapped to the main viewshell
which means LOK can't load any widgets.

Currently there's no mechanism to find the sub viewshell

Change-Id: I4f9ce161101ef6815f4d9e712d9bd42f0dc83ea3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180038
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180287
Tested-by: Jenkins
2025-01-16 15:44:08 +01:00
Pranam Lashkari 1dd45462fd svx: avoid emptying sidebar properties
these properties are either updated or reformatted based on *Blanked variables so no need to do an extra update

problem:
emptying these properties causes to lose measurement units in LOK. It happens due to second time this sidebar is not completly initialised but just updated the value of the fields so units are lost for LOK.

Change-Id: Id32638686578652ab4ffa25a638b5308c46eea2b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179583
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180288
Tested-by: Jenkins
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2025-01-16 11:44:30 +01:00
Pranam Lashkari 161cd3c3a2 lok: use locale units in dialogs and sidebar
this patch updates fix for the dialog which were not fixed by e2708fecb3

Change-Id: I7a9531d5af5b388cd6d763ea8c8d62ff4e7f12ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177896
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178203
Tested-by: Jenkins
2024-12-10 11:28:36 +01:00
Pranam Lashkari c9763a9f16 LOK: don't recreate the dialogs of an old view when loading new views
follow up for f5ebf512ccd3d5ae3af5fe706b411a85fa19182d

now same actions are performed on all the dialogs

Change-Id: I6531a766327dda106770a2c513ebd492dea7c655
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176933
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
(cherry picked from commit 2fba6df7242586870988b62909156538b42c2bc0)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177892
Tested-by: Jenkins
2024-12-05 18:49:58 +01:00
Pranam Lashkari f643a98b2b Revert "sc: manage conditional format with simpler dialog"
This reverts commit 58c3f70c514ef4ce0de5419ab7daa3bebfb96f37.

Change-Id: I500a96508684547c158cdd1814540a4b24f667d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177290
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177341
Tested-by: Jenkins
2024-12-03 16:12:38 +01:00
Pranam Lashkari acc8b8c49d Revert "sc: added date condition option in conditional format manage dialog"
This reverts commit 9928f1fa147d4ff838cbf6fcfe0d976ecef97cef.

Change-Id: Ieb7dfdeccaffed4ad81ff9b5b0eb3b3b49fd8d05
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177289
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177340
Tested-by: Pranam Lashkari <lpranam@collabora.com>
2024-12-03 16:12:31 +01:00
Pranam Lashkari ec1b094127 Revert "sc: now formula conditions can be managed
...from condition format manager"

This reverts commit 8374dd472cb4a2e2edab969a73ca88ffeaadbcd8.

Change-Id: I532c17596adccfa5c88baaf2df897f3ffbee0fe6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177288
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177339
Tested-by: Pranam Lashkari <lpranam@collabora.com>
2024-12-03 16:08:36 +01:00
Pranam Lashkari eb933099a5 Revert "sc: preview style in easy format dialog"
This reverts commit 2661be5f8fb28ada80b4f5336d59f54b520bf614.

Change-Id: Ie3482641cbbb34baa866a679c782221d2d513df1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177287
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177338
Tested-by: Jenkins
2024-12-03 16:08:26 +01:00
Pranam Lashkari 904b515782 Revert "sc: give warning about condition input in easy condition dialog"
This reverts commit 2a6dc9dfd84b278352608f475a600e866846af2e.

Change-Id: I061f8ebfbf0115dd55d357c325a3905c5a774a57
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177286
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177337
Tested-by: Jenkins
2024-12-03 16:08:19 +01:00
Pranam Lashkari 70b9e65eae Revert "sc: display all the conditions of same ranges
...in conditional format manager"

This reverts commit 399253ca8ca391504ff1f6a3709fb41d438ce2d6.

Change-Id: I3c0a79ee0a34364d0a51ab4736810f35efe4bfdc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177285
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177336
Tested-by: Jenkins
2024-12-03 16:08:11 +01:00
Pranam Lashkari 36108acc12 Revert "sc: now conditions can be edited from easy conditional format dialog"
This reverts commit 8115c82f1f7f2621e2d99c93e1a3b2196279602a.

Change-Id: Ie3f389561ee8f734ac76b3dec352382281f91c30
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177284
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177335
Tested-by: Pranam Lashkari <lpranam@collabora.com>
2024-12-03 16:08:04 +01:00
Pranam Lashkari dcf48b9d2d Revert "sc: prefill easy condition dialog with editing condition data"
This reverts commit 598e93b1b11f4cdff96f6117c2a7d35f3698fd23.

Change-Id: Ifdbc8920f232d388eac2a07cd6e2e2dece204a7a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177283
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177334
Tested-by: Jenkins
2024-12-03 16:07:56 +01:00
Pranam Lashkari 85ced7dad8 LOK: use boolean or disabled payload for EditDoc
it is more appropriate state variable for this particular command,
as in many cases its disabled and that can not be treated as false
as document still maybe editable

Change-Id: Ib19a0cc087518a18bf295abd08b93815606af1fa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176736
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit 04375f2a31cc6c233a015215f06682462b30425f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176748
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
Tested-by: Jenkins
2024-11-19 15:04:25 +01:00
Pranam Lashkari 69817b8a8c LOK: send state of EditDoc for write protection status
Change-Id: I58eb4ab04b4063e382bc6550b5cf08d7806a6c6a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173470
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit 3fa8df9e7f46fd7bf988ca96b0454e5c1ee0a153)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176749
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
Tested-by: Jenkins
2024-11-19 10:47:47 +01:00
Pranam Lashkari df8941ee5b tdf#163805: set fill style to solid on fill color selection
problem:
The issue here is that the table does not have a fill style set,
but using the fill tool from the menubar does not give any error
or warning, either, which confuses the user.

Change-Id: Ib7d6ecdbb315b6eb2eca21423fba28d3cb086450
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176245
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit c0623158f010e08e0bfadaffb988eac14e1ff34e)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176238
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
Tested-by: Jenkins
2024-11-14 07:17:08 +01:00
Pranam Lashkari dbf963f899 sc: fixed incorrect conditional format list usage
problem:
incorrect list was fetched caused problem when edited the condition

Change-Id: Idd277074b94bed13327fd1e58f80a5ab7697c7b3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175766
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit 5690f62d3226d6a91dfdc79489b74c726870f683)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175911
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
Tested-by: Jenkins
2024-11-01 23:21:43 +01:00
Pranam Lashkari a9235b93ff sc: fixed crashing on conditional format entry selection
Change-Id: I40e5b77cb98803664cff0db370f3079431820129
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175765
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
(cherry picked from commit 69c6ce6d8c6c6a6f9e3f0ea1319dbdb2190ccaab)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175910
Tested-by: Jenkins
2024-11-01 23:21:33 +01:00
Pranam Lashkari ce4ae4f082 sw: redline changes may try to set broadcast on non PostIt fields
broadcast was set from sw::UpdateFramesForRemoveDeleteRedline
which triggered SwPostItMgr::Notify
in that case SwFormatFieldHintWhich::INSERTED may have pField which maybe different from SwPostIt

fixed regression from 0b7a9c231f66b5c2659ab3aa6a0f3c7991b9e721

problem:(in LOK)
with tracked changed on delete a merge field
then reject the changes
LOK will crash

Change-Id: Ic1fafa1408d7a238133f5b3d18bf948d539aa991
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175808
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175833
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
Tested-by: Jenkins
2024-10-30 21:34:31 +01:00
Pranam Lashkari 1ec575d133 make quotes warning clearer for conditional format dialog
Change-Id: I70fcc98962c46be32352fad72d5717fa685b881e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175133
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit d3bc1970fa9bd7acf7a6d0a2e1dba756cfc70e86)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175618
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
Tested-by: Jenkins
2024-10-28 14:22:27 +01:00
Pranam Lashkari 65fea94ac0 tdf#163467 svx: calculate fill color with transparency
calculate absolutely visible color based on transparency against the doc background

TODO:
calculate this color based on the object in the background to increase visibility more

Change-Id: I56076c29f10c58c6ee13e1358da92a4685ea01e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175621
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit f8c87d617fc684e8e204a17cbd119c179a7e86e3)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175616
Tested-by: Jenkins
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2024-10-28 14:21:03 +01:00
Pranam Lashkari 3fd308fef3 sc: prefill easy condition dialog with editing condition data
Change-Id: I207bcbf15bedf3dd51980f04899b2c751b64295d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175036
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit 598e93b1b11f4cdff96f6117c2a7d35f3698fd23)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175207
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
Tested-by: Jenkins
2024-10-27 00:07:24 +02:00
Pranam Lashkari 5702619540 sc: make sure autofilter color area is caluculated
problem:
in autofilter popup entries were made before color area was correctly extended

Change-Id: I38f27666109e99e22e16804c0fdf8df9840864f6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174755
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
(cherry picked from commit 8903ddff872d579b06bd3acc413d3d14f4284228)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174781
Tested-by: Jenkins
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2024-10-15 14:43:06 +02:00
Pranam Lashkari 2ac55839b4 sc: give warning about condition input in easy condition dialog
Change-Id: I3cea0ae966951b5ff554f4ce9aeec5a1ed11ca13
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174779
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174906
Tested-by: Jenkins
2024-10-15 09:23:04 +02:00
Pranam Lashkari 4bc4472108 loplugin:ostr in sc
Change-Id: I9398b112be1329fff914d2014fcc0f59f27a968a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174913
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-15 08:24:00 +02:00
Pranam Lashkari 663ad4abfc sc: maintain calc function list per language
problem:
when multiple users used calc in kit in different languages,
all the users will be shows formula autocomplete in first language
list was created in, and later or new list creation was skipped.

Change-Id: I92af9b3481825e554b6aaeb4b46e7873dadc39c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172669
Tested-by: Jenkins
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2024-08-31 00:19:30 +02:00
Pranam Lashkari a37c185bbc LOK: avoid dark auto color font on dark background
Change-Id: I259d1af222af33c0226a3d11c7b146a8a5fd72f5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172527
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172563
Tested-by: Jenkins
2024-08-29 11:12:10 +02:00
Pranam Lashkari 0427231a14 sc: LOK: automatic text color was based on doc color instead background
problem:
when document was in light mode but cell had black background,
automatic font color was black based on the doc color but ideally
it should have been while based on the background color

partially reverts 8534ad7b7b for online

Change-Id: I155cc6044dd97e642619b88f24b82fb98a7b393f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172483
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit 2ca381b31e40d516c5d79ce4e59cecbf9683b616)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172495
Tested-by: Jenkins
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2024-08-29 03:00:14 +02:00
Pranam Lashkari c52f139b4f svx: fixed textbox text always black on dark theme
problem:
when doc is in dark mode and a textbox is inserted,
even though text has automatic color it will be black on unselecting textbox

Change-Id: I8736c15a1254682f06218a1eb1039b1985eda552
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170537
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit 41b277224310b63a181d65a279e1d77950db9309)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172494
Tested-by: Jenkins
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2024-08-28 23:33:30 +02:00
Pranam Lashkari bdd06e255c tdf#162475 sc: now conditions can be edited from easy conditional format dialog
now when a conditional format entry is edited,
instead of editing entry in the same format,
we delete entry from the origianal format and create
a new format with modified entry alone.

This way it easier to manage formats, and it also aligns
with implementation of how format manager adds new
format condition(it adds new format for each condition instead
of adding new entry to existing format)

Change-Id: Iaa92292ca67eaf90374d2af44d2402f9ebe29787
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169537
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170915
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
2024-08-15 18:40:21 +02:00
Pranam Lashkari f684f284de fixed tdf#162471: display comment time in ods if available
Change-Id: I2fe2621458608a2bf6c382397ec5acdaeffe3748
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171774
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-15 17:14:21 +02:00
Pranam Lashkari 8090d7a54f tdf#162475 sc: display all the conditions of same ranges in conditional format manager
Change-Id: I775f96f4cea19e8da34c2d64ac601e5ea3fc5c43
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169482
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170914
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-15 14:53:59 +02:00
Pranam Lashkari 367c2319a8 tdf#162475 sc: preview style in easy format dialog
Change-Id: If9c96129daefd5100b4211c9b3b07953b603166d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169483
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170913
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-15 14:53:48 +02:00
Pranam Lashkari 1e29baa755 sc: now formula conditions can be managed from condition format manager
Change-Id: I52cab33f5486c835dd13720eff93b497331561ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169536
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170912
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
2024-08-15 12:44:11 +02:00
Pranam Lashkari 723e035e1f tdf#162475 sc: added date condition option in conditional format manage dialog
Change-Id: I453b4ef47bed1607f42fbb3e48303531c6f355a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169323
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170911
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
2024-08-15 12:42:24 +02:00
Pranam Lashkari 20350c7f10 sc: tdf#162475 manage conditional format with simpler dialog
now we can add new conitions for formating from manage conditional formating dialog

Change-Id: I69660f108068a64e66301d62a61c485c81e8b97b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169322
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170910
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-15 12:28:10 +02:00
Pranam Lashkari 8f591839b9 Resolves: tdf#157851 sc comments loaded incorrectly in xlsx
problem:
1. when loading xlsx files, comments in that format does not store date,
there for libreoffice loaded comments with current date and time.

2. Author names were not loaded at all in xlsx, and by default
name of user was used as author instead

Change-Id: I7b1f7fcda01565a6ba131fbae72e7d86e5eaaf15
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171805
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171809
Tested-by: Jenkins
2024-08-13 15:41:13 +02:00
Pranam Lashkari 4c3f2194bb LOK: fixed incorrect Logic point calculation for Map mode
problem:
it was very difficult to select line in online,
specifically in writer if line is very think and
it was almost impossible to select line

Change-Id: Ib641cd3d9795b93d47c78bc8f57211f51714844d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168837
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
(cherry picked from commit a0612242a395e1be1fe8383537bc5a82d6b882ac)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169011
Tested-by: Jenkins
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2024-07-05 14:06:27 +02:00
Pranam Lashkari 124a988ea9 create comment reply synchronously
so we can bundle the creation of the comment and the insertion
of its "reply" characteristics together as a single Undo group.

wrap the new combination with a single undo operation showing "Insert
Comment" using Rewriter

Change-Id: I5927fa5501da0c49cc1182c60e23be290b8c37c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168190
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-29 14:24:31 +02:00
Pranam Lashkari 66f968242e sc: LOK: invalidate sheet geometry on row height changes
sometimes if undo/redeo affected row heights (i.e: undo an autofill)
sheet geometry was not updated in LOK

Change-Id: I995d23752712f6baf3c348f6fe5fb292f7c9043b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167878
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit bb605f31f92eeeca292824931ef0e8d1db750702)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167828
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
Tested-by: Jenkins
2024-05-21 22:43:38 +02:00
Pranam Lashkari 45e0c28a69 Added parent / child relationship to comments.
Adding parent name of a comment into odf file when there is a parent.

problem:
adding reply to any comment, saving and reopening doc will not show
reply in same thread.
regression from: c0187d9f5e

this part affects core only, similar thing online was done in 62cc221721

Change-Id: I563e3a2785543da69d717f8770f91a514699e604
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167711
Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
(cherry picked from commit 2a040bfe3e9f58db5c9f6503796778f07e2beba9)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167680
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
2024-05-17 12:05:40 +02:00
Pranam Lashkari 2b85bceca8 sc: undo: unify height adjust logic in undo with regular logic
in ScBlockUndo::AdjustHeight now we use device like ScViewFunc::SetWidthOrHeight
This provides unified behavior with user adjusting height or triggered it by undo

problem:
in online sometimes undoing would cause wrong selection due to incorrect height set
steps to reproduce(happened in certain files only):
1. autofill down a couple of cells
2. undo it
3. try to select the same cell again

cell selection will act like auto filled cells are merged cells

Change-Id: I81b798c4150284792ac3953caf822fefab0ccee2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167424
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit 726b133fd8c823c7f05a30c1995de26db372174d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167454
Tested-by: Jenkins
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2024-05-11 01:48:33 +02:00
Pranam Lashkari 312740f1ef LOK: hide cancel button in csv import dialog
it did not make any sense to have cancel button in this dialog
because it would not load file at all.
user can still use close button in title bar to close dialog

Change-Id: Id3ba3e4030553db18bdbd068d92b3395f4fb8c3d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166764
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
(cherry picked from commit 290d70a476bab7d100baa3568ec547633109033e)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166835
(cherry picked from commit 7171c9e8f6fecedac29e89deaeb2afa4d67a2a17)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166844
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
2024-05-01 11:03:48 +02:00
Pranam Lashkari 11ae1cf4e4 sw lok: .uno:SetDocumentProperties: add file size parameter
problem:
in LOK/online to support async save, files in jails may have
different extensions (ie: .upload, .uploading)
this caused problem to detect files as original file name may not exist.
As result property like file size were always set to 0

Change-Id: I552aef203297470d01032659a266210970129e66
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165769
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit aa4e10efc6e9ac92b0c652f238526aacbe2096c6)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166171
Tested-by: Jenkins
2024-04-17 13:32:27 +02:00
Pranam Lashkari dd7e03fe7f LOK: set creation date when online creates file from template
problem:
when online created file using WOPI clients, creation dates were never set.
in online files are created using templates, even empty files are created using
an empty template

Change-Id: I3f022427745de7204faac9418620e2a87f9cf684
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165711
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-04-03 14:26:11 +02:00
Pranam Lashkari 437161094d LOK: enter editing directly after textbox insertion
Change-Id: I3e77a1eb72a12c0e4ffc289ca854e0edb4ae9e2d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165007
Tested-by: Jenkins
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2024-03-22 12:33:18 +01:00