100 Commits
Author SHA1 Message Date
Gülşah Köse 111a2ffc8b cool#16233 sw: keep a formula's font size across DOCX import and export
An equation's size lives in the w:sz of its math runs. The import ignored it,
so every equation came in at the 12pt default of the formula editor, and a file
holding equations at three sizes showed all three the same. An equation whose
runs name no size takes the size of the text around it, which the styles and
the document defaults hold.

The export wrote no size at all. It now puts the size on every math run, and in
the control properties of each object, which is where the fraction bar, the
radical sign and the brackets take theirs from. The size travels in the w
namespace, so it goes out for a DOCX only, the way the color of a formula
already does.

Every formula now carries a size of its own on the way out, including one
written in ODF. Such a formula used to leave the size open and took whatever
the text around it had in the reading application. It now keeps the size it is
drawn at here, so both applications show it the same.

Setting the base size means giving each of the fonts that same size. The font
size dialog, the BaseFontHeight property of the model and this import each did
that on their own, so they now share SmFormat::SetBaseSizeAndFonts. The
property used to put the sizes in a copy that a later merge step reads only for
a font the same call has named, so a lone BaseFontHeight left the fonts alone.

Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: I18b6c5814a57d8ccb8be5b7bdd357ce76cea024d
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/13297
Reviewed-by: Balázs Varga <balazs.varga@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit 582e3fdb6496d9f511dfefc1f716b4ead6cc3797)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211600
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2026-09-30 12:12:58 +02:00
Gülşah Köse 388360bb07 cool#16218 writerfilter: apply the table alignment a table style sets
A table that took its alignment only from the w:jc of its table style
imported left aligned.

TablePropertiesHandler keeps the alignment in TablePropertyMap's
setValue() channel, which only another TablePropertyMap copies. The
style path hands the properties to the plain PropertyMap of the style
entry, so the value was dropped there, and endTableGetTableStyle() then
wrote the left default over the style.

Store the alignment as a plain property as well, for the whole table
part of a style only, and start from it in endTableGetTableStyle() so
direct formatting and the floating table frame properties still win.

Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: I31ca48f77ba3388e950ff8edcd0d61a71055c853
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/12632
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit b04ae23b97badfc8b617a9c2b8a492cfab754657)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211103
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2026-09-18 13:56:19 +02:00
Gülşah Köse 936ab76166 tdf#127184 Use caption text instead of category in navigator
At first creating a caption, navigator just gets the last name (Figure) from
dialog without translated to UI language (as user type). But while
opening again the same file, Figure is translated to UI language in
sw::DocumentFieldsManager::InitFieldTypes.

The problem is when user inserts a new category name and the category
name is same with built in category names. Built in category names are
always in English. There is no way for navigator to choose translated
one or untranslated one.

<text:sequence-decls>
    <text:sequence-decl text:display-outline-level="0" text:name="Illustration"/>
    <text:sequence-decl text:display-outline-level="0" text:name="Table"/>
    <text:sequence-decl text:display-outline-level="0" text:name="Text"/>
    <text:sequence-decl text:display-outline-level="0" text:name="Drawing"/>
    <text:sequence-decl text:display-outline-level="0" text:name="Figure"/>
    <text:sequence-decl text:display-outline-level="0" text:name="Figure"/>
</text:sequence-decls>

Instead of we can use the caption directly just like inital caption insert
function did. In this patch we use first two word of the caption to prevent
long lines in the navigator.

Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: I9bffdc3edad1eee91a000997b3ba9c8a3ea5b673
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197792
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198428
Tested-by: Jenkins
2026-01-30 16:27:45 +01:00
Gülşah Köse 4622aacbd8 cool#13543 Fix the empty hyperlink issue
Using EE_TEXTPOS_MAX is safer than GetSelectionText().length in case we
have trailing spaces at the end of the string.

Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: I09cc55d317f741cb092dd225480a66093ac99286
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194342
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Code-Style: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit 40881e7dbd192994d3d32cd312068e960d9ee275)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196793
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2026-01-09 07:56:11 +01:00
Gülşah Köse 7ab8ed87dc tdf#169456 Fix the placeholder of master slide style issue
In some cases we see the object in the slide has no fill syle directly but parent object
in master slide can has fill style.

We should apply the style to object in this case.

Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: I0b061cfde4ac2067c84383764770f155564531a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195368
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit 92b0bcb3136a77de97415b900a0e9b4a271715ae)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195672
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
2025-12-17 10:19:40 +01:00
Gülşah Köse 3f6050f369 cool#13193 Fix Ctrl Shift V issue on impress
f0c25c751c is merged to fix tdf#115783
But that commit caused a bug on Impress when the we have different
character and paragraph styles in textboxes. Commit aims to solve a
table issue.

To solve the Impress regression we should
apply the solution only table objects

I tried to write a test but it's not testable with reasonable
amount of effort

Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: I132e8257af2aadbdb816865678966b54de373ef8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192389
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194947
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
2025-12-03 12:17:37 +01:00
Gülşah Köse dbe29bc354 Revert "Prevent cursor invalidation if the cursor position doesn't change."
This reverts commit a260cc52b2fae1382805b4389c95f29ed8671f42.
This commit causes the view jump on writer.

This commit originally merged for the following issue

Open two writer documents side by side includes hyperlink
Click the hyperilnk one of them and see hyperlink popup
Type into the other document

There was a glich on hyperlink popup in the first document

Issue doesn't exist even without this patch. So we remove it completely.

Change-Id: I8a341d66a963ed1943d9f666ba026d7eca240f08
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192157
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193082
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2025-11-30 12:51:35 +01:00
Gülşah Köse 819db80c7c GH#13135 ONLINE: Get URL field from selection instead of cursor position
Getting field by cursor position is not safe. It uses the top left point
of the cursor rect. Some small cursor size/pos bugs may direcly affect the
field.

Getting URL field from selection is better in this case.

Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: Ib2a98322b15e9263e7024298c60021e54ba23880
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192097
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193067
Tested-by: Jenkins
2025-10-28 09:52:07 +01:00
Gülşah Köse 033efbdef8 GH#13078 ONLINE: Fix the selecting shell issue on math objects
Issue:
Double click to math formula in Writer (Shows the right Sidebar elemets)
Single click the outside
Double click the formula again (Doesn't show the sidebar)

Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: I627c280d6ef676dedfcac53387bc10a3882a247f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191830
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193015
Tested-by: Jenkins
2025-10-28 07:17:07 +01:00
Gülşah Köse 60af166fcd cool#12574 Show empty placeholder objects if they have background or linestyle
Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: Iebb32f0d18de271ea14bf77565c72d1b38073b30
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189512
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193014
Tested-by: Jenkins
2025-10-27 09:22:18 +01:00
Gülşah Köse ea37c7805a Invalidate column haaders when style brush is applied.
Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: Iff56926a230b60f71c6103b5a86f5d7e7deda68b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188335
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192964
Tested-by: Jenkins
2025-10-27 06:59:50 +01:00
Gülşah Köse 734ea9b93f Make calc hyperlink dialog same with other components
Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: I6d6b5a6a46a34d88d31572ffaaff6b9ee6ce504b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188268
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192946
Tested-by: Jenkins
2025-10-25 00:09:30 +02:00
Gülşah Köse 2040cb0d4a ONLINE: Make math related dialogs async
Following dialogs run async:
Fonts->Default
Fonts-> Modify
Font Size->Default
Spacing->Default
Alignment->Default

Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: I40faa18d8a171aab9832223b3ca4cef6e5834037
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184569
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184765
Tested-by: Jenkins
2025-10-22 15:04:25 +02:00
Gülşah Köse 5ed96520e4 ONLINE: Fix uno:ChangeDistance dialog.
Check if the label is exist before creating label instance.

Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: I158c059c206e314add534af65bbd8142cf7b1a17
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183786
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184764
Tested-by: Jenkins
2025-10-21 22:05:41 +02:00
Gülşah Köse 76c510d107 ONLINE: Make new formula dialogs async
.uno:ChangeFont
.uno:ChangeFontSize
.uno:ChangeDistance
.uno:ChangeAlignment

Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: I938fb49db7f8bbbd57c2af90e4b3629391c59089
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183720
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184763
Tested-by: Jenkins
2025-07-29 14:20:14 +02:00
Gülşah Köse eaa5c029e9 ONLINE: Send color names and values Online
Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: I5a754b106468a0f00a6a1ee54ee4971460759300
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184285
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184766
Tested-by: Jenkins
2025-07-29 14:19:49 +02:00
Gülşah Köse 90fcd86c0c ONLINE: Fix the problem with changing text box font color.
Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: Ia39bda929964ae55a2c032a8c386ef77342b2d0d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186454
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
(cherry picked from commit 12d98f7c55ef87ec488472de22bc4aca89243f53)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186557
Tested-by: Jenkins
2025-07-03 12:04:30 +02:00
Gülşah Köse e3da51b84f tdf#167082 Fix the missing style
While we tracking change of the document, if action is delete and if it
doesn't delete the whole node, we shoud use remaining text parts's
style. If delete removes whole node we can use previous node' style.

Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: Ie5cc40c12b9e2dad521ee35098630c94048d490f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187266
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2025-07-03 06:28:24 +02:00
Gülşah Köse 8933bdc9db cool#11216 Remove unnecessary control to invalidate cursor
bPostItActive control is introduced by b9cc665360
Then new annotation changes introduced by 69c546e1e7
makes this control unnecessary so removed the test testWriterCommentInsertCursor
introduced in first commit.

To keep that control makes buggy finding text via "Find and Replace"
dialog in comments. It never moves the visible cursor if the text
matches only in comments

Now it fixed.

Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: Ice60b4de2ae65c400b49153c3a0a4f3cccb7ad87
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181634
Tested-by: Miklos Vajna <vmiklos@collabora.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183844
Tested-by: Jenkins
2025-04-08 19:28:36 +02:00
Gülşah Köse eb0a2864dc ONLINE: Make Area panel visible for OLE objects
Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: Ic4db91a7a4583c10eb62267f8bb233df661aabd5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183194
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183846
Tested-by: Jenkins
2025-04-08 15:58:54 +02:00
Gülşah Köse 218948f488 ONLINE: Check cursor position changes more safely
Prevent cursor invalidation if the cursor position doesn't change.
It prevents to flickering hyperlink popup while other users are typing.

Fixes the regression caused by a260cc52b2fae1382805b4389c95f29ed8671f42

With that patch we can use next and previous page buttons in the status
bar safely.

Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: I82bfe2355f91d18057d2254a8969fd4994dab4df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180784
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
(cherry picked from commit ccaeb27fafbd7ab40a6b811202edd6a65da639fb)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181471
Tested-by: Jenkins
2025-02-12 13:39:01 +01:00
Gülşah Köse e7f05ee2e3 tdf#164141 Fix command button xls to xlsx convert problem.
MSO has two type controls. ActiveX and normal. ControlTypeinMSO
specifies the form control object is ActiveX or not.

2: ActiveX form control
1: Normal form control

Current case is simple ActiveX button created by MSO can not be exported by
LibreOffice properly. It was triggering the repair dialog on MSO. And we
even lost the button in LibreOffice.

If the pCurrXclObj is failed, we need to give a chance to export button
by using XclExpTbxControlObj instead of directly XclObjAny

This patch just fixes the Command button xls to xlsx convertion problem.
Not all the form controls.

Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: Ifabf4d0e16bd620f8201a2143d8af7c64d8859a6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180414
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181345
(cherry picked from commit 7f06e1e26cd3e76c65fcb271563d5741b3a45333)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181472
Tested-by: Jenkins
2025-02-12 13:38:51 +01:00
Gülşah Köse 641fd15464 Fix wrong detection of sortCondition reference
Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: I877ede71f9487ba35efd7da6aeeee954560272cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181344
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Jenkins
2025-02-11 08:53:29 +01:00
Gülşah Köse d902401452 tdf#163842 Fix autofilter ascending sort condition reference import
if (rSorConditionLoaded.mbDescending) condition ignores the ascending sort.
So when we import a document that uses ascending sort then export it, we
don't know which column is sorted.

With the following patch we fix this case.

Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: I561146517959a87eb0fb6cec419d68299bcb7eee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177016
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177222
Tested-by: Jenkins
2024-11-26 08:57:48 +01:00
Gülşah Köse b4b3949da1 Fix the wrong detection of hidden autofilter button
Regression caused by 2942fdc8db

OOXML <filterColumn colId="0">

Autofilter range colID is not absolute id. It starts always with 0 even
if the autofiltered range doesn't start with col 0 in the document.

So we are checking the flag from document (rDoc), not from the autofiltered range. So
we should use absolute column id  to get right flag.

Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: I1f94058caa23686596d57dd6983ddf02cd8f5e71
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176564
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176717
Tested-by: Jenkins
2024-11-19 05:38:59 +01:00
Gülşah Köse daf2e27b96 Reapply "Prevent cursor invalidation if the cursor position doesn't change."
This reverts commit 8da753752898984425c98a7f3db02b1aa69b74c8.
Merge cells case were failing. Fixed now.

Change-Id: I1dfd7e939c5590d64d096707edff40cb414ef3cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174813
(cherry picked from commit a260cc52b2fae1382805b4389c95f29ed8671f42)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175302
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Jenkins
2024-10-24 09:34:16 +02:00
Gülşah Köse 0036a8c05c ONLINE: Fix multi user dark mode link color problem
If one user change the theme to dark mode, other user's link color is
changed to dark mode link color too. In this commit we prevent that
problem.

Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: I65838e106794d649c362cf181ca300045053f169
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169984
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
(cherry picked from commit 1ae9e6fc33bac1ba0ac49a61ca567965dc81a6d6)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172668
Tested-by: Jenkins
2024-09-03 08:12:54 +02:00
Gülşah Köse e0daa8a142 ONLINE: Add Invert document background color command.
Change-Id: Ia8868a80e4eba9a9a1c0b31077d9eca0c5b00466
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171633
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-08-08 16:43:43 +02:00
Gülşah Köse f3f3ea4cc9 tdf#160213 Don't let insert empty line with numbering, end numbering
We applied the writer's empty bullet line policy to impres. Now We don't let
insert empty bullet lines in impress too. Instead we end numbering and start
to write normal paragraph at the same line.

Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: I28042d9db59b5622434da0826f8b760f01ad64f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164799
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-03-15 12:12:51 +01:00
Gülşah Köse b1f84f5479 Online: Make tooltip message specific to function usage tooltip
Using same callback caused a regression about showing tooltip while
reviewing a change in writer. So we need a type to understand which
tooltip comes.

Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: Iae26ff48f9c5c711af071fd66b5314e7bc96ff8b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164093
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2024-02-29 14:24:20 +01:00
Gülşah Köse d208c1910b Online: Prevent hiding tooltips due to other users action.
Other user's actions like reloading reopening or refreshing
document causes hiding other user function tooltips.

Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: I0aeb0aeb98182398e4740c71cfd65c4df2c51ba6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164027
Tested-by: Jenkins
2024-02-27 17:13:34 +01:00
Gülşah Köse 7e406cf5df ONLINE: Add calc formula tooltip support.
Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: I1f3c438f5152e2b372212d003c1ec4e74e4d3ff2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163651
Tested-by: Jenkins
2024-02-23 11:29:26 +01:00
Gülşah Köse e0f710ad29 ONLINE: Exit cell edit mode before add a new sheet
Prevents to move last edited cell to new sheet.

Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: If4a4533d81ce244ae50bbdde1fae89da14f6b53a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160758
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2024-01-03 11:59:46 +01:00
Gülşah Köse c9bae2d26e Online: Put the image width height info into json.
When online's image render is delayed we don't have any image size info
so getting 0x0. To show better result we need that info into message.

Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: I28f345cdd64de5fa47b3b1054330e606e7b32f03
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160106
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-11-29 22:28:50 +01:00
Gülşah Köse a6fffac033 Online: Fix Wizard Help button
Wizard dialog help button's response is not initialized if we don't run
any other dialogs. It should be initialized in RoadmapWizard itself.

response_help function can not detect wizard dialog's Help button. So we
should handle this case in function too.

Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: If80a2e54dcbf5eaa3d0e07347d12296ace5c9569
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159282
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Jenkins
2023-11-22 13:46:39 +01:00
Gülşah Köse 5a683f2d7c Prevent to open multiple Theme Color Edit dialog
When we do super fast clicks to Add button prevent to open multiple
dialog. Follow-up commit e73b2bc4e6

Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: If40c4982b873d41984bea298284eae062742b057
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155083
Tested-by: Jenkins
2023-08-02 11:46:51 +02:00
Gülşah Köse e73b2bc4e6 Prevent to open multiple Theme Color Edit dialog
Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: Ibf4db096b44ce941140a12d003b89b636f5e7224
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154514
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-07-17 13:53:20 +02:00
Gülşah Köse 48e8490784 Hide fill Attribute widget if fill style is none
When Fill style is none we can not use fill attribute element. So It is
better to hide.

Change-Id: I88d5e49448040b3afa18fbf66377d254716e7415
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145817
Tested-by: Jenkins
Tested-by: Pedro Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-01-20 09:51:23 +00:00
Gülşah Köse 959fbfc000 tdf#91265 Use same plot area distance as used in MSO
Changes the postion calculation for pie charts, where the margin
min distance is now constant for pie charts, but unchanged for
other chart types.

This changes the positions of various pie charts used in tests,
which have been changed to the new value after the cases have been
checked.

Added a new test with all 3 use cases (chart area width equals
height, width is greater than height, width is less than height).

Change-Id: I51f98f336a7c64a3e6762144fc7dc8d9df80f696
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143179
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-17 07:19:32 +00:00
Gülşah Köse e9356f9ced tdf#152483 Fix the insert hyperlink behaviour on Calc
Cursor invalidation message shouldn't carry a hyperlink info to online
side if there is no hyperlink under the cursor

Change-Id: Ibdb6e32d029e101212d03bc117a5a14a712822ef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143986
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2022-12-14 12:15:12 +00:00
Gülşah KöseandMike Kaganski 9790585a62 tdf#149915 Proper creation of vnd.sun.star.pkg:// URL
Using different methods of creation (one using DecodeMechanism::NONE,
another using DecodeMechanism::WithCharset) gave differently encoded
end results, comparing unequal.

The proper way is using DecodeMechanism::NONE on the document's URL,
as implemented in commit 06756e412b
  Author Mike Kaganski <mike.kaganski@collabora.com>
  Date   Sat Nov 18 22:41:40 2017 +0300
    One more proper construction of vnd.sun.star.pkg URL

Co-authored-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I272f277ef8b4bd23e6cb7884e68f3c79f742683a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136901
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-07-20 19:20:33 +02:00
Gülşah Köse a658129012 tdf#136787 Add control to create 1-bit B&W bitmap while creating mask.
Glow effect creates half transparent pixels on shadow. Creating 1-bit
B&W bitmap mask treates that half transparent pixels as black.
We control 1-bit B&W bitmap creation when we have half transparent
pixels.

Change-Id: Iaf298a0e5ffeeb6637fe5d3f56cf4f8e30a203e4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134981
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2022-06-03 10:15:56 +02:00
Gülşah Köse 362fb6c7b1 tdf#96389 Use default tab stop value of MSO for pptx import.
Change-Id: Ib3dde68c672b44d8b60f121fb0e637942b5986b1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131698
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2022-03-25 08:25:49 +01:00
Gülşah Köse f8ac4be066 tdf#147766 Export empty lines as line with noFill
We have a case that 0 width line but has auto color. If that case
exported there is no line over there, LO handles normally but MSO draws
back borders as default. To prevent this we have to export them as line
with noFill.

testTableBorderLineStyle change reverts a workaround for
3faf005a36

testBnc480256 Cell(1,0) still invisible. We are just checking
this with another way.

Change-Id: If5f6d2dbdba5c295d58307fcfe3b37629ede8a8e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131532
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2022-03-17 08:05:06 +01:00
Gülşah Köse 3faf005a36 tdf#135843 Implement inside horizontal vertical borders.
wholeTbl as TableStylePart should be handled in different way. Before
left border of the whole table was handling like all cells left
border but it should be left border of the first column.

insideV and and insideH properties are imported but never handled. I
added the inside vertical and horizontal borders handling.

Change-Id: I5aea5cbefc746db637eac6c1438fa70a7d741bc0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128971
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2022-03-02 11:57:25 +01:00
Gülşah Köse 48575b3eb8 tdf#135843 Do not export unused border lines.
Setting as XML_solidFill all borders caused wrong exported borders.
All table parts aren't used for all table styles. We should set borderline
if only they had used.

Change-Id: I35b247f520c7d7862599ade2c6fdfb0d7efcd5c7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129227
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2022-02-01 06:22:12 +01:00
Gülşah Köse 586a0f149f tdf#135843 tdf#146731 Fix the missing border handling
Reverts fa5ab8aa5d inside. And fix the
missing border problem with better way. Reason of the problem is using
ORIGCELL cell style for bottom and right of merged ranges is wrong.

Eg: We have Row X Col 3X3 table. (0,1) and (0,2) merged. The right side
of right border style should be same with (0,2). But ORIGCELL points (0,1)
instead. In case we should use LASTCELL. Same reason is valid for bottom case.

Change-Id: I5282083541f0bd02f3765943da4f34cabe05ef13
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128493
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
Tested-by: Gülşah Köse <gulsah.kose@collabora.com>
2022-01-17 13:14:42 +01:00
Gülşah Köse fa5ab8aa5d tdf#135843 Fix the missing border handling
Adding +1 at that stage causes indexoutofbounds.
But never throws that exception and tries to pull
empty cell style instead. As a result we can not
see the border. Actually no idea why +1 used here.

Change-Id: Id54ba6445d022540173af3bbf5d679b7edefc55b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127990
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2022-01-06 15:16:28 +01:00
gulsahkose 7b3be7f6f3 tdf#140912 Better handling of the picture placeholders.
To see icon and placeholder text at the center of picture
placeholder shape, we set the TextContourFrame and GraphicCrop
properties.

Change-Id: I49e3d08c9020e593232c60c97af3f45fb620075e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126165
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-12-01 14:11:36 +01:00
Gülşah Köse 92a407b7f9 tdf143222 Handle alternate content of graphicData element.
Handle alternate content and make true choice.

According to ooxml spec ole object requires exactly one pic
element. (ECMA-376 Part 1, Annex A, CT_OleObject). In the
current case first choice has not pic element and we should
allow fallback processing.

Change-Id: I30b7de703b8c2f00d6bf286e05eea505ac3627f2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118539
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-07-08 23:12:07 +02:00
Gülşah Köse e837f50313 tdf#142716 Update selection after any text is inserted.
When we don't update the selection after insertion of new text
SvxUnoTextBase::createEnumeration knows old selection and losts last part
of the text.

Change-Id: I20f6530f34097ff213ff00cff617139887fd287a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117409
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-06-21 10:27:24 +02:00
Gülşah Köse 936af331ba Clean redundant SvxBackgroundColorItem and use SvxColorItem instead.
SvxBackgroundColorItem is just copied from SvxColorItem. There is
nothing special to SvxBackgroundColorItem class. SvxColorItem is a
generic item and it's used on many places related with colors. We can
use SvxColorItem for background colors too.

Change-Id: Iacea31a7557b806e95f5859ff60add9a2626ec05
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116282
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jenkins
2021-05-31 11:36:18 +02:00
Gülşah Köse 1cd26a9ab6 tdf#96061 Unset the highlight property
When we have highlight property on specific part of the text
the following texts were highligthing. To prevent this we unset the
highlight property when we have not highlight property anymore.

Change-Id: I802cde1c784afe47201a9ba4f41827dd0c705035
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115800
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-05-26 10:14:57 +02:00
Gülşah Köse 350d40417f Seperate SvxBackgroundColorItem from SvxColorItem
SvxBackgroundColorItem derivated from SfxPoolItem instead of
SvxColorItem.

Casting is common usage to control if object is this or not.
When we can cast SvxBackgroundColorItem to SvxColorItem we can not
seperate them anymore.

eg: Char color is a SvxColorItem and char background color is a
SvxBackgroundColorItem. They can be hold together and we should
understand they are different types.

Change-Id: I7b1879a1b00de26c0b8a2d9f8d658aa3aef75ecb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116135
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-05-26 09:04:37 +02:00
Gülşah Köse 5ef0461b64 Mail Merge: Remove the missing data source warning on load.
User can easily forget that they (or somebody else ) added a
data source to document. This warning is only useful for the
user that plans to use mail merge wizard. When they don't plan
to use mail merge wizard and see that warning on infobar they
can confuse. We already have the same warning on mail merge
dialog itself. We don't need on load warning anymore.

Change-Id: I8d80148a9637ee66cc35e2ef583fff51a04386eb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116029
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-05-24 10:02:00 +02:00
Gülşah Köse 81d6ed89d1 tdf#142276 Use vertical GtkBox insted of horizontal GtkGrid for the left side.
Keep the layout as simple as possible.

Change-Id: Ie4e77e76dccd4f0a6f41e646ba819dba161b3cc8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115701
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-05-18 05:39:37 +02:00
Gülşah Köse b1c0734ffe tdf#141677 Make columns sortable
Change-Id: Ib4cb8aaba4c59a7afa347f8010deef41477b77f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115688
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-05-17 23:57:17 +02:00
Gülşah Köse b1099568ff tdf#141458 Set inital column width of Properties and Methods tabs.
Change-Id: I60a51de849d332bbf4579eac3d60834f17cb4fb8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115482
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-05-14 08:59:08 +02:00
Gülşah Köse b2f8032c43 Fix broken TOX in Online.
1. Open a German file in the Online
2. Insert a new paragraph, and change its style to "Ueberschrift 1"
3. Go to the Table of Content, and choose "Update Index"
4. See the index got destroyed, and when you look at the list of
   styles, the "Ueberschrift 1" has disappeared, and "Heading 1"
   appeared instead.

This reverts part of:
commit ca435be45f316120b9df6c9d547b781ed975817d
writer: handle styles in multiple languages for online

Change-Id: I82e46b3cf7824df6efdbb4b2a16716153ddae0df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114683
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115273
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-05-12 14:35:47 +02:00
Gülşah Köse db35b90864 tdf#141426 Remove GtkPaned struct unnecessary tabs.
In development tool we need GtkPaned for only properties tab.
Unnecessary hide() show() calls for the other tabs(Interfaces, Services,
Methods) causes complex problems about inital height of the second pane
with gen plugin.

Change-Id: I7523ef0bc425d7fc97ec5bd9e30e874f88e354f7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115450
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-05-12 11:19:25 +02:00
Gülşah Köse 95a1ccff3a tdf#141426 Fix VclBox inital size allocation.
Change-Id: If7380c9dbbcda091a2de93b722bf90182677af6c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115295
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-05-12 11:18:49 +02:00
Gülşah Köse 6af7691518 tdf#141424 Include the margin sizes while calculating width of window.
Follow up development f61fcf6fe6
First one fixed only horizontal panes. Apply the same fix to vertical
panes (eg: sidebar->gallery)

Change-Id: I7e5e1bb7bf559741dd265a8bbc6f845a2f31efde
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115151
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-05-06 07:18:18 +02:00
Gülşah Köse f61fcf6fe6 tdf#141424 Include the margin sizes while calculating width of window.
Change-Id: I0863dc62f1ade6cc07835e83eb242f3d5a9906bd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115068
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-05-05 17:11:52 +02:00
Gülşah Köse 4a39bfc7a9 tdf#141678 Set class name alignment.
Change-Id: I402e28903ec0bef10ad9fd2e74178b615af07c37
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115022
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2021-05-03 09:02:53 +02:00
Gülşah Köse 3c6692f88d tdf#141422 Set inital height of the develepment tool window.
Change-Id: I703edc227ee163e2a7b8fb9b03c71f055c6e0a3b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114775
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-04-29 20:07:55 +02:00
Gülşah Köse a809b2ab25 tdf#139906 Add an option to change data source from mail merge wizard dialog.
Change-Id: I52dfd9be82813a1b01c725eab97a7534ae9a05d2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114079
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-04-16 00:00:53 +02:00
Gülşah Köse d7d4878752 tdf#139906 Prevent to use the Mail Merge wizard without data source.
When the file has a data source but that data source is not available in
LibreOffice we shouldn't let user continue mail merging.

Change-Id: Ic28101a12b2e33e78fd9b478fc41707786344e52
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113432
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-04-02 14:10:39 +02:00
Gülşah Köse e64dc07ca8 tdf#139906 Show warning message when data source is not avaible.
CurrentDatabaseDataSource config item holds a database name for a
specific file. When document has CurrentDatabaseDataSource config
item but LibreOffice doesn't have in registered databases we should
notify the user at load time and put a button to fix the problem.

Change-Id: Ia0a6fd53985fc2fb82ce37d3962b3f479c20a647
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113296
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-04-02 14:10:19 +02:00
Gülşah Köse db39b68c3c tdf#140714 Import graphics cropped into custom geometry as custom shapes.
Change-Id: I2054d24ce41c9f0d6cc1675f461274067c3b2898
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112943
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-03-23 09:32:22 +01:00
Gülşah Köse b90a67838e Reset ShapeProperty priority and handle only crop case.
With 2c96bd26ec we changed the
ShapeProperty priority uncessarily. Reset the priority
as use FillBitmapName if supported.

BlipFillProperties::moFillRect negative GraphicCrop values means
stretched. BlipFillProperties::moClipRect positive GraphicCrop
values means stretched. We add a control to handle only stretched
cases.

Change-Id: I2eb1233d0477acf093ada36b4cc29ff34f767037
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111479
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-03-03 13:19:08 +01:00
Gülşah Köse befc0c2b0e tdf#133473 Change SDRATTR_SHADOWSIZEX flag.
SDRATTR_SHADOWSIZEX holds a percentage value. So we
shouldn't use METRIC_ITEM.

Change-Id: I9f1a20d5871f60d2899ef7d525f4cf837b0a9088
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111311
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-02-25 07:32:10 +01:00
Gülşah Köse 7400372efb Prevent the unnecessary lclCropGraphic call.
In case text::GraphicCrop aGraphCrop( 0, 0, 0, 0 )
we don't need to call lclCropGraphic.

Change-Id: I9960900f9b5c5b770824c76ffeb9ec9b51cbaef3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111401
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-02-24 13:18:16 +01:00
Gülşah Köse 185ed8d270 tdf#128213 Add unit test for text camera z rotation.
Change-Id: I50dab62ba1013d4ae17684edde620f9c94c5ec47
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111028
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-02-17 11:57:49 +01:00
Gülşah Köse cf2a539928 tdf#134210 Better testing for cropping bitmap of custom shape.
Change-Id: I592e2e99306a4aa27dce17e8b8d75e4bb2262cab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110723
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-02-11 15:05:01 +01:00
Gülşah Köse b7189e1a9a tdf#134210 Handle greyscale effect on bitmap filled custom shapes.
Change-Id: Ia4a0828dad80e32cc0c7fe12227ffca717d62e03
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110572
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-02-10 08:08:35 +01:00
Gülşah Köse b6d53ce535 tdf#139511 Correct calculation of minimum row height during resize.
Change-Id: Id47b5877d56850c80395897a83daae8e24f5c099
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110662
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-02-10 07:46:31 +01:00
Gülşah Köse ccdee8eeba tdf#134210 Import crop position of bitmap filled shape.
Change-Id: I6a62d68cd0f57e53934851a2f53dae05bf7d3730
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110262
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-02-10 07:04:38 +01:00
Gülşah Köse 62ee7fdce3 tdf#134210 Apply mirror property to custom cropped graphic.
Change-Id: I5bf2ba8fa432af8b6a560cc60c18bef799834fd0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110039
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-01-28 15:46:14 +01:00
Gülşah Köse 2c96bd26ec tdf#134210 Import support for custom stretch values.
Change-Id: I33ced8d667e37b7fb79f4c87b689f45966ac0097
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109658
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-01-21 10:52:46 +01:00
Gülşah Köse b83c168347 tdf#136278 Follow-up Check when the eventqueue needs to be emptied.
Follow up commit a63caf4995

Change-Id: I90b94f6aee1e1fe62f61ca20a75fd59e2a12d5da
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108559
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-01-03 20:17:19 +01:00
Gülşah Köse a63caf4995 tdf#134133 Check when the eventqueue needs to be emptied.
To fix tdf#131254, forceEmpty call removed without a control.
Bug was related advance time setting. Now we control if slide has
advance time setting.

Change-Id: Ie83f4d7ff3e4bd0a744ca205173d747204918b39
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108282
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-12-26 23:11:36 +01:00
Gülşah Köse 5d80f679e1 tdf#136957 Use bigger dots for better handling in presentation mode.
3 pt bigger dots are used. Human eye can't catch this
change so we will see same dots in edit mode and presentation mode.

Change-Id: I4a56406f4eb7a6832075a09a4d2f092bd689e9cb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106855
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-12-02 14:06:46 +01:00
Gülşah Köse 72998fc859 tdf#128213 Fix text camera z rotation import and export.
Text3DProperties is added to distinguish shape and text 3D effects.
Before there was implementation error about text camera z rotation
support. We were using shape effects for text. We already have not
support shape 3D rotation but we have text camera z rotation. This
patch includes import and export filter changes about text camera z
rotation.

Change-Id: I623392b82edf4585888d2f15ad91ffb2109d8f96
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106033
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-11-18 10:36:07 +01:00
Gülşah Köse c9619a5f6c tdf#138148 Protect aspect ratio of graphic bullets.
Change-Id: I166d547cdc01853fd81436c6cdc8d64b0fe817be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105618
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-11-14 22:06:22 +01:00
Gülşah Köse b7b05dd364 tdf#137949 Fix table row heigths.
Consider "Height" property of the the table while calculating
the minimum row height.

Change-Id: I4dbb0f7f87517423fd3075515b4b9817d6a9a71a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105422
Tested-by: Jenkins
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-11-09 12:36:07 +01:00
Gülşah Köse 9f3b85dc29 tdf#128213 Fix export rotation problem.
Export code has written for case that we have normal
rotation angle and camera z rotation together. If object
has not normal rotation but have camera z rotation, problem occurs.

Camera z rotation info is already exist between <scene3d> tags. If we
have not <xfrm rot="..."> (normal rotation angle) we shouldn't add camera
rotation here.

Change-Id: I1819953c937783d30b6e7ced978758300bb56d7e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105341
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-11-05 17:05:46 +01:00
Gülşah Köse 7dc234fa57 tdf#137949 Fix table row heigths.
Consider "Height" property of the the table while calculating
the minimum row height.

Change-Id: I4a57b69c4c0fc4dd004c895bd105ebc70f0c4bb3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105228
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-11-04 22:48:32 +01:00
Gülşah Köse 9c0ca63f2e Prevent crash with invalid lang tag.
Change-Id: I778b5b007d4edce946e8b4c26e5a07f12103a968
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104707
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-10-23 16:34:40 +02:00
Gülşah Köse c6d12d44a8 Database Wizard: show info label instead of empty list.
In Apple Store version or in case --without-java and
disable-firebird-sdbc we cannot have Java based HSQLDB or Firebird.
Instead of the empty list, there should be a static text label.

Change-Id: I6034a749f28a3c29c9c9e50929cb42aa1312a46b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104359
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-10-16 22:36:25 +02:00
Gülşah Köse c7ada1cc8a tdf#128212 Change the text z camera rotation order.
Old order:
1) Apply all rotation values (normal and camera z)
2) Do the adjustment (top, middle, bottom)

New Order:
1) Apply rotation values except camera z
2) Do the adjustment (top, middle, bottom)
3) Apply camera z rotation.

We rotate the text at the center of the already positioned rectangle
of the text, which depends on e.g. the length of the laid out text.
This matches the PowerPoint behavior.

Change-Id: I8741cf443834bf01cc07c04318fd6205ed6a0dd6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103965
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-10-16 12:05:02 +02:00
Gülşah Köse de59062d95 tdf#136247 Change element order of data labels
Reference OOXML (Appendix B.5.1, line 248)

Change-Id: Idf5c2546b4ad65c8e78ca03e18ecfa575ef17fe8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103005
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-09-21 09:33:19 +02:00
Gülşah Köse a11bb74d4f tdf#136247 OOXML export data label background color.
Change-Id: Ie3e00e8195239e6570bfe76c2451bae11c209145
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102999
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-09-18 18:55:17 +02:00
Gülşah Köse 9fe8814109 tdf#134174 Fix the rotation of bitmap filled custom shapes.
During import we were rotating only custom shape. Not its bitmap.
Custom shape and its bitmap rotated with same rotation value
in that commit.

Change-Id: I02d19c820670df7b4d1622836156c6bf8ed1c154
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101255
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-08-24 16:20:37 +02:00
Gülşah Köse 6e99f606ba tdf#133015 Add test for multicolumn textboxes.
Change-Id: I92d6af17313fb5a4a27fc8768b8f3fbe64db1816
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100452
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-08-11 11:52:09 +02:00
Gülşah Köse 99dff69b56 tdf#133015 Fix table position during import multicol textbox.
Change-Id: Ied1a03ff9f4556a551738b698ccb284fe74299da
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100414
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-08-10 23:51:39 +02:00
Gülşah Köse 33696b2820 tdf#133015 Inherit numCol from placeholder.
Change-Id: I402a40be7e8899ca017996f2bf77a2fb884b9462
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100372
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-08-10 06:18:49 +02:00
Gülşah Köse 7b64bd9063 tdf#133015 Do not import multicol table text on master.
Change-Id: I0a1b1dc2f9b314858ed90347065407bcd1dbbb73
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100311
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-08-10 06:18:12 +02:00
Gülşah Köse e0018be102 tdf#133687 Fix the placeholders priority order.
When we don't have type attribute on slide but have on
slidelayout we have to use it instead of default type.

Change-Id: Ibb874b5ee39c48641484fe1a8686f66c31695f76
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99904
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-08-03 22:59:50 +02:00
Gülşah Köse 08d16c76e4 Use enable/disable widgets instead of hide/show.
Change-Id: Ied3eb671155b88d47a5a91fcd81351492ccf9bb9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99560
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-07-27 22:31:32 +02:00
Gülşah Köse c50ae6a282 tdf#133015 Fix duplicated row and column problem.
LibreOffice imports multicolumn texboxes as tables. When
document has numCols=2 (or more) attribute at slidelayout and slide,
the table rows and columns duplicates.

maPPTShapes vector holds our PPTShape objects, hasSameSubTypeIndex
function finds the status that I mention above. So that we can prevent
that duplication.

Change-Id: Iee03d130452a16e9b46d471a9b6ed5910e6351ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99279
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-07-24 09:47:05 +02:00