Accessing an address book contact's Note field requires an entitlement since
Mac OS 13. Without that entitlement the following error occurs:
CoreData: error: Unhandled error occurred during faulting: Error Domain=NSCocoaErrorDomain Code=134092 "(null)"
It seems unlikely that the Note field functionality is widely used for
anything the address book functionality is used for, so just ignore the
field entirely.
Signed-off-by: Dan Williams <dan@ioncontrol.co>
Change-Id: I694f3ac40a8dccb49f51818dcdb3da7948f560d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191057
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
Tested-by: Jenkins
A number of places that #include <Carbon/Carbon.h> don't actually
need it, but want CoreFoundation or other includes instead. We're
trying to get rid of Carbon so let's make it clearer what really
needs it still.
Change-Id: Ief60b4324dccd936aa7def3ea2c685c393f9050a
Signed-off-by: Dan Williams <dan@ioncontrol.co>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191030
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
Tested-by: Jenkins
When constructing a MacabRecords by passing an existing MacabRecords
object, the new object allocates storage for records but does not copy
them, which is left up to the caller. But if the caller does not copy
records, the 'records' array elements are uninitialized garbage, leading
to a crash when the new MacabRecords object is disposed and those
garbage pointers are freed.
Signed-off-by: Dan Williams <dan@ioncontrol.co>
Change-Id: I6d381e523dd3f252f088bb879e886854ffe0163a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191058
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Dan Williams