143 Commits
Author SHA1 Message Date
Andreas Heinisch 970058a668 tdf#170842 - Check for missing table style info on plain database ranges
Change-Id: I8bed747726bd729fcef9b3845c8ba3e62f2ca2a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211786
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Tested-by: Jenkins
2026-10-05 21:15:16 +02:00
Gabor Kelemen 663551c5c4 tdf#146619 Run IWYU again on include/test
Change-Id: Ia2fe7435e0fbd6185c40655cd6c5ae93d39c7963
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193916
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
2025-11-30 18:25:35 +01:00
Noel Grandin 193207c5ab improve loplugin passparamsbyref
I think I managed to disable this when I converted it to
use the shared plugin infrastructure.

So fix that, and then make it much smarter to avoid various
false positives.

Change-Id: I0a4657cff3b40a00434924bf764d024dbfd7d5b3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176646
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-19 07:46:25 +01:00
Mike Kaganski 1180b3473a com::sun::star -> css
Change-Id: I890ec73e30d3cc6b210903ecee29431f3cb5f635
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175979
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-10 10:50:15 +01:00
Noel Grandin 008f4273ae loplugin:ostr in test
Change-Id: Ie261167fc3e1ed9073210e0f8b179455da340c83
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167620
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
2024-05-14 11:47:53 +02:00
Keldin Maldonado (KNM) 405e3f8815 tdf#143148 use pragma once instead of include guards
Change-Id: I42c39d991d243191f410ebb8f91940d5922a6fc5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162678
Tested-by: Jenkins
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-01-29 10:30:01 +01:00
Noel Grandin bc2101646b loplugin:stringviewparam improvements
improve the check by checking for methods that exclude
using string_view, rather than checking for methods that
__can__ use string_view, which leads to exposing
some holes in our o3tl/string_view.hxx coverage.

Change-Id: Ic9dd60441c671f502692f9cd2a1bb67301c4b960
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150277
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-14 07:54:28 +02:00
Stephan Bergmann 758050caa0 Use a more reasonable type for XDataPilotDescriptor::checkName nIndex parameter
Change-Id: If9e6760a6b23c63d03d337d6b111493684d67c85
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148568
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-03-13 19:01:37 +00:00
Xisco Fauli 331a013ee3 UnoApiTest: factor out common code
Change-Id: Ia8874d65ea8d7eb26d10b18e37ba2bac1a7d756b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141730
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-24 18:05:04 +02:00
Xisco Fauli 57a03d7a52 sc: remove unused method
Change-Id: I4e98ff61d5b592df970595b7aad551a9e37b93df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141615
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-21 13:41:36 +02:00
Xisco Fauli 8451f4691e test: remove unneeded setUp/tearDown
no other class in include/test/sheet/ has them

Change-Id: Ia7e196f57f929e466e4dc5c2fb76d654f3be6d05
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141446
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-17 13:37:11 +02:00
Noel Grandin 2bf18879d7 clang-tidy modernize-pass-by-value in test
Change-Id: I375ff43a60d0058be36dd07e409027ad1dcd1bcc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136558
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-28 12:42:54 +02:00
Philipp Hofer 01baeab998 tdf#123936 Formatting files in module include with clang-format
Change-Id: I0507dd797cd5a35e0ae14f4b69ee4e172d08a71a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105681
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Jenkins
2020-11-21 13:19:17 +01:00
Noel 8ef6067596 loplugin:stringviewparam check methods too
not just functions

Change-Id: Icca295dd159002b428b73f2c95d40725434f04d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105789
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-17 09:57:35 +01:00
Noel 4fbd638605 switching long to a 64-bit type on 64-bit windows
(*) create a rewriting plugin to do most of the work, heavily
    based on the fakebool plugin
(*) but there are still a number of "long"s in the codebase
    that will need to be done by hand
(*) the plugin needs lots of handholding, due to needing to
    add #include and update macros

Change-Id: I8184d7000ca482c0469514bb73178c3a1123b1e9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104203
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-26 07:35:36 +01:00
Andrea Gelmini 6505f43b09 tdf#124176 Use #pragma once in some include/
switch to #pragma

It passed "make check" on Linux

Change-Id: Idb01cc7d4ccf404df82016b1b3356400320eb317
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103305
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
2020-09-25 08:27:22 +02:00
Andrea Gelmini 2c7bed21f4 Fix typo in code
Change-Id: I4709f3fd11c8d5800efab65b6f9533cbad3ffe78
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92927
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-04-26 15:38:46 +02:00
Noel Grandin 17e712ccc8 Revert "loplugin:constfields in sw"
This reverts commit 4969f4c0d3.

Change-Id: I527e9366b05e8a20633720e334395b285991c524
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90473
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-13 15:41:42 +01:00
Noel Grandin b0a07d9409 remove some dead code
GpgComponentFactory is unused since:
    commit 06d7dbb356
    Date:   Sun May 21 14:28:57 2017 +0200
    gpg4libre: share static xmlsec lib between nss and gpg

tableautoformatfield.cxx should have been removed in:
    commit 5990beed9a
    Date:   Fri Aug 29 16:37:43 2014 +0200
    Dead code

xmlRow is unused since initial import

Change-Id: Ief186e9ef46238cc8cdb49f4adde52a45a98cbc4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89830
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-03 08:26:40 +01:00
Pelin Kuran f61ed40fff tdf#124176: Use pragma once instead of header guard
Change-Id: Id28874549342349fb2727c3cb8e92da1dcdb727c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87513
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-27 21:44:04 +01:00
Eike Rathke ec1478f7da Test results across all imported and inserted sheets.
Change-Id: I573467a962a2835765cc5672b81cce4c7772ddff
Reviewed-on: https://gerrit.libreoffice.org/84669
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
2019-12-06 23:19:14 +01:00
Noel Grandin e724f245e9 loplugin:constmethod in test
Change-Id: I15aa90d962b9d428a911f4b47a06d55318b42ba4
Reviewed-on: https://gerrit.libreoffice.org/77953
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-22 15:46:24 +02:00
Gabor Kelemen bfe225b700 tdf#42949 Fix IWYU warnings in include/test
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

New IWYU and recent developments in f-u-i helped to identify
some non self contained files, those were fixed too.

Change-Id: I527f7c2cf2660a758b13eabb4c444ff79ae35f8c
Reviewed-on: https://gerrit.libreoffice.org/75186
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-23 14:16:09 +02:00
Samuel Mehrbrodt 8ecdaecfa8 Split large test method in two
Change-Id: If1b915f721a5768b682c63dc9c08b708ba37a705
Reviewed-on: https://gerrit.libreoffice.org/70116
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-04-02 15:03:53 +02:00
Noel Grandin 705558aa45 condition always true in XSpreadsheets2::importSheetToCopy
leftover from
    commit ed45c87896
    Date:   Mon Oct 20 21:08:54 2014 +0200
    sc: fix temp file leak in ScTableSheetsObj

Change-Id: Ic108fb36cc0caccbe57f2b47f7fcbe80156842dc
Reviewed-on: https://gerrit.libreoffice.org/69749
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-27 07:40:12 +01:00
Jens Carl fe632c86aa tdf#45904 Move XRefreshable Java tests to C++
Move XRefreshable Java tests to C++ for ScAreaLinkObj.
To make this test work, had to provide parameter aSourceArea (in this
case file sc/qa/extras/testdocuments/scarealinkobj.ods). All the other
depended tests of ScAreaLinkObj had to adjusted to the new test
environment.
Also fixes i84711, because the XRefreshable test runs independent from
the other tests, as mentioned in the bug description.

Change-Id: I8847813431e2fdd60ed95be0f7d115bcaeafe500
Reviewed-on: https://gerrit.libreoffice.org/68949
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-09 02:52:05 +01:00
Jens Carl ce2b98580b Add XSheetFilterDescriptor2 and XSheetFilterDescriptor3 tests
Add XSheetFilterDescriptor2 and XSheetFilterDescriptor3 tests
to ScFilterDescriptorBase.

Change-Id: I932560c42d9c5f3077f47f116f6ae011f6aea79e
Reviewed-on: https://gerrit.libreoffice.org/67097
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-29 23:57:08 +01:00
Michael Stahl 3cacdf5b0f sc: fix CppunitTest_sc_ddelinkobj to copy its test document
XRefreshable::testRefreshListener() fails on read-only filesystem
because the ScDDELinksObj.ods cannot be loaded read-write.

It is loaded read-write since commit
5b2794e27a.

Change-Id: I27b954b216acd3d138ade0d3f1b21fedd2f74fb1
Reviewed-on: https://gerrit.libreoffice.org/67071
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-01-29 17:02:17 +01:00
Jens Carl 412fbb6f01 tdf#45904 Move XEnumerationAccess Java test to C++
Move XEnumerationAccess Java test to C++ for ScNamedRangesObj.

Change-Id: Ia19281b8e481eda2535eb6f26c60dedc65f1beec
Reviewed-on: https://gerrit.libreoffice.org/66933
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-26 02:12:24 +01:00
Jens Carl 059a958a65 Add XMultiFormulaTokens tests to ScTableValidationObj
Change-Id: I6239cfba2b275c5f0b8794e30d57d1835ed569fa
Reviewed-on: https://gerrit.libreoffice.org/66892
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-25 14:55:18 +01:00
Jens Carl eee8c16a5c Add XDDELinks tests to ScDDELinksObj
Change-Id: I9e6efbd5a1cd9e4787e8143dd4f8adbe6ab2cae7
Reviewed-on: https://gerrit.libreoffice.org/66561
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-18 08:41:38 +01:00
Jens Carl 7b7cc20d83 Move XStyleLoader2 tests to ScStyleFamiliesObj
Change-Id: Ibba0464d17a9517eb48f3f33b46db2455093ac52
Reviewed-on: https://gerrit.libreoffice.org/66413
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-16 18:57:49 +01:00
Jens Carl 68e841326a Rename testGetByIndex to testIndex
Rename testGetByIndex to testIndex of sheet::XSheetAnnotations test
cases so it won't collide with testGetByIndex of
container::XIndexAccess.

Change-Id: Ic48ffe954c9f4f00b68066ad5d0d2df89cc4dfd7
Reviewed-on: https://gerrit.libreoffice.org/64402
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-01 21:17:40 +01:00
Noel Grandin a2751c0795 loplugin:staticmethods improvement
Change-Id: I8889ce8a7d2309b54454cfe4c6421282e1c6e755
Reviewed-on: https://gerrit.libreoffice.org/63434
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-16 07:26:27 +01:00
Jens Carl e3f013dadb Replace "using namespace" with qualified indentifiers
Change-Id: I69cfd2a3528b059fe7d0be8c38e49782ca1fa78a
Reviewed-on: https://gerrit.libreoffice.org/63272
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-12 05:12:12 +01:00
Noel Grandin 4969f4c0d3 loplugin:constfields in sw
Change-Id: I1eb6583bb9ec815bc0564b0d7c676f5b1fb9045f
Reviewed-on: https://gerrit.libreoffice.org/61177
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-03 11:56:43 +02:00
Noel Grandin e7cc6b253f loplugin:returnconstant in hwpfilter,test
Change-Id: I7c7c450f1da4ac3205148d2de8b344f0735f92ba
Reviewed-on: https://gerrit.libreoffice.org/58881
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-13 08:34:55 +02:00
Jens Carl 8164399df0 tdf#45904 Move _XSheetCellCursor Java tests to C++
Change-Id: I9d12f9a13d3e0c59b7a28ff91563878efde22b68
Reviewed-on: https://gerrit.libreoffice.org/45067
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-08 10:04:11 +02:00
Noel Grandin 40b1e5d406 loplugin:passstuffbyref
Change-Id: I6e6c47020073ec183c6c8ff9cd026a0bec23b177
Reviewed-on: https://gerrit.libreoffice.org/57088
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-08 08:31:45 +02:00
Jens Carl 81260b1266 tdf#45904 Move _XDocumentAuditing Java test to C++
Change-Id: Ic03e42c9c2ff27579b442dc8d1408deaea839ec4
Reviewed-on: https://gerrit.libreoffice.org/56644
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-06-29 06:15:16 +02:00
Jens Carl cceef18820 tdf#45904 Move _XFormulaQuery Java tests to C++
Enable tests for ScTableSheetObj and fixes #i86793.

Change-Id: Ic9914fd74a70034e4adc7e55203c92935a472f9d
Reviewed-on: https://gerrit.libreoffice.org/55782
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-06-14 18:25:57 +02:00
Jens Carl 600987b415 tdf#45904 Move remaining _XCellRangeReferrer Java tests to C++
Move remaining _XCellRangeReferrer tests to C++ and partly fix #i84656.

Change-Id: I77cc8550888f460a6ae265816907a19a81cbe871
Reviewed-on: https://gerrit.libreoffice.org/55732
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-06-13 17:53:30 +02:00
Jens Carl 939fc7dc50 tdf#45904 Move _XCellRangeData Java test to C++
Move the remaining tests to C++ and also enable/fix #i84671 by creating
test cases for ScTableSheetObj.

Change-Id: I9412fe7a1947b9afb4343a8f5726eccf9ea371a3
Reviewed-on: https://gerrit.libreoffice.org/55657
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-06-12 18:38:52 +02:00
Jens Carl 6bf05f004b tdf#45904 Move _XScenario Java tests to C++
Change-Id: Ic12eebe62de5132dce26ec46c62501f90200b909
Reviewed-on: https://gerrit.libreoffice.org/52180
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-04-18 17:53:02 +02:00
Jens Carl 73a7c7ddbc tdf#45904 Move _SheetSortDescriptor Java tests to C++
The C++ tests are now located in sheetsortdescriptor2.(hxx|cxx), because
this is the latest implementation of the UNO API interface
(SheetSortDescriptor2.idl).

Change-Id: I5b11a38f6cd0473714c4d57ee92889bfd7605e83
Reviewed-on: https://gerrit.libreoffice.org/52930
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-04-17 17:45:53 +02:00
Jens Carl c8c74a0b4c tdf#45904 Move _FunctionDescription Java tests to C++
Change-Id: Ib4baf75dddb3b63bab25ab13967a20c65d692ce2
Reviewed-on: https://gerrit.libreoffice.org/52613
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-04-15 00:58:31 +02:00
Jens Carl 7dcda19e4a tdf#45904 Move _XCellRangeMovement Java tests to C++
Change-Id: I8d3697b9c409e4fd9f9d28b8598b8807b91c5363
Reviewed-on: https://gerrit.libreoffice.org/52485
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-04-06 17:32:47 +02:00
Jens Carl a7fc11be30 tdf#45904 Move _XCellRangeFormula Java tests to C++
Change-Id: Iff5ca30e47a3a3eee704ad9aefdf61b3fcd72f5d
Reviewed-on: https://gerrit.libreoffice.org/52286
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-04-03 07:11:02 +02:00
Jens Carl 387896a051 tdf#45904 Move _XArrayFormulaRange Java tests to C++
Change-Id: I87b6e52507428537fcc574842c2da9c36fbd672b
Reviewed-on: https://gerrit.libreoffice.org/52247
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-04-02 18:55:03 +02:00
Jens Carl 34568738bb tdf#45904 Move _XActivationBroadcaster Java tests to C++
Change-Id: If8f44b24e58663bacb1cf6b2a1ec533e87fb8a38
Reviewed-on: https://gerrit.libreoffice.org/52216
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-04-02 00:27:19 +02:00