ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
520,958 Commits 3 Branches 3 Tags
main
Commit Graph
54 Commits
Author SHA1 Message Date
Caolán McNamara 7f135227a9 cid#1556131 COPY_INSTEAD_OF_MOVE 
and

cid#1556135 COPY_INSTEAD_OF_MOVE
cid#1556146 COPY_INSTEAD_OF_MOVE
cid#1556164 COPY_INSTEAD_OF_MOVE
cid#1556171 COPY_INSTEAD_OF_MOVE
cid#1556177 COPY_INSTEAD_OF_MOVE
cid#1556181 COPY_INSTEAD_OF_MOVE
cid#1556182 COPY_INSTEAD_OF_MOVE
cid#1556183 COPY_INSTEAD_OF_MOVE
cid#1556192 COPY_INSTEAD_OF_MOVE
cid#1556201 COPY_INSTEAD_OF_MOVE
cid#1556208 COPY_INSTEAD_OF_MOVE
cid#1556215 COPY_INSTEAD_OF_MOVE
cid#1556224 COPY_INSTEAD_OF_MOVE
cid#1556227 COPY_INSTEAD_OF_MOVE
cid#1556228 COPY_INSTEAD_OF_MOVE
cid#1556238 COPY_INSTEAD_OF_MOVE
cid#1556246 COPY_INSTEAD_OF_MOVE
cid#1556247 COPY_INSTEAD_OF_MOVE
cid#1556288 COPY_INSTEAD_OF_MOVE
cid#1556293 COPY_INSTEAD_OF_MOVE
cid#1556305 COPY_INSTEAD_OF_MOVE
cid#1556310 COPY_INSTEAD_OF_MOVE
cid#1556317 COPY_INSTEAD_OF_MOVE
cid#1556321 COPY_INSTEAD_OF_MOVE
cid#1556322 COPY_INSTEAD_OF_MOVE
cid#1556331 COPY_INSTEAD_OF_MOVE
cid#1556339 COPY_INSTEAD_OF_MOVE
cid#1556342 COPY_INSTEAD_OF_MOVE
cid#1556351 COPY_INSTEAD_OF_MOVE
cid#1556358 COPY_INSTEAD_OF_MOVE
cid#1556370 COPY_INSTEAD_OF_MOVE
cid#1556379 COPY_INSTEAD_OF_MOVE
cid#1556390 COPY_INSTEAD_OF_MOVE
cid#1556423 COPY_INSTEAD_OF_MOVE
cid#1556532 COPY_INSTEAD_OF_MOVE
cid#1556561 COPY_INSTEAD_OF_MOVE
cid#1556662 COPY_INSTEAD_OF_MOVE
cid#1556704 COPY_INSTEAD_OF_MOVE
cid#1556730 COPY_INSTEAD_OF_MOVE
cid#1556988 COPY_INSTEAD_OF_MOVE
cid#1557071 COPY_INSTEAD_OF_MOVE
cid#1557081 COPY_INSTEAD_OF_MOVE
cid#1557177 COPY_INSTEAD_OF_MOVE

Change-Id: I2c723f0fe9a4eefa62a68f47049ed690d06eb0ba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170932
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2024-07-24 22:12:32 +02:00
Noel Grandin 8ef4dc07cd improve loplugin:staticmethods 
Some of the exclusions were too aggressive. Restrict them to only the
important classes, which exposes some more places this plugin applies.

Change-Id: I1b2d1fb24391adc71ed0984f94168f61a149479f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165154
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2024-03-22 11:47:36 +01:00
Stephan Bergmann 64c47c92d0 Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: framework 
Change-Id: I0f17c569eddcdc30bfca4cdcd25cb05cf783ec23
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158200
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2023-10-20 07:06:17 +02:00
Mike Kaganski f662ba9536 Prepare for removal of non-const operator[] from Sequence in framework 
Change-Id: Ied2683a0b8a1bab1a7594da1e9bdbd3cb753552c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124370
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2021-10-30 10:31:26 +02:00
Noel Grandin ae29e471ca convert #defines to OUStringLiteral 
mostly by doing

$ git grep -l '#define.*\"' -- *.cxx
    | xargs perl -pi -e
's/^#define\s+(\w+)\s+(\".*\")/constexpr OUStringLiteral \1 =
u\2;/g'

Change-Id: I63a4b050f220f0a61749892cd47fb91813f7d088
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119844
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-08-02 12:57:28 +02:00
Noel Grandin d1dfb7d561 no need to allocate these separately 
Change-Id: I9464fbcc1af966755cc4eb8fe0beead4638848ba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116479
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-05-31 21:36:25 +02:00
Gabor Kelemen 0f25e181c1 tdf#42949 Fix IWYU warnings in framework/*/*cxx 
Also drop the now unused framework/inc/general.h

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I8e19036a507dbdcd178835b6ac4182719d27a654
Reviewed-on: https://gerrit.libreoffice.org/82744
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
 2019-11-20 10:47:20 +01:00
Noel Grandin 0f874472c6 size some stringbuffer to prevent re-alloc 
found by the simple expidient of putting asserts in
the resize routine. Where an explicit const size is used,
I started with 32 and kept doubling until that site
did not need resizing anymore.

Change-Id: I998787edc940d0a3ba23b5ac37131ab9ecd300f4
Reviewed-on: https://gerrit.libreoffice.org/81138
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-21 08:36:01 +02:00
Caolán McNamara fbc038cc4f an uno -> a uno 
Change-Id: I538db88f8477dd2d2ad25c372928fec6c11d979d
Reviewed-on: https://gerrit.libreoffice.org/72105
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-05-10 14:50:59 +02:00
Caolán McNamara 1156f981ac an is used before a vowel sound 
not before vowels with a consonant sound so its a url not an url

Change-Id: Ic27ff3bee67469284d460c31ced6f63cb3633db2
Reviewed-on: https://gerrit.libreoffice.org/72062
Reviewed-by: Jens Carl <j.carl43@gmx.de>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-05-10 10:01:13 +02:00
Arkadiy Illarionov 44841a6778 Simplify containers iterations in [f-l]* 
Use range-based loop or replace with STL functions

Change-Id: Ib3fab47318d1bfbb4df8f886a8cd9596525a420f
Reviewed-on: https://gerrit.libreoffice.org/67914
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-02-18 07:41:05 +01:00
Michael Stahl 48c6f4e088 framework: avoid crashing in ~HandlerCFGAccess() in atexit() 
Commit d587931fba changed
HandlerCache::s_pConfig to a unique_ptr, which may now crash on
shutdown because it's a utl::ConfigItem and by atexit() time the
configmgr is long gone.

Due to the HandlerCache::m_nRefCount, the crash probably only happens
in case of an unclean shutdown, but we don't know whether this can
happen in practice or not, so just avoid crashing on shutdown.

Change-Id: Ifd2b782aa5592c344d1bc85acaa434c3f2a69b60
Reviewed-on: https://gerrit.libreoffice.org/67029
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
 2019-01-29 12:19:57 +01:00
Noel Grandin f9de7c851e HandlerCFGAccess::read should take references 
Change-Id: Icecb26e15d97fcf9c6694053fafc99b62385ffb5
Reviewed-on: https://gerrit.libreoffice.org/65395
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-12-19 09:52:03 +01:00
Noel Grandin d587931fba loplugin:useuniqueptr in HandlerCache 
Change-Id: Ic3ba52568cbf1281162b3b4146d8c5d2ce9574b4
Reviewed-on: https://gerrit.libreoffice.org/59942
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-09-04 09:28:20 +02:00
Gabor Kelemen bdb0775a26 Add missing sal/log.hxx headers 
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it.
This is a continuation of commit 6ff2d84ade to be able to remove those unneeded includes.

This commit adds missing headers to every file found by:
grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG')
to directories from filter to jvmfwk

Change-Id: I2a73d63f2aaef5f26d7d08957daaa8a30b412ac5
Reviewed-on: https://gerrit.libreoffice.org/58204
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
 2018-07-30 09:28:40 +02:00
Julien Nabet 823ef9ef32 Use for-range loops in framework 
Change-Id: I72ea832848fd7c76863bcee70a3303de488c0b0f
Reviewed-on: https://gerrit.libreoffice.org/51471
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2018-03-17 23:08:48 +01:00
Stephan Bergmann c7d59ad877 loplugin:subtlezeroinit: framework 
Change-Id: I88871abd4b57debeb8002a25ef5f59f57e065803
 2017-02-21 07:35:06 +01:00
Noel Grandin f4a9ba4b48 convert ConfigNameFormat to scoped enum 
and drop unused constants
    CONFIG_NAME_PLAINTEXT_NAME
    CONFIG_NAME_FULL_PATH

Change-Id: Ibf7e88da0ae54516cb863b8efa995201f2a95268
 2017-02-10 08:08:45 +02:00
Stephan Bergmann 4be81de0d6 Resolve OUStringList typedef 
Change-Id: Ifb5dc5128b5619abb83eea427c7fb1115fd825f3
 2016-04-07 21:44:02 +02:00
Stephan Bergmann 9a2dea0640 dllexport class deriving from template means trouble with MSVC 
Change-Id: I9d170168eac26c52fd6ca8d22124e8ff78b81226
 2016-04-07 21:15:55 +02:00
Stephan Bergmann f57c9921de Get rid of BaseHash wrapper (to unbreak Windows build) 
Change-Id: Ieae7d6af7a4753958ebf2aeae9d2ae6fafe5efe9
 2016-04-07 18:14:53 +02:00
Noel Grandin 8e234c5b7d use initialiser syntax for Sequence<OUString> 
replaced using the script:

git grep -lP 'Sequence.*OUString.*\(1\)'
  | xargs perl -0777 -pi
    -e "s/Sequence< OUString > (\w+)\(1\);
.*\[0\] = (\S+);/Sequence< OUString > \1 { \2 };/g"

Change-Id: I23688a91562051a8eed11fc2a85599545c285c34
Reviewed-on: https://gerrit.libreoffice.org/19967
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-15 10:13:08 +00:00
Stephan Bergmann 06c5c63020 loplugin:nullptr (automatic rewrite) 
Change-Id: Ie178c474921c1695927a9b01a9972baf09fbb73d
 2015-11-10 10:31:27 +01:00
Andrea Gelmini eab0904f0e Fix typos 
Change-Id: I81f6f356c1a6873fcc9a3bde487127b673fa9a61
Reviewed-on: https://gerrit.libreoffice.org/18952
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
Tested-by: Oliver Specht <oliver.specht@cib.de>
 2015-09-30 12:39:01 +00:00
Michael Stahl 765f6211b1 utl::ConfigItem::Commit() should call ClearModified() 
Rename the virtual function, and add a new non-virtual Commit() to do
that.

Change-Id: I09421df781ba965d6ff638b46cd8214fb3a00022
 2015-03-11 16:50:00 +01:00
Stephan Bergmann b98352996c framework: Use appropriate OUString functions on string constants 
Change-Id: I5da5cd3254102c742021b3e7b4e1f907ca897ca5
 2014-12-18 14:12:22 +01:00
Jan Holesovsky e6ac6cbccf automaticly -> automatically. 
Change-Id: Iae55083160eee86ac8301f272634dd3ae65fd847
 2014-04-27 01:28:55 +02:00
Jan Holesovsky dc6175ff1f Remove LockHelper::getGlobalMutex(). 
Do what the TODO suggests - change it to SolarMutex in most cases.

In some cases it is only there to guard a local static, introduce a local
mutex for those.

Change-Id: Idc3155818f737b958b36ee9125e2e9e8cb1b91a1
 2014-04-15 13:10:56 +02:00
Noel Grandin a6287e21f1 framework: sal_Bool->bool 
Change-Id: Ia6e87e2b382bd4005637e14088bde9e809996a25
 2014-04-07 13:53:49 +02:00
Tor Lillqvist ee3945bd98 Kill superfluous spacing before semicolons 
Change-Id: I53689e78221f3fe074e47d6b47f1a2c3fef96222
 2014-04-06 19:37:48 +03:00
Caolán McNamara 7ac3a62379 coverity#738659 Uninitialized pointer field 
Change-Id: I5d3ebc066f36f9cdcfb031a58ecb9c64ddea26c3
 2014-03-22 19:27:03 +00:00
Stephan Bergmann c8239a1dd4 Remove newly unused framework::LockHelper class 
...and make LockHelper::getGlobalLock() FWI_DLLPUBLIC again (so there's a single
such lock, not one per library).

Change-Id: I0aed77333dc93cdf1c7dd7b96620fb7a8eb3dd64
 2014-03-20 17:30:03 +01:00
Stephan Bergmann 4ddb43bcf1 Turn odd framework::LockHelper::getGlobalLock() into an osl::Mutex 
...and extract it to framework::GlobalLock::get().

The old lock was actually effectively two different locks,
LockHelper::getGloblaLock() and
LockHelper::getGlobalLock().getShareableOslMutex(), and both were used in
different places.  These places all use the same single osl::Mutex instance now,
but hopefully that does not lead to problems (which it shouldn't, given the
documentation of LockHelper::getShareableOslMutex: "Sometimes we need a osl-
mutex for sharing with our uno helper ... What can we do? We must use a
different mutex member :-( I HOPE IT WORKS!").

Of course, the "TODO: This presumable should return the SolarMutex" still
applies.

Change-Id: I7caea3241d1b70a00272fe1f2214c071ef22cf2c
 2014-03-20 17:30:02 +01:00
Stephan Bergmann ab3acb7ef7 Consolidate framework::{Read,Write}Guard 
...now that it is obvious that they both do the same

Change-Id: I6878acca4750ef4204fe32a695b6d9e1c5140115
 2014-03-17 16:52:34 +01:00
Andras Timar b55259eeb5 typo fixes 
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
 2013-12-20 15:55:00 +01:00
Andras Timar 7f436c1fd3 typo fixes in comments 
Change-Id: Iaadec33715f8e0e0c6595c5e684606905274fdab
 2013-09-26 11:47:45 +02:00
Tor Lillqvist 9a8e2d09bc Use SAL_WARN_IF instead of framework's home-grown LOG_ASSERT(2) 
Also remove declarations for debug function that don't exist (have been
removed (misguidedly?) as unused perhaps).

Change-Id: I0bc3320c52b3d50dc851a07fdc30b593cc4856b1
 2013-09-08 23:51:41 +03:00
Philipp Riemer bf42b6f9f5 fdo#62475 - remove visual noise 
This is a follow up commit to
 - 22d1beb78a
 - 1c7af455ab

Change-Id: I102685391125f3b4f7bdf838f8bd17a2283d558d
 2013-08-31 22:41:10 +02:00
Michael Meeks 1c7af455ab Re-work 8bit characters in source code, or remove them. 
Change-Id: I93e14d4936c0ffbe03425d4a54bb0e09bc62b3e3
Reviewed-on: https://gerrit.libreoffice.org/5550
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@suse.com>
Tested-by: Michael Meeks <michael.meeks@suse.com>
 2013-08-20 19:30:59 +00:00
Tor Lillqvist cb6d67c21f Spelling "separate" (etc) correctly is hard 2013-05-15 11:14:28 +03:00
Thomas Arnhold 60fbefc615 fdo#60724 informations -> information 
Change-Id: Ifd34ebfc7fe01b4a470eb072597dd3ec97c97863
 2013-04-15 04:49:39 +02:00
Luboš Luňák 1946794ae0 mass removal of rtl:: prefixes for O(U)String* 
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
 2013-04-07 14:23:11 +02:00
Michael Meeks 17ff7b41d1 re-base on ALv2 code. Includes: 
Patches contributed by: Armin Le Grand.
    #118558# Correcting OLE attributes of LO3.4 at load time by loading as OOo3.3, details see task.
    http://svn.apache.org/viewvc?view=revision&revision=1195906
    #118485# - Styles for OLEs are not saved.
    http://svn.apache.org/viewvc?view=revision&revision=1182166
    #118898# Adapted ImpGraphic::ImplGetBitmap to correctly convert metafiles
    http://svn.apache.org/viewvc?view=revision&revision=1293316
    #119337# Solves the wrong get/setPropertyValue calls in
    SvxShapeText (and thus in SvxOle2Shape)
    http://svn.apache.org/viewvc?view=revision&revision=1344156

    Patches contributed by Mathias Bauer (and others)
    gnumake4 work variously
    http://svn.apache.org/viewvc?view=revision&revision=1394707
    http://svn.apache.org/viewvc?view=revision&revision=1394326
    cws mba34issues01: #i117717#: remove wrong assertion
    http://svn.apache.org/viewvc?view=revision&revision=1172349

    Patch contributed by Herbert Duerr
    goodbye Registration and License dialogs, don't let the door hit you
    http://svn.apache.org/viewvc?view=revision&revision=1172613
    help gcc 4.6.0 on 32bit ubuntu 11.10"
    http://svn.apache.org/viewvc?view=revision&revision=1245357

    Do not add targets for junit tests when junit is disabled.
    Patch contributed by Andre Fischer
    http://svn.apache.org/viewvc?view=revision&revision=1241508

Revert "sb140: #i117082# avoid unncessary static class data members
    commit 21d97438e2.
remove obsolete FreeBSD visibility special case.
retain consolidated BSD bridge code, remove OS/2 pieces.
 2012-11-15 16:06:08 +00:00
Thomas Arnhold 2beba8f93e reduce ascii noise and useless comments 
Change-Id: I317058e3b25cebb7c1d89361636261c5f16a84d4
 2012-08-08 13:53:54 +02:00
Thomas Arnhold 49ad17e2b1 remove include comments and boxes 
Change-Id: I9ccf664e8f75a68b1b87c2b29ae617a90d0741a7
 2012-08-08 13:53:53 +02:00
Thomas Arnhold 548a2ffe3a remove bogus date information 
Change-Id: I2789153ee35f4ec10e760f9412eb7d379de031bf
 2012-08-07 18:08:30 +02:00
Tor Lillqvist 383a9c777f s/pathes/paths/ 2012-04-09 14:19:58 +03:00
Tor Lillqvist e1c10e673c s/pathes/paths/ 2012-04-09 14:19:56 +03:00
Norbert Thiebaud e4603954d1 remove include of pch header from framework 2011-11-27 13:11:33 -06:00
Caolán McNamara 17b8373171 callcatcher: various unused methods 2011-09-23 09:02:23 +01:00