28 Commits
Author SHA1 Message Date
Andrea Gelmini b2987ad577 Fix typos
Change-Id: I3fbc308fa4c51674e90b27cff704830904a372f2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209889
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2026-08-25 14:25:24 +02:00
Gabor Kelemen 49cb3077fb tdf#146619 Use more forward declarations in include/vcl/outdev.hxx
these were skipped in previous runs, since they contain some code behind #if

After inspecting these, it seems like the removals should not cause trouble.

This also shaves off some 140M input

Change-Id: Ie1f57174dd6fec3ba5b0b91eb0688acdc1a8143d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197494
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
2026-01-23 21:27:08 +01:00
Gabor Kelemen 66ffc2417b tdf#146619 Run IWYU on cppcanvas/
Change-Id: Ie98b497409e394ac13176d4e1ea8753278698fd7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189791
Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Tested-by: Jenkins
2025-08-19 09:48:00 +02:00
Noel Grandin 4977c89e3e BitmapEx->Bitmap in CreateFromCairoSurface
now that Bitmap supports transparency

Change-Id: I8c890db186c1e37ea535ff515633d083fec8d8c9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189617
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-08-15 07:22:01 +02:00
Noel Grandin 11b1557147 convert KernArray from sal_Int32 to double
which allows us to eliminate a bunch of rounding at various layers, and
consequently maintain a lot more precision

Change-Id: I911dedd7c041c1d67396c082e5695346ea689acb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175814
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-31 12:10:52 +01:00
Stephan Bergmann e0c33ec15f loplugin:ostr: automatic rewrite
Change-Id: I2d09b2b83e1b50493ec88d0b2c323a83c0c86395
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157647
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins
2023-10-07 00:47:20 +02:00
Khaled Hosny 558892a77d CppunitTest_cppcanvas_test: clang-format
Change-Id: Id6497a9dd275ec4e782bcb58b90a27ef569764fe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153266
Tested-by: Jenkins
Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-06-19 20:46:36 +02:00
Khaled Hosny 5dfaecfd87 tdf#155810: Add test
Change-Id: I7cea421778335e8d5dd344dd04efdba843945383
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153264
Tested-by: Jenkins
Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-06-19 20:46:25 +02:00
Khaled Hosny 1f7a367f0d CppunitTest_cppcanvas_test: generalize testComposite
Make it pass without cairo canvas.

Change-Id: I81dd5d21bde6d1e09c2e8eeea75d05ddf1793d91
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153263
Tested-by: Jenkins
Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-06-19 20:46:13 +02:00
Khaled Hosny fc72d1d0c6 CppunitTest_cppcanvas_test: enable even if cairo canvas is not
I want to add more tests to it.

Change-Id: Ibadfbafbaa6d6b1cfc1f9aa3761a04de2e2c1f09
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153262
Tested-by: Jenkins
Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-06-19 20:46:03 +02:00
Khaled Hosny cf69509628 CppunitTest_cppcanvas_test: use CPPUNIT_TEST_FIXTURE()
Change-Id: I736e67530643a0949e3078a873ba3105f359ed1d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153261
Tested-by: Jenkins
Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-06-19 20:45:42 +02:00
Noel Grandin cfb2a587bc rename BitmapEx::GetAlpha to GetAlphaMask
to ease the reading of code related to an upcoming patch to convert
transparency to alpha, since there is already a GetAlpha in Color.

Change-Id: I1af0f8f6dd94acfe4673c8556c7aff6c20da3f7a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145209
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-11 08:57:13 +00:00
Mike Kaganski a9d314b57b Prepare for removal of non-const operator[] from Sequence in cppcanvas
Change-Id: I2a16a8ea7776447592e51a23ce21aac0a156735f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124354
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-29 13:15:06 +02:00
Noel Grandin 9090dc1f3b split OutputDevice from Window
as part of a longer-term goal of doing our
widget rendering only inside a top-level render-
context.

I moved all of the OutputDevice-related code that existed in vcl::Window
into a new subclass of OutputDevice called WindowOutputDevice.

Notes for further work

(*) not sure why we are getting an 1x1 surface in
    SvpSalGraphics::releaseCairoContext, but to fix it I clamp
    the size there

(*) might have to dump VCLXDevice, and move it's code down into VCLXWindow and VCLXVirtualDevice

(*) can we remove use of VCLXDevice in other places, in favour of just talking to the VCL code?

Change-Id: I105946377f5322677d6f7d0c1c23847178a720b6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113204
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-17 12:56:51 +02:00
Noel c7483d48df drop operator bool and operator! from Bitmap and BitmapEx
IRC chat:
<quikee[m]> noelgrandin: doesn't adding operator bool to Bitmap
  has the same problem as Graphic and the reason why you dropped that
  commit 7334034ae9
  "drop Graphic::operator bool"
<noelgrandin> quikee[m], hmmm, good point
<noelgrandin> maybe I should just drop both operator bool and
  operator! in favor of IsEmpty
<quikee[m]> noelgrandin: I don't remember what the problem is I just
  remembered we dropped it Graphic :) sure, dropping everything for
  IsEmpty is probably the best

Change-Id: Ieae289cda64f0b8d8fdecd5ea9e6f2bb874ff4cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113163
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-28 10:26:06 +02:00
Gabor Kelemen 977c993353 tdf#42949 Fix IWYU warnings in cppcanvas/
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I3e6b35acf6266157d4cf634e2143e6e19a73102a
Reviewed-on: https://gerrit.libreoffice.org/81813
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-31 11:29:44 +01:00
Caolán McNamara fbc038cc4f an uno -> a uno
Change-Id: I538db88f8477dd2d2ad25c372928fec6c11d979d
Reviewed-on: https://gerrit.libreoffice.org/72105
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-10 14:50:59 +02:00
Noel Grandin 725a1f514c loplugin:sequentialassign in comphelper..cui
Change-Id: I1a08f3684b785e31535adcfb4220ded267a77c3b
Reviewed-on: https://gerrit.libreoffice.org/70643
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-12 15:33:02 +02:00
Jochen Nitschke 9401c7c28a remove unused processfactory.hxx includes
and fix fallout

Change-Id: Id06bf31f2075111e426ba40c84c885ae70697bee
Reviewed-on: https://gerrit.libreoffice.org/52206
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-04-01 12:11:26 +02:00
Stephan Bergmann 3aaf523d68 Dispose Window when done
Change-Id: I6b67d12174c3caa0a4bf230d87421f5768a331f8
2016-12-22 10:22:21 +01:00
Caolán McNamara 3a00aaef2a boost->std
Change-Id: Ie490bf2c6921f393bdeed96b1a8815996b701bf0
Reviewed-on: https://gerrit.libreoffice.org/18670
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-18 07:59:14 +00:00
Michael Meeks 4ff758fea1 Manual cleanup of misc. issues.
Change-Id: Ib0b9b17010f7c1b0814b48f6fb0144e5296418df
2015-04-10 13:40:40 +01:00
Michael Meeks 5d133eb621 first half of non-scriptable, Instance constructor conversion.
Change-Id: If73bb41bfa805e22609748f25971724b4778edb3
2015-04-10 13:27:16 +01:00
Michael Meeks d7930771b8 boost references are unhealty for VclPtr.
Change-Id: I7ce41ecff1eee4cb45f685a0f4dddb31225ac542
2015-04-10 11:02:08 +01:00
Noel Grandin 827c46e7d7 fdo#82577: Handle Window
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.

Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-23 14:11:39 +03:00
Stephan Bergmann bb78022488 Fix memory leak in test code
Change-Id: I318878b3fa883eebbc081a6faf6a594dad2c6e26
2014-05-30 15:55:01 +02:00
Michael Meeks 58b8211f4a canvas unit test - tolerate canvas non-creation: really no X server...
Change-Id: Id8be7bc4ad454e7e246e412803e4d672a921c08e
2013-06-11 16:35:49 +01:00
Michael Meeks eb5e3e3a4e create a cairo canvas unit test, if only I could use the XCanvas API.
Change-Id: I3b0fdbe92db751e59ecb3f3b59f27e160b3ca226
2013-06-11 14:41:51 +01:00