ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
520,958 Commits 3 Branches 3 Tags
main
Commit Graph
15 Commits
Author SHA1 Message Date
Ilmari Lauhakangas c5823a2e27 android, compilerplugins: fix issues found by Ruff linter 
Change-Id: Idab013bf2ff1f274a07911ec8b545cd26142139c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171050
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
 2024-07-26 18:45:56 +02:00
Leonard Sasse 52b08068c9 tdf#158803 compilerplugins: remove semicolons; improve membership checks 
Change-Id: Ifd5fdee23e5adba2b5a667f74c38ba6fb28f54b4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165446
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
 2024-05-21 11:40:31 +02:00
Bogdan B 06468a15d5 Remove unused imports from compilerplugins/clang 
Change-Id: I923ace7bedf022d49222e71c96c7e4c20f90e6cb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142521
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
 2023-01-02 04:39:16 +00:00
Noel Grandin e307716807 loplugin:finalclasses 
improve the plugin to detect more cases.

I only apply the new final changes to classes in /include here.

Which reveals that
    RoadmapWizard::getPageController( TabPage* _pCurrentPage )
will always return nullptr

Also needed to sprinkle some
   SAL_DLLPUBLIC_TEMPLATE
around to workaround Visual Studio linking problems.

Change-Id: Iadb7d46a9e0e73dabce562375ca013c0fea6690c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117365
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-06-19 14:08:50 +02:00
Stephan Bergmann f416acdc3a systools is no longer part of the URE interface 
...since de030cd7a2 "gbuild: Remove MSVC 2013
legacy code", so no longer treat it as such in compilerplugins.  (Which caused a
few loplugin:includeform and loplugin:nullptr warnings.)

Change-Id: I99b42e76992e31aff56b417c05738d4d29e3faf9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112575
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2021-03-16 14:53:44 +01:00
Noel 95b2ee0070 improve sorting in global-analysis plugins 
Change-Id: I417f6d9fd6981bb402cd216a08db285cc9adeed0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105628
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-11-13 13:44:12 +01:00
Mike Kaganski bd96a6f7b7 Don't rely on Python's treatment of unrecognized escape sequences 
According to [1]:

> Changed in version 3.6: Unrecognized escape sequences produce a DeprecationWarning.
> In a future Python version they will be a SyntaxWarning and eventually a SyntaxError.

[1] https://docs.python.org/3/reference/lexical_analysis.html#string-and-bytes-literals

Change-Id: Ia4f79f17ccb121f423f35b1e1306d5ae285e8762
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98321
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2020-07-13 22:23:44 +02:00
Noel Grandin d9e4783302 loplugin:finalclasses in xmlsecurity..UnoControls 
Change-Id: I8e942bf37c9173a01bef6e1403ca21f579e7f608
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91612
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-04-03 11:37:53 +02:00
Noel Grandin de37f3c3b2 loplugin:finalclasses in xmlsecurity 
Change-Id: I1c2d0c418d2aa2198c82e89ce048851f30d07a7d
Reviewed-on: https://gerrit.libreoffice.org/85698
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-12-22 18:04:00 +01:00
Andrea Gelmini ff566c67d6 Fix typo 
Change-Id: I197a4e5ab4985c2d67ca8a83980069ba2622576a
Reviewed-on: https://gerrit.libreoffice.org/85081
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2019-12-12 23:14:49 +01:00
Noel Grandin 36b90e6c23 loplugin:finalclasses 
Change-Id: Ia9865271cf0a75ebf4b885ff376f7d0a152b2555
Reviewed-on: https://gerrit.libreoffice.org/84925
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-12-12 13:11:16 +01:00
Noel Grandin 85cf4d25a3 loplugin:mergeclasses fix ignoring some stuff 
Seems that calling getCanonicalDecl here results in us sometimes picking
up forward-decl's, which hides stuff

Also make the python processing code spit out a message if I manage to
mess up the log files

Change-Id: I08bf50eb26cf463c126507b51535b0a0fc9f7ecf
 2018-07-12 12:41:01 +02:00
Noel Grandin 64a5d65f4c put the loplugin output files in the workdir 
so that the next time I accidentally leave one turned on, and commit it,
the buildbots will clean up naturally the next time they run 'make
clean'

Change-Id: Ia09dea9c272c322c7e2773c5458cb54aceb50dd1
 2018-04-10 15:54:24 +02:00
Noel Grandin 493a7e9932 loplugin:finalclasses trim the output a little 
Change-Id: Iad0f0ded624e95448421c19a04535c2511b66a02
 2017-10-17 09:10:48 +02:00
Noel Grandin ccb1894c02 new loplugin:finalclasses 
look for classes which are effectively final, but contain protected
members. These members can be made private.

Change-Id: If53d535b068b668d1aff548ebfd0fe6c51a48a0e
 2017-10-03 11:15:47 +02:00