ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
520,958 Commits 3 Branches 3 Tags
main
Commit Graph
189 Commits
Author SHA1 Message Date
Asad Tauqeer 241e14a762 tdf#153109 replace for loop in unmarshal.cxx 
Replaced a manual for-loop used for searching an array with std::any_of from the <algorithm> header.

Change-Id: I0a3f6b46e22ef92449a637f4164a0e47f794b598
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/204585
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2026-05-07 21:15:19 +02:00
RashmiVid 2d09ec6611 tdf#158237 Use contains() instead of find() != end() for maps/sets 
Replace occurrences of find() != end() with contains() where supported.

Change-Id: Ie8e4625dc2e0f6e6b7273fe2190e52580eef90f2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202908
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Jenkins
 2026-03-30 18:13:10 +02:00
Gabor Kelemen 3fc666e120 Fix some non self contained headers in modules [a-r]* 
Change-Id: I844cfcfa2bc31fae0256e0c7b757b6223ac8ac35
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196633
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
Tested-by: Jenkins
 2026-01-18 00:34:04 +01:00
Neacsa Leonard 9f25059ea1 tdf#163691 Use std::copy() and std::copy_n instead of memcpy() 
Signed-off-by: Neacsa Leonard <leonardneacsa2005@gmail.com>
Change-Id: I7d69cbb0c93f5d9223607f519bbcf5e2acb393cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194359
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
 2025-12-08 07:58:45 +01:00
Gabor Kelemen 9ae1e92464 tdf#146619 Run IWYU on binaryurp/ 
Change-Id: Ie3bcad1a6653350ae10ed69371138d3d413a51e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188750
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
 2025-08-18 20:19:18 +02:00
Gabor Kelemen 530e3ae320 Remove obsolete fw declarations from avmedia, basctl, basic, binaryurp 
found with bin/find-unneeded-includes --fwdecl

Change-Id: Ia9eb16d95b02b5e8c13a98b6cc4b06a6315f2311
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183878
Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Tested-by: Jenkins
 2025-04-11 10:52:47 +02:00
Noel Grandin aa48441b0b clang-tidy: performance-unnecessary-copy-initialization in binaryurp 
Change-Id: I8af73afaf063294786890a71abe97add283289a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176390
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2024-11-11 15:47:00 +01:00
Mike Kaganski 1180b3473a com::sun::star -> css 
Change-Id: I890ec73e30d3cc6b210903ecee29431f3cb5f635
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175979
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2024-11-10 10:50:15 +01:00
Caolán McNamara 10b662b8bc cid#1557276 COPY_INSTEAD_OF_MOVE 
and

cid#1556657 COPY_INSTEAD_OF_MOVE
cid#1556654 COPY_INSTEAD_OF_MOVE
cid#1556397 COPY_INSTEAD_OF_MOVE
cid#1556339 COPY_INSTEAD_OF_MOVE

Change-Id: I20be9764c327ebda9beeb62b54c399998180bfab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172098
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2024-08-20 21:14:18 +02:00
Caolán McNamara a4dfd23e44 cid#1557694 COPY_INSTEAD_OF_MOVE 
and

cid#1557162 COPY_INSTEAD_OF_MOVE
cid#1556896 COPY_INSTEAD_OF_MOVE
cid#1556893 COPY_INSTEAD_OF_MOVE
cid#1556873 COPY_INSTEAD_OF_MOVE
cid#1556872 COPY_INSTEAD_OF_MOVE
cid#1556789 COPY_INSTEAD_OF_MOVE
cid#1556570 COPY_INSTEAD_OF_MOVE
cid#1556519 COPY_INSTEAD_OF_MOVE
cid#1556516 COPY_INSTEAD_OF_MOVE
cid#1556451 COPY_INSTEAD_OF_MOVE
cid#1556396 COPY_INSTEAD_OF_MOVE
cid#1556237 COPY_INSTEAD_OF_MOVE
cid#1556113 COPY_INSTEAD_OF_MOVE
cid#1556094 COPY_INSTEAD_OF_MOVE
cid#1555991 COPY_INSTEAD_OF_MOVE
cid#1555982 COPY_INSTEAD_OF_MOVE
cid#1555885 COPY_INSTEAD_OF_MOVE
cid#1555702 COPY_INSTEAD_OF_MOVE
cid#1555610 COPY_INSTEAD_OF_MOVE
cid#1555450 COPY_INSTEAD_OF_MOVE
cid#1555327 COPY_INSTEAD_OF_MOVE
cid#1555145 COPY_INSTEAD_OF_MOVE

Change-Id: I38cc1a38e8cb2c33f33e0fc3afd34a0fb39e5ec1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172028
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2024-08-19 15:15:54 +02:00
Caolán McNamara dd689fb914 cid#1557699 COPY_INSTEAD_OF_MOVE 
and

cid#1557435 COPY_INSTEAD_OF_MOVE
cid#1557307 COPY_INSTEAD_OF_MOVE
cid#1557209 COPY_INSTEAD_OF_MOVE
cid#1557192 COPY_INSTEAD_OF_MOVE
cid#1557184 COPY_INSTEAD_OF_MOVE
cid#1557183 COPY_INSTEAD_OF_MOVE
cid#1557171 COPY_INSTEAD_OF_MOVE
cid#1557150 COPY_INSTEAD_OF_MOVE
cid#1557148 COPY_INSTEAD_OF_MOVE
cid#1557123 COPY_INSTEAD_OF_MOVE
cid#1557118 COPY_INSTEAD_OF_MOVE
cid#1557116 COPY_INSTEAD_OF_MOVE
cid#1557103 COPY_INSTEAD_OF_MOVE
cid#1557078 COPY_INSTEAD_OF_MOVE
cid#1557075 COPY_INSTEAD_OF_MOVE
cid#1557071 COPY_INSTEAD_OF_MOVE
cid#1557070 COPY_INSTEAD_OF_MOVE
cid#1557067 COPY_INSTEAD_OF_MOVE
cid#1557049 COPY_INSTEAD_OF_MOVE
cid#1557046 COPY_INSTEAD_OF_MOVE
cid#1557042 COPY_INSTEAD_OF_MOVE
cid#1557036 COPY_INSTEAD_OF_MOVE
cid#1557030 COPY_INSTEAD_OF_MOVE
cid#1557024 COPY_INSTEAD_OF_MOVE
cid#1557012 COPY_INSTEAD_OF_MOVE
cid#1557009 COPY_INSTEAD_OF_MOVE
cid#1557008 COPY_INSTEAD_OF_MOVE
cid#1557004 COPY_INSTEAD_OF_MOVE
cid#1556999 COPY_INSTEAD_OF_MOVE
cid#1556992 COPY_INSTEAD_OF_MOVE
cid#1556987 COPY_INSTEAD_OF_MOVE
cid#1556984 COPY_INSTEAD_OF_MOVE
cid#1556981 COPY_INSTEAD_OF_MOVE

Change-Id: Id2687aa282f4e2d4b8053b73c7aa1a74a9516b16
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171974
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2024-08-18 11:04:45 +02:00
Caolán McNamara 437412d79b cid#1557980 COPY_INSTEAD_OF_MOVE 
and

cid#1557869 COPY_INSTEAD_OF_MOVE
cid#1557807 COPY_INSTEAD_OF_MOVE
cid#1557804 COPY_INSTEAD_OF_MOVE
cid#1557799 COPY_INSTEAD_OF_MOVE
cid#1557781 COPY_INSTEAD_OF_MOVE
cid#1557781 COPY_INSTEAD_OF_MOVE
cid#1557766 COPY_INSTEAD_OF_MOVE
cid#1557746 COPY_INSTEAD_OF_MOVE
cid#1557737 COPY_INSTEAD_OF_MOVE

Change-Id: I1866c576f525ea697c62e9e0a96890e5fdaa780f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171795
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2024-08-14 09:27:19 +02:00
Caolán McNamara 4504d921a6 cid#1555694 COPY_INSTEAD_OF_MOVE 
and

cid#1555695 COPY_INSTEAD_OF_MOVE
cid#1555696 COPY_INSTEAD_OF_MOVE
cid#1555705 COPY_INSTEAD_OF_MOVE
cid#1555711 COPY_INSTEAD_OF_MOVE
cid#1555713 COPY_INSTEAD_OF_MOVE
cid#1555727 COPY_INSTEAD_OF_MOVE
cid#1555742 COPY_INSTEAD_OF_MOVE
cid#1555745 COPY_INSTEAD_OF_MOVE
cid#1555749 COPY_INSTEAD_OF_MOVE
cid#1555760 COPY_INSTEAD_OF_MOVE
cid#1555773 COPY_INSTEAD_OF_MOVE
cid#1555774 COPY_INSTEAD_OF_MOVE
cid#1555778 COPY_INSTEAD_OF_MOVE
cid#1555790 COPY_INSTEAD_OF_MOVE
cid#1555831 COPY_INSTEAD_OF_MOVE
cid#1555847 COPY_INSTEAD_OF_MOVE
cid#1555851 COPY_INSTEAD_OF_MOVE
cid#1555853 COPY_INSTEAD_OF_MOVE
cid#1607763 COPY_INSTEAD_OF_MOVE
cid#1607504 COPY_INSTEAD_OF_MOVE

Change-Id: I991f15f12e773d325ed9725498df5725b049a858
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170625
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2024-07-17 21:49:14 +02:00
Caolán McNamara e5aa87aeeb drop requirement for rtl_random_getBytes to have "Pool" arg 
Seeing as since:

commit e9531b792d
Date:   Tue Feb 6 14:39:47 2024 +0100

    sal: rtlRandomPool: require OS random device, abort if not present

    Both rtl_random_createPool() and rtl_random_getBytes() first try to get
    random data from the OS, via /dev/urandom or rand_s() (documented to
    call RtlGenRandom(), see [1]).

we don't use the initial arg to rtl_random_getBytes anymore, drop the
requirement to have one. Then simplify our usages of that, and
addtionally deprecate rtl_random_createPool and rtl_random_destroyPool.

Change-Id: I13dcc067714a8a741a4e8f2bfcf2006373f832c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167067
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2024-05-08 11:29:54 +02:00
Noel Grandin 14cca2c88f loplugin:ostr in binaryurp 
Change-Id: I8fbb3a64cd101f219408103a771e1197e1e69776
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167203
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2024-05-06 19:23:50 +02:00
Caolán McNamara 990b9d7acc cid#1591493 Unchecked return value 
Change-Id: I0d39e142d3fd4100f68f1fff3f9d305aa1b59728
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162954
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2024-02-04 08:50:22 +01:00
Mike Kaganski 0fa827dbb2 Drop std::as_const from css::uno::Sequence iterations 
Obsoleted by commit 2484de6728 (Remove
non-const Sequence::begin()/end() in internal code, 2021-10-15) and
commit fb3c04bd19 (Drop non-const
Sequence::operator[] in internal code, 2021-11-05).

Change-Id: Idbafef5d34c0d4771cbbf75b9db9712e504164cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162640
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2024-01-27 12:43:48 +01:00
Julien Nabet c05595d242 c++20: use std::erase instead of std::removed followed by erase (part 1) 
Change-Id: I8d038fc37a4de25bdeff2e2cc55775e3981240b7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159610
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2023-11-18 18:38:01 +01:00
Noel Grandin 5f3031b33a Revert "loplugin:unodispose in binaryurp" 
This reverts commit 3d9f9b1b29.

Reason for revert: comment from sberg:

I'm not convinced that a general rule of "clear all references in dispose()" is a good idea.  For example, in this class, access to connection_ and provider_ is not guarded against MT-races, on the basis that those two are never modified post construction.  That is broken now.  Also, e.g. Bridge::getDescription dereferences connection_, and benignly used to work fine even when called on a disposed instance.  Now, it causes UB.

Change-Id: I6039d5b1488146f09439312800ceb1de3cfcf0ba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156878
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-09-13 12:29:13 +02:00
Noel Grandin 3d9f9b1b29 loplugin:unodispose in binaryurp 
Change-Id: Iab83b304ab7928dc4ca88a90f3184e2b2e7bf741
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156842
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-09-13 09:45:20 +02:00
Mike Kaganski c19c775c0b Use getXWeak in binaryurp 
Change-Id: If1891fc180126aa5d5ac92772cbca9b485619f46
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150836
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2023-05-28 09:06:11 +02:00
Caolán McNamara 341d1462c2 cid#1500596 silence Resource leak 
Change-Id: I4600c9cd0f7fdea698750ca416fc7f46dcebf23c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138928
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2022-08-27 13:13:29 +02:00
Caolán McNamara ea892cc0ea cid#1500523 silence Resource leak 
Change-Id: I9c2d026cb71615ac3121f47e47a6b0b163e820f5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138925
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2022-08-27 12:47:58 +02:00
Noel Grandin 7531f027c7 BridgeFactory should be a singleton 
regression from
    commit 9be078ae0d
    Date:   Sat Jul 4 09:12:35 2020 +0200
    binaryurp: create instances with uno constructors

Change-Id: Ib7a7316fdee4afffac35b282adaf437ff8bdd009
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135904
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-06-16 16:30:28 +02:00
Stephan Bergmann 7d8d65d850 The return value of XConnection::read is guaranteed to be non-negative 
...so use o3tl::make_unsigned when comparing it against an expression of
unsigned integer type, instead of casting that expression to a signed type

Change-Id: Id2bea3010bf67bdaeb0766b20baecba195bf0181
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135227
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2022-06-01 16:02:19 +02:00
Stephan Bergmann e89e3a8b5a The return value of those getLength functions is guaranteed to be non-negative 
...so use o3tl::make_unsigned when comparing it against an expression of
unsigned integer type, instead of casting that expression to a signed type

Change-Id: Ic47c6d96919b2aba2d16ce6d1a2a8e4c5761a480
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135219
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2022-06-01 10:49:20 +02:00
Stephan Bergmann 6974647815 cid#1504543 Silence unhelpful, aggressive UNINIT_CTOR 
Change-Id: Ida0c1bfd34ee68968b22579492bce4b137fa8a93
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134749
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2022-05-23 10:55:45 +02:00
Stephan Bergmann de403384f2 Adapt comment 
...after 084b2b068a "optimise Any::operator=(&&) a
little" folded moveAnyInternals into its only remaining call site

Change-Id: I2a9d8a775d601bc0307a3f3a5dfc139c571489ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134751
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2022-05-23 10:32:40 +02:00
Noel Grandin b36b225c6a clang-tidy modernize-pass-by-value in binaryurp 
Change-Id: I1570ed8ace3e1684ad228efbd8b13d2fe9b0f2af
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134706
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-05-21 17:30:08 +02:00
Pragat Pandya 6abc09926c tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro 
Change-Id: I54257e87da0cd66da59d820c7960c3e4b020fda3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134027
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
Tested-by: Jenkins
 2022-05-09 20:42:03 +02:00
Arnaud Versini 34df7e2cb9 binaryurp: use more std::mutex 
Change-Id: I1d16c4cbf60e78323b74e7df049736bd0d0ab591
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132072
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-03-25 09:20:48 +01:00
Mike Kaganski f6aef99057 Prepare for removal of non-const operator[] from Sequence in binaryurp 
Change-Id: Ibbe07a6de488461a99bb06d558cf740caa606bc9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124344
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2021-10-29 06:50:43 +02:00
Noel Grandin 953d8429c9 loplugin:moveparam in binaryurp 
Change-Id: Ia69e2307872813ede3339c0e9fbe1f2ae6a3508a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123246
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-10-08 17:10:07 +02:00
Noel Grandin e8c940b738 clang:optin.performance.Padding in binaryurp 
Excessive padding in 'struct binaryurp::OutgoingRequest' (11 padding
bytes, where 3 is optimal).

Excessive padding in 'struct binaryurp::Writer::Item' (28 padding bytes,
where 4 is optimal).

Excessive padding in 'class binaryurp::IncomingRequest' (19 padding
bytes, where 3 is optimal).

Change-Id: I43ef9c513ad2bbb1151edbf5db578d69d35ccfbf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121919
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-09-10 21:19:07 +02:00
Noel Grandin 05ab38359a Consolidate on C++17 std::scoped_lock instead of std::lock_guard 
as in commit 9376f65a26

Change-Id: I3ad9afd4d113582a214a4a4bc7eea55e38cd6ff9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119927
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-08-03 12:20:53 +02:00
Arnaud Versini 3785f97ec1 binaryurp : use std::mutex in outgoingrequests 
Change-Id: Ib0670af4596c5a40da27138d62b78df69bb77b9a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119121
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-07-18 11:37:21 +02:00
Noel Grandin 039180f825 Revert "improve logging message" 
This reverts commit 9f0484c2bc.

Reason for revert: this patch was unnecessary, the operator<< for css::uno::Exception alreadys logs the message, I got confused

Change-Id: I45932be060059eac92d460a70c944e1b19b5c375
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116706
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-06-07 22:05:23 +02:00
Noel Grandin 9f0484c2bc improve logging message 
Change-Id: Ib8f4fdbe3d644c035a125f7ae0a035a95bcafc76
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116781
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-06-07 16:07:23 +02:00
Julien Nabet 3e8e5f079e Simplify Sequences initializations (accessibility/binaryurp) 
Change-Id: I4b388b7faa1dc47f27d29aaaff9041fe81a29f71
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116739
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2021-06-05 16:21:03 +02:00
Noel Grandin d8d1565681 small perf improvement in readMemberValues 
Change-Id: I5d5973401a87b69dd54721d16ed19e227a6c2ac6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115674
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-05-17 10:39:05 +02:00
Stephan Bergmann 10d29c390d throw() -> noexcept, part 2/3: Automatic loplugin:noexcept rewrite 
Change-Id: I076f16d0536b534abf0ced4d76051eadb4c0e033
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114949
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2021-05-02 17:02:28 +02:00
Mike Kaganski 96388e5e80 Drop 'static_cast<cppu::OWeakObject*>' syntactic noise 
... where the object is created in-place, and its type is known

Change-Id: Ifabfcf2f3ad0d60152f14e8d970c1faa42115288
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112256
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2021-03-10 08:22:26 +01:00
Noel 7874cba970 loplugin:referencecasting in basctl..binaryurp 
Change-Id: I3fbc287cf76e453e2c464837d2431ff19501fde3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110968
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-02-16 08:57:02 +01:00
Noel bb06f51308 loplugin:stringviewparam extend to comparison operators 
which means that some call sites have to change to use
unicode string literals i.e. u"foo" instead of "foo"

Change-Id: Ie51c3adf56d343dd1d1710777f9d2a43ee66221c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106125
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-11-24 09:45:04 +01:00
Philipp Hofer 31fbd2be47 tdf#123936 Formatting files in module binaryurp with clang-format 
Change-Id: If0965d1d1fa500d74bad16871f7036fe4bb6d869
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105647
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
 2020-11-13 15:13:02 +01:00
Gabor Kelemen 0505a00a9b tdf#42949 Fix new IWYU warnings in directories [ab]* 
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: Ib0008b9bb095f27e5e436d6b507dc709ab7bf01a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105313
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
 2020-11-05 14:57:25 +01:00
George Bateman 5381af18b6 tdf#124176 Use #pragma once in binaryurp 
This commit was carried out by a Python script, source of which
is at https://bugs.documentfoundation.org/show_bug.cgi?id=124176#c97.

Change-Id: I7141f07eca2b8338be6bd6b24580256cda6ba092
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100129
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2020-09-04 08:58:54 +02:00
Noel Grandin 9be078ae0d binaryurp: create instances with uno constructors 
See tdf#74608 for motivation

Change-Id: Ide39715f83b0183f560e16fa69fcb3112496936d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97933
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-07-05 11:36:55 +02:00
Stephan Bergmann eb582a59f8 Upcoming improved loplugin:staticanonymous -> redundantstatic: binaryurp 
Change-Id: I67340a41005d93d11686ed5f5d49bf6e4938f8c7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97523
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2020-06-30 18:51:07 +02:00
Stephan Bergmann acbe57481e Rephrase comment 
760980b0b5 "Fix typos" had, IMO incorrectly,
removed one "that" from

  ..., so that that asynchronous request would...

Lets rephrase the original comment in a less problematic way.

Change-Id: Ic13ffaad43e2777eb36425363851b53f2f641865
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97087
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2020-06-25 11:09:22 +02:00