Marking binary document types as such prevents errors that I see
locally, like
$ git log -S getWordCompatibilityMode
E: unsupported filetype sw/qa/uitest/data/tdf168070_2.docx
fatal: unable to read files to diff
This also speeds up the search.
RTF files are marked 'diff', because they could in theory be considered
plaintext markup; maybe marking them also binary would be better.
Having them here helps prevents this:
E: unsupported filetype C:\Users\mikek\AppData\Local\Temp/git-blob-a26856/CVE-2005-2971-1.rtf
fatal: unable to read files to diff
Change-Id: I5da14b041f828e2ed1ff6c0acc9722e252802ef9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191591
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
When researching <https://gerrit.libreoffice.org/c/core/+/136350> "Make
CppunitTest_svgio CPPUNIT_TEST_NAME=Test::testCssClassRedefinition robust", I
was genuinely puzzled that git treated .svg files as binary data, until I
discovered 93e425cda7 ".gitattributes: treat .svg
and .jcs as binary". I don't consider its rationale of "this is apparently the
only way to prevent results from endless base64 encoded lines (svg) [...] in
'git grep foo'" convincing enough, compared to the puzzlement and inconvenience
it causes when you do want to grep for the content of SVG files.
(I didn't experience similar issues with .jcs files, so leave that alone for
now.))
Change-Id: I1b1f4aa92f7a538408e246080cdd415e109d2002
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136351
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
this is apparently the only way to prevent results from endless base64
encoded lines (svg) or endless line containing all UNO API identifiers
(jcs) in "git grep foo".
Change-Id: I53326386ece9dbde0fb372d1616e643a89d51a40
Mike Kaganski