ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

tdf#163486: PVS: Expression is always true

Browse Source 
V560 	A part of conditional expression is always true: pItem.

Change-Id: I4ae18820dc7ec3232bccb099e56dd0da2b4f59eb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175456
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
This commit is contained in:
Xisco Fauli
2024-10-23 09:25:22 +02:00
parent 156506630f
commit f6fc9dd338
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
svx/source/fmcomp/fmgridcl.cxx
+2 -3
View File
@@ -800,10 +800,9 @@ void FmGridHeader::PreExecuteColumnContextMenu(sal_uInt16 nColId, weld::Menu& rM
std::unique_ptr<SfxBoolItem> pItem;
SfxItemState eState = pCurrentFrame->GetBindings().QueryState(SID_FM_CTL_PROPERTIES, pItem);
if (eState >= SfxItemState::DEFAULT && pItem != nullptr)
if (eState >= SfxItemState::DEFAULT && pItem)
{
bool bChecked = pItem && pItem->GetValue();
rMenu.set_active(u"column"_ustr, bChecked);
rMenu.set_active(u"column"_ustr, pItem->GetValue());
}
}
}