ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

ofz#5475 Integer-overflow

Browse Source 
Change-Id: I11d706c544698d57b75231e33e3d49f1ac1d4d73
Reviewed-on: https://gerrit.libreoffice.org/48159
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
This commit is contained in:
Caolán McNamara
2018-01-19 21:51:31 +01:00
parent 25d159dd76
commit f69e2f739c
4 changed files with 28 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
emfio/source/reader/mtftools.cxx
+4 -1
View File
@@ -497,7 +497,10 @@ namespace emfio
tools::Rectangle MtfTools::ImplMap( const tools::Rectangle& rRect )
{
return tools::Rectangle( ImplMap( rRect.TopLeft() ), ImplMap( rRect.GetSize() ) );
tools::Rectangle aRect;
aRect.SetPos(ImplMap(rRect.TopLeft()));
aRect.SaturatingSetSize(ImplMap(rRect.GetSize()));
return aRect;
}
void MtfTools::ImplMap( vcl::Font& rFont )
include/tools/gen.hxx
+4
View File
@@ -430,6 +430,10 @@ public:
inline void expand(long nExpandBy);
inline void shrink(long nShrinkBy);
/**
* Sanitizing variants for handling data from the outside
*/
void SaturatingSetSize(const Size& rSize);
private:
long nLeft;
long nTop;
starmath/source/mathmlimport.cxx
+2 -2
View File
@@ -3062,14 +3062,14 @@ void SmXMLImport::SetViewSettings(const Sequence<PropertyValue>& aViewProps)
pValue->Value >>= nTmp;
Size aSize( aRect.GetSize() );
aSize.Width() = nTmp;
aRect.SetSize( aSize );
aRect.SaturatingSetSize(aSize);
}
else if (pValue->Name == "ViewAreaHeight" )
{
pValue->Value >>= nTmp;
Size aSize( aRect.GetSize() );
aSize.Height() = nTmp;
aRect.SetSize( aSize );
aRect.SaturatingSetSize(aSize);
}
pValue++;
}
tools/source/generic/gen.cxx
+18 -1
View File
@@ -20,7 +20,7 @@
#include <sal/config.h>
#include <sstream>
#include <o3tl/safeint.hxx>
#include <tools/gen.hxx>
#include <tools/stream.hxx>
@@ -68,6 +68,23 @@ void tools::Rectangle::SetSize( const Size& rSize )
nBottom = RECT_EMPTY;
}
void tools::Rectangle::SaturatingSetSize(const Size& rSize)
{
if (rSize.Width() < 0)
nRight = o3tl::saturating_add(nLeft, (rSize.Width() + 1));
else if ( rSize.Width() > 0 )
nRight = o3tl::saturating_add(nLeft, (rSize.Width() - 1));
else
nRight = RECT_EMPTY;
if ( rSize.Height() < 0 )
nBottom = o3tl::saturating_add(nTop, (rSize.Height() + 1));
else if ( rSize.Height() > 0 )
nBottom = o3tl::saturating_add(nTop, (rSize.Height() - 1));
else
nBottom = RECT_EMPTY;
}
tools::Rectangle& tools::Rectangle::Union( const tools::Rectangle& rRect )
{
if ( rRect.IsEmpty() )