Improved loplugin:stringconstant (now that GCC 7 supports it): scripting

Change-Id: I60519d5f0663ab244468f10cbc79a8fc80771726
Reviewed-on: https://gerrit.libreoffice.org/76651
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

scripting/source/basprov/basprov.cxx

@@ -70,7 +70,7 @@ namespace basprov
 
     static OUString getImplementationName_BasicProviderImpl()
     {
-        return OUString( "com.sun.star.comp.scripting.ScriptProviderForBasic"  );
+        return "com.sun.star.comp.scripting.ScriptProviderForBasic";
     }
 
 
@@ -399,7 +399,7 @@ namespace basprov
 
     OUString BasicProviderImpl::getName(  )
     {
-        return OUString("Basic");
+        return "Basic";
     }
 
 

scripting/source/dlgprov/dlgprov.cxx

@@ -69,7 +69,7 @@ namespace comp_DialogModelProvider
 
     OUString _getImplementationName()
     {
-        return OUString("com.sun.star.comp.scripting.DialogModelProvider");
+        return "com.sun.star.comp.scripting.DialogModelProvider";
     }
 
     uno::Sequence< OUString > _getSupportedServiceNames()
@@ -160,7 +160,7 @@ namespace dlgprov
 
     static OUString getImplementationName_DialogProviderImpl()
     {
-        return OUString( "com.sun.star.comp.scripting.DialogProvider"  );
+        return "com.sun.star.comp.scripting.DialogProvider";
     }
 
 

scripting/source/protocolhandler/scripthandler.cxx

@@ -434,7 +434,7 @@ Sequence< OUString > ScriptProtocolHandler::impl_getStaticSupportedServiceNames(
 /* Helper for XServiceInfo */
 OUString ScriptProtocolHandler::impl_getStaticImplementationName()
 {
-    return OUString("com.sun.star.comp.ScriptProtocolHandler");
+    return "com.sun.star.comp.ScriptProtocolHandler";
 }
 
 /* Helper for registry */

scripting/source/provider/BrowseNodeFactoryImpl.cxx

@@ -544,7 +544,7 @@ public:
 
     virtual OUString SAL_CALL getName() override
     {
-        return OUString("Root");
+        return "Root";
     }
 
     virtual Sequence< Reference< browse::XBrowseNode > > SAL_CALL
@@ -632,8 +632,8 @@ bnf_getSupportedServiceNames( )
 OUString
 bnf_getImplementationName( )
 {
-    return OUString(
-        "com.sun.star.script.browse.BrowseNodeFactory" );
+    return
+        "com.sun.star.script.browse.BrowseNodeFactory";
 }
 
 Reference< XInterface >

scripting/source/provider/MasterScriptProvider.cxx

@@ -656,7 +656,7 @@ sal_Bool SAL_CALL MasterScriptProvider::hasElements(  )
 
 OUString SAL_CALL MasterScriptProvider::getImplementationName( )
 {
-    return OUString( "com.sun.star.script.provider.MasterScriptProvider"  );
+    return "com.sun.star.script.provider.MasterScriptProvider";
 }
 
 sal_Bool SAL_CALL MasterScriptProvider::supportsService( const OUString& serviceName )
@@ -700,7 +700,7 @@ static Sequence< OUString > sp_getSupportedServiceNames( )
 
 static OUString sp_getImplementationName( )
 {
-    return OUString( "com.sun.star.script.provider.MasterScriptProvider"  );
+    return "com.sun.star.script.provider.MasterScriptProvider";
 }
 
 // ***** registration or ScriptingFrameworkURIHelper
@@ -718,8 +718,8 @@ static Sequence< OUString > urihelper_getSupportedServiceNames( )
 
 static OUString urihelper_getImplementationName( )
 {
-    return OUString(
-        "com.sun.star.script.provider.ScriptURIHelper");
+    return
+        "com.sun.star.script.provider.ScriptURIHelper";
 }
 
 static const struct cppu::ImplementationEntry s_entries [] =

scripting/source/provider/MasterScriptProviderFactory.cxx

@@ -72,8 +72,8 @@ Sequence< OUString > mspf_getSupportedServiceNames( )
 
 OUString mspf_getImplementationName( )
 {
-    return OUString(
-        "com.sun.star.script.provider.MasterScriptProviderFactory");
+    return
+        "com.sun.star.script.provider.MasterScriptProviderFactory";
 }
 
 Reference< XInterface >

scripting/source/provider/URIHelper.cxx

@@ -237,8 +237,8 @@ ScriptingFrameworkURIHelper::getRootStorageURI()
 OUString SAL_CALL
 ScriptingFrameworkURIHelper::getImplementationName()
 {
-    return OUString(
-        "com.sun.star.script.provider.ScriptURIHelper" );
+    return
+        "com.sun.star.script.provider.ScriptURIHelper";
 }
 
 sal_Bool SAL_CALL

scripting/source/stringresource/stringresource.cxx

@@ -80,7 +80,7 @@ static Sequence< OUString > getSupportedServiceNames_StringResourceImpl()
 
 static OUString getImplementationName_StringResourceImpl()
 {
-    return OUString( "com.sun.star.comp.scripting.StringResource" );
+    return "com.sun.star.comp.scripting.StringResource";
 }
 
 static Reference< XInterface > create_StringResourceImpl(
@@ -683,7 +683,7 @@ StringResourcePersistenceImpl::~StringResourcePersistenceImpl()
 
 OUString StringResourcePersistenceImpl::getImplementationName(  )
 {
-    return OUString( "com.sun.star.comp.scripting.StringResource");
+    return "com.sun.star.comp.scripting.StringResource";
 }
 
 
@@ -2065,7 +2065,7 @@ static Sequence< OUString > getSupportedServiceNames_StringResourceWithStorageIm
 
 static OUString getImplementationName_StringResourceWithStorageImpl()
 {
-    return OUString( "com.sun.star.comp.scripting.StringResourceWithStorage" );
+    return "com.sun.star.comp.scripting.StringResourceWithStorage";
 }
 
 static Reference< XInterface > create_StringResourceWithStorageImpl(
@@ -2351,7 +2351,7 @@ static Sequence< OUString > getSupportedServiceNames_StringResourceWithLocationI
 
 static OUString getImplementationName_StringResourceWithLocationImpl()
 {
-    return OUString( "com.sun.star.comp.scripting.StringResourceWithLocation" );
+    return "com.sun.star.comp.scripting.StringResourceWithLocation";
 }
 
 static Reference< XInterface > create_StringResourceWithLocationImpl(

scripting/source/vbaevents/eventhelper.cxx

@@ -575,7 +575,7 @@ public:
 
     OUString SAL_CALL getImplementationName() override
     {
-        return OUString( "ooo.vba.EventListener"  );
+        return "ooo.vba.EventListener";
     }
 
     sal_Bool SAL_CALL supportsService(OUString const & ServiceName) override
@@ -921,7 +921,7 @@ public:
 
     OUString SAL_CALL getImplementationName() override
     {
-        return OUString( "ooo.vba.VBAToOOEventDesc"  );
+        return "ooo.vba.VBAToOOEventDesc";
     }
 
     sal_Bool SAL_CALL supportsService(OUString const & ServiceName) override