Revert "tdf#172399 skip redrawing of old surface during live resize"

This reverts commit 2a7e219bea.

Reason for revert: I was finally able to reproduce the bug and this patch didn't fix the bug. Apparently, the bug only occurs when the notebook bar is used with Skia/Metal. Why the notebook bar keeps moving around with Skia/Metal but not Skia/Raster is now the mystery that needs to be solved.

Change-Id: I36dbb296d1737f6f7d24b0b9a478a4614ef4db5e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208131
Tested-by: Jenkins
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

vcl/skia/gdiimpl.cxx

@@ -52,10 +52,6 @@
 #include <o3tl/sorted_vector.hxx>
 #include <rtl/math.hxx>
 
-#ifdef MACOSX
-#include <svdata.hxx>
-#endif
-
 using namespace SkiaHelper;
 
 namespace
@@ -559,22 +555,8 @@ void SkiaSalGraphicsImpl::checkSurface()
             sk_sp<SkImage> snapshot;
             if (!isOffscreen())
             {
-#ifdef MACOSX
-                // tdf#172399 skip redrawing of old surface during live resize
-                // During live resize on macOS, there is a flood of resize
-                // events in quick succession so not only are most of the
-                // newly created surfaces short lived, but preserving and
-                // redrawing the original content drawn to the old surface
-                // is unnecessary since AquaSalFrame::SendPaintEvent() is
-                // is called after each resize event.
-                if (!ImplGetSVData()->mpWinData->mbIsLiveResize)
-                {
-#endif
-                    flushDrawing();
-                    snapshot = makeCheckedImageSnapshot(mSurface);
-#ifdef MACOSX
-                }
-#endif
+                flushDrawing();
+                snapshot = makeCheckedImageSnapshot(mSurface);
             }
 
             destroySurface();