cid#1556058 COPY_INSTEAD_OF_MOVE

and

cid#1556064 COPY_INSTEAD_OF_MOVE
cid#1556066 COPY_INSTEAD_OF_MOVE
cid#1556072 COPY_INSTEAD_OF_MOVE
cid#1556075 COPY_INSTEAD_OF_MOVE
cid#1556077 COPY_INSTEAD_OF_MOVE

Change-Id: Ie2992d321ecff15f104547e3a3cad6e8c1a786a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171708
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

cppcanvas/source/mtfrenderer/implrenderer.cxx

@@ -370,7 +370,7 @@ namespace cppcanvas::internal
                 aCalculatedNewState.pushFlags = rNewState.pushFlags;
 
                 // flush to stack
-                getState() = aCalculatedNewState;
+                getState() = std::move(aCalculatedNewState);
             }
             else
             {

helpcompiler/source/HelpLinker.cxx

@@ -671,7 +671,7 @@ void HelpLinker::main( std::vector<std::string> &args,
             }
             addFile = args[i];
             if (!addFileUnderPath.empty() && !addFile.empty())
-                additionalFiles[addFileUnderPath] = addFile;
+                additionalFiles[addFileUnderPath] = std::move(addFile);
         }
         else if (args[i].compare("-nolangroot") == 0)
             m_bUseLangRoot = false;

sc/source/ui/miscdlgs/optsolver.cxx

@@ -1072,7 +1072,7 @@ bool ScOptSolverDlg::CallSolver()       // return true -> close dialog after cal
         }
 
         aConstraints.realloc( nConstrPos + 1 );
-        aConstraints.getArray()[nConstrPos++] = aConstraint;
+        aConstraints.getArray()[nConstrPos++] = std::move(aConstraint);
     }
 
     // copy old document values

ucb/source/ucp/hierarchy/hierarchycontent.cxx

@@ -1246,7 +1246,7 @@ uno::Sequence< uno::Any > HierarchyContent::setPropertyValues(
         aEvent.OldValue     <<= aOldTitle;
         aEvent.NewValue     <<= m_aProps.getTitle();
 
-        aChanges.getArray()[ nChanged ] = aEvent;
+        aChanges.getArray()[ nChanged ] = std::move(aEvent);
         nChanged++;
     }
 

vcl/source/bitmap/BitmapSobelGreyFilter.cxx

@@ -143,7 +143,7 @@ BitmapEx BitmapSobelGreyFilter::execute(BitmapEx const& rBitmapEx) const
     const MapMode aMap(aBitmap.GetPrefMapMode());
     const Size aPrefSize(aBitmap.GetPrefSize());
 
-    aBitmap = aNewBmp;
+    aBitmap = std::move(aNewBmp);
 
     aBitmap.SetPrefMapMode(aMap);
     aBitmap.SetPrefSize(aPrefSize);

vcl/source/control/field.cxx

@@ -323,7 +323,7 @@ bool ImplNumericGetValue( const OUString& rStr, sal_Int64& rValue,
             aStr2.append(aStrFrac.getStr()+nDecPos+1);
         }
         else
-            aStr1 = aStrFrac;
+            aStr1 = std::move(aStrFrac);
     }
 
     // prune and round fraction