a11y: Drop "===== internal ======" comments
It's unclear to me what these
//==== internal =========================================================
comments are trying to say.
(What does it mean if the public ctor of a class that
gets called from outside that class is "internal"?)
If those were intended to say what methods are internal to a class
then access specifiers (private, protected, public) would be the proper
way to specify what is internal to a class (but that doesn't seem to
be the semantic used here).
If "internal" is meant to indicate that these are LibreOffice-internal
(not available for third-party code in extensions or
macros), then there is no need to explicitly mention that, because
all a11y class implementations are internal only, no instances are
created directly by calling ctors from third party code.)
Change-Id: I118c7e0bee77cda68e67f0a3bfe134aeaaa86d73
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186746
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
This commit is contained in:
Michael Weghorn
@@ -37,9 +37,6 @@ class EDITENG_DLLPUBLIC AccessibleContextBase
|
||||
css::lang::XServiceInfo, css::accessibility::XAccessible>
|
||||
{
|
||||
public:
|
||||
|
||||
//===== internal ========================================================
|
||||
|
||||
/** The origin of the accessible name or description.
|
||||
*/
|
||||
enum StringOrigin {
|
||||
|
||||
@@ -65,7 +65,6 @@ class SAL_DLLPUBLIC_RTTI AccessibleControlShape final
|
||||
,public AccessibleControlShape_Base
|
||||
{
|
||||
public:
|
||||
//===== internal ========================================================
|
||||
AccessibleControlShape(
|
||||
const AccessibleShapeInfo& rShapeInfo,
|
||||
const AccessibleShapeTreeInfo& rShapeTreeInfo);
|
||||
|
||||
@@ -44,7 +44,6 @@ class SVX_DLLPUBLIC AccessibleGraphicShape
|
||||
public css::accessibility::XAccessibleImage
|
||||
{
|
||||
public:
|
||||
//===== internal ========================================================
|
||||
AccessibleGraphicShape (
|
||||
const AccessibleShapeInfo& rShapeInfo,
|
||||
const AccessibleShapeTreeInfo& rShapeTreeInfo);
|
||||
|
||||
@@ -45,7 +45,6 @@ class SVX_DLLPUBLIC AccessibleOLEShape
|
||||
public css::accessibility::XAccessibleAction
|
||||
{
|
||||
public:
|
||||
//===== internal ========================================================
|
||||
AccessibleOLEShape (
|
||||
const AccessibleShapeInfo& rShapeInfo,
|
||||
const AccessibleShapeTreeInfo& rShapeTreeInfo);
|
||||
|
||||
@@ -94,8 +94,6 @@ class SVX_DLLPUBLIC AccessibleShape
|
||||
public css::lang::XUnoTunnel
|
||||
{
|
||||
public:
|
||||
//===== internal ========================================================
|
||||
|
||||
/** Create a new accessible object that makes the given shape accessible.
|
||||
@param rShapeInfo
|
||||
This object contains all information specific to the new
|
||||
|
||||
@@ -43,7 +43,6 @@ class UNOTOOLS_DLLPUBLIC AccessibleRelationSetHelper final
|
||||
: public cppu::WeakImplHelper<css::accessibility::XAccessibleRelationSet>
|
||||
{
|
||||
public:
|
||||
//===== internal ========================================================
|
||||
AccessibleRelationSetHelper();
|
||||
|
||||
css::uno::Reference<css::accessibility::XAccessibleRelationSet> Clone() const;
|
||||
|
||||
@@ -303,8 +303,6 @@ uno::Sequence< OUString> SAL_CALL
|
||||
return comphelper::concatSequences(ScAccessibleContextBase::getSupportedServiceNames(), vals);
|
||||
}
|
||||
|
||||
//==== internal =========================================================
|
||||
|
||||
bool ScAccessibleCell::IsDefunc(sal_Int64 nParentStates)
|
||||
{
|
||||
return ScAccessibleContextBase::IsDefunc() || (mpDoc == nullptr) || (mpViewShell == nullptr) || !getAccessibleParent().is() ||
|
||||
|
||||
@@ -44,8 +44,6 @@ using namespace ::com::sun::star::accessibility;
|
||||
|
||||
#define DEFAULT_LINE_WIDTH 2
|
||||
|
||||
//===== internal ============================================================
|
||||
|
||||
ScAccessibleCellBase::ScAccessibleCellBase(const uno::Reference<XAccessible>& rxParent,
|
||||
ScDocument* pDoc, const ScAddress& rCellAddress,
|
||||
sal_Int64 nIndex)
|
||||
|
||||
@@ -255,8 +255,6 @@ uno::Sequence< OUString> SAL_CALL
|
||||
u"com.sun.star.accessibility.AccessibleContext"_ustr};
|
||||
}
|
||||
|
||||
//===== internal ============================================================
|
||||
|
||||
OUString
|
||||
ScAccessibleContextBase::createAccessibleDescription()
|
||||
{
|
||||
|
||||
@@ -82,8 +82,6 @@
|
||||
using namespace ::com::sun::star;
|
||||
using namespace ::com::sun::star::accessibility;
|
||||
|
||||
//===== internal ========================================================
|
||||
|
||||
namespace {
|
||||
|
||||
struct ScAccessibleShapeData
|
||||
@@ -1981,8 +1979,6 @@ Size ScAccessibleDocument::LogicToPixel (const Size& rSize) const
|
||||
return aSize;
|
||||
}
|
||||
|
||||
//===== internal ========================================================
|
||||
|
||||
rtl::Reference<utl::AccessibleRelationSetHelper> ScAccessibleDocument::GetRelationSet(const ScAddress* pAddress) const
|
||||
{
|
||||
rtl::Reference<utl::AccessibleRelationSetHelper> pRelationSet;
|
||||
|
||||
@@ -24,8 +24,6 @@
|
||||
using namespace ::com::sun::star;
|
||||
using namespace ::com::sun::star::accessibility;
|
||||
|
||||
//===== internal ========================================================
|
||||
|
||||
ScAccessibleDocumentBase::ScAccessibleDocumentBase(const uno::Reference<XAccessible>& rxParent)
|
||||
: ScAccessibleContextBase(rxParent, AccessibleRole::DOCUMENT_SPREADSHEET)
|
||||
{
|
||||
|
||||
@@ -1109,8 +1109,6 @@ ScPagePreviewCountData::ScPagePreviewCountData( const ScPreviewLocationData& rDa
|
||||
nNoteParagraphs = pNotesChildren->GetChildrenCount();
|
||||
}
|
||||
|
||||
//===== internal ========================================================
|
||||
|
||||
ScAccessibleDocumentPagePreview::ScAccessibleDocumentPagePreview(
|
||||
const uno::Reference<XAccessible>& rxParent, ScPreviewShell* pViewShell ) :
|
||||
ScAccessibleDocumentBase(rxParent),
|
||||
@@ -1435,8 +1433,6 @@ uno::Sequence< OUString> SAL_CALL ScAccessibleDocumentPagePreview::getSupportedS
|
||||
return comphelper::concatSequences(ScAccessibleContextBase::getSupportedServiceNames(), vals);
|
||||
}
|
||||
|
||||
//===== internal ========================================================
|
||||
|
||||
OUString ScAccessibleDocumentPagePreview::createAccessibleDescription()
|
||||
{
|
||||
return STR_ACC_PREVIEWDOC_DESCR;
|
||||
|
||||
@@ -54,8 +54,6 @@ using ::com::sun::star::lang::IndexOutOfBoundsException;
|
||||
using namespace ::com::sun::star;
|
||||
using namespace ::com::sun::star::accessibility;
|
||||
|
||||
//===== internal ============================================================
|
||||
|
||||
ScAccessibleEditObject::ScAccessibleEditObject(
|
||||
const uno::Reference<XAccessible>& rxParent,
|
||||
EditView* pEditView, vcl::Window* pWin, const OUString& rName,
|
||||
@@ -339,8 +337,6 @@ uno::Sequence<sal_Int8> SAL_CALL
|
||||
return css::uno::Sequence<sal_Int8>();
|
||||
}
|
||||
|
||||
//==== internal =========================================================
|
||||
|
||||
bool ScAccessibleEditObject::IsDefunc(sal_Int64 nParentStates)
|
||||
{
|
||||
return ScAccessibleContextBase::IsDefunc() || !getAccessibleParent().is() ||
|
||||
|
||||
@@ -276,8 +276,6 @@ uno::Sequence<OUString> SAL_CALL ScAccessiblePageHeader::getSupportedServiceName
|
||||
return comphelper::concatSequences(ScAccessibleContextBase::getSupportedServiceNames(), vals);
|
||||
}
|
||||
|
||||
//==== internal =========================================================
|
||||
|
||||
OUString ScAccessiblePageHeader::createAccessibleDescription()
|
||||
{
|
||||
OUString sDesc(mbHeader ? STR_ACC_HEADER_DESCR : STR_ACC_FOOTER_DESCR);
|
||||
|
||||
@@ -40,8 +40,6 @@
|
||||
using namespace ::com::sun::star;
|
||||
using namespace ::com::sun::star::accessibility;
|
||||
|
||||
//===== internal ========================================================
|
||||
|
||||
ScAccessiblePageHeaderArea::ScAccessiblePageHeaderArea(
|
||||
const uno::Reference<XAccessible>& rxParent,
|
||||
ScPreviewShell* pViewShell,
|
||||
|
||||
@@ -38,8 +38,6 @@
|
||||
using namespace ::com::sun::star;
|
||||
using namespace ::com::sun::star::accessibility;
|
||||
|
||||
//===== internal ============================================================
|
||||
|
||||
ScAccessiblePreviewCell::ScAccessiblePreviewCell(
|
||||
const rtl::Reference<ScAccessiblePreviewTable>& rParent, ScPreviewShell* pViewShell,
|
||||
const ScAddress& rCellAddress, sal_Int32 nIndex)
|
||||
@@ -181,8 +179,6 @@ uno::Sequence<OUString> SAL_CALL ScAccessiblePreviewCell::getSupportedServiceNam
|
||||
return comphelper::concatSequences(ScAccessibleContextBase::getSupportedServiceNames(), vals);
|
||||
}
|
||||
|
||||
//==== internal =========================================================
|
||||
|
||||
AbsoluteScreenPixelRectangle ScAccessiblePreviewCell::GetBoundingBoxOnScreen()
|
||||
{
|
||||
tools::Rectangle aCellRect;
|
||||
|
||||
@@ -49,8 +49,6 @@
|
||||
using namespace ::com::sun::star;
|
||||
using namespace ::com::sun::star::accessibility;
|
||||
|
||||
//===== internal ============================================================
|
||||
|
||||
ScAccessiblePreviewHeaderCell::ScAccessiblePreviewHeaderCell( const css::uno::Reference<css::accessibility::XAccessible>& rxParent,
|
||||
ScPreviewShell* pViewShell,
|
||||
const ScAddress& rCellPos, bool bIsColHdr, bool bIsRowHdr,
|
||||
@@ -281,8 +279,6 @@ uno::Sequence<sal_Int8> SAL_CALL
|
||||
return css::uno::Sequence<sal_Int8>();
|
||||
}
|
||||
|
||||
//==== internal =========================================================
|
||||
|
||||
AbsoluteScreenPixelRectangle ScAccessiblePreviewHeaderCell::GetBoundingBoxOnScreen()
|
||||
{
|
||||
tools::Rectangle aCellRect;
|
||||
|
||||
@@ -42,8 +42,6 @@
|
||||
using namespace ::com::sun::star;
|
||||
using namespace ::com::sun::star::accessibility;
|
||||
|
||||
//===== internal ============================================================
|
||||
|
||||
ScAccessiblePreviewTable::ScAccessiblePreviewTable(
|
||||
const css::uno::Reference<css::accessibility::XAccessible>& rxParent,
|
||||
ScPreviewShell* pViewShell, sal_Int32 nIndex)
|
||||
@@ -517,8 +515,6 @@ uno::Sequence<OUString> SAL_CALL ScAccessiblePreviewTable::getSupportedServiceNa
|
||||
return aSequence;
|
||||
}
|
||||
|
||||
//==== internal =========================================================
|
||||
|
||||
OUString ScAccessiblePreviewTable::createAccessibleDescription()
|
||||
{
|
||||
return STR_ACC_TABLE_DESCR;
|
||||
|
||||
@@ -237,8 +237,6 @@ bool ScAccessibleSpreadsheet::CalcScRangeListDifferenceMax(ScRangeList *pSrc, Sc
|
||||
return false;
|
||||
}
|
||||
|
||||
//===== internal ============================================================
|
||||
|
||||
// FIXME: really unclear why we have an ScAccessibleTableBase with
|
||||
// only this single sub-class
|
||||
ScAccessibleSpreadsheet::ScAccessibleSpreadsheet(
|
||||
@@ -1316,8 +1314,6 @@ uno::Sequence<sal_Int8> SAL_CALL
|
||||
return css::uno::Sequence<sal_Int8>();
|
||||
}
|
||||
|
||||
//==== internal =========================================================
|
||||
|
||||
AbsoluteScreenPixelRectangle ScAccessibleSpreadsheet::GetBoundingBoxOnScreen()
|
||||
{
|
||||
AbsoluteScreenPixelRectangle aRect;
|
||||
|
||||
@@ -34,8 +34,6 @@
|
||||
using namespace ::com::sun::star;
|
||||
using namespace ::com::sun::star::accessibility;
|
||||
|
||||
//===== internal ============================================================
|
||||
|
||||
ScAccessibleTableBase::ScAccessibleTableBase(
|
||||
const uno::Reference<XAccessible>& rxParent,
|
||||
ScDocument* pDoc,
|
||||
|
||||
@@ -28,7 +28,6 @@ class ScAccessibleCellBase
|
||||
css::accessibility::XAccessibleValue>
|
||||
{
|
||||
public:
|
||||
//===== internal ========================================================
|
||||
ScAccessibleCellBase(
|
||||
const css::uno::Reference<css::accessibility::XAccessible>& rxParent,
|
||||
ScDocument* pDoc,
|
||||
|
||||
@@ -42,7 +42,6 @@ class ScAccessibleContextBase
|
||||
{
|
||||
|
||||
public:
|
||||
//===== internal ========================================================
|
||||
ScAccessibleContextBase(
|
||||
css::uno::Reference<css::accessibility::XAccessible> xParent,
|
||||
const sal_Int16 aRole);
|
||||
|
||||
@@ -54,7 +54,6 @@ class ScAccessibleDocument
|
||||
public accessibility::IAccessibleViewForwarder
|
||||
{
|
||||
public:
|
||||
//===== internal ========================================================
|
||||
ScAccessibleDocument(
|
||||
const css::uno::Reference<css::accessibility::XAccessible>& rxParent,
|
||||
ScTabViewShell* pViewShell,
|
||||
|
||||
@@ -24,7 +24,6 @@
|
||||
class ScAccessibleDocumentBase : public ScAccessibleContextBase
|
||||
{
|
||||
public:
|
||||
//===== internal ========================================================
|
||||
ScAccessibleDocumentBase(const css::uno::Reference<css::accessibility::XAccessible>& rxParent);
|
||||
|
||||
protected:
|
||||
|
||||
@@ -35,7 +35,6 @@ class ScAccessibleDocumentPagePreview
|
||||
: public ScAccessibleDocumentBase
|
||||
{
|
||||
public:
|
||||
//===== internal ========================================================
|
||||
ScAccessibleDocumentPagePreview(
|
||||
const css::uno::Reference<css::accessibility::XAccessible>& rxParent,
|
||||
ScPreviewShell* pViewShell );
|
||||
@@ -86,8 +85,6 @@ public:
|
||||
virtual css::uno::Sequence< OUString> SAL_CALL
|
||||
getSupportedServiceNames() override;
|
||||
|
||||
///===== internal ========================================================
|
||||
|
||||
protected:
|
||||
/// Return this object's description.
|
||||
virtual OUString
|
||||
|
||||
@@ -33,7 +33,6 @@ class ScAccessiblePageHeaderArea
|
||||
: public ScAccessibleContextBase
|
||||
{
|
||||
public:
|
||||
//===== internal ========================================================
|
||||
ScAccessiblePageHeaderArea(
|
||||
const css::uno::Reference<css::accessibility::XAccessible>& rxParent,
|
||||
ScPreviewShell* pViewShell,
|
||||
|
||||
@@ -41,7 +41,6 @@ class ScAccessibleTableBase :
|
||||
public ScAccessibleTableBaseImpl
|
||||
{
|
||||
public:
|
||||
//===== internal ========================================================
|
||||
ScAccessibleTableBase(
|
||||
const css::uno::Reference<css::accessibility::XAccessible>& rxParent,
|
||||
ScDocument* pDoc,
|
||||
|
||||
@@ -57,7 +57,6 @@ using ::com::sun::star::uno::Reference;
|
||||
|
||||
namespace accessibility {
|
||||
|
||||
//===== internal ============================================================
|
||||
AccessibleDocumentViewBase::AccessibleDocumentViewBase (
|
||||
::sd::Window* pSdWindow,
|
||||
::sd::ViewShell* pViewShell,
|
||||
|
||||
@@ -78,8 +78,6 @@ struct XShapePosCompareHelper
|
||||
|
||||
}
|
||||
|
||||
//===== internal ============================================================
|
||||
|
||||
AccessibleDrawDocumentView::AccessibleDrawDocumentView (
|
||||
::sd::Window* pSdWindow,
|
||||
::sd::ViewShell* pViewShell,
|
||||
|
||||
@@ -39,8 +39,6 @@ using namespace ::com::sun::star::accessibility;
|
||||
|
||||
namespace accessibility {
|
||||
|
||||
//===== internal ============================================================
|
||||
|
||||
AccessibleOutlineView::AccessibleOutlineView (
|
||||
::sd::Window* pSdWindow,
|
||||
::sd::OutlineViewShell* pViewShell,
|
||||
|
||||
@@ -36,8 +36,6 @@ using ::com::sun::star::uno::Reference;
|
||||
|
||||
namespace accessibility {
|
||||
|
||||
//===== internal ============================================================
|
||||
|
||||
AccessiblePageShape::AccessiblePageShape (
|
||||
uno::Reference<drawing::XDrawPage> xPage,
|
||||
const uno::Reference<XAccessible>& rxParent,
|
||||
|
||||
@@ -30,8 +30,6 @@ using namespace ::com::sun::star::accessibility;
|
||||
|
||||
namespace accessibility
|
||||
{
|
||||
//===== internal ============================================================
|
||||
|
||||
AccessiblePresentationGraphicShape::AccessiblePresentationGraphicShape(
|
||||
const AccessibleShapeInfo& rShapeInfo, const AccessibleShapeTreeInfo& rShapeTreeInfo)
|
||||
: AccessibleGraphicShape(rShapeInfo, rShapeTreeInfo)
|
||||
|
||||
@@ -30,8 +30,6 @@ using namespace ::com::sun::star::accessibility;
|
||||
|
||||
namespace accessibility
|
||||
{
|
||||
//===== internal ============================================================
|
||||
|
||||
AccessiblePresentationOLEShape::AccessiblePresentationOLEShape(
|
||||
const AccessibleShapeInfo& rShapeInfo, const AccessibleShapeTreeInfo& rShapeTreeInfo)
|
||||
: AccessibleOLEShape(rShapeInfo, rShapeTreeInfo)
|
||||
|
||||
@@ -31,8 +31,6 @@ using namespace ::com::sun::star;
|
||||
|
||||
namespace accessibility
|
||||
{
|
||||
//===== internal ============================================================
|
||||
|
||||
AccessiblePresentationShape::AccessiblePresentationShape(
|
||||
const AccessibleShapeInfo& rShapeInfo, const AccessibleShapeTreeInfo& rShapeTreeInfo)
|
||||
: AccessibleShape(rShapeInfo, rShapeTreeInfo)
|
||||
|
||||
@@ -87,8 +87,6 @@ class AccessibleDocumentViewBase
|
||||
public css::accessibility::XAccessibleExtendedAttributes
|
||||
{
|
||||
public:
|
||||
//===== internal ========================================================
|
||||
|
||||
/** Create a new object. Note that the caller has to call the
|
||||
Init method directly after this constructor has finished.
|
||||
@param pSdWindow
|
||||
|
||||
@@ -41,7 +41,6 @@ class AccessibleDrawDocumentView final :
|
||||
,public css::accessibility::XAccessibleGroupPosition
|
||||
{
|
||||
public:
|
||||
//===== internal ========================================================
|
||||
|
||||
AccessibleDrawDocumentView (::sd::Window* pSdWindow,
|
||||
::sd::ViewShell* pViewShell,
|
||||
|
||||
@@ -33,7 +33,6 @@ class AccessiblePageShape final
|
||||
: public AccessibleShape
|
||||
{
|
||||
public:
|
||||
//===== internal ========================================================
|
||||
|
||||
/** Create a new accessible object that makes the given shape accessible.
|
||||
@param rxParent
|
||||
|
||||
@@ -32,7 +32,6 @@ class AccessiblePresentationGraphicShape final
|
||||
: public AccessibleGraphicShape
|
||||
{
|
||||
public:
|
||||
//===== internal ========================================================
|
||||
AccessiblePresentationGraphicShape (
|
||||
const AccessibleShapeInfo& rShapeInfo,
|
||||
const AccessibleShapeTreeInfo& rShapeTreeInfo);
|
||||
@@ -45,8 +44,6 @@ public:
|
||||
virtual OUString SAL_CALL
|
||||
getImplementationName() override;
|
||||
|
||||
//===== internal ========================================================
|
||||
|
||||
/// Create a name string that contains the accessible name.
|
||||
virtual OUString
|
||||
CreateAccessibleBaseName () override;
|
||||
|
||||
@@ -29,7 +29,6 @@ class AccessiblePresentationOLEShape final
|
||||
: public AccessibleOLEShape
|
||||
{
|
||||
public:
|
||||
//===== internal ========================================================
|
||||
AccessiblePresentationOLEShape (
|
||||
const AccessibleShapeInfo& rShapeInfo,
|
||||
const AccessibleShapeTreeInfo& rShapeTreeInfo);
|
||||
@@ -42,8 +41,6 @@ public:
|
||||
virtual OUString SAL_CALL
|
||||
getImplementationName() override;
|
||||
|
||||
//===== internal ========================================================
|
||||
|
||||
/// Create a name string that contains the accessible name.
|
||||
virtual OUString
|
||||
CreateAccessibleBaseName () override;
|
||||
|
||||
@@ -29,7 +29,6 @@ class AccessiblePresentationShape final
|
||||
: public AccessibleShape
|
||||
{
|
||||
public:
|
||||
//===== internal ========================================================
|
||||
AccessiblePresentationShape (
|
||||
const AccessibleShapeInfo& rShapeInfo,
|
||||
const AccessibleShapeTreeInfo& rShapeTreeInfo);
|
||||
@@ -42,8 +41,6 @@ public:
|
||||
virtual OUString SAL_CALL
|
||||
getImplementationName() override;
|
||||
|
||||
//===== internal ========================================================
|
||||
|
||||
/// Create a name string that contains the accessible name.
|
||||
virtual OUString
|
||||
CreateAccessibleBaseName () override;
|
||||
|
||||
@@ -40,8 +40,6 @@ namespace accessibility
|
||||
class AccessibleViewForwarder final : public IAccessibleViewForwarder
|
||||
{
|
||||
public:
|
||||
//===== internal ========================================================
|
||||
|
||||
AccessibleViewForwarder(SdrPaintView* pView, const OutputDevice& rDevice);
|
||||
|
||||
virtual ~AccessibleViewForwarder() override;
|
||||
|
||||
@@ -38,8 +38,6 @@ using namespace ::com::sun::star::uno;
|
||||
using namespace ::com::sun::star::accessibility;
|
||||
|
||||
|
||||
//===== internal ============================================================
|
||||
|
||||
SvtRulerAccessible::SvtRulerAccessible(uno::Reference<XAccessible> xParent, Ruler& rRepr,
|
||||
OUString aName)
|
||||
: msName(std::move(aName))
|
||||
|
||||
@@ -38,7 +38,6 @@ class SvtRulerAccessible final
|
||||
css::accessibility::XAccessible, css::lang::XServiceInfo>
|
||||
{
|
||||
public:
|
||||
//===== internal ========================================================
|
||||
SvtRulerAccessible(
|
||||
css::uno::Reference< css::accessibility::XAccessible> xParent, Ruler& rRepresentation, OUString aName );
|
||||
|
||||
|
||||
@@ -40,7 +40,6 @@ namespace
|
||||
return AccessibleRelation();
|
||||
}
|
||||
}
|
||||
//===== internal ============================================================
|
||||
|
||||
AccessibleRelationSetHelper::AccessibleRelationSetHelper ()
|
||||
{
|
||||
|
||||
Reference in New Issue
Block a user