cid#1556474 COPY_INSTEAD_OF_MOVE

and

cid#1557319 COPY_INSTEAD_OF_MOVE
cid#1557320 COPY_INSTEAD_OF_MOVE
cid#1558101 COPY_INSTEAD_OF_MOVE
cid#1606536 COPY_INSTEAD_OF_MOVE

Change-Id: Ibe10ee3fad7f6ca1f3c5b316fdafe4bf15f0ead7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170280
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins

oox/source/drawingml/diagram/layoutnodecontext.cxx

@@ -244,7 +244,7 @@ LayoutNodeContext::onCreateContext( ::sal_Int32 aElement,
 
         ShapeAtomPtr pAtom = std::make_shared<ShapeAtom>(mpNode->getLayoutNode(), pShape);
         LayoutAtom::connect(mpNode, pAtom);
-        return new ShapeContext( *this, ShapePtr(), pShape );
+        return new ShapeContext( *this, ShapePtr(), std::move(pShape) );
     }
     case DGM_TOKEN( extLst ):
         return nullptr;

sc/source/core/tool/interpr1.cxx

@@ -386,7 +386,7 @@ void ScInterpreter::ScIfError( bool bNAonly )
                         }
                         nR = 0;
                     }
-                    xNew = new ScJumpMatrixToken( pJumpMat );
+                    xNew = new ScJumpMatrixToken(std::move(pJumpMat));
                     GetTokenMatrixMap().emplace( pCur, xNew );
                 }
                 nGlobalError = nOldGlobalError;

sd/source/ui/annotations/annotationmanager.cxx

@@ -1102,7 +1102,7 @@ void AnnotationManagerImpl::SyncAnnotationObjects()
             for (auto const& rPolygon : rInfo.maPolygons)
                 aPolyPolygon.append(rPolygon);
 
-            pNewObject = new SdrPathObj(rModel, ekind, aPolyPolygon);
+            pNewObject = new SdrPathObj(rModel, ekind, std::move(aPolyPolygon));
 
             applyAnnotationCommon(*pNewObject, xAnnotation);
             applyAnnotationProperties(*pNewObject, rInfo);

svgio/source/svgreader/svgcharacternode.cxx

@@ -396,7 +396,7 @@ namespace svgio::svgreader
                         std::move(aTextArray),
                         {},
                         aFontAttribute,
-                        aLocale,
+                        std::move(aLocale),
                         aFill,
                         COL_TRANSPARENT,
 
@@ -425,7 +425,7 @@ namespace svgio::svgreader
                         std::move(aTextArray),
                         {},
                         aFontAttribute,
-                        aLocale,
+                        std::move(aLocale),
                         aFill);
                 }
 

sw/source/writerfilter/dmapper/DomainMapper_Impl.cxx

@@ -1485,7 +1485,7 @@ uno::Any DomainMapper_Impl::GetPropertyFromStyleSheet(PropertyIds eId, StyleShee
         if (pEntry == pNewEntry) //fdo#49587
             break;
 
-        pEntry = pNewEntry;
+        pEntry = std::move(pNewEntry);
     }
     // not found in style, try the document's DocDefault properties
     if ( bDocDefaults && bPara )