xmlsec: upgrade to 1.3.8

Downloaded from
<https://www.aleksey.com/xmlsec/download/xmlsec1-1.3.8.tar.gz>.

Remove 0001-const-up-xmlSecErrorsTable.patch, which is upstream already.

Change-Id: I633ed7ecc90b8d798aa9ae03a4237fda4cf26b47
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192476
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

download.lst

@@ -455,8 +455,8 @@ LIBWEBP_TARBALL := libwebp-1.6.0.tar.gz
 # three static lines
 # so that git cherry-pick
 # will not run into conflicts
-XMLSEC_SHA256SUM := d82e93b69b8aa205a616b62917a269322bf63a3eaafb3775014e61752b2013ea
-XMLSEC_TARBALL := xmlsec1-1.3.7.tar.gz
+XMLSEC_SHA256SUM := d0180916ae71be28415a6fa919a0684433ec9ec3ba1cc0866910b02e5e13f5bd
+XMLSEC_TARBALL := xmlsec1-1.3.8.tar.gz
 # three static lines
 # so that git cherry-pick
 # will not run into conflicts

external/xmlsec/0001-const-up-xmlSecErrorsTable.patch

@@ -1,26 +0,0 @@
-From 49382b442e2c1c651019c58966f7a6378759954b Mon Sep 17 00:00:00 2001
-From: =?UTF-8?q?Caol=C3=A1n=20McNamara?= <caolan.mcnamara@collabora.com>
-Date: Sat, 12 Jul 2025 21:33:34 +0100
-Subject: [PATCH] const up xmlSecErrorsTable
-
-to move it out of the .data table
----
- src/errors.c | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/src/errors.c b/src/errors.c
-index 075265d6..fe7e6601 100644
---- a/src/errors.c
-+++ b/src/errors.c
-@@ -41,7 +41,7 @@ struct _xmlSecErrorDescription {
-     const char*         errorMsg;
- };
- 
--static xmlSecErrorDescription xmlSecErrorsTable[XMLSEC_ERRORS_MAX_NUMBER + 1] = {
-+static const xmlSecErrorDescription xmlSecErrorsTable[XMLSEC_ERRORS_MAX_NUMBER + 1] = {
-   { XMLSEC_ERRORS_R_XMLSEC_FAILED,              "xmlsec library function failed" },
-   { XMLSEC_ERRORS_R_MALLOC_FAILED,              "malloc function failed" },
-   { XMLSEC_ERRORS_R_STRDUP_FAILED,              "strdup function failed" },
--- 
-2.49.0
-

external/xmlsec/UnpackedTarball_xmlsec.mk

@@ -10,8 +10,6 @@
 xmlsec_patches :=
 # Remove this when Ubuntu 20.04 is EOL in 2025.
 xmlsec_patches += old-nss.patch.1
-# Upstreamed as: https://github.com/lsh123/xmlsec/pull/937
-xmlsec_patches += 0001-const-up-xmlSecErrorsTable.patch
 
 $(eval $(call gb_UnpackedTarball_UnpackedTarball,xmlsec))