ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

Emscripten Qt5: Reliably send cut/copy data to browser Clipboard API

Browse Source 
Change-Id: I11204b77649e0543f5350546505dbe965a2a471c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183160
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
This commit is contained in:
Stephan Bergmann
2025-03-20 16:50:37 +01:00
parent 612891865a
commit cbe801780a
1 changed files with 40 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
vcl/qt5/QtClipboard.cxx
+40
View File
@@ -11,6 +11,7 @@
#include <QtClipboard.hxx>
#include <QtClipboard.moc>
#include <comphelper/diagnose_ex.hxx>
#include <cppuhelper/supportsservice.hxx>
#include <sal/log.hxx>
@@ -24,6 +25,10 @@
#include <map>
#include <utility>
#if defined EMSCRIPTEN && QT_VERSION < QT_VERSION_CHECK(6, 0, 0)
#include <emscripten.h>
#endif
QtClipboard::QtClipboard(OUString aModeString, const QClipboard::Mode aMode)
: cppu::WeakComponentImplHelper<css::datatransfer::clipboard::XSystemClipboard,
css::datatransfer::clipboard::XFlushableClipboard,
@@ -145,6 +150,41 @@ void QtClipboard::setContents(
aGuard.clear();
#if defined EMSCRIPTEN && QT_VERSION < QT_VERSION_CHECK(6, 0, 0)
// At least Qt5, in QWasmEventTranslator::processKeyboard in qbase
// src/plugins/platforms/wasm/qwasmeventtranslator.cpp, listens for Ctrl-C and initiates a
// browser Clipboard API writeText call, but (a) calls it before LO has sent the to-be-copied
// data to Qt (so calls it with old data), and (b) only works for Ctrl-C, not for Ctrl-X nor for
// cut/copy operations not initiated via the keyboard; so always do a writeText call here, and
// hope that the browser gives permission:
OUString textContents;
css::datatransfer::DataFlavor flav{ u"text/plain;charset=utf-16"_ustr, u""_ustr,
cppu::UnoType<OUString>::get() };
if (xTrans->isDataFlavorSupported(flav))
{
try
{
xTrans->getTransferData(flav) >>= textContents;
}
catch (css::io::IOException)
{
TOOLS_WARN_EXCEPTION("vcl.qt", "");
}
}
MAIN_THREAD_EM_ASM(
{
// clang-format off
try {
//TODO: Support embedded NULs:
navigator.clipboard.writeText(Module.UTF16ToString($0, 2 * $1));
} catch (e) {
console.warn("clipboard.writeText failed:", e);
}
// clang-format on
},
textContents.getStr(), textContents.getLength());
#endif
// we have to notify only an owner change, since handleChanged can't
// access the previous owner anymore and can just handle lost ownership.
if (xOldOwner.is() && xOldOwner != xClipboardOwner)