ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

Simplify cow_wrapper's refcounting policies implementation

Browse Source 
... using a shared template.
Also: use size_t in thread-safe policy, at least for consistency.

Change-Id: I1342a171103df5db5e156253580e6ef0bfee09d4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194233
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
This commit is contained in:
Mike Kaganski
2025-11-21 05:11:41 +01:00
parent 25ed44c0cd
commit cbc1310237
1 changed files with 10 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
include/o3tl/cow_wrapper.hxx
+10 -17
View File
@@ -26,35 +26,28 @@
namespace o3tl
{
template<typename N> struct RefCountingPolicy_t
{
typedef N ref_count_t;
static void incrementCount(ref_count_t& rCount) { ++rCount; }
static bool decrementCount(ref_count_t& rCount) { return --rCount != 0; }
static std::size_t getCount(const ref_count_t& rCount) { return rCount; }
};
/** Thread-unsafe refcounting
This is the default locking policy for cow_wrapper. No
locking/guarding against concurrent access is performed
whatsoever.
*/
struct UnsafeRefCountingPolicy
{
typedef std::size_t ref_count_t;
static void incrementCount( ref_count_t& rCount ) { ++rCount; }
static bool decrementCount( ref_count_t& rCount ) { return --rCount != 0; }
static std::size_t getCount( ref_count_t rCount) { return rCount; }
};
using UnsafeRefCountingPolicy = RefCountingPolicy_t<std::size_t>;
/** Thread-safe refcounting
Use this to have the cow_wrapper refcounting mechanisms employ
the thread-safe oslInterlockedCount .
*/
struct ThreadSafeRefCountingPolicy
{
typedef std::atomic<int> ref_count_t;
static void incrementCount( ref_count_t& rCount ) { rCount++; }
static bool decrementCount( ref_count_t& rCount )
{
return (--rCount) != 0;
}
static std::size_t getCount( const ref_count_t& rCount) { return rCount; }
};
using ThreadSafeRefCountingPolicy = RefCountingPolicy_t<std::atomic<std::size_t>>;
/** Copy-on-write wrapper.