cid#1660226 silence Uncaught exception

and

cid#1659881 Uncaught exception
cid#1482285 Uncaught exception
cid#1448465 Uncaught exception
cid#1421098 Uncaught exception
cid#1421084 Uncaught exception
cid#1400542 Uncaught exception
cid#1399276 Uncaught exception
cid#1399221 Uncaught exception
cid#1399212 Uncaught exception

Change-Id: I448e698047a6d2db7b0ac7575a54473fc5e88cc9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194394
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

sc/inc/scopetools.hxx

@@ -72,7 +72,7 @@ class DelayFormulaGroupingSwitch
 
 public:
     DelayFormulaGroupingSwitch(ScDocument& rDoc, bool delay);
-    ~DelayFormulaGroupingSwitch() COVERITY_NOEXCEPT_FALSE;
+    ~DelayFormulaGroupingSwitch();
     void reset();
 };
 

sc/source/core/tool/scopetools.cxx

@@ -64,9 +64,9 @@ DelayFormulaGroupingSwitch::DelayFormulaGroupingSwitch(ScDocument& rDoc, bool de
     mrDoc.DelayFormulaGrouping(delay);
 }
 
-DelayFormulaGroupingSwitch::~DelayFormulaGroupingSwitch() COVERITY_NOEXCEPT_FALSE
+DelayFormulaGroupingSwitch::~DelayFormulaGroupingSwitch()
 {
-    mrDoc.DelayFormulaGrouping(mbOldValue);
+    suppress_fun_call_w_exception(mrDoc.DelayFormulaGrouping(mbOldValue));
 }
 
 void DelayFormulaGroupingSwitch::reset()

sd/source/ui/sidebar/RecentlyUsedMasterPages.cxx

@@ -83,7 +83,7 @@ RecentlyUsedMasterPages::RecentlyUsedMasterPages()
 {
 }
 
-RecentlyUsedMasterPages::~RecentlyUsedMasterPages()
+void RecentlyUsedMasterPages::ImplDestroy()
 {
     Link<MasterPageContainerChangeEvent&,void> aLink (LINK(this,RecentlyUsedMasterPages,MasterPageContainerChangeListener));
     mpContainer->RemoveChangeListener(aLink);
@@ -92,6 +92,11 @@ RecentlyUsedMasterPages::~RecentlyUsedMasterPages()
         LINK(this,RecentlyUsedMasterPages,MasterPageChangeListener));
 }
 
+RecentlyUsedMasterPages::~RecentlyUsedMasterPages()
+{
+    suppress_fun_call_w_exception(ImplDestroy());
+}
+
 void RecentlyUsedMasterPages::LateInit()
 {
     Link<MasterPageContainerChangeEvent&,void> aLink (LINK(this,RecentlyUsedMasterPages,MasterPageContainerChangeListener));

sd/source/ui/sidebar/RecentlyUsedMasterPages.hxx

@@ -119,6 +119,8 @@ private:
     void SavePersistentValues();
 
     void ResolveList();
+
+    void ImplDestroy();
 };
 
 } // end of namespace sd::sidebar

starmath/inc/edit.hxx

@@ -86,9 +86,11 @@ class SmEditWindow final
 
     void CreateEditView(weld::Builder& rBuilder);
 
+    void ImplDestroy();
+
 public:
     SmEditWindow(SmCmdBoxWindow& rMyCmdBoxWin, weld::Builder& rBuilder);
-    ~SmEditWindow() COVERITY_NOEXCEPT_FALSE;
+    ~SmEditWindow();
 
     weld::Window* GetFrameWeld() const;
 

starmath/source/edit.cxx

@@ -143,12 +143,17 @@ SmEditWindow::SmEditWindow(SmCmdBoxWindow &rMyCmdBoxWin, weld::Builder& rBuilder
     CreateEditView(rBuilder);
 }
 
-SmEditWindow::~SmEditWindow() COVERITY_NOEXCEPT_FALSE
+void SmEditWindow::ImplDestroy()
 {
     DeleteEditView();
     mxScrolledWindow.reset();
 }
 
+SmEditWindow::~SmEditWindow()
+{
+    suppress_fun_call_w_exception(ImplDestroy());
+}
+
 weld::Window* SmEditWindow::GetFrameWeld() const
 {
     return rCmdBox.GetFrameWeld();

starmath/source/tmpdevice.hxx

@@ -33,7 +33,7 @@ class SmTmpDevice
 
 public:
     SmTmpDevice(OutputDevice& rTheDev, bool bUseMap100th_mm);
-    ~SmTmpDevice() COVERITY_NOEXCEPT_FALSE { rOutDev.Pop(); }
+    ~SmTmpDevice() { suppress_fun_call_w_exception(rOutDev.Pop()); }
 
     void SetFont(const vcl::Font& rNewFont);
 

sw/inc/ndtxt.hxx

@@ -211,6 +211,8 @@ class SW_DLLPUBLIC SwTextNode final
     void DelFrames_TextNodePart();
     void HandleNonLegacyHint(const SfxHint&);
 
+    SAL_DLLPRIVATE void ImplDestroy();
+
 public:
     bool IsWordCountDirty() const;
     sw::WrongState GetWrongDirty() const;

sw/inc/node.hxx

@@ -530,6 +530,8 @@ public:
 private:
     SwContentNode( const SwContentNode & rNode ) = delete;
     SwContentNode & operator= ( const SwContentNode & rNode ) = delete;
+
+    void ImplDestroy();
 };
 
 // SwTableNode
@@ -539,6 +541,8 @@ class SW_DLLPUBLIC SwTableNode final : public SwStartNode, public sw::Broadcasti
     friend class SwNodes;
     std::unique_ptr<SwTable> m_pTable;
 
+    void ImplDestroy();
+
     virtual ~SwTableNode() override;
 
 public:

sw/inc/pausethreadstarting.hxx

@@ -30,10 +30,12 @@ class SwPauseThreadStarting
 {
 public:
     SwPauseThreadStarting();
-    ~SwPauseThreadStarting() COVERITY_NOEXCEPT_FALSE;
+    ~SwPauseThreadStarting();
 
 private:
     bool mbPausedThreadStarting;
+
+    void ImplDestroy();
 };
 #endif
 

sw/inc/swddetbl.hxx

@@ -42,6 +42,7 @@ public:
 
 private:
     virtual void SwClientNotify(const SwModify&, const SfxHint&) override;
+    void ImplDestroy();
 };
 
 inline const SwDDEFieldType* SwDDETable::GetDDEFieldType() const

sw/source/core/docnode/ndtbl.cxx

@@ -2455,7 +2455,7 @@ SwTableNode::SwTableNode( const SwNode& rWhere )
     m_pTable.reset(new SwTable);
 }
 
-SwTableNode::~SwTableNode()
+void SwTableNode::ImplDestroy()
 {
     // Notify UNO wrappers
     GetTable().GetFrameFormat()->GetNotifier().Broadcast(SfxHint(SfxHintId::Dying));
@@ -2464,6 +2464,11 @@ SwTableNode::~SwTableNode()
     m_pTable.reset();
 }
 
+SwTableNode::~SwTableNode()
+{
+    suppress_fun_call_w_exception(ImplDestroy());
+}
+
 SwTabFrame *SwTableNode::MakeFrame( SwFrame* pSib )
 {
     return new SwTabFrame( *m_pTable, pSib );

sw/source/core/docnode/node.cxx

@@ -1083,7 +1083,7 @@ SwContentNode::SwContentNode( const SwNode& rWhere, const SwNodeType nNdType,
         pColl->Add(*this);
 }
 
-SwContentNode::~SwContentNode()
+void SwContentNode::ImplDestroy()
 {
     // The base class SwClient of SwFrame excludes itself from the dependency list!
     // Thus, we need to delete all Frames in the dependency list.
@@ -1100,6 +1100,11 @@ SwContentNode::~SwContentNode()
     InvalidateInSwCache();
 }
 
+SwContentNode::~SwContentNode()
+{
+    suppress_fun_call_w_exception(ImplDestroy());
+}
+
 void SwContentNode::UpdateAttr(const SwUpdateAttr& rUpdate)
 {
     if (GetNodes().IsDocNodes()

sw/source/core/docnode/pausethreadstarting.cxx

@@ -17,6 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
+#include <o3tl/deleter.hxx>
 #include <pausethreadstarting.hxx>
 #include <swthreadmanager.hxx>
 
@@ -37,7 +38,7 @@ SwPauseThreadStarting::SwPauseThreadStarting()
     }
 }
 
-SwPauseThreadStarting::~SwPauseThreadStarting() COVERITY_NOEXCEPT_FALSE
+void SwPauseThreadStarting::ImplDestroy()
 {
     if (mbPausedThreadStarting)
     {
@@ -45,4 +46,6 @@ SwPauseThreadStarting::~SwPauseThreadStarting() COVERITY_NOEXCEPT_FALSE
     }
 }
 
+SwPauseThreadStarting::~SwPauseThreadStarting() { suppress_fun_call_w_exception(ImplDestroy()); }
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */

sw/source/core/fields/ddetbl.cxx

@@ -62,7 +62,7 @@ SwDDETable::SwDDETable( SwTable& rTable, SwDDEFieldType* pDDEType, bool bUpdate
     }
 }
 
-SwDDETable::~SwDDETable()
+void SwDDETable::ImplDestroy()
 {
     SwDoc& rDoc = GetFrameFormat()->GetDoc();
     if (!rDoc.IsInDtor() && !m_aLines.empty())
@@ -83,6 +83,11 @@ SwDDETable::~SwDDETable()
     }
 }
 
+SwDDETable::~SwDDETable()
+{
+    suppress_fun_call_w_exception(ImplDestroy());
+}
+
 void SwDDETable::SwClientNotify(const SwModify& rModify, const SfxHint& rHint)
 {
     if (rHint.GetId() == SfxHintId::SwLegacyModify

sw/source/core/txtnode/ndtxt.cxx

@@ -247,7 +247,7 @@ SwTextNode::SwTextNode( const SwNode& rWhere, SwTextFormatColl *pTextColl, const
     m_bRecalcHiddenCharFlags = true;
 }
 
-SwTextNode::~SwTextNode()
+void SwTextNode::ImplDestroy()
 {
     // delete only removes the pointer not the array elements!
     if ( m_pSwpHints )
@@ -291,6 +291,11 @@ SwTextNode::~SwTextNode()
     InvalidateInSwCache();
 }
 
+SwTextNode::~SwTextNode()
+{
+    suppress_fun_call_w_exception(ImplDestroy());
+}
+
 void SwTextNode::FileLoadedInitHints()
 {
     if (m_pSwpHints)