ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

cui: remove duplicate code

Browse Source 
The line:

aCurrentEntryColor.nColor = m_xColorChangeBtn->GetSelectEntryColor();

was called twice with two different comments. Remove the line that
has the inaccurate comment and leave the one that describes what's
actually happening now.

Change-Id: I566e8254425f4499cefa7c159468e531aaf9e355
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195737
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
This commit is contained in:
Dan Williams
2025-12-19 12:31:41 +01:00
committed by Hossein
parent 5623aac80c
commit bef1b114ee
1 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cui/source/options/appearance.cxx
-3
View File
@@ -352,9 +352,6 @@ IMPL_LINK_NOARG(SvxAppearanceTabPage, ColorValueChgHdl, ColorListBox&, void)
if (nEntry >= WINDOWCOLOR)
m_bRestartRequired = true;
// set the color in pColorConfig
aCurrentEntryColor.nColor = m_xColorChangeBtn->GetSelectEntryColor();
// use nColor for caching the value of color in use. This avoids tedious refactoring which IMO
// would use function calls to discriminate between colors. Those functions themself call some virtual functions
// making the whole thing super slow (comparatively).