ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

Avoid uninitialized temp_file_handle

Browse Source 
...in case osl_create_temp_file_impl_ doesn't assign to it, for whatever
osl_error reason, which then apparently leads to
<https://crashreport.libreoffice.org/stats/crash_details/e47a9fbb-a6f1-4020-ade8-ab51549b727a>
SIGSEGV at (relative to libreoffice-7-1)

> 0  libuno_sal.so.3  osl_closeFile                               sal/osl/unx/file.cxx:1154
> 1  libuno_sal.so.3  osl_createTempFile                          sal/osl/unx/tempfile.cxx:330
> 2  libmergedlo.so   PackedFile::flush                           include/osl/file.hxx:310
> 3  libmergedlo.so   comphelper::BackupFileHelper::tryPush_file  comphelper/source/misc/backupfilehelper.cxx:2090
[...]

Change-Id: I2e81bbeab7daaaa3c19de4accce8a76ad24faa47
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135111
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
This commit is contained in:
Stephan Bergmann
2022-05-30 12:48:28 +02:00
parent c3f73f7577
commit bbcf26337c
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sal/osl/unx/tempfile.cxx
+1 -1
View File
@@ -278,7 +278,7 @@ oslFileError SAL_CALL osl_createTempFile(
rtl_uString** ppustrTempFileURL)
{
rtl_uString* base_directory = nullptr;
oslFileHandle temp_file_handle;
oslFileHandle temp_file_handle = nullptr;
bool b_delete_on_close;
oslFileError osl_error;