vcl: Add TrueTypeFont::getTypeFlags()

Change-Id: I16bf9fc3cbe5794023fdd54a5c8ec312f4d55697
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203707
Reviewed-by: Khaled Hosny <khaled@libreoffice.org>
Tested-by: Jenkins

vcl/inc/sft.hxx

@@ -59,7 +59,6 @@ namespace vcl
 
     typedef struct TTGlobalFontInfo_ {
         bool  microsoftSymbolEncoded = false;  /**< true: MS symbol encoded */
-        sal_uInt32 typeFlags = 0;     /**< type flags (copyright bits)                             */
     } TTGlobalFontInfo;
 
 
@@ -319,6 +318,7 @@ public:
     FontWidth getFontWidth() const;
     FontItalic getFontItalic() const;
     FontPitch getFontPitch() const;
+    sal_uInt32 getTypeFlags() const;
 };
 
 } // namespace vcl

vcl/source/fontsubset/sft.cxx

@@ -160,10 +160,6 @@ TTGlobalFontInfo TrueTypeFont::getGlobalFontInfo() const
     if (!aCmap.empty())
         info.microsoftSymbolEncoded = HasMicrosoftSymbolCmap(aCmap.data(), aCmap.size());
 
-    auto aOS2 = getTable(T_OS2);
-    if (aOS2.size() >= 42)
-        info.typeFlags = GetUInt16(aOS2.data(), OS2_fsType_offset);
-
     return info;
 }
 
@@ -190,6 +186,14 @@ static FontWeight ImplWeightToSal( float nWeight )
         return WEIGHT_BLACK;
 }
 
+sal_uInt32 TrueTypeFont::getTypeFlags() const
+{
+    auto aOS2 = getTable(T_OS2);
+    if (aOS2.size() >= 42)
+        return GetUInt16(aOS2.data(), OS2_fsType_offset);
+    return 0;
+}
+
 FontPitch TrueTypeFont::getFontPitch() const
 {
     auto aPost = getTable(T_post);

vcl/source/gdi/embeddedfontsmanager.cxx

@@ -227,9 +227,8 @@ OUString getFilenameForExport(std::u16string_view familyName, FontFamily family,
 bool sufficientTTFRights(const TrueTypeFont& font,
                          EmbeddedFontsManager::FontRights rights)
 {
-    TTGlobalFontInfo info = font.getGlobalFontInfo();
     // https://www.microsoft.com/typography/otspec/os2.htm#fst
-    int copyright = info.typeFlags;
+    int copyright = font.getTypeFlags();
     switch (rights)
     {
         case EmbeddedFontsManager::FontRights::ViewingAllowed: