tdf#42949 Fix IWYU warnings in include/

Recheck directories in include/ between vcl and svx in the module hierarchy Found with bin/find-unneeded-includes Only removal proposals are dealt with here. New IWYU and recent developments in f-u-i helped to identify some non self contained files, those were fixed too. Change-Id: Ieab6083ee2aae33baf32d05943b07ad2de6f9d7f Reviewed-on: https://gerrit.libreoffice.org/75170 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-16 09:15:41 +02:00
parent 8d4fbc532e
commit b53403c54c
22 changed files with 37 additions and 13 deletions
@@ -279,6 +279,10 @@ blacklist:
    include/vcl/FilterConfigItem.hxx:
    # Needed on Windows with --disable-pch
    - com/sun/star/beans/PropertyValue.hpp
+    include/vcl/builderfactory.hxx:
+    # Needed for macro #define
+    - vcl/builder.hxx
+    - vcl/vclptr.hxx
    include/vcl/decoview.hxx:
    # Full definition needed for VclPtr
    - vcl/outdev.hxx
@@ -298,6 +302,14 @@ blacklist:
    include/vcl/mtfxmldump.hxx:
    # Full definition needed for o3tl::enumarray
    - vcl/metaactiontypes.hxx
+    include/vcl/salbtype.hxx:
+    # TODO remove this file entirely, contains only these headers now
+    - vcl/BitmapAccessMode.hxx
+    - vcl/BitmapBuffer.hxx
+    - vcl/BitmapColor.hxx
+    - vcl/BitmapPalette.hxx
+    - vcl/ColorMask.hxx
+    - vcl/Scanline.hxx
    include/vcl/outdevstate.hxx:
    # Full definition needed for boost::optional
    - vcl/mapmod.hxx
@@ -21,6 +21,7 @@
 #define INCLUDED_CANVAS_BASE_CANVASBASE_HXX

 #include <com/sun/star/uno/Reference.hxx>
+#include <com/sun/star/uno/Sequence.hxx>
 #include <com/sun/star/rendering/TextDirection.hpp>
 #include <osl/diagnose.h>
 #include <osl/mutex.hxx>
@@ -20,6 +20,8 @@
 #ifndef INCLUDED_CANVAS_BASE_CANVASCUSTOMSPRITEBASE_HXX
 #define INCLUDED_CANVAS_BASE_CANVASCUSTOMSPRITEBASE_HXX

+#include <com/sun/star/rendering/XCanvas.hpp>
+
 #include <basegfx/point/b2dpoint.hxx>
 #include <basegfx/vector/b2dvector.hxx>
 #include <basegfx/range/b2drange.hxx>
@@ -20,6 +20,12 @@
 #ifndef INCLUDED_CANVAS_BASE_GRAPHICDEVICEBASE_HXX
 #define INCLUDED_CANVAS_BASE_GRAPHICDEVICEBASE_HXX

+#include <com/sun/star/rendering/XBufferController.hpp>
+#include <com/sun/star/rendering/XLinePolyPolygon2D.hpp>
+#include <com/sun/star/rendering/XBezierPolyPolygon2D.hpp>
+#include <com/sun/star/rendering/XBitmap.hpp>
+#include <com/sun/star/rendering/XVolatileBitmap.hpp>
+
 #include <rtl/ref.hxx>

 #include <canvas/parametricpolypolygon.hxx>
@@ -20,8 +20,6 @@
 #ifndef INCLUDED_CPPCANVAS_SPRITE_HXX
 #define INCLUDED_CPPCANVAS_SPRITE_HXX

-#include <memory>
-
 namespace basegfx
 {
    class B2DHomMatrix;
@@ -22,6 +22,7 @@
 #include <sal/config.h>
 #include <sfx2/dllapi.h>

+#include <com/sun/star/beans/PropertyValue.hpp>
 #include <com/sun/star/util/DateTime.hpp>
 #include <com/sun/star/util/Duration.hpp>
 #include <com/sun/star/document/CmisProperty.hpp>
@@ -19,6 +19,10 @@
 #ifndef INCLUDED_SFX2_GROUPID_HXX
 #define INCLUDED_SFX2_GROUPID_HXX

+#include <sal/types.h>
+
+#include <functional>
+
 // !! If you add a new group, please change sfxbasecontroller.cxx and
 // !! com.sun.star.frame.CommandGroup accordingly!

@@ -27,7 +27,6 @@
 #include <com/sun/star/uno/Reference.h>
 #include <com/sun/star/uno/Sequence.hxx>

-#include <vcl/vclptr.hxx>
 #include <svl/poolitem.hxx>
 #include <sot/formats.hxx>
 #include <sot/object.hxx>
@@ -21,13 +21,9 @@
 #define INCLUDED_SVTOOLS_CALENDAR_HXX

 #include <svtools/svtdllapi.h>
-#include <unotools/calendarwrapper.hxx>

 #include <vcl/calendar.hxx>
-#include <vcl/ctrl.hxx>
 #include <vcl/field.hxx>
-#include <memory>
-#include <set>

 class MouseEvent;
 class TrackingEvent;
@@ -12,6 +12,8 @@

 #include <svtools/svtdllapi.h>

+#include <com/sun/star/uno/Sequence.hxx>
+
 #include <rtl/ustring.hxx>

 /** Localize a URI to one of the foundation's webservices
@@ -21,6 +21,7 @@
 #define INCLUDED_SVTOOLS_PRNSETUP_HXX

 #include <svtools/svtdllapi.h>
+#include <vcl/print.hxx>
 #include <vcl/weld.hxx>
 #include <vcl/timer.hxx>

@@ -20,6 +20,8 @@
 #ifndef INCLUDED_SVTOOLS_RTFTOKEN_H
 #define INCLUDED_SVTOOLS_RTFTOKEN_H

+#include <rtl/ustring.hxx>
+
 namespace rtl {
  class OUString;
 };
@@ -24,7 +24,6 @@
 #include <vcl/headbar.hxx>
 #include <vcl/svtabbx.hxx>
 #include <unotools/collatorwrapper.hxx>
-#include <vcl/commandevent.hxx>

 class SvSimpleTable;
 class SVT_DLLPUBLIC SvSimpleTableContainer : public Control
@@ -22,7 +22,6 @@

 #include <vcl/dllapi.h>
 #include <tools/color.hxx>
-#include <memory>

 class VCL_DLLPUBLIC BitmapColor final : public Color
 {
@@ -13,6 +13,8 @@
 #include <vcl/EnumContext.hxx>
 #include <vector>

+#include <algorithm>
+
 namespace vcl
 {

@@ -10,6 +10,8 @@
 #ifndef INCLUDED_VCL_IPRIORITABLE_HXX
 #define INCLUDED_VCL_IPRIORITABLE_HXX

+#include <vcl/dllapi.h>
+
 #define VCL_PRIORITY_DEFAULT -1

 namespace vcl
@@ -20,7 +20,6 @@
 #ifndef INCLUDED_VCL_SCANLINE_HXX
 #define INCLUDED_VCL_SCANLINE_HXX

-#include <vcl/dllapi.h>
 #include <o3tl/typed_flags_set.hxx>

 typedef sal_uInt8*        Scanline;
@@ -10,7 +10,6 @@
 #ifndef INCLUDED_VCL_ABOUT_DIALOG_HXX
 #define INCLUDED_VCL_ABOUT_DIALOG_HXX

-#include <vcl/button.hxx>
 #include <vcl/fixed.hxx>
 #include <vcl/fixedhyper.hxx>
 #include <vcl/dialog.hxx>
@@ -21,7 +21,6 @@
 #define INCLUDED_VCL_ANIMATE_ANIMATIONBITMAP_HXX

 #include <vcl/dllapi.h>
-#include <vcl/timer.hxx>
 #include <vcl/bitmapex.hxx>

 enum class Disposal
@@ -21,6 +21,7 @@
 #define INCLUDED_VCL_MSGBOX_HXX

 #include <vcl/dllapi.h>
+#include <vcl/image.hxx>

 VCL_DLLPUBLIC Image const & GetStandardInfoBoxImage();
 VCL_DLLPUBLIC OUString GetStandardInfoBoxText();
@@ -22,7 +22,6 @@

 #include <sal/config.h>

-#include <map>
 #include <unordered_map>
 #include <utility>

@@ -21,6 +21,7 @@
 #define INCLUDED_SD_SOURCE_UI_INC_SDXFER_HXX

 #include <vcl/transfer.hxx>
+#include <vcl/vclptr.hxx>
 #include <sfx2/objsh.hxx>
 #include <svl/lstner.hxx>