ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

XLSX: Invalid cell link in Form Controls

Browse Source 
Cell links of Form Controls contains tab names, they should be checked
for quotes. Also escape characters are not escaped.

bug-document: forum-mso-en4-356971.xls
Change-Id: I6ca8abed209171c7e78a99a27edaee05d0f221b0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199719
Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
(cherry picked from commit 30a127e54390aeaad12f51eaa6323863fa04b3b3)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200409
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/204092
Tested-by: Jenkins
This commit is contained in:
Karthik Godha
2026-04-22 17:16:19 +02:00
committed by Xisco Fauli
parent 634ef3b31d
commit ae6a829e04
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sc/source/filter/excel/xeescher.cxx
+3 -1
View File
@@ -1449,7 +1449,9 @@ OUString XclExpTbxControlObj::SaveControlPropertiesXml(XclExpXmlStream& rStrm) c
pFormControl->write(" fmlaLink=\"");
if (aCellLink.indexOf('!') < 0)
{
pFormControl->write(GetTabInfo().GetScTabName(mxCellLinkAddress.Tab()));
OUString sTabName = GetTabInfo().GetScTabName(mxCellLinkAddress.Tab());
ScCompiler::CheckTabQuotes(sTabName);
pFormControl->writeEscaped(sTabName);
pFormControl->write("!");
}
pFormControl->write(aCellLink);