Elaborate comment what happens, tdf#78840 follow-up

Change-Id: I30bfc2891e422e8cfcb83f01136c654e3a1b03f5
2020-01-03 21:13:29 +01:00
parent 12b4590f3a
commit ace8602466
1 changed files with 8 additions and 1 deletions
@@ -131,8 +131,15 @@ void TextSearch::setOptions2( const SearchOptions2& rOptions )
    maWildcardReversePattern2.clear();
    TransliterationFlags transliterateFlags = static_cast<TransliterationFlags>(aSrchPara.transliterateFlags);
    if (aSrchPara.AlgorithmType2 == SearchAlgorithms2::REGEXP)
-        // RESrchPrepare will consider SearchAlgorithms2::REGEXP in aSrchPara.transliterateFlags
+    {
+        // RESrchPrepare will consider aSrchPara.transliterateFlags when
+        // picking the actual regex pattern
+        // (sSrchStr|sSrchStr2|SearchOptions2::searchString) and setting
+        // case-insensitivity. Create transliteration instance, if any, without
+        // ignore-case so later in TextSearch::searchForward() the string to
+        // match is not case-altered, leave case-(in)sensitive to regex engine.
        transliterateFlags &= ~TransliterationFlags::IGNORE_CASE;
+    }

    // Create Transliteration class
    if( isSimpleTrans( transliterateFlags) )