Improved loplugin:stringconstant (now that GCC 7 supports it): idlc

Change-Id: I53e4be7db68622b7ce283014874074004b83a8ba
Reviewed-on: https://gerrit.libreoffice.org/76669
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

idlc/source/astexpression.cxx

@@ -1169,9 +1169,9 @@ OString AstExpression::toString()
                 return OString::number(m_exprValue->u.byval);
             case ET_boolean:
                 if ( m_exprValue->u.lval == 0)
-                    return OString("FALSE");
+                    return "FALSE";
                 else
-                    return OString("TRUE");
+                    return "TRUE";
             default:
                 OSL_ASSERT(false);
                 return OString();

idlc/source/idlccompile.cxx

@@ -161,7 +161,7 @@ static OString makeTempName(const OString& prefix)
 #endif
 #endif
 
-    return OString(tmpFilePattern);
+    return tmpFilePattern;
 }
 
 bool copyFile(const OString* source, const OString& target)