ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

sw: Pass SwAbstractDialogFactory::CreateAuthMarkFloatDlg param by ref

Browse Source 
The SfxChildWinInfo* param is always non-null.
Pass by ref instead.

Change-Id: I4a14046bee6dbf6def328803d89a9db64af24bfe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208308
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
This commit is contained in:
Michael Weghorn
2026-07-22 17:41:25 +02:00
parent a3bf38b063
commit a1f479b508
4 changed files with 14 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sw/inc/swabstdlg.hxx
+4 -5
View File
@@ -597,11 +597,10 @@ public:
CreateIndexMarkFloatDlg(SfxBindings* pBindings, SfxChildWindow* pChild, weld::Window* pParent,
SfxChildWinInfo& rInfo)
= 0;
virtual VclPtr<AbstractMarkFloatDlg> CreateAuthMarkFloatDlg(
SfxBindings* pBindings,
SfxChildWindow* pChild,
weld::Window *pParent,
SfxChildWinInfo* pInfo) = 0;
virtual VclPtr<AbstractMarkFloatDlg>
CreateAuthMarkFloatDlg(SfxBindings* pBindings, SfxChildWindow* pChild, weld::Window* pParent,
SfxChildWinInfo& rInfo)
= 0;
virtual VclPtr<VclAbstractDialog> CreateIndexMarkModalDlg(
weld::Window *pParent, SwWrtShell& rSh, SwTOXMark* pCurTOXMark) = 0;
sw/source/ui/dialog/swdlgfact.cxx
+5 -6
View File
@@ -1098,13 +1098,12 @@ public:
};
}
VclPtr<AbstractMarkFloatDlg> SwAbstractDialogFactory_Impl::CreateAuthMarkFloatDlg(
SfxBindings* pBindings,
SfxChildWindow* pChild,
weld::Window *pParent,
SfxChildWinInfo* pInfo)
VclPtr<AbstractMarkFloatDlg>
SwAbstractDialogFactory_Impl::CreateAuthMarkFloatDlg(SfxBindings* pBindings, SfxChildWindow* pChild,
weld::Window* pParent, SfxChildWinInfo& rInfo)
{
return VclPtr<AbstractAuthMarkFloatDlg_Impl>::Create(pBindings, pChild, pParent, pInfo, true/*bNew*/);
return VclPtr<AbstractAuthMarkFloatDlg_Impl>::Create(pBindings, pChild, pParent, &rInfo,
true /*bNew*/);
}
namespace
sw/source/ui/dialog/swdlgfact.hxx
+4 -5
View File
@@ -182,11 +182,10 @@ public:
SfxChildWindow* pChild,
weld::Window* pParent,
SfxChildWinInfo& rInfo) override;
virtual VclPtr<AbstractMarkFloatDlg> CreateAuthMarkFloatDlg(
SfxBindings* pBindings,
SfxChildWindow* pChild,
weld::Window *pParent,
SfxChildWinInfo* pInfo) override;
virtual VclPtr<AbstractMarkFloatDlg> CreateAuthMarkFloatDlg(SfxBindings* pBindings,
SfxChildWindow* pChild,
weld::Window* pParent,
SfxChildWinInfo& rInfo) override;
virtual VclPtr<VclAbstractDialog> CreateIndexMarkModalDlg(
weld::Window *pParent, SwWrtShell& rSh, SwTOXMark* pCurTOXMark ) override;
sw/source/uibase/index/idxmrk.cxx
+1 -1
View File
@@ -53,7 +53,7 @@ SwInsertAuthMarkWrapper::SwInsertAuthMarkWrapper(vcl::Window* pParentWindow, sal
{
SwAbstractDialogFactory* pFact = SwAbstractDialogFactory::Create();
m_xAbstDlg
= pFact->CreateAuthMarkFloatDlg(pBindings, this, pParentWindow->GetFrameWeld(), &rInfo);
= pFact->CreateAuthMarkFloatDlg(pBindings, this, pParentWindow->GetFrameWeld(), rInfo);
SetController(m_xAbstDlg->GetController());
}